102703 2012-11-19 12:16:49 -0800 [garden-o-matic] Enable serving garden-o-matic with gardeningserver. 2012-11-19 13:24:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov abarth dpranke ojan webkit.review.bot oldest_to_newest 770929 0 dglazkov 2012-11-19 12:16:49 -0800 [garden-o-matic] Enable serving garden-o-matic with gardeningserver. 770933 1 175021 dglazkov 2012-11-19 12:20:36 -0800 Created attachment 175021 Patch 770941 2 175021 dpranke 2012-11-19 12:30:55 -0800 Comment on attachment 175021 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175021&action=review > Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py:81 > + _, extension = os.path.splitext(self.path) This module should probably be moved over to using the filesystem interface, but seeing as how it doesn't yet, I wouldn't add it as part of this change. 770991 3 175021 webkit.review.bot 2012-11-19 13:24:07 -0800 Comment on attachment 175021 Patch Clearing flags on attachment: 175021 Committed r135191: <http://trac.webkit.org/changeset/135191> 770992 4 webkit.review.bot 2012-11-19 13:24:11 -0800 All reviewed patches have been landed. Closing bug. 175021 2012-11-19 12:20:36 -0800 2012-11-19 13:24:07 -0800 Patch bug-102703-20121119121826.patch text/plain 6033 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzg4ZTUxNzdhNDViMjJmZWFhOGM0OGJkMGY3ZmNiZjUy M2U2MDM2MS4uZGZhNDQwZjljZDY2N2E1YzQ3ZmNlM2M2NGZjOWNmOWY0ZDUxZThkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTExLTE5ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW2dhcmRlbi1vLW1hdGljXSBFbmFibGUgc2VydmluZyBnYXJkZW4tby1tYXRp YyB3aXRoIGdhcmRlbmluZ3NlcnZlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMjcwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRvIGVuYWJsZSBnYXJkZW5pbmcgZnJvbSBhIENocm9tZSBPUyBkZXZp Y2UsIHdlIG5lZWQgdGhlIGFiaWxpdHkgdG8gc2VydmUgZ2FyZGVuLW8tbWF0aWMKKyAgICAgICAg ZnJvbSB0aGUgc2FtZSBvcmlnaW4gYXMgdGhlIGdhcmRlbmluZyBzZXJ2ZXIuIFRoaXMgY2hhbmdl IGdlbnRseSBtYXNzYWdlcyB0aGUgY3VycmVudAorICAgICAgICBsb2dpYyB0byBhZGFwdCBhbiBl eHRlbnNpb24tc25pZmZpbmctYmFzZWQgYXBwcm9hY2ggb2YgaWRlbnRpZnlpbmcgc3RhdGljIGZp bGVzLAorICAgICAgICByYXRoZXIgdGhhbiByZXF1aXJpbmcgYW4gZXhwbGljaXQgbGlzdC4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL3JlZmxlY3Rpb25oYW5kbGVy LnB5OgorICAgICAgICAoUmVmbGVjdGlvbkhhbmRsZXIpOiBSZXBsYWNlZCBTVEFUSUNfRklMRV9O QU1FUyB3aXRoIFNUQVRJQ19GSUxFX0VYVEVOU0lPTlMuCisgICAgICAgIChSZWZsZWN0aW9uSGFu ZGxlci5faGFuZGxlX3JlcXVlc3QpOiBDaGFuZ2VkIHRoZSBsb2dpYyB0byBzbWVsbCBmb3IgZXh0 ZW5zaW9ucywgcmF0aGVyIHRoYW4gc3BlY2lmaWMgZmlsZXMuCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL3NlcnZlcnMvcmVmbGVjdGlvbmhhbmRsZXJfdW5pdHRlc3QucHk6IEFkZGVk LgorCiAyMDEyLTExLTE2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmVtb3ZlIEVOQUJMRV9DU1NfSElFUkFSQ0hJRVMgc2luY2UgaXQncyBubyBsb25nZXIgaW4g dXNlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9yZWZs ZWN0aW9uaGFuZGxlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL3Jl ZmxlY3Rpb25oYW5kbGVyLnB5CmluZGV4IDkzMDg3MDk2MWEyNjQ4MzE5ZDdkMDBjOTRjNWFkMmUy ZmUzNzQxN2EuLjIxNDhiNGViMmIyNTRlMWU5YjEzZTE5MjZkODUxNTRlMDdjMTQ3N2QgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL3JlZmxlY3Rpb25oYW5k bGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2ZXJzL3JlZmxlY3Rp b25oYW5kbGVyLnB5CkBAIC00NCw4ICs0NCw4IEBAIGltcG9ydCBCYXNlSFRUUFNlcnZlcgogCiAK IGNsYXNzIFJlZmxlY3Rpb25IYW5kbGVyKEJhc2VIVFRQU2VydmVyLkJhc2VIVFRQUmVxdWVzdEhh bmRsZXIpOgorICAgIFNUQVRJQ19GSUxFX0VYVEVOU0lPTlMgPSBbJy5qcycsICcuY3NzJywgJy5o dG1sJ10KICAgICAjIFN1YmNsYXNzZXMgc2hvdWxkIG92ZXJyaWRlLgotICAgIFNUQVRJQ19GSUxF X05BTUVTID0gTm9uZQogICAgIFNUQVRJQ19GSUxFX0RJUkVDVE9SWSA9IE5vbmUKIAogICAgICMg U2V0dGluZyB0aGlzIGZsYWcgdG8gVHJ1ZSBjYXVzZXMgdGhlIHNlcnZlciB0byBzZW5kCkBAIC03 OCw3ICs3OCw4IEBAIGNsYXNzIFJlZmxlY3Rpb25IYW5kbGVyKEJhc2VIVFRQU2VydmVyLkJhc2VI VFRQUmVxdWVzdEhhbmRsZXIpOgogICAgICAgICAgICAgc2VsZi5xdWVyeSA9IHt9CiAgICAgICAg IGZ1bmN0aW9uX29yX2ZpbGVfbmFtZSA9IHBhdGhbMTpdIG9yICJpbmRleC5odG1sIgogCi0gICAg ICAgIGlmIGZ1bmN0aW9uX29yX2ZpbGVfbmFtZSBpbiBzZWxmLlNUQVRJQ19GSUxFX05BTUVTOgor ICAgICAgICBfLCBleHRlbnNpb24gPSBvcy5wYXRoLnNwbGl0ZXh0KHNlbGYucGF0aCkKKyAgICAg ICAgaWYgZXh0ZW5zaW9uIGluIHNlbGYuU1RBVElDX0ZJTEVfRVhURU5TSU9OUzoKICAgICAgICAg ICAgIHNlbGYuX3NlcnZlX3N0YXRpY19maWxlKGZ1bmN0aW9uX29yX2ZpbGVfbmFtZSkKICAgICAg ICAgICAgIHJldHVybgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c2VydmVycy9yZWZsZWN0aW9uaGFuZGxlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zZXJ2ZXJzL3JlZmxlY3Rpb25oYW5kbGVyX3VuaXR0ZXN0LnB5Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmQyNjlkZmNmNTAzYjZlYjUyMzJhMWY2ZGIxZDJmN2Q0NDliMjA5MDQKLS0tIC9kZXYvbnVs bAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9yZWZsZWN0aW9uaGFu ZGxlcl91bml0dGVzdC5weQpAQCAtMCwwICsxLDcwIEBACisjIENvcHlyaWdodCAoQykgMjAxMiBH b29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zIGFyZQorIyBtZXQ6CisjCisjICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2Rl IG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAgICAqIFJlZGlzdHJp YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJp Z2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHBy b3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgKiBOZWl0aGVyIHRoZSBuYW1l IG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCisjIGNvbnRyaWJ1dG9ycyBtYXkg YmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMgZGVyaXZlZCBmcm9tCisjIHRo aXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCisj CisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhFIENPUFlSSUdIVCBIT0xERVJTIEFO RCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJS QU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisjIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hU CisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElS RUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwg REFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9G IFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQ Uk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBB TlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJ QUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBB UklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKworaW1wb3J0 IHVuaXR0ZXN0CisKK2Zyb20gd2Via2l0cHkudG9vbC5zZXJ2ZXJzLnJlZmxlY3Rpb25oYW5kbGVy IGltcG9ydCBSZWZsZWN0aW9uSGFuZGxlcgorCisKK2NsYXNzIFRlc3RSZWZsZWN0aW9uSGFuZGxl cihSZWZsZWN0aW9uSGFuZGxlcik6CisgICAgU1RBVElDX0ZJTEVfRElSRUNUT1JZID0gIi8iCisK KyAgICBkZWYgX19pbml0X18oc2VsZik6CisgICAgICAgIHNlbGYuc3RhdGljX2ZpbGVzX3NlcnZl ZCA9IHNldCgpCisgICAgICAgIHNlbGYuZXJyb3JzX3NlbnQgPSBzZXQoKQorICAgICAgICBzZWxm LmZ1bmN0aW9uc19ydW4gPSBzZXQoKQorCisgICAgZGVmIF9zZXJ2ZV9zdGF0aWNfZmlsZShzZWxm LCBuYW1lKToKKyAgICAgICAgc2VsZi5zdGF0aWNfZmlsZXNfc2VydmVkLmFkZChuYW1lKQorCisg ICAgZGVmIHNlbmRfZXJyb3Ioc2VsZiwgY29kZSwgZGVzY3JpcHRpb24pOgorICAgICAgICBzZWxm LmVycm9yc19zZW50LmFkZChjb2RlKQorCisgICAgZGVmIGZ1bmN0aW9uX29uZShzZWxmKToKKyAg ICAgICAgc2VsZi5mdW5jdGlvbnNfcnVuLmFkZCgiZnVuY3Rpb25fb25lIikKKworICAgIGRlZiBz b21lX2h0bWwoc2VsZik6CisgICAgICAgIHNlbGYuZnVuY3Rpb25zX3J1bi5hZGQoInNvbWVfaHRt bCIpCisKKworY2xhc3MgUmVmbGVjdGlvbkhhbmRsZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK KyAgICBkZWYgYXNzZXJ0X2hhbmRsZXJfcmVzcG9uc2Uoc2VsZiwgcmVxdWVzdHMsIGV4cGVjdGVk X3N0YXRpY19maWxlcywgZXhwZWN0ZWRfZXJyb3JzLCBleHBlY3RlZF9mdW5jdGlvbnMpOgorICAg ICAgICBoYW5kbGVyID0gVGVzdFJlZmxlY3Rpb25IYW5kbGVyKCkKKyAgICAgICAgZm9yIHJlcXVl c3QgaW4gcmVxdWVzdHM6CisgICAgICAgICAgICBoYW5kbGVyLnBhdGggPSByZXF1ZXN0CisgICAg ICAgICAgICBoYW5kbGVyLl9oYW5kbGVfcmVxdWVzdCgpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoaGFuZGxlci5zdGF0aWNfZmlsZXNfc2VydmVkLCBleHBlY3RlZF9zdGF0aWNfZmlsZXMpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoaGFuZGxlci5lcnJvcnNfc2VudCwgZXhwZWN0ZWRfZXJy b3JzKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGhhbmRsZXIuZnVuY3Rpb25zX3J1biwgZXhw ZWN0ZWRfZnVuY3Rpb25zKQorCisgICAgZGVmIHRlc3Rfc3RhdGljX2NvbnRlbnRfb3JfZnVuY3Rp b25fc3dpdGNoKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9oYW5kbGVyX3Jlc3BvbnNlKFsi L3Rlc3QuanMiXSwgc2V0KFsidGVzdC5qcyJdKSwgc2V0KCksIHNldCgpKQorICAgICAgICBzZWxm LmFzc2VydF9oYW5kbGVyX3Jlc3BvbnNlKFsiL3Rlc3QuanMiLCAiL3Rlc3QuY3NzIiwgIi90ZXN0 Lmh0bWwiXSwgc2V0KFsidGVzdC5qcyIsICJ0ZXN0Lmh0bWwiLCAidGVzdC5jc3MiXSksIHNldCgp LCBzZXQoKSkKKyAgICAgICAgc2VsZi5hc3NlcnRfaGFuZGxlcl9yZXNwb25zZShbIi90ZXN0Lmpz IiwgIi90ZXN0LmV4ZSIsICIvdGVzdGh0bWwiXSwgc2V0KFsidGVzdC5qcyJdKSwgc2V0KFs0MDRd KSwgc2V0KCkpCisgICAgICAgIHNlbGYuYXNzZXJ0X2hhbmRsZXJfcmVzcG9uc2UoWyIvdGVzdC5o dG1sIiwgIi9mdW5jdGlvbi5vbmUiXSwgc2V0KFsidGVzdC5odG1sIl0pLCBzZXQoKSwgc2V0KFsn ZnVuY3Rpb25fb25lJ10pKQorICAgICAgICBzZWxmLmFzc2VydF9oYW5kbGVyX3Jlc3BvbnNlKFsi L3NvbWUuaHRtbCJdLCBzZXQoWyJzb21lLmh0bWwiXSksIHNldCgpLCBzZXQoKSkK