102702 2012-11-19 12:01:59 -0800 Add 64-bit specializations for atomicIncrement and atomicDecrement 2012-11-19 15:16:08 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 98537 1 beidson beidson benjamin webkit.review.bot oldest_to_newest 770915 0 beidson 2012-11-19 12:01:59 -0800 Add 64-bit specializations for WTF::atomicIncrement and WTF::atomicDecrement These are needed for WK2 code that might is nominally cross platform. I only know how to add the specializations for Mac, so anyone adopting code that uses them going forward will have to provide their own specializations. 770918 1 175020 beidson 2012-11-19 12:04:45 -0800 Created attachment 175020 Patch v1 770926 2 beidson 2012-11-19 12:13:20 -0800 http://trac.webkit.org/changeset/135186 175020 2012-11-19 12:04:45 -0800 2012-11-19 12:06:21 -0800 Patch v1 patch text/plain 5447 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMmMzMGNjZS4uMDdmNjUxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMS0xOSAg QnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIDY0LWJpdCBz cGVjaWFsaXphdGlvbnMgZm9yIGF0b21pY0luY3JlbWVudCBhbmQgYXRvbWljRGVjcmVtZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI3MDIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9BdG9t aWNzLmg6CisgICAgICAgIChXVEY6OmF0b21pY0luY3JlbWVudCk6IEFkZCBBIDY0LWJpdCB2ZXJz aW9uIGZvciBEYXJ3aW4uCisgICAgICAgIChXVEY6OmF0b21pY0RlY3JlbWVudCk6IERpdHRvLgor CiAyMDEyLTExLTE4ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgUmVtb3ZlIG5vbi1leGlzdGVudCBkaXJlY3RvcmllcyBmcm9tIHRoZSBtYWtlIHN5c3Rl bQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXRvbWljcy5oIGIvU291cmNlL1dURi93dGYv QXRvbWljcy5oCmluZGV4IGUyNTYwYWIuLjc1MGUxMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL0F0b21pY3MuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKQEAgLTEsNSArMSw1 IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA3LCAyMDA4LCAyMDEwIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNywgMjAwOCwgMjAxMCwgMjAx MiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcg SnVzdGluIEhheWdvb2QgKGpoYXlnb29kQHJlYWt0aXguY29tKQogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApA QCAtOTgsNiArOTgsOSBAQCBpbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChpbnQgdm9sYXRpbGUq IGFkZGVuZCkgeyByZXR1cm4gSW50ZXJsb2NrZWREZWNyZW1lbnQocgogaW5saW5lIGludCBhdG9t aWNJbmNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIE9TQXRvbWljSW5jcmVt ZW50MzJCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50Kj4oYWRkZW5kKSk7IH0KIGlubGluZSBpbnQgYXRv bWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBPU0F0b21pY0RlY3Jl bWVudDMyQmFycmllcihjb25zdF9jYXN0PGludCo+KGFkZGVuZCkpOyB9CiAKK2lubGluZSBpbnQ2 NF90IGF0b21pY0luY3JlbWVudChpbnQ2NF90IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIE9T QXRvbWljSW5jcmVtZW50NjRCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50NjRfdCo+KGFkZGVuZCkpOyB9 CitpbmxpbmUgaW50NjRfdCBhdG9taWNEZWNyZW1lbnQoaW50NjRfdCB2b2xhdGlsZSogYWRkZW5k KSB7IHJldHVybiBPU0F0b21pY0RlY3JlbWVudDY0QmFycmllcihjb25zdF9jYXN0PGludDY0X3Qq PihhZGRlbmQpKTsgfQorCiAjZWxpZiBPUyhRTlgpCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZSRUVf VEhSRUFEU0FGRVJFRkNPVU5URUQgMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjY3ZDAwZC4uOTRkMTU2NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTExLTE5ICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBBZGQgNjQtYml0IHNwZWNpYWxpemF0aW9ucyBm b3IgYXRvbWljSW5jcmVtZW50IGFuZCBhdG9taWNEZWNyZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjcwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgYXdheSBmcm9tIHRoZSBEYXJ3aW4t c3BlY2lmaWMgT1NBdG9taWNJbmNyZW1lbnQ2NEJhcnJpZXIgYW5kIHVzZSBXVEY6OmF0b21pY0lu Y3JlbWVudCBpbnN0ZWFkLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Z2VuZXJhdGVXaWxsU2VuZFJlcXVlc3RJ RCk6IEFkb3B0IFdURjo6YXRvbWljSW5jcmVtZW50LgorICAgICAgICAoV2ViS2l0OjpnZW5lcmF0 ZUNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2VJRCk6IERpdHRvLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9tYWMvS2V5Y2hhaW5JdGVtU2hpbU1ldGhvZHMubW06CisgICAgICAg IChXZWJLaXQ6OmdlbmVyYXRlU2VjS2V5Y2hhaW5JdGVtUmVxdWVzdElEKTogRGl0dG8uCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL21hYy9TZWNJdGVtU2hpbU1ldGhvZHMubW06CisgICAgICAgIChX ZWJLaXQ6OmdlbmVyYXRlU2VjSXRlbVJlcXVlc3RJRCk6IERpdHRvLgorCisyMDEyLTExLTE5ICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAgICAgICBOZXR3b3JrUHJvY2Vz cyBBdXRoZW50aWNhdGlvbi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMjU5MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCA0OWMwMjZkLi44MGFhODEzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNv dXJjZUxvYWRlci5jcHAKQEAgLTE4OCw3ICsxODgsNyBAQCBzdGF0aWMgQmxvY2tpbmdSZXNwb25z ZU1hcDxSZXNvdXJjZVJlcXVlc3QqPiYgd2lsbFNlbmRSZXF1ZXN0UmVzcG9uc2VNYXAoKQogc3Rh dGljIHVpbnQ2NF90IGdlbmVyYXRlV2lsbFNlbmRSZXF1ZXN0SUQoKQogewogICAgIHN0YXRpYyBp bnQ2NF90IHVuaXF1ZVdpbGxTZW5kUmVxdWVzdElEOwotICAgIHJldHVybiBPU0F0b21pY0luY3Jl bWVudDY0QmFycmllcigmdW5pcXVlV2lsbFNlbmRSZXF1ZXN0SUQpOworICAgIHJldHVybiBhdG9t aWNJbmNyZW1lbnQoJnVuaXF1ZVdpbGxTZW5kUmVxdWVzdElEKTsKIH0KIAogdm9pZCBOZXR3b3Jr UmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZUhhbmRsZSosIFJlc291cmNl UmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25z ZSkKQEAgLTMxNiw3ICszMTYsNyBAQCBzdGF0aWMgQmxvY2tpbmdCb29sUmVzcG9uc2VNYXAmIGNh bkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2VSZXNwb25zZU1hcAogc3RhdGljIHVp bnQ2NF90IGdlbmVyYXRlQ2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZUlEKCkK IHsKICAgICBzdGF0aWMgaW50NjRfdCB1bmlxdWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVj dGlvblNwYWNlSUQ7Ci0gICAgcmV0dXJuIE9TQXRvbWljSW5jcmVtZW50NjRCYXJyaWVyKCZ1bmlx dWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlSUQpOworICAgIHJldHVybiBh dG9taWNJbmNyZW1lbnQoJnVuaXF1ZUNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3Bh Y2VJRCk7CiB9CiAKIGJvb2wgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpjYW5BdXRoZW50aWNhdGVB Z2FpbnN0UHJvdGVjdGlvblNwYWNlKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUHJvdGVjdGlvblNw YWNlJiBwcm90ZWN0aW9uU3BhY2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL21hYy9LZXljaGFpbkl0ZW1TaGltTWV0aG9kcy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvbWFjL0tleWNoYWluSXRlbVNoaW1NZXRob2RzLm1tCmluZGV4IDU3NTlhYTUuLjIyMDZm OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL0tleWNoYWluSXRl bVNoaW1NZXRob2RzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL0tleWNo YWluSXRlbVNoaW1NZXRob2RzLm1tCkBAIC0xNTAsNyArMTUwLDcgQEAgc3RhdGljIEJsb2NraW5n UmVzcG9uc2VNYXA8U2VjS2V5Y2hhaW5JdGVtUmVzcG9uc2VEYXRhPiYgcmVzcG9uc2VNYXAoKQog c3RhdGljIHVpbnQ2NF90IGdlbmVyYXRlU2VjS2V5Y2hhaW5JdGVtUmVxdWVzdElEKCkKIHsKICAg ICBzdGF0aWMgaW50NjRfdCB1bmlxdWVTZWNLZXljaGFpbkl0ZW1SZXF1ZXN0SUQ7Ci0gICAgcmV0 dXJuIE9TQXRvbWljSW5jcmVtZW50NjRCYXJyaWVyKCZ1bmlxdWVTZWNLZXljaGFpbkl0ZW1SZXF1 ZXN0SUQpOworICAgIHJldHVybiBhdG9taWNJbmNyZW1lbnQoJnVuaXF1ZVNlY0tleWNoYWluSXRl bVJlcXVlc3RJRCk7CiB9CiAKIHZvaWQgZGlkUmVjZWl2ZVNlY0tleWNoYWluSXRlbVJlc3BvbnNl KHVpbnQ2NF90IHJlcXVlc3RJRCwgY29uc3QgU2VjS2V5Y2hhaW5JdGVtUmVzcG9uc2VEYXRhJiBy ZXNwb25zZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1NlY0l0 ZW1TaGltTWV0aG9kcy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1NlY0l0ZW1T aGltTWV0aG9kcy5tbQppbmRleCA1MGNiYjU4Li42ZTYzNDlkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL21hYy9TZWNJdGVtU2hpbU1ldGhvZHMubW0KKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9tYWMvU2VjSXRlbVNoaW1NZXRob2RzLm1tCkBAIC00OCw3ICs0 OCw3IEBAIHN0YXRpYyBCbG9ja2luZ1Jlc3BvbnNlTWFwPFNlY0l0ZW1SZXNwb25zZURhdGE+JiBy ZXNwb25zZU1hcCgpCiBzdGF0aWMgdWludDY0X3QgZ2VuZXJhdGVTZWNJdGVtUmVxdWVzdElEKCkK IHsKICAgICBzdGF0aWMgaW50NjRfdCB1bmlxdWVTZWNJdGVtUmVxdWVzdElEOwotICAgIHJldHVy biBPU0F0b21pY0luY3JlbWVudDY0QmFycmllcigmdW5pcXVlU2VjSXRlbVJlcXVlc3RJRCk7Cisg ICAgcmV0dXJuIGF0b21pY0luY3JlbWVudCgmdW5pcXVlU2VjSXRlbVJlcXVlc3RJRCk7CiB9CiAK IHZvaWQgZGlkUmVjZWl2ZVNlY0l0ZW1SZXNwb25zZSh1aW50NjRfdCByZXF1ZXN0SUQsIGNvbnN0 IFNlY0l0ZW1SZXNwb25zZURhdGEmIHJlc3BvbnNlKQo=