102693 2012-11-19 08:32:58 -0800 webkitpy unit tests should run serially when checking code coverage 2012-11-20 00:20:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth dpranke ojan webkit.review.bot oldest_to_newest 770777 0 zan 2012-11-19 08:32:58 -0800 webkitpy unit tests should run serially when checking code coverage 770778 1 174990 zan 2012-11-19 08:35:21 -0800 Created attachment 174990 Patch 770793 2 174993 zan 2012-11-19 08:54:27 -0800 Created attachment 174993 Patch 770902 3 174993 dpranke 2012-11-19 11:57:13 -0800 Comment on attachment 174993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174993&action=review Thanks for looking at this! I had noticed this but hadn't gotten around to posting a patch. > Tools/Scripts/webkitpy/test/main.py:138 > + self.printer.write("Checking code coverage, so running things serially\n") What's wrong with using _log.warning() for this and the above? 771633 4 174993 zan 2012-11-20 00:17:54 -0800 Comment on attachment 174993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174993&action=review >> Tools/Scripts/webkitpy/test/main.py:138 >> + self.printer.write("Checking code coverage, so running things serially\n") > > What's wrong with using _log.warning() for this and the above? It skews the output a bit, i.e. the warning is written out on the same line as the 'Checking autoinstalled packages ...' update. 'Checking autoinstalled packages ...Checking code coverage, so running things serially' I'll land this with the code using _log.warning and create a patch with a better solution. 771634 5 zan 2012-11-20 00:20:36 -0800 Committed r135264: <http://trac.webkit.org/changeset/135264> 174990 2012-11-19 08:35:21 -0800 2012-11-19 08:54:23 -0800 Patch bug-102693-20121119173311.patch text/plain 1565 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2FiMTE2MmFlYjQzYjdkOTgyMThmNWJmNWE3NmJiNWU0 MDdiOTg4OC4uMDM3ODdlYTViNjFjNjVjMGY1MWUxOWU1Yzg3Y2YwZTZkNTQ0YjllZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTExLTE5ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgd2Via2l0cHkgdW5pdCB0ZXN0cyBzaG91bGQgcnVuIHNlcmlhbGx5IHdoZW4gY2hl Y2tpbmcgY29kZSBjb3ZlcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAyNjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2hlbiBjaGVja2luZyBjb2RlIGNvdmVyYWdlLCB0aGUgdW5pdCB0ZXN0cyBz aG91bGQgbm90IGJlIHJ1biBpbiBwYXJhbGxlbAorICAgICAgICBhcyB0aGlzIGNhdXNlcyB0aGUg dHJhY2luZyBmdW5jdGlvbnMgKHNldCB2aWEgc3lzLnNldHRyYWNlIGluIHRoZSBjb3ZlcmFnZQor ICAgICAgICBtb2R1bGUpIGJlaW5nIG92ZXJyaWRlbiwgcmVzdWx0aW5nIGluIGluY29ycmVjdCBj b3ZlcmFnZSByZXBvcnRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4u cHk6CisgICAgICAgIChUZXN0ZXIuX3J1bl90ZXN0cyk6CisKIDIwMTItMTEtMTkgIENocmlzdG9w aGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbV0syXVtX VFJdIE1lbW9yeSBsZWFrIGluIFRlc3RDb250cm9sbGVyOjppbml0aWFsaXplKCkKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90ZXN0L21haW4ucHkKaW5kZXggZTYzOWE0NTc4NDNkMTQxNjJhOGZiNjliMTZkYmMx NTc1YzMwNTAwNC4uZDhmOTk3ODA1NzJmMzRiNjg5ZDcyYzQ1MDA4MjUyNDlkZjkzNWQ5ZCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkKQEAgLTEzNSw2ICsxMzUsOSBAQCBjbGFzcyBU ZXN0ZXIob2JqZWN0KToKICAgICAgICAgICAgIHNlbGYuX29wdGlvbnMuY2hpbGRfcHJvY2Vzc2Vz ID0gMQogCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuY292ZXJhZ2U6CisgICAgICAgICAgICBf bG9nLndhcm5pbmcoIkNoZWNraW5nIGNvZGUgY292ZXJhZ2UsIHNvIHJ1bm5pbmcgdGhpbmdzIHNl cmlhbGx5IikKKyAgICAgICAgICAgIHNlbGYuX29wdGlvbnMuY2hpbGRfcHJvY2Vzc2VzID0gMQor CiAgICAgICAgICAgICBpbXBvcnQgd2Via2l0cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFsbGVkLmNv dmVyYWdlIGFzIGNvdmVyYWdlCiAgICAgICAgICAgICBjb3YgPSBjb3ZlcmFnZS5jb3ZlcmFnZSgp CiAgICAgICAgICAgICBjb3Yuc3RhcnQoKQo= 174993 2012-11-19 08:54:27 -0800 2012-11-20 00:17:54 -0800 Patch bug-102693-20121119175216.patch text/plain 2810 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2FiMTE2MmFlYjQzYjdkOTgyMThmNWJmNWE3NmJiNWU0 MDdiOTg4OC4uNDMxN2NmMmI1OGZmOGEwYjFiYzA5ZDgzYzRjOGNmODEwYWFkZWMxNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTExLTE5ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgd2Via2l0cHkgdW5pdCB0ZXN0cyBzaG91bGQgcnVuIHNlcmlhbGx5IHdoZW4gY2hl Y2tpbmcgY29kZSBjb3ZlcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTAyNjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2hlbiBjaGVja2luZyBjb2RlIGNvdmVyYWdlLCB0aGUgdW5pdCB0ZXN0cyBz aG91bGQgbm90IGJlIHJ1biBpbiBwYXJhbGxlbAorICAgICAgICBhcyB0aGlzIGNhdXNlcyB0aGUg dHJhY2luZyBmdW5jdGlvbnMgKHNldCB2aWEgc3lzLnNldHRyYWNlIGluIHRoZSBjb3ZlcmFnZQor ICAgICAgICBtb2R1bGUpIGJlaW5nIG92ZXJyaWRlbiwgcmVzdWx0aW5nIGluIGluY29ycmVjdCBj b3ZlcmFnZSByZXBvcnRzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4u cHk6CisgICAgICAgIChUZXN0ZXIuX3J1bl90ZXN0cyk6IFByaW50IHRoZSB3YXJuaW5nIG9mIHJ1 bm5pbmcgdGVzdHMgc2VyaWFsbHkgYWZ0ZXIgcGFja2FnZQorICAgICAgICBpbnN0YWxsYXRpb24g dGhyb3VnaCB0aGUgcHJpbnRlciBhcyB3ZWxsLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dGVzdC9wcmludGVyLnB5OgorICAgICAgICAoUHJpbnRlci53cml0ZSk6IEFkZCBhIG5ldyBtZXRo b2QgZm9yIHdyaXRpbmcgYSBub24tdXBkYXRlIG1lc3NhZ2UgdG8gdGhlIG1ldGVyIHN0cmVhbS4K KwogMjAxMi0xMS0xOSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwu Y29tPgogCiAgICAgICAgIFtXSzJdW1dUUl0gTWVtb3J5IGxlYWsgaW4gVGVzdENvbnRyb2xsZXI6 OmluaXRpYWxpemUoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21h aW4ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQppbmRleCBlNjM5YTQ1 Nzg0M2QxNDE2MmE4ZmI2OWIxNmRiYzE1NzVjMzA1MDA0Li41YzRiZmUwNGJjYzk2NDVjODIyMzZl NjUxY2M4ZGIxMDJhY2M0MTk1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rl c3QvbWFpbi5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQpAQCAt MTMxLDEwICsxMzEsMTMgQEAgY2xhc3MgVGVzdGVyKG9iamVjdCk6CiAgICAgICAgICMgRklYTUU6 IFRoZXJlIGFwcGVhcnMgdG8gYmUgYSBidWcgaW4gUHl0aG9uIDIuNi4xIHRoYXQgaXMgY2F1c2lu ZyBtdWx0aXByb2Nlc3NpbmcKICAgICAgICAgIyB0byBoYW5nIGFmdGVyIHdlIGluc3RhbGwgdGhl IHBhY2thZ2VzIGluIGEgY2xlYW4gY2hlY2tvdXQuCiAgICAgICAgIGlmIGluc3RhbGxlZF9zb21l dGhpbmc6Ci0gICAgICAgICAgICBfbG9nLndhcm5pbmcoIldlIGluc3RhbGxlZCBuZXcgcGFja2Fn ZXMsIHNvIHJ1bm5pbmcgdGhpbmdzIHNlcmlhbGx5IGF0IGZpcnN0IikKKyAgICAgICAgICAgIHNl bGYucHJpbnRlci53cml0ZSgiV2UgaW5zdGFsbGVkIG5ldyBwYWNrYWdlcywgc28gcnVubmluZyB0 aGluZ3Mgc2VyaWFsbHkgYXQgZmlyc3RcbiIpCiAgICAgICAgICAgICBzZWxmLl9vcHRpb25zLmNo aWxkX3Byb2Nlc3NlcyA9IDEKIAogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmNvdmVyYWdlOgor ICAgICAgICAgICAgc2VsZi5wcmludGVyLndyaXRlKCJDaGVja2luZyBjb2RlIGNvdmVyYWdlLCBz byBydW5uaW5nIHRoaW5ncyBzZXJpYWxseVxuIikKKyAgICAgICAgICAgIHNlbGYuX29wdGlvbnMu Y2hpbGRfcHJvY2Vzc2VzID0gMQorCiAgICAgICAgICAgICBpbXBvcnQgd2Via2l0cHkudGhpcmRw YXJ0eS5hdXRvaW5zdGFsbGVkLmNvdmVyYWdlIGFzIGNvdmVyYWdlCiAgICAgICAgICAgICBjb3Yg PSBjb3ZlcmFnZS5jb3ZlcmFnZSgpCiAgICAgICAgICAgICBjb3Yuc3RhcnQoKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L3ByaW50ZXIucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3Rlc3QvcHJpbnRlci5weQppbmRleCAwZWMzMDM1YjM2NGVhYTU2YWZlMWMyNjky ZDg2YTcwYmI0MmRkMTcxLi5kZWQyYzgxYWJiNGUxZWMxNWIyN2ZiNmI2ZDY5NTlmYjJlMGY5YmRh IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvcHJpbnRlci5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvcHJpbnRlci5weQpAQCAtMTA3LDYgKzEwNyw5 IEBAIGNsYXNzIFByaW50ZXIob2JqZWN0KToKICAgICBkZWYgd3JpdGVfdXBkYXRlKHNlbGYsIG1z Zyk6CiAgICAgICAgIHNlbGYubWV0ZXIud3JpdGVfdXBkYXRlKG1zZykKIAorICAgIGRlZiB3cml0 ZShzZWxmLCBtc2cpOgorICAgICAgICBzZWxmLm1ldGVyLndyaXRlKG1zZykKKwogICAgIGRlZiBw cmludF9zdGFydGVkX3Rlc3Qoc2VsZiwgc291cmNlLCB0ZXN0X25hbWUpOgogICAgICAgICBzZWxm LnJ1bm5pbmdfdGVzdHMuYXBwZW5kKHRlc3RfbmFtZSkKICAgICAgICAgaWYgbGVuKHNlbGYucnVu bmluZ190ZXN0cykgPiAxOgo=