102692 2012-11-19 08:29:43 -0800 [BlackBerry] Remove RTSP handling from FrameLoaderClientBlackBerry 2012-11-19 11:30:55 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 lquinn lquinn mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 770772 0 lquinn 2012-11-19 08:29:43 -0800 We currently handle "rtsp:" URIs in FrameLoaderClientBlackBerry, but this causes HTTP redirects to "rtsp:" URIs to fail. We should move handling of "rtsp:" URIs to the network layer alongside other URI schemes like "data:" and "file:". 770790 1 174991 lquinn 2012-11-19 08:44:06 -0800 Created attachment 174991 Patch 770847 2 174991 rwlbuis 2012-11-19 10:29:40 -0800 Comment on attachment 174991 Patch Patch seems fine, but it would be good to have PR and internal reviewer handy as reference. 770848 3 175002 lquinn 2012-11-19 10:31:42 -0800 Created attachment 175002 Patch 770851 4 175002 rwlbuis 2012-11-19 10:36:16 -0800 Comment on attachment 175002 Patch LGTM. 770888 5 175002 webkit.review.bot 2012-11-19 11:30:52 -0800 Comment on attachment 175002 Patch Clearing flags on attachment: 175002 Committed r135181: <http://trac.webkit.org/changeset/135181> 770889 6 webkit.review.bot 2012-11-19 11:30:55 -0800 All reviewed patches have been landed. Closing bug. 174991 2012-11-19 08:44:06 -0800 2012-11-19 10:31:40 -0800 Patch bug-102692-20121119114206.patch text/plain 2191 lquinn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiZjZhOTQ1YjgwOGYwNzkzYjkxY2IzMzk5MTAzMGM1MzlmZThlZWM1Li43ZTdkYWZlMjc3 MTgzNDRiN2VlMjBlNTZhMjBkMTc3YjM3YTZmNTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0xOSAgTGlhbSBRdWlubiAgPGxxdWlubkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgUlRTUCBoYW5kbGluZyBmcm9t IEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgT3VyIFJUU1AgaGFuZGxpbmcgaW4gRnJhbWVMb2FkZXJDbGll bnRCbGFja0JlcnJ5IGNhdXNlcyBIVFRQIHJlZGlyZWN0cyB0byAicnRzcDoiIFVSSXMgdG8gZmFp bC4gUmVtb3ZlIGhhbmRsaW5nIG9mIFJUU1AgZnJvbSB0aGlzIGNsYXNzOyBpdCB3aWxsIGJlIG1v dmVkIHRvIHRoZSBuZXR3b3JrIGxheWVyIGFsb25nc2lkZSBvdGhlciBVUkkgc2NoZW1lcyBsaWtl ICJkYXRhOiIgYW5kICJmaWxlOiIuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJD bGllbnRCbGFja0JlcnJ5OjpjcmVhdGVEb2N1bWVudExvYWRlcik6CisKIDIwMTItMTEtMTYgIEFk YW0gVHJlYXQgIDxhdHJlYXRAcmltLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEJsYWNrQmVycnkuY3BwCmluZGV4IDA3OTBhYjhjOTMwMTAyNmE4YTg3MjNmMjJhMDY0Yjc1ODNm ZDMwNzMuLjBlMDYxOWI0YjE3ZTZhOTlhNWRmYTM1ZWYxNzkxNDMyNGQxZWI4MjggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC03NCw3ICs3NCw2IEBA CiAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1FeGVjdXRhYmxlTWVzc2FnZS5oPgogI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUxvZy5oPgotI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0 Zm9ybU1lZGlhRG9jdW1lbnQuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1NZXNzYWdl Q2xpZW50Lmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtU2NyZWVuLmg+CiAjaW5jbHVk ZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgpAQCAtNDA0LDggKzQwMyw3IEBAIFBhc3NSZWZQ dHI8RG9jdW1lbnRMb2FkZXI+IEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6Y3JlYXRlRG9j dW1lbnRMb2FkZXIoY29uCiAgICAgICAgICAgICAvLyBUaGUgZmlyc3QgNiBsZXR0ZXJzIGlzICJh Ym91dDoiCiAgICAgICAgICAgICBTdHJpbmcgYWJvdXRXaGF0ID0gcmVxdWVzdC51cmwoKS5zdHJp bmcoKS5zdWJzdHJpbmcoNik7CiAgICAgICAgICAgICBzb3VyY2UgPSBhYm91dERhdGEoYWJvdXRX aGF0KTsKLSAgICAgICAgfSBlbHNlIGlmIChyZXF1ZXN0LnVybCgpLnByb3RvY29sSXMoInJ0c3Ai KSkKLSAgICAgICAgICAgIHNvdXJjZSA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjptZWRpYURvY3Vt ZW50KHJlcXVlc3QudXJsKCkuc3RyaW5nKCkpOworICAgICAgICB9CiAKICAgICAgICAgaWYgKCFz b3VyY2UuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAvLyBBbHdheXMgaWdub3JlIGV4aXN0aW5n IHN1YnN0aXR1dGUgZGF0YSBpZiBhbnkuCg== 175002 2012-11-19 10:31:42 -0800 2012-11-19 11:30:51 -0800 Patch bug-102692-20121119132942.patch text/plain 2261 lquinn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBiZjZhOTQ1YjgwOGYwNzkzYjkxY2IzMzk5MTAzMGM1MzlmZThlZWM1Li42YmI4Y2EyMjdm MzQ4MjU1M2EwNWU4NTIwMGQ3YTFlNjg5MzlkZjk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0xOSAgTGlhbSBRdWlubiAgPGxxdWlubkBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgUlRTUCBoYW5kbGluZyBmcm9t IEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBHZW9yZ2UgU3RhaWtv cy4gSW50ZXJuYWwgUFIgMjQyNzUwLgorCisgICAgICAgIE91ciBSVFNQIGhhbmRsaW5nIGluIEZy YW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeSBjYXVzZXMgSFRUUCByZWRpcmVjdHMgdG8gInJ0c3A6 IiBVUklzIHRvIGZhaWwuIFJlbW92ZSBoYW5kbGluZyBvZiBSVFNQIGZyb20gdGhpcyBjbGFzczsg aXQgd2lsbCBiZSBtb3ZlZCB0byB0aGUgbmV0d29yayBsYXllciBhbG9uZ3NpZGUgb3RoZXIgVVJJ IHNjaGVtZXMgbGlrZSAiZGF0YToiIGFuZCAiZmlsZToiLgorCisgICAgICAgICogV2ViQ29yZVN1 cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6Y3JlYXRlRG9jdW1lbnRMb2FkZXIpOgorCiAy MDEyLTExLTE2ICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjU0MApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50Qmxh Y2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCAwNzkwYWI4YzkzMDEwMjZhOGE4NzIz ZjIyYTA2NGI3NTgzZmQzMDczLi4wZTA2MTliNGIxN2U2YTk5YTVkZmEzNWVmMTc5MTQzMjRkMWVi ODI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQv RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcApAQCAt NzQsNyArNzQsNiBAQAogCiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtRXhlY3V0YWJsZU1l c3NhZ2UuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1Mb2cuaD4KLSNpbmNsdWRlIDxC bGFja0JlcnJ5UGxhdGZvcm1NZWRpYURvY3VtZW50Lmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBs YXRmb3JtTWVzc2FnZUNsaWVudC5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNjcmVl bi5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0FQSUNhc3QuaD4KQEAgLTQwNCw4ICs0MDMs NyBAQCBQYXNzUmVmUHRyPERvY3VtZW50TG9hZGVyPiBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnk6OmNyZWF0ZURvY3VtZW50TG9hZGVyKGNvbgogICAgICAgICAgICAgLy8gVGhlIGZpcnN0IDYg bGV0dGVycyBpcyAiYWJvdXQ6IgogICAgICAgICAgICAgU3RyaW5nIGFib3V0V2hhdCA9IHJlcXVl c3QudXJsKCkuc3RyaW5nKCkuc3Vic3RyaW5nKDYpOwogICAgICAgICAgICAgc291cmNlID0gYWJv dXREYXRhKGFib3V0V2hhdCk7Ci0gICAgICAgIH0gZWxzZSBpZiAocmVxdWVzdC51cmwoKS5wcm90 b2NvbElzKCJydHNwIikpCi0gICAgICAgICAgICBzb3VyY2UgPSBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6bWVkaWFEb2N1bWVudChyZXF1ZXN0LnVybCgpLnN0cmluZygpKTsKKyAgICAgICAgfQogCiAg ICAgICAgIGlmICghc291cmNlLmlzRW1wdHkoKSkgewogICAgICAgICAgICAgLy8gQWx3YXlzIGln bm9yZSBleGlzdGluZyBzdWJzdGl0dXRlIGRhdGEgaWYgYW55Lgo=