102682 2012-11-19 05:36:33 -0800 [EFL][WK2] Fix possible crash in EwkViewImpl::displayTimerFired() 2012-11-19 08:17:46 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez d-r gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi ostap73 rakuco tonikitoo webkit.review.bot yael oldest_to_newest 770644 0 cdumez 2012-11-19 05:36:33 -0800 We sometimes get the following crash in EwkViewImpl::displayTimerFired(): 1 0x411ed8 2 0x2b997e86acb0 3 0x2b997e6dd9f1 EwkViewImpl::displayTimerFired(WebCore::Timer<EwkViewImpl>*) 4 0x2b998122f8fa WebCore::ThreadTimers::sharedTimerFiredInternal() 5 0x2b9981b6f7fd 6 0x2b997ef1746e _ecore_timer_expired_call 7 0x2b997ef1763b _ecore_timer_expired_timers_call 8 0x2b997ef14551 9 0x2b997ef14b45 ecore_main_loop_iterate 10 0x411265 TestWebKitAPI::Util::run(bool*) 11 0x40ff15 TestWebKitAPI::WebKit2_DOMWindowExtensionNoCache_Test::TestBody() 12 0x2b997e7ee7ea testing::Test::Run() 13 0x2b997e7ee8f8 testing::internal::TestInfoImpl::Run() 14 0x2b997e7ee9b5 testing::TestCase::Run() 15 0x2b997e7eecee testing::internal::UnitTestImpl::RunAllTests() 16 0x4118a2 TestWebKitAPI::TestsController::run(int, char**) 17 0x4111d9 main 18 0x2b997fb2976d __libc_start_main 19 0x40f3e9 This is caused by the following line: LayerTreeRenderer* renderer = page()->drawingArea()->layerTreeCoordinatorProxy()->layerTreeRenderer(); When the timer is fired, the drawingAreaProxy or the LayerTreeCoordinatorProxy may be NULL already so we need to check for it. 770650 1 174962 cdumez 2012-11-19 05:40:11 -0800 Created attachment 174962 Patch 770705 2 174962 webkit.review.bot 2012-11-19 06:58:52 -0800 Comment on attachment 174962 Patch Clearing flags on attachment: 174962 Committed r135154: <http://trac.webkit.org/changeset/135154> 770706 3 webkit.review.bot 2012-11-19 06:58:56 -0800 All reviewed patches have been landed. Closing bug. 770765 4 yael 2012-11-19 08:17:46 -0800 *** Bug 102222 has been marked as a duplicate of this bug. *** 174962 2012-11-19 05:40:11 -0800 2012-11-19 06:58:52 -0800 Patch 102682_displayTimerFired_crash.patch text/plain 4187 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNmI1NmM4Li5lMTQxZjJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMTEtMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZpeCBwb3NzaWJsZSBjcmFzaCBpbiBFd2tWaWV3 SW1wbDo6ZGlzcGxheVRpbWVyRmlyZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIE5VTEwgY2hlY2sgZm9yIERyYXdpbmdBcmVhUHJveHkgYW5k IExheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkKKyAgICAgICAgaW4gZGlzcGxheVRpbWVyRmlyZWQo KSB0byBhdm9pZCBjcmFzaGluZyBpZiB0aG9zZSBoYXZlIGFscmVhZHkKKyAgICAgICAgYmVlbiBk ZXN0cm95ZWQgYnkgdGhlIHRpbWUgdG8gdGltZXIgaXMgZmlyZWQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHA6CisgICAgICAgIChFd2tWaWV3SW1wbDo6bGF5 ZXJUcmVlUmVuZGVyZXIpOgorICAgICAgICAoRXdrVmlld0ltcGw6OmRpc3BsYXlUaW1lckZpcmVk KToKKyAgICAgICAgKEV3a1ZpZXdJbXBsOjpjcmVhdGVHTFN1cmZhY2UpOgorICAgICAgICAoRXdr Vmlld0ltcGw6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUpOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6CisgICAgICAgIChXZWJLaXQpOgorICAgICAg ICAoRXdrVmlld0ltcGwpOgorCiAyMDEyLTExLTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBUZXN0IC93ZWJraXQyL1dlYktpdFdl YlZpZXcvY3JlYXRlLXJlYWR5LWNsb3NlIGlzIGZhaWxpbmcgYWZ0ZXIgcjEzNDU4NgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwCmluZGV4IGFj YTJkNGQuLjA3NTUzYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL0V3a1ZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9Fd2tWaWV3SW1wbC5jcHAKQEAgLTMyNyw2ICszMjcsMjEgQEAgQWZmaW5lVHJhbnNmb3JtIEV3 a1ZpZXdJbXBsOjp0cmFuc2Zvcm1Ub1NjcmVlbigpIGNvbnN0CiAgICAgcmV0dXJuIHRyYW5zZm9y bTsKIH0KIAorI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKK0xheWVyVHJlZVJlbmRlcmVy KiBFd2tWaWV3SW1wbDo6bGF5ZXJUcmVlUmVuZGVyZXIoKQoreworICAgIERyYXdpbmdBcmVhUHJv eHkqIGRyYXdpbmdBcmVhID0gcGFnZSgpLT5kcmF3aW5nQXJlYSgpOworICAgIGlmICghZHJhd2lu Z0FyZWEpCisgICAgICAgIHJldHVybiAwOworCisgICAgV2ViS2l0OjpMYXllclRyZWVDb29yZGlu YXRvclByb3h5KiBsYXllclRyZWVDb29yZGluYXRvclByb3h5ID0gZHJhd2luZ0FyZWEtPmxheWVy VHJlZUNvb3JkaW5hdG9yUHJveHkoKTsKKyAgICBpZiAoIWxheWVyVHJlZUNvb3JkaW5hdG9yUHJv eHkpCisgICAgICAgIHJldHVybiAwOworCisgICAgcmV0dXJuIGxheWVyVHJlZUNvb3JkaW5hdG9y UHJveHktPmxheWVyVHJlZVJlbmRlcmVyKCk7Cit9CisjZW5kaWYKKwogdm9pZCBFd2tWaWV3SW1w bDo6ZGlzcGxheVRpbWVyRmlyZWQoVGltZXI8RXdrVmlld0ltcGw+KikKIHsKICNpZiBVU0UoQ09P UkRJTkFURURfR1JBUEhJQ1MpCkBAIC0zMzcsNyArMzUyLDEwIEBAIHZvaWQgRXdrVmlld0ltcGw6 OmRpc3BsYXlUaW1lckZpcmVkKFRpbWVyPEV3a1ZpZXdJbXBsPiopCiAgICAgLy8gV2UgYXJlIHN1 cHBvc2VkIHRvIGNsaXAgdG8gdGhlIGFjdHVhbCB2aWV3cG9ydCwgbm90aGluZyBsZXNzLgogICAg IEludFJlY3Qgdmlld3BvcnQoc2QtPnZpZXcueCwgc2QtPnZpZXcueSwgc2QtPnZpZXcudywgc2Qt PnZpZXcuaCk7CiAKLSAgICBMYXllclRyZWVSZW5kZXJlciogcmVuZGVyZXIgPSBwYWdlKCktPmRy YXdpbmdBcmVhKCktPmxheWVyVHJlZUNvb3JkaW5hdG9yUHJveHkoKS0+bGF5ZXJUcmVlUmVuZGVy ZXIoKTsKKyAgICBMYXllclRyZWVSZW5kZXJlciogcmVuZGVyZXIgPSBsYXllclRyZWVSZW5kZXJl cigpOworICAgIGlmICghcmVuZGVyZXIpCisgICAgICAgIHJldHVybjsKKwogICAgIHJlbmRlcmVy LT5zZXRBY3RpdmUodHJ1ZSk7CiAgICAgcmVuZGVyZXItPnNldERyYXdzQmFja2dyb3VuZChtX3Nl dERyYXdzQmFja2dyb3VuZCk7CiAgICAgcmVuZGVyZXItPnN5bmNSZW1vdGVDb250ZW50KCk7CkBA IC01OTYsNyArNjE0LDcgQEAgYm9vbCBFd2tWaWV3SW1wbDo6Y3JlYXRlR0xTdXJmYWNlKGNvbnN0 IEludFNpemUmIHZpZXdTaXplKQogICAgICAgICBpZiAoIW1fZXZhc0dMKSB7CiAgICAgICAgICAg ICBXQVJOKCJGYWlsZWQgdG8gY3JlYXRlIEV2YXNfR0wsIGZhbGxpbmcgYmFjayB0byBzb2Z0d2Fy ZSBtb2RlLiIpOwogICAgICAgICAgICAgbV9pc0hhcmR3YXJlQWNjZWxlcmF0ZWQgPSBmYWxzZTsK LSAgICAgICAgICAgIHBhZ2UoKS0+ZHJhd2luZ0FyZWEoKS0+bGF5ZXJUcmVlQ29vcmRpbmF0b3JQ cm94eSgpLT5sYXllclRyZWVSZW5kZXJlcigpLT5zZXRBY2NlbGVyYXRpb25Nb2RlKFRleHR1cmVN YXBwZXI6OlNvZnR3YXJlTW9kZSk7CisgICAgICAgICAgICBsYXllclRyZWVSZW5kZXJlcigpLT5z ZXRBY2NlbGVyYXRpb25Nb2RlKFRleHR1cmVNYXBwZXI6OlNvZnR3YXJlTW9kZSk7CiAjaWYgRU5B QkxFKFdFQkdMKQogICAgICAgICAgICAgbV9wYWdlUHJveHktPnBhZ2VHcm91cCgpLT5wcmVmZXJl bmNlcygpLT5zZXRXZWJHTEVuYWJsZWQoZmFsc2UpOwogI2VuZGlmCkBAIC02NDEsNyArNjU5LDcg QEAgYm9vbCBFd2tWaWV3SW1wbDo6Y3JlYXRlR0xTdXJmYWNlKGNvbnN0IEludFNpemUmIHZpZXdT aXplKQogCiBib29sIEV3a1ZpZXdJbXBsOjplbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KCkKIHsKLSAgICBwYWdlKCktPmRyYXdpbmdBcmVhKCktPmxheWVyVHJlZUNvb3JkaW5hdG9yUHJv eHkoKS0+bGF5ZXJUcmVlUmVuZGVyZXIoKS0+c2V0QWN0aXZlKHRydWUpOworICAgIGxheWVyVHJl ZVJlbmRlcmVyKCktPnNldEFjdGl2ZSh0cnVlKTsKIAogICAgIGlmICghbV9pc0hhcmR3YXJlQWNj ZWxlcmF0ZWQpCiAgICAgICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgKaW5kZXggMjRjYTRmZC4uYmQyNTZiYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCkBAIC02Miw2 ICs2MiwxMCBAQCBjbGFzcyBXZWJQb3B1cE1lbnVQcm94eUVmbDsKICNpZiBFTkFCTEUoVklCUkFU SU9OKQogY2xhc3MgVmlicmF0aW9uQ2xpZW50RWZsOwogI2VuZGlmCisKKyNpZiBVU0UoQ09PUkRJ TkFURURfR1JBUEhJQ1MpCitjbGFzcyBMYXllclRyZWVSZW5kZXJlcjsKKyNlbmRpZgogfQogCiBu YW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0yMDYsNiArMjEwLDEwIEBAIHByaXZhdGU6CiAgICAgaW5s aW5lIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSgpIGNvbnN0OwogICAgIHZvaWQgZGlz cGxheVRpbWVyRmlyZWQoV2ViQ29yZTo6VGltZXI8RXdrVmlld0ltcGw+Kik7CiAKKyNpZiBVU0Uo Q09PUkRJTkFURURfR1JBUEhJQ1MpCisgICAgV2ViS2l0OjpMYXllclRyZWVSZW5kZXJlciogbGF5 ZXJUcmVlUmVuZGVyZXIoKTsKKyNlbmRpZgorCiAgICAgdm9pZCBpbmZvcm1JY29uQ2hhbmdlKCk7 CiAKICAgICBzdGF0aWMgdm9pZCBvbk1vdXNlRG93bih2b2lkKiBkYXRhLCBFdmFzKiwgRXZhc19P YmplY3QqLCB2b2lkKiBldmVudEluZm8pOwo=