102673 2012-11-19 04:20:59 -0800 Web Inspector: Refine JsDoc in DebuggerScriptMapping.js 2012-11-19 05:23:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas.bug eustas.bug apavlov caseq eustas.bug keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 770590 0 eustas.bug 2012-11-19 04:20:59 -0800 DebuggerScriptMapping calls public method "addScript" not defined in SourceMapping interface. To make things clear I've added ScriptSourceMapping interface that extends SourceMapping interface by adding "addScript" method. 770599 1 174951 eustas.bug 2012-11-19 04:28:21 -0800 Created attachment 174951 Patch 770635 2 174951 webkit.review.bot 2012-11-19 05:23:40 -0800 Comment on attachment 174951 Patch Clearing flags on attachment: 174951 Committed r135142: <http://trac.webkit.org/changeset/135142> 770636 3 webkit.review.bot 2012-11-19 05:23:43 -0800 All reviewed patches have been landed. Closing bug. 174951 2012-11-19 04:28:21 -0800 2012-11-19 05:23:40 -0800 Patch bug-102673-20121119162610.patch text/plain 5434 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU3NDU3YzFhM2M5Zjhi MTNmYTNjNzM4ZWQ1NTA5YzQyNTdkMWZkYS4uMjM1MGI0NzZlYzA4MWU1NTcyY2E2OTE5NjI3N2Y5 ZjVlYzlkN2IyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTE5ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBSZWZpbmUgSnNEb2MgaW4gRGVidWdnZXJTY3JpcHRNYXBwaW5nLmpzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NzMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWJ1Z2dlclNjcmlwdE1h cHBpbmcgY2FsbHMgcHVibGljIG1ldGhvZCAiYWRkU2NyaXB0IiBub3QgZGVmaW5lZAorICAgICAg ICBpbiBTb3VyY2VNYXBwaW5nIGludGVyZmFjZS4KKworICAgICAgICBUbyBtYWtlIHRoaW5ncyBj bGVhciBJJ3ZlIGFkZGVkIFNjcmlwdFNvdXJjZU1hcHBpbmcgaW50ZXJmYWNlIHRoYXQKKyAgICAg ICAgZXh0ZW5kcyBTb3VyY2VNYXBwaW5nIGludGVyZmFjZSBieSBhZGRpbmcgImFkZFNjcmlwdCIg bWV0aG9kLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VNYXBwaW5nLmpz OiBBZGRlZCAiU2NyaXB0U291cmNlTWFwcGluZyIuCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Db21waWxlclNjcmlwdE1hcHBpbmcuanM6CisgICAgICAgIFVwZGF0ZWQgIkBpbXBsZW1l bnRzIiB0byBTY3JpcHRTb3VyY2VNYXBwaW5nLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvUmVzb3VyY2VTY3JpcHRNYXBwaW5nLmpzOiBEaXR0by4KKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL1NjcmlwdFNuaXBwZXRNb2RlbC5qczogRGl0dG8uCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9EZWJ1Z2dlclNjcmlwdE1hcHBpbmcuanM6IFVwZGF0ZWQgc2lnbmF0dXJl cy4KKyAgICAgICAgUmVtb3ZlZCB1c2VsZXNzIGNvZGUuCisKIDIwMTItMTEtMTkgIEtlbnRhcm8g SGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMzUxMTQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0NvbXBpbGVyU2NyaXB0TWFwcGluZy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCmluZGV4IDYyNTllOWEzZjQyMWUz NzE4ZDg2ZDc1ZDIwMTdmMjQyYmE3ZjIxOWQuLmU3MDMwNjY5NTNhYTZmMjRkMzEzYWQ2NDRlODk1 ZWZhNGI0NTM2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29tcGlsZXJTY3JpcHRNYXBwaW5nLmpzCkBAIC0zMCw3ICszMCw3IEBACiAK IC8qKgogICogQGNvbnN0cnVjdG9yCi0gKiBAaW1wbGVtZW50cyB7V2ViSW5zcGVjdG9yLlNvdXJj ZU1hcHBpbmd9CisgKiBAaW1wbGVtZW50cyB7V2ViSW5zcGVjdG9yLlNjcmlwdFNvdXJjZU1hcHBp bmd9CiAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5Xb3Jrc3BhY2V9IHdvcmtzcGFjZQogICogQHBh cmFtIHtXZWJJbnNwZWN0b3IuTmV0d29ya1dvcmtzcGFjZVByb3ZpZGVyfSBuZXR3b3JrV29ya3Nw YWNlUHJvdmlkZXIKICAqLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9EZWJ1Z2dlclNjcmlwdE1hcHBpbmcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RlYnVnZ2VyU2NyaXB0TWFwcGluZy5qcwppbmRleCBmYTFhNmU4YTE4OGEx N2RlMDk4NTM4ZWEwMDE1ZWI3ZmQxODIwMTE1Li5jZTgwNWM0MjJiMTUyNWNlMzE4NTM4OTE3MDNi Y2JmZjcyYTRlMzE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0RlYnVnZ2VyU2NyaXB0TWFwcGluZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0RlYnVnZ2VyU2NyaXB0TWFwcGluZy5qcwpAQCAtMzUsMTQgKzM1LDkgQEAK ICAqLwogV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2NyaXB0TWFwcGluZyA9IGZ1bmN0aW9uKHdvcmtz cGFjZSwgbmV0d29ya1dvcmtzcGFjZVByb3ZpZGVyKQogewotICAgIHRoaXMuX21hcHBpbmdzID0g W107Ci0gIAogICAgIHRoaXMuX3Jlc291cmNlTWFwcGluZyA9IG5ldyBXZWJJbnNwZWN0b3IuUmVz b3VyY2VTY3JpcHRNYXBwaW5nKHdvcmtzcGFjZSk7Ci0gICAgdGhpcy5fbWFwcGluZ3MucHVzaCh0 aGlzLl9yZXNvdXJjZU1hcHBpbmcpOwogICAgIHRoaXMuX2NvbXBpbGVyTWFwcGluZyA9IG5ldyBX ZWJJbnNwZWN0b3IuQ29tcGlsZXJTY3JpcHRNYXBwaW5nKHdvcmtzcGFjZSwgbmV0d29ya1dvcmtz cGFjZVByb3ZpZGVyKTsKLSAgICB0aGlzLl9tYXBwaW5ncy5wdXNoKHRoaXMuX2NvbXBpbGVyTWFw cGluZyk7CiAgICAgdGhpcy5fc25pcHBldE1hcHBpbmcgPSBXZWJJbnNwZWN0b3Iuc2NyaXB0U25p cHBldE1vZGVsLnNjcmlwdE1hcHBpbmc7Ci0gICAgdGhpcy5fbWFwcGluZ3MucHVzaCh0aGlzLl9z bmlwcGV0TWFwcGluZyk7CiAKICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNb2RlbC5hZGRFdmVu dExpc3RlbmVyKFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1vZGVsLkV2ZW50cy5QYXJzZWRTY3JpcHRT b3VyY2UsIHRoaXMuX3BhcnNlZFNjcmlwdFNvdXJjZSwgdGhpcyk7CiAgICAgV2ViSW5zcGVjdG9y LmRlYnVnZ2VyTW9kZWwuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuRGVidWdnZXJNb2Rl bC5FdmVudHMuRmFpbGVkVG9QYXJzZVNjcmlwdFNvdXJjZSwgdGhpcy5fcGFyc2VkU2NyaXB0U291 cmNlLCB0aGlzKTsKQEAgLTYxLDcgKzU2LDcgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyU2NyaXB0 TWFwcGluZy5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAgKiBAcGFyYW0ge1dlYkluc3Bl Y3Rvci5TY3JpcHR9IHNjcmlwdAotICAgICAqIEByZXR1cm4ge1dlYkluc3BlY3Rvci5Tb3VyY2VN YXBwaW5nfQorICAgICAqIEByZXR1cm4ge1dlYkluc3BlY3Rvci5TY3JpcHRTb3VyY2VNYXBwaW5n fQogICAgICAqLwogICAgIF9tYXBwaW5nRm9yU2NyaXB0OiBmdW5jdGlvbihzY3JpcHQpCiAgICAg ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZVNjcmlwdE1hcHBpbmcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlU2NyaXB0TWFwcGluZy5qcwppbmRleCA2ZmZjNDczYjZjN2Q1NWUyMzYwM2NiNGQ5MGU1 NTMzZTc3ZDYwZGIwLi4wMGYxMWMyMTU1NTQzMTRiN2VlYmU5MzczZDllMWI2MjNjM2RjY2VmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlU2Ny aXB0TWFwcGluZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlU2NyaXB0TWFwcGluZy5qcwpAQCAtMzAsNyArMzAsNyBAQAogCiAvKioKICAqIEBjb25z dHJ1Y3RvcgotICogQGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5Tb3VyY2VNYXBwaW5nfQorICog QGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5TY3JpcHRTb3VyY2VNYXBwaW5nfQogICogQHBhcmFt IHtXZWJJbnNwZWN0b3IuV29ya3NwYWNlfSB3b3Jrc3BhY2UKICAqLwogV2ViSW5zcGVjdG9yLlJl c291cmNlU2NyaXB0TWFwcGluZyA9IGZ1bmN0aW9uKHdvcmtzcGFjZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0U25pcHBldE1vZGVsLmpzIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRTbmlwcGV0TW9kZWwuanMK aW5kZXggYTE5NzA4M2NkN2MyODcxYjdjZTVhMDVmYzczOTIzZjU1ODAyMzE1Ny4uZjViMTQ0Yjgy MTJmMjI4MTI5YWVkYzdhYmU0ZjI2ZjE3MzdiMjFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRTbmlwcGV0TW9kZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRTbmlwcGV0TW9kZWwuanMKQEAgLTQ4 Miw3ICs0ODIsNyBAQCBXZWJJbnNwZWN0b3IuU25pcHBldFNjcmlwdEZpbGUucHJvdG90eXBlID0g ewogCiAvKioKICAqIEBjb25zdHJ1Y3RvcgotICogQGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5T b3VyY2VNYXBwaW5nfQorICogQGltcGxlbWVudHMge1dlYkluc3BlY3Rvci5TY3JpcHRTb3VyY2VN YXBwaW5nfQogICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuU2NyaXB0U25pcHBldE1vZGVsfSBzY3Jp cHRTbmlwcGV0TW9kZWwKICAqLwogV2ViSW5zcGVjdG9yLlNuaXBwZXRTY3JpcHRNYXBwaW5nID0g ZnVuY3Rpb24oc2NyaXB0U25pcHBldE1vZGVsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VNYXBwaW5nLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VNYXBwaW5nLmpzCmluZGV4IDg4NzhmMTEzNTljZGU4YzYx NzJlY2JmZjE4N2QwNjViYTQ0MWZhM2EuLmNkOTAxMzQzOTAwNjM5YWY2ZmMwMWNkMjlmODE4ZTRl OGZjYjUzYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv U291cmNlTWFwcGluZy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1NvdXJjZU1hcHBpbmcuanMKQEAgLTUwLDMgKzUwLDE4IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VN YXBwaW5nLnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAgICB1aUxvY2F0aW9uVG9SYXdMb2NhdGlv bjogZnVuY3Rpb24odWlTb3VyY2VDb2RlLCBsaW5lTnVtYmVyLCBjb2x1bW5OdW1iZXIpIHsgfQog fQorCisvKioKKyAqIEBpbnRlcmZhY2UKKyAqIEBleHRlbmRzIHtXZWJJbnNwZWN0b3IuU291cmNl TWFwcGluZ30KKyAqLworV2ViSW5zcGVjdG9yLlNjcmlwdFNvdXJjZU1hcHBpbmcgPSBmdW5jdGlv bigpCit7Cit9CisKK1dlYkluc3BlY3Rvci5TY3JpcHRTb3VyY2VNYXBwaW5nLnByb3RvdHlwZSA9 IHsKKyAgICAvKioKKyAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5TY3JpcHR9IHNjcmlwdAor ICAgICAqLworICAgIGFkZFNjcmlwdDogZnVuY3Rpb24oc2NyaXB0KSB7IH0KK30KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCg==