10267 2006-08-05 02:52:16 -0700 Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe 2007-07-06 12:25:24 -0700 1 1 1 Unclassified WebKit Frames 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.screwedbydesign.com/blog/2006/08/firefox_2_visual_refresh_progress.php HasReduction P3 Normal --- 1 jonathanjohnsson webkit-unassigned ap hyatt mitz mjuhos mrowe timothy.c.bates oldest_to_newest 51843 0 jonathanjohnsson 2006-08-05 02:52:16 -0700 In the reported page, try scrolling the page with the mouse scroll wheel, when the mouse pointer is on top of the google ad just above the comments section. You can only scroll up, not down. (The ads may change, it's the two column, text only ads that seem to have this behaviour.) I reduced the problem, and it shows that if the iframe has scrolling="no" set, and the iframe height is smaller than its enclosed source, you can't scroll downward as described above (scrolling sideways works). Both Firefox 1.5 and Opera 9 will scroll in any direction, while both latest Safari and latest WebKit won't scroll downwards. Reduction follows. 51844 1 9889 jonathanjohnsson 2006-08-05 02:55:20 -0700 Created attachment 9889 Iframe used in reduction 51845 2 9890 jonathanjohnsson 2006-08-05 02:56:52 -0700 Created attachment 9890 Reduction of the reported page 42923 3 timothy.c.bates 2006-12-07 18:20:50 -0800 Repros in the current build. can't scroll down when mouse is over the iFrame. 35250 4 12415 jonathanjohnsson 2007-01-13 06:53:55 -0800 Created attachment 12415 Reduction of the reported page Changed a link in the reduction, the link broke when buzilla moved. Maybe it isn't a good idea to link between attachments... 35251 5 jonathanjohnsson 2007-01-13 06:56:42 -0800 Trying the reduction using a trackpad with ToT, I noticed that you can neither scroll down nor to the right when the mouse pointer is on top of the iframe. 35252 6 jonathanjohnsson 2007-01-13 07:05:05 -0800 I just want to say that this is one of very few bugs that I notice almost daily, and that I would really appreciate it if someone could fix it, even if it's non-critical and easy to work around. 35133 7 hyatt 2007-01-13 14:35:45 -0800 This appears to be an AppKit bug. It is not forwarding the scroll wheel event up the nextResponder chain properly. For some reason it's just eating the event. I'll have to hunt for a workaround... 11164 8 mitz 2007-05-04 11:06:19 -0700 *** Bug 13586 has been marked as a duplicate of this bug. *** 5602 9 mrowe 2007-07-04 09:53:03 -0700 Dave, any luck with finding a workaround? 5523 10 mrowe 2007-07-05 10:41:45 -0700 NSScrollView determines whether to forward the event to the next responder by verifying whether the document view is already "pinned" at the relevant edge of the scroll view. In the case of the attached reduction this is never true. The iframe's document is 1 pixel taller than the iframe itself, but it has the scrollbars hidden. Because the document view is not pinned the scroll view accepts the mouse wheel event, but as the scrollbars are hidden the scrolling has no effect. 5508 11 15403 mitz 2007-07-05 12:22:33 -0700 Created attachment 15403 Forward wheel events to the next responder if scrolling is not allowed Patch mostly by Mark Rowe. I did not find a way in AppKit to generate mouse wheel events, so there is no test (and no changes to DumpRenderTree). 5510 12 15403 mitz 2007-07-05 12:49:39 -0700 Comment on attachment 15403 Forward wheel events to the next responder if scrolling is not allowed Forgot to mention that checking each direction separately is required for cases such as an iframe whose root has 'overflow-x:hidden; overflow-y:scroll'. 5486 13 15403 mjs 2007-07-05 19:38:32 -0700 Comment on attachment 15403 Forward wheel events to the next responder if scrolling is not allowed This looks incorrect in the case where both deltas are non-zero - in that case it should be checking for both horizontal and vertical scrolling allowed. (I think this can actually happen when doing the "two finger scroll" gesture on trackpacks). 5440 14 15412 mitz 2007-07-05 23:43:49 -0700 Created attachment 15412 Forward wheel events to the next responder if scrolling is not allowed This version decides based on the bigger component of the scroll direction. 5438 15 mrowe 2007-07-06 00:01:39 -0700 The reason whether the Y axis was given priority over the X axis in the initial patch as this is the same logic that NSScrollView uses to determine whether a the document view is pinned. If the scroll event has *any* Y component it will check whether it is pinned on the Y axis, and completely ignore the X component. In my opinion it makes sense to match that logic here. 5417 16 mitz 2007-07-06 00:14:26 -0700 (In reply to comment #15) > If the scroll event has *any* Y component it will > check whether it is pinned on the Y axis, and completely ignore the X > component. In that case, if the view is not pinned on the Y axis, but does not have a vertical scrollbar, is the event completely ignored or does horizontal scrolling still happen if possible? If it's the former, then I agree that it's best to match AppKit. Otherwise, I think the new patch is currently equivalent but will be even better in the future if AppKit changes. 5418 17 mitz 2007-07-06 00:19:21 -0700 Actually it's not equivalent in either case, and is indeed worse if AppKit will swallow the event. 5430 18 mrowe 2007-07-06 02:03:58 -0700 In the scenario you mention, the Y component of the scroll event will simply be ignored and the scroll view will process the X component. 5431 19 mitz 2007-07-06 02:08:48 -0700 (In reply to comment #18) > In the scenario you mention, the Y component of the scroll event will simply be > ignored and the scroll view will process the X component. > So if the iframe is scrollable along the X axis and a wheel event comes in with a tiny Y component and a big X component, the new patch will keep the event in the iframe and subsequently it will scroll horizontally, whereas the initial patch will forward to the page (which may or may not scroll). I think the behavior of the new patch is better. 5409 20 15412 mjs 2007-07-06 02:47:46 -0700 Comment on attachment 15412 Forward wheel events to the next responder if scrolling is not allowed I'm convinced. r=me 5412 21 mrowe 2007-07-06 02:54:28 -0700 Landed in r24050. 5390 22 jonathanjohnsson 2007-07-06 04:41:05 -0700 I tested the reduction above using ToT (r24057), and it now works to two-finger scroll in all directions when on top of the black area. Nice, thanks! :) However, when the pointer is positioned on what seems to be a two pixel thick border around the iframe, I can't scroll in any direction. While it in no way is as annoying as before, and the target area is small, I believe you could quite easily stumble upon it when two-finger scrolling, since this is done pixel by pixel. Try two-finger scrolling slowly across the reduction to see what I mean. 5388 23 mrowe 2007-07-06 04:46:57 -0700 Thanks for testing Jonathan. The other problem you describe is one we ran into while testing. It'd be great if you could file a bug report specifically for that problem so it can also be tracked in Bugzilla. 5383 24 jonathanjohnsson 2007-07-06 04:56:24 -0700 Ok, Mark, I will do that. I thought this new bug might have been a result of the fix for this bug, but now when I look at it I see that it appeared before the fix as well. 5341 25 mitz 2007-07-06 12:25:24 -0700 (In reply to comment #24) > Ok, Mark, I will do that. I thought this new bug might have been a result of > the fix for this bug, but now when I look at it I see that it appeared before > the fix as well. > I think I have a fix for it, so I am going to file it now (it was a totally different problem than I thought). 9889 2006-08-05 02:55:20 -0700 2006-08-05 02:55:20 -0700 Iframe used in reduction iframe.html text/html 128 jonathanjohnsson PEhUTUw+Cgk8SEVBRD4KCTwvSEVBRD4KCTxCT0RZIGJnY29sb3I9IiMwMDAwMDAiIHN0eWxlPSJo ZWlnaHQ6IDIwMXB4OyB3aWR0aDogMjAwMXB4OyBwYWRkaW5nOiAwOyBtYXJnaW46IDA7Ij4KCTwv Qk9EWT4KPC9IVE1MPgo= 9890 2006-08-05 02:56:52 -0700 2007-01-13 06:53:55 -0800 Reduction of the reported page reduction_bug10267.html text/html 693 jonathanjohnsson PEhUTUw+Cgk8SEVBRD4KCQk8VElUTEU+DQoJCVJlZHVjdGlvbiBvZiBidWcgMTAyNjcKCQk8L1RJ VExFPgoJCTxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+DQoJCTwhLS0NCgkJLnNwYWNlciB7IGRpc3Bs YXk6YmxvY2s7IA0KCQkgICAgICAgICAgaGVpZ2h0OiA2MDBweDsNCgkJfQ0KCQktLT4NCgkJPC9z dHlsZT4KCTwvSEVBRD4KCTxCT0RZIGJnY29sb3I9IiNGRkZGRkYiPgoJCTxkaXYgY2xhc3M9InNw YWNlciI+CgkJCVRyeSBzY3JvbGxpbmcgdGhlIHBhZ2Ugd2l0aCB5b3VyIG1vdXNlIHdoZWVsLCB3 aGVuIHlvdSBoYXZlIHRoZSBwb2ludGVyIG9uIHRvcCBvZiB0aGUgYmxhY2sgaWZyYW1lIGJlbG93 LiBBbGwgZGlyZWN0aW9ucyB3b3JrLCBleGNlcHQgZG93bndhcmRzLiBJZiB0aGUgaGVpZ2h0IG9m IHRoZSBpZnJhbWUgaXMgc21hbGxlciB0aGFuIHRoZSBoZWlnaHQgb2YgdGhlIGJvZHkgZWxlbWVu dCBpbiB0aGUgaWZyYW1lLCB5b3UgY2FuJ3Qgc2Nyb2xsIGRvd253YXJkcyBpbiBXZWJLaXQuCgkJ PC9kaXY+CgkJPElGUkFNRSB3aWR0aD0iMjAwMCIgaGVpZ2h0PSIyMDAiIHNyYz0iaHR0cDovL2J1 Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTk4ODkiIHNjcm9sbGluZz0i bm8iPgoJCTwvSUZSQU1FPgoJCTxkaXYgY2xhc3M9InNwYWNlciI+CgkJPC9kaXY+Cgk8L0JPRFk+ CjwvSFRNTD4K 12415 2007-01-13 06:53:55 -0800 2007-01-13 06:53:55 -0800 Reduction of the reported page Reduced test case for bug 10267.html text/html 678 jonathanjohnsson PEhUTUw+Cgk8SEVBRD4KCQk8VElUTEU+CgkJUmVkdWN0aW9uIG9mIGJ1ZyAxMDI2NwoJCTwvVElU TEU+CgkJPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCQk8IS0tCgkJLnNwYWNlciB7IGRpc3BsYXk6 YmxvY2s7IAoJCSAgICAgICAgICBoZWlnaHQ6IDYwMHB4OwoJCX0KCQktLT4KCQk8L3N0eWxlPgoJ PC9IRUFEPgoJPEJPRFkgYmdjb2xvcj0iI0ZGRkZGRiI+CgkJPGRpdiBjbGFzcz0ic3BhY2VyIj4K CQkJVHJ5IHNjcm9sbGluZyB0aGUgcGFnZSB3aXRoIHlvdXIgbW91c2Ugd2hlZWwsIHdoZW4geW91 IGhhdmUgdGhlIHBvaW50ZXIgb24gdG9wIG9mIHRoZSBibGFjayBpZnJhbWUgYmVsb3cuIEFsbCBk aXJlY3Rpb25zIHdvcmssIGV4Y2VwdCBkb3dud2FyZHMuIElmIHRoZSBoZWlnaHQgb2YgdGhlIGlm cmFtZSBpcyBzbWFsbGVyIHRoYW4gdGhlIGhlaWdodCBvZiB0aGUgYm9keSBlbGVtZW50IGluIHRo ZSBpZnJhbWUsIHlvdSBjYW4ndCBzY3JvbGwgZG93bndhcmRzIGluIFdlYktpdC4KCQk8L2Rpdj4K CQk8SUZSQU1FIHdpZHRoPSIyMDAwIiBoZWlnaHQ9IjIwMCIgc3JjPSJodHRwOi8vYnVncy53ZWJr aXQub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTk4ODkiIHNjcm9sbGluZz0ibm8iPgoJCTwvSUZSQU1F PgoJCTxkaXYgY2xhc3M9InNwYWNlciI+CgkJPC9kaXY+Cgk8L0JPRFk+CjwvSFRNTD4K 15403 2007-07-05 12:22:33 -0700 2007-07-05 23:43:49 -0700 Forward wheel events to the next responder if scrolling is not allowed 10267_r0.patch text/plain 1799 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjQwMjEpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKzIwMDctMDctMDUgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NworICAgICAgICAgIENhbid0 IHNjcm9sbCBwYWdlIGRvd253YXJkcyB3aXRoIHNjcm9sbCB3aGVlbCwgd2hlbiBwb2ludGVyIGlz IG9uIHRvcCBvZiBub24tc2Nyb2xsaW5nIGlmcmFtZQorCisgICAgICAgICogV2ViVmlldy9XZWJE eW5hbWljU2Nyb2xsQmFyc1ZpZXcubToKKyAgICAgICAgKC1bV2ViRHluYW1pY1Njcm9sbEJhcnNW aWV3IHNjcm9sbFdoZWVsOl0pOiBPdmVycmlkZSB0aGUgc3VwZXJjbGFzcworICAgICAgICBpbXBs ZW1lbnRhdGlvbiB0byBmb3J3YXJkIHRoZSB3aGVlbCBldmVudCB0byB0aGUgbmV4dCByZXNwb25k ZXIgaWYgdGhpcyB2aWV3CisgICAgICAgIGRvZXMgbm90IGFsbG93IHNjcm9sbGluZyBpbiB0aGUg ZXZlbnQncyBkaXJlY3Rpb24uCisKIDIwMDctMDctMDQgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBw bGUuY29tPgogCiAgICAgICAgIE1vdmUgdG9vbHRpcCBsb2dpYyBkb3duIGludG8gV2ViQ29yZSBz byB0aGF0IGl0IGNhbiBiZSBzaGFyZWQgY3Jvc3MtcGxhdGZvcm0KSW5kZXg6IFdlYktpdC9XZWJW aWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9XZWJW aWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tCShyZXZpc2lvbiAyNDAxOCkKKysrIFdlYktp dC9XZWJWaWV3L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tCSh3b3JraW5nIGNvcHkpCkBAIC0y OSw2ICsyOSw3IEBACiAjaW1wb3J0IDxXZWJLaXQvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lmg+ CiAKICNpbXBvcnQgPFdlYktpdC9XZWJEb2N1bWVudC5oPgorI2ltcG9ydCA8V2ViS2l0U3lzdGVt SW50ZXJmYWNlLmg+CiAKIEBpbXBsZW1lbnRhdGlvbiBXZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcK IApAQCAtMjc0LDQgKzI3NSwyNCBAQAogICAgIHJldHVybiBZRVM7CiB9CiAKKy0gKHZvaWQpc2Ny b2xsV2hlZWw6KE5TRXZlbnQgKilldmVudAoreworICAgIGZsb2F0IGRlbHRhWDsKKyAgICBmbG9h dCBkZWx0YVk7CisgICAgQk9PTCBpc0NvbnRpbnVvdXM7CisgICAgV0tHZXRXaGVlbEV2ZW50RGVs dGFzKGV2ZW50LCAmZGVsdGFYLCAmZGVsdGFZLCAmaXNDb250aW51b3VzKTsKKworICAgIGlmIChk ZWx0YVkpIHsKKyAgICAgICAgaWYgKCFbc2VsZiBhbGxvd3NWZXJ0aWNhbFNjcm9sbGluZ10pIHsK KyAgICAgICAgICAgIFtbc2VsZiBuZXh0UmVzcG9uZGVyXSBzY3JvbGxXaGVlbDpldmVudF07Cisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICB9IGVsc2UgaWYgKCFbc2VsZiBhbGxv d3NIb3Jpem9udGFsU2Nyb2xsaW5nXSkgeworICAgICAgICBbW3NlbGYgbmV4dFJlc3BvbmRlcl0g c2Nyb2xsV2hlZWw6ZXZlbnRdOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgW3N1cGVy IHNjcm9sbFdoZWVsOmV2ZW50XTsKK30KKwogQGVuZAo= 15412 2007-07-05 23:43:49 -0700 2007-07-06 02:47:46 -0700 Forward wheel events to the next responder if scrolling is not allowed 10267_r1.patch text/plain 1767 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjQwNDIpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKzIwMDctMDctMDUgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NworICAgICAgICAgIENhbid0 IHNjcm9sbCBwYWdlIGRvd253YXJkcyB3aXRoIHNjcm9sbCB3aGVlbCwgd2hlbiBwb2ludGVyIGlz IG9uIHRvcCBvZiBub24tc2Nyb2xsaW5nIGlmcmFtZQorCisgICAgICAgICogV2ViVmlldy9XZWJE eW5hbWljU2Nyb2xsQmFyc1ZpZXcubToKKyAgICAgICAgKC1bV2ViRHluYW1pY1Njcm9sbEJhcnNW aWV3IHNjcm9sbFdoZWVsOl0pOiBPdmVycmlkZSB0aGUgc3VwZXJjbGFzcworICAgICAgICBpbXBs ZW1lbnRhdGlvbiB0byBmb3J3YXJkIHRoZSB3aGVlbCBldmVudCB0byB0aGUgbmV4dCByZXNwb25k ZXIgaWYgdGhpcyB2aWV3CisgICAgICAgIGRvZXMgbm90IGFsbG93IHNjcm9sbGluZyBpbiB0aGUg ZXZlbnQncyBkaXJlY3Rpb24uCisKIDIwMDctMDctMDUgIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZh bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbQpJbmRleDogd2Via2l0L1dl YlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd2Via2l0L1dl YlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm0JKHJldmlzaW9uIDI0MDQyKQorKysgd2Vi a2l0L1dlYlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm0JKHdvcmtpbmcgY29weSkKQEAg LTI5LDYgKzI5LDcgQEAKICNpbXBvcnQgPFdlYktpdC9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcu aD4KIAogI2ltcG9ydCA8V2ViS2l0L1dlYkRvY3VtZW50Lmg+CisjaW1wb3J0IDxXZWJLaXRTeXN0 ZW1JbnRlcmZhY2UuaD4KIAogQGltcGxlbWVudGF0aW9uIFdlYkR5bmFtaWNTY3JvbGxCYXJzVmll dwogCkBAIC0yNzQsNCArMjc1LDI0IEBACiAgICAgcmV0dXJuIFlFUzsKIH0KIAorLSAodm9pZClz Y3JvbGxXaGVlbDooTlNFdmVudCAqKWV2ZW50Cit7CisgICAgZmxvYXQgZGVsdGFYOworICAgIGZs b2F0IGRlbHRhWTsKKyAgICBCT09MIGlzQ29udGludW91czsKKyAgICBXS0dldFdoZWVsRXZlbnRE ZWx0YXMoZXZlbnQsICZkZWx0YVgsICZkZWx0YVksICZpc0NvbnRpbnVvdXMpOworCisgICAgaWYg KGZhYnNmKGRlbHRhWSkgPiBmYWJzZihkZWx0YVgpKSB7CisgICAgICAgIGlmICghW3NlbGYgYWxs b3dzVmVydGljYWxTY3JvbGxpbmddKSB7CisgICAgICAgICAgICBbW3NlbGYgbmV4dFJlc3BvbmRl cl0gc2Nyb2xsV2hlZWw6ZXZlbnRdOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9Cisg ICAgfSBlbHNlIGlmICghW3NlbGYgYWxsb3dzSG9yaXpvbnRhbFNjcm9sbGluZ10pIHsKKyAgICAg ICAgW1tzZWxmIG5leHRSZXNwb25kZXJdIHNjcm9sbFdoZWVsOmV2ZW50XTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworICAgIFtzdXBlciBzY3JvbGxXaGVlbDpldmVudF07Cit9CisKIEBlbmQK