102668 2012-11-19 02:22:37 -0800 [GTK] Test /webkit2/WebKitWebView/create-ready-close is failing after r134586 2012-11-19 03:23:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot oldest_to_newest 770510 0 cgarcia 2012-11-19 02:22:37 -0800 Change in r134586 is not the problem, it indeed fixes the FIXME we have in the tests. The problem is that we were assuming that when no geometry is given to window.open() the default window rect is empty. This is not true anymore after r134586. 770517 1 174927 cgarcia 2012-11-19 02:29:16 -0800 Created attachment 174927 Patch 770518 2 webkit.review.bot 2012-11-19 02:32:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 770552 3 cgarcia 2012-11-19 03:23:27 -0800 Committed r135135: <http://trac.webkit.org/changeset/135135> 174927 2012-11-19 02:29:16 -0800 2012-11-19 03:14:15 -0800 Patch wk2-window-props.diff text/plain 3922 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NWQwNzM3Li44NDEyN2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0V2ViVmlldy9jcmVhdGUtcmVh ZHktY2xvc2UgaXMgZmFpbGluZyBhZnRlciByMTM0NTg2CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NjgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayBvbmx5IHRoYXQgd2luZG93IHByb3BlcnRp ZXMgbWF0Y2ggd2hlbiBjcmVhdGluZyBhIG5ldyB3aW5kb3cKKyAgICAgICAgaWYgdGhlIGV4cGVj dGVkIHdpbmRvdyBwcm9wZXJ0aWVzIGhhcyBiZWVuIHNldC4gQWxzbyByZW1vdmUgYQorICAgICAg ICBGSVhNRSBhbmQgYWN0dWFsbHkgY2hlY2sgdGhhdCB4IGFuZCB5IGFyZSBlcXVhbCB0byB0aGUg ZXhwZWN0ZWQKKyAgICAgICAgb25lLCBub3cgdGhhdCB0aGUgaXNzdWUgaXMgZml4ZWQuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0V2ViVmlldy5jcHA6CisK IDIwMTItMTEtMTggIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl0gV3JvbmcgdHJhbnNmb3JtIHdoZW4gdXNpbmcgc29mdHdhcmUgcGF0aC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RX ZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3Rz L1Rlc3RXZWJLaXRXZWJWaWV3LmNwcAppbmRleCA1NTM1MGU2Li4wOGNkYmU4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0V2ViVmll dy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdl YktpdFdlYlZpZXcuY3BwCkBAIC05Myw3ICs5Myw4IEBAIHB1YmxpYzoKICAgICBjbGFzcyBXaW5k b3dQcm9wZXJ0aWVzIHsKICAgICBwdWJsaWM6CiAgICAgICAgIFdpbmRvd1Byb3BlcnRpZXMoKQot ICAgICAgICAgICAgOiBtX3Rvb2xiYXJWaXNpYmxlKHRydWUpCisgICAgICAgICAgICA6IG1faXNO dWxsKHRydWUpCisgICAgICAgICAgICAsIG1fdG9vbGJhclZpc2libGUodHJ1ZSkKICAgICAgICAg ICAgICwgbV9zdGF0dXNiYXJWaXNpYmxlKHRydWUpCiAgICAgICAgICAgICAsIG1fc2Nyb2xsYmFy c1Zpc2libGUodHJ1ZSkKICAgICAgICAgICAgICwgbV9tZW51YmFyVmlzaWJsZSh0cnVlKQpAQCAt MTA1LDcgKzEwNiw4IEBAIHB1YmxpYzoKICAgICAgICAgfQogCiAgICAgICAgIFdpbmRvd1Byb3Bl cnRpZXMoV2ViS2l0V2luZG93UHJvcGVydGllcyogd2luZG93UHJvcGVydGllcykKLSAgICAgICAg ICAgIDogbV90b29sYmFyVmlzaWJsZSh3ZWJraXRfd2luZG93X3Byb3BlcnRpZXNfZ2V0X3Rvb2xi YXJfdmlzaWJsZSh3aW5kb3dQcm9wZXJ0aWVzKSkKKyAgICAgICAgICAgIDogbV9pc051bGwoZmFs c2UpCisgICAgICAgICAgICAsIG1fdG9vbGJhclZpc2libGUod2Via2l0X3dpbmRvd19wcm9wZXJ0 aWVzX2dldF90b29sYmFyX3Zpc2libGUod2luZG93UHJvcGVydGllcykpCiAgICAgICAgICAgICAs IG1fc3RhdHVzYmFyVmlzaWJsZSh3ZWJraXRfd2luZG93X3Byb3BlcnRpZXNfZ2V0X3N0YXR1c2Jh cl92aXNpYmxlKHdpbmRvd1Byb3BlcnRpZXMpKQogICAgICAgICAgICAgLCBtX3Njcm9sbGJhcnNW aXNpYmxlKHdlYmtpdF93aW5kb3dfcHJvcGVydGllc19nZXRfc2Nyb2xsYmFyc192aXNpYmxlKHdp bmRvd1Byb3BlcnRpZXMpKQogICAgICAgICAgICAgLCBtX21lbnViYXJWaXNpYmxlKHdlYmtpdF93 aW5kb3dfcHJvcGVydGllc19nZXRfbWVudWJhcl92aXNpYmxlKHdpbmRvd1Byb3BlcnRpZXMpKQpA QCAtMTE4LDcgKzEyMCw4IEBAIHB1YmxpYzoKIAogICAgICAgICBXaW5kb3dQcm9wZXJ0aWVzKEdk a1JlY3RhbmdsZSogZ2VvbWV0cnksIGJvb2wgdG9vbGJhclZpc2libGUsIGJvb2wgc3RhdHVzYmFy VmlzaWJsZSwgYm9vbCBzY3JvbGxiYXJzVmlzaWJsZSwgYm9vbCBtZW51YmFyVmlzaWJsZSwKICAg ICAgICAgICAgICAgICAgICAgICAgICBib29sIGxvY2F0aW9uYmFyVmlzaWJsZSwgYm9vbCByZXNp emFibGUsIGJvb2wgZnVsbHNjcmVlbikKLSAgICAgICAgICAgIDogbV9nZW9tZXRyeSgqZ2VvbWV0 cnkpCisgICAgICAgICAgICA6IG1faXNOdWxsKGZhbHNlKQorICAgICAgICAgICAgLCBtX2dlb21l dHJ5KCpnZW9tZXRyeSkKICAgICAgICAgICAgICwgbV90b29sYmFyVmlzaWJsZSh0b29sYmFyVmlz aWJsZSkKICAgICAgICAgICAgICwgbV9zdGF0dXNiYXJWaXNpYmxlKHN0YXR1c2JhclZpc2libGUp CiAgICAgICAgICAgICAsIG1fc2Nyb2xsYmFyc1Zpc2libGUoc2Nyb2xsYmFyc1Zpc2libGUpCkBA IC0xMjksMTAgKzEzMiwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHsKICAgICAgICAgfQogCisgICAg ICAgIGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gbV9pc051bGw7IH0KKwogICAgICAgICB2 b2lkIGFzc2VydEVxdWFsKGNvbnN0IFdpbmRvd1Byb3BlcnRpZXMmIG90aGVyKSBjb25zdAogICAg ICAgICB7Ci0gICAgICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFzc2VydCB4IGFuZCB5IGFy ZSBlcXVhbCwgYnV0IHdlIGFyZSBnZXR0aW5nIGFuIGluY29ycmVjdAotICAgICAgICAgICAgLy8g dmFsdWUgZnJvbSBXZWJDb3JlICgyODAgaW5zdGVhZCBvZiAxNTApLgorICAgICAgICAgICAgZ19h c3NlcnRfY21waW50KG1fZ2VvbWV0cnkueCwgPT0sIG90aGVyLm1fZ2VvbWV0cnkueCk7CisgICAg ICAgICAgICBnX2Fzc2VydF9jbXBpbnQobV9nZW9tZXRyeS55LCA9PSwgb3RoZXIubV9nZW9tZXRy eS55KTsKICAgICAgICAgICAgIGdfYXNzZXJ0X2NtcGludChtX2dlb21ldHJ5LndpZHRoLCA9PSwg b3RoZXIubV9nZW9tZXRyeS53aWR0aCk7CiAgICAgICAgICAgICBnX2Fzc2VydF9jbXBpbnQobV9n ZW9tZXRyeS5oZWlnaHQsID09LCBvdGhlci5tX2dlb21ldHJ5LmhlaWdodCk7CiAgICAgICAgICAg ICBnX2Fzc2VydF9jbXBpbnQoc3RhdGljX2Nhc3Q8aW50PihtX3Rvb2xiYXJWaXNpYmxlKSwgPT0s IHN0YXRpY19jYXN0PGludD4ob3RoZXIubV90b29sYmFyVmlzaWJsZSkpOwpAQCAtMTQ1LDYgKzE1 MCw4IEBAIHB1YmxpYzoKICAgICAgICAgfQogCiAgICAgcHJpdmF0ZToKKyAgICAgICAgYm9vbCBt X2lzTnVsbDsKKwogICAgICAgICBHZGtSZWN0YW5nbGUgbV9nZW9tZXRyeTsKIAogICAgICAgICBi b29sIG1fdG9vbGJhclZpc2libGU7CkBAIC0zMTIsNyArMzE5LDggQEAgcHVibGljOgogCiAgICAg ICAgIFdlYktpdFdpbmRvd1Byb3BlcnRpZXMqIHdpbmRvd1Byb3BlcnRpZXMgPSB3ZWJraXRfd2Vi X3ZpZXdfZ2V0X3dpbmRvd19wcm9wZXJ0aWVzKHdlYlZpZXcpOwogICAgICAgICBnX2Fzc2VydCh3 aW5kb3dQcm9wZXJ0aWVzKTsKLSAgICAgICAgV2luZG93UHJvcGVydGllcyh3aW5kb3dQcm9wZXJ0 aWVzKS5hc3NlcnRFcXVhbChtX3dpbmRvd1Byb3BlcnRpZXMpOworICAgICAgICBpZiAoIW1fd2lu ZG93UHJvcGVydGllcy5pc051bGwoKSkKKyAgICAgICAgICAgIFdpbmRvd1Byb3BlcnRpZXMod2lu ZG93UHJvcGVydGllcykuYXNzZXJ0RXF1YWwobV93aW5kb3dQcm9wZXJ0aWVzKTsKIAogICAgICAg ICBtX3dlYlZpZXdFdmVudHMuYXBwZW5kKFJlYWR5VG9TaG93KTsKICAgICB9Cg==