102661 2012-11-19 01:29:56 -0800 Move in animation should be disabled until the calendar picker is loaded. 2012-11-19 20:20:36 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 770473 0 keishi 2012-11-19 01:29:56 -0800 <input type=week value="2012-W01"> 770528 1 174930 keishi 2012-11-19 02:52:45 -0800 Created attachment 174930 Patch 771359 2 174930 tkent 2012-11-19 18:33:04 -0800 Comment on attachment 174930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174930&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1317 > + if (this.picker.isPreparing) > + return; I feel Introducing a new flag is inelegant though it's ok if there are no better ways. 771423 3 keishi 2012-11-19 20:05:42 -0800 (In reply to comment #2) > (From update of attachment 174930 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174930&action=review > > > Source/WebCore/Resources/pagepopups/calendarPicker.js:1317 > > + if (this.picker.isPreparing) > > + return; > > I feel Introducing a new flag is inelegant though it's ok if there are no better ways. We only ever need to disable animation during load so this is cleaner than adding an argument to selectRange and we might use this flag when adding other animations. 771435 4 174930 webkit.review.bot 2012-11-19 20:20:32 -0800 Comment on attachment 174930 Patch Clearing flags on attachment: 174930 Committed r135238: <http://trac.webkit.org/changeset/135238> 771436 5 webkit.review.bot 2012-11-19 20:20:36 -0800 All reviewed patches have been landed. Closing bug. 174930 2012-11-19 02:52:45 -0800 2012-11-19 20:20:32 -0800 Patch bug-102661-20121119195036.patch text/plain 2517 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAwNmQ1NWQyODFjZDZl OWFjMzg1OGVlMmJhZmYzMGYwOGViYTU2MS4uYTE4Yjc2YzI2OGRkMTRjZGE4NjU0NDY0ODFjZjk4 ZmRlMDViMTQ4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTE5ICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIE1vdmUgaW4gYW5pbWF0 aW9uIHNob3VsZCBiZSBkaXNhYmxlZCB1bnRpbCB0aGUgY2FsZW5kYXIgcGlja2VyIGlzIGxvYWRl ZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjY2 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIHdl ZWtzIHdoZXJlIHRoZSBmaXJzdCBkYXkgaXMgaW4gdGhlIHByZXZpb3VzIG1vbnRoIChlLnguIDIw MTMtVzAxKQorICAgICAgICB0aGUgbW92ZSBpbiBhbmltYXRpb24gaGFwcGVucyB3aGVuIHlvdSBv cGVuIHRoZSBjYWxlbmRhciBwaWNrZXIuIFRoaXMKKyAgICAgICAgcGF0Y2ggZGlzYWJsZXMgdGhl IG1vdmUgaW4gYW5pbWF0aW9uIHVudGlsIHRoZSBjYWxlbmRhciBwaWNrZXIgaXMgZnVsbHkKKyAg ICAgICAgbG9hZGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIFJlc291 cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2VyLmpzOgorICAgICAgICAoQ2FsZW5kYXJQaWNr ZXIpOgorICAgICAgICAoQ2FsZW5kYXJQaWNrZXIucHJvdG90eXBlLl9oYW5kbGVXaW5kb3dSZXNp emUpOgorICAgICAgICAoRGF5c1RhYmxlLnByb3RvdHlwZS5fc3RhcnRNb3ZlSW5BbmltYXRpb24p OgorCiAyMDEyLTExLTE2ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4K IAogICAgICAgICB3ZWJhdWRpbzogbGVhazogQXVkaW9Db250ZXh0IG9iamVjdHMgYXJlIGxlYWtp bmcuIFRoZXkgcmV0YWluIDM2bWIgb2Ygc2hhcmVkIGRhdGEuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9SZXNvdXJjZXMvcGFnZXBvcHVwcy9jYWxlbmRhclBpY2tlci5qcyBiL1NvdXJjZS9X ZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2VyLmpzCmluZGV4IDA2YzQ1 YjFkMzI2M2Q5YzM4MWFmZmU1MGZkODM3NjM5MTVhNDJjOTQuLmU4MTU2MTE1YWY5YzFiZTI3NWQy MGJmZTJkOWQwMzBlOGJmMjVkMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNl cy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL1Jlc291 cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlja2VyLmpzCkBAIC02NzEsNiArNjcxLDcgQEAgZnVu Y3Rpb24gQ2FsZW5kYXJQaWNrZXIoZWxlbWVudCwgY29uZmlnKSB7CiAgICAgfQogICAgIHRoaXMu X2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgiY2FsZW5kYXItcGlja2VyIik7CiAgICAgdGhpcy5fZWxl bWVudC5jbGFzc0xpc3QuYWRkKCJwcmVwYXJpbmciKTsKKyAgICB0aGlzLmlzUHJlcGFyaW5nID0g dHJ1ZTsKICAgICB0aGlzLl9oYW5kbGVXaW5kb3dSZXNpemVCb3VuZCA9IHRoaXMuX2hhbmRsZVdp bmRvd1Jlc2l6ZS5iaW5kKHRoaXMpOwogICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJyZXNp emUiLCB0aGlzLl9oYW5kbGVXaW5kb3dSZXNpemVCb3VuZCwgZmFsc2UpOwogICAgIC8vIFdlIGFz c3VtZSB0aGlzLl9jb25maWcubWluL21heCBhcmUgdmFsaWQgZGF0ZXMgb3IgbW9udGhzLgpAQCAt NzA5LDYgKzcxMCw3IEBAIENhbGVuZGFyUGlja2VyLk5hdmlnYXRpb25CZWhhdmlvdXIgPSB7CiAK IENhbGVuZGFyUGlja2VyLnByb3RvdHlwZS5faGFuZGxlV2luZG93UmVzaXplID0gZnVuY3Rpb24o KSB7CiAgICAgdGhpcy5fZWxlbWVudC5jbGFzc0xpc3QucmVtb3ZlKCJwcmVwYXJpbmciKTsKKyAg ICB0aGlzLmlzUHJlcGFyaW5nID0gZmFsc2U7CiB9OwogCiBDYWxlbmRhclBpY2tlci5wcm90b3R5 cGUuY2xlYW51cCA9IGZ1bmN0aW9uKCkgewpAQCAtMTMxMSw2ICsxMzEzLDggQEAgRGF5c1RhYmxl LnByb3RvdHlwZS5uYXZpZ2F0ZVRvTW9udGggPSBmdW5jdGlvbihtb250aCwgbmF2aWdhdGlvbkJl aGF2aW91cikgewogICogQHBhcmFtIHshTW9udGh9IG1vbnRoCiAgKi8KIERheXNUYWJsZS5wcm90 b3R5cGUuX3N0YXJ0TW92ZUluQW5pbWF0aW9uID0gZnVuY3Rpb24obW9udGgpIHsKKyAgICBpZiAo dGhpcy5waWNrZXIuaXNQcmVwYXJpbmcpCisgICAgICAgIHJldHVybjsKICAgICB2YXIgZGF5c1N0 eWxlID0gdGhpcy5fZGF5c0NvbnRhaW5lci5zdHlsZTsKICAgICBkYXlzU3R5bGUucG9zaXRpb24g PSAicmVsYXRpdmUiOwogICAgIGRheXNTdHlsZS53ZWJraXRUcmFuc2l0aW9uID0gImxlZnQgMC4x cyBlYXNlIjsK