102648 2012-11-18 22:45:39 -0800 [V8] Remove unused variables from CodeGeneratorV8.pm 2012-11-18 23:35:47 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 770367 0 haraken 2012-11-18 22:45:39 -0800 [V8] Remove unused variables from CodeGeneratorV8.pm 770368 1 174894 haraken 2012-11-18 22:53:16 -0800 Created attachment 174894 Patch 770390 2 174894 webkit.review.bot 2012-11-18 23:35:44 -0800 Comment on attachment 174894 Patch Clearing flags on attachment: 174894 Committed r135115: <http://trac.webkit.org/changeset/135115> 770391 3 webkit.review.bot 2012-11-18 23:35:47 -0800 All reviewed patches have been landed. Closing bug. 174894 2012-11-18 22:53:16 -0800 2012-11-18 23:35:44 -0800 Patch bug-102648-20121119155107.patch text/plain 6447 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFhNmZjOTEzNzA3YjYy YzVlMjViMDU0ZmFkZDVjYzljNTRlNjgyMC4uNWI3OWJhOGQ4ZjlhOTFiZDhmYjQwMzc2ZGFkMGZi Mjg4OTY5YjI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSB1 bnVzZWQgdmFyaWFibGVzIGZyb20gQ29kZUdlbmVyYXRvclY4LnBtCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGdl bmVyYXRlZCBjb2RlLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG06CisgICAgICAgIChHZW5lcmF0ZUludGVyZmFjZSk6CisgICAgICAgIChHZW5lcmF0ZUhl YWRlcik6CisgICAgICAgIChHZXRJbnRlcm5hbEZpZWxkcyk6CisgICAgICAgIChHZW5lcmF0ZU5v cm1hbEF0dHJHZXR0ZXIpOgorICAgICAgICAoR2VuZXJhdGVTaW5nbGVCYXRjaGVkQXR0cmlidXRl KToKKyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb25DdXN0b21DYWxsKToKKyAgICAgICAg KEdlbmVyYXRlRnVuY3Rpb25DYWxsU3RyaW5nKToKKyAgICAgICAgKENyZWF0ZUN1c3RvbVNpZ25h dHVyZSk6CisgICAgICAgIChHZXRDb250ZXh0RW5hYmxlRnVuY3Rpb24pOgorCiAyMDEyLTExLTE4 ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHlsZWRFbGVt ZW50OiBNYWtlIGhhbmRsaW5nIHRoZSAic3R5bGUiIGF0dHJpYnV0ZSBhIGxpdHRlIGZhc3Rlci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv clY4LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0KaW5kZXggOGFjY2I3YWQ2MjNmODBmZWUwY2Q4YTc0NjI4OTEwNGZiODUwMjk5MC4uZWQ3NTY3 MzlmNTZkZWY0OWMzM2I4MmQ1MmFmNGRkZGI0OTg5NGNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTM3LDcgKzM3LDYg QEAgbXkgJG91dHB1dEhlYWRlcnNEaXIgPSAiIjsKIAogbXkgQGhlYWRlckNvbnRlbnQgPSAoKTsK IG15IEBpbXBsQ29udGVudEhlYWRlciA9ICgpOwotbXkgQGltcGxGaXhlZEhlYWRlciA9ICgpOwog bXkgQGltcGxDb250ZW50ID0gKCk7CiBteSBAaW1wbENvbnRlbnREZWNscyA9ICgpOwogbXkgJWlt cGxJbmNsdWRlcyA9ICgpOwpAQCAtODUsNyArODQsNiBAQCBzdWIgR2VuZXJhdGVJbnRlcmZhY2UK IHsKICAgICBteSAkb2JqZWN0ID0gc2hpZnQ7CiAgICAgbXkgJGRhdGFOb2RlID0gc2hpZnQ7Ci0g ICAgbXkgJGRlZmluZXMgPSBzaGlmdDsKIAogICAgICMgU3RhcnQgYWN0dWFsIGdlbmVyYXRpb24K ICAgICBpZiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ2FsbGJhY2sifSkgewpA QCAtNTA4LDcgKzUwNiw2IEBAIEVORAogCiAgICAgbXkgJG5vVG9WOCA9ICRkYXRhTm9kZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IlN1cHByZXNzVG9KU09iamVjdCJ9OwogICAgIG15ICRub1dyYXAg PSAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJWOE5vV3JhcHBlckNhY2hlIn0gfHwg JG5vVG9WODsKLSAgICBteSAkY3JlYXRlV3JhcHBlckFyZ3VtZW50VHlwZSA9IEdldFBhc3NSZWZQ dHJUeXBlKCRuYXRpdmVUeXBlKTsKICAgICBpZiAoISRub1dyYXApIHsKICAgICAgICAgbXkgJGNy ZWF0ZVdyYXBwZXJBcmd1bWVudFR5cGUgPSBHZXRQYXNzUmVmUHRyVHlwZSgkbmF0aXZlVHlwZSk7 CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsIDw8RU5EKTsKQEAgLTYyMiw3ICs2MTksNiBA QCBFTkQKIHN1YiBHZXRJbnRlcm5hbEZpZWxkcwogewogICAgIG15ICRkYXRhTm9kZSA9IHNoaWZ0 OwotICAgIG15ICRuYW1lID0gJGRhdGFOb2RlLT5uYW1lOwogCiAgICAgbXkgQGN1c3RvbUludGVy bmFsRmllbGRzID0gKCk7CiAgICAgIyBXZSBjYW4ndCBhc2sgd2hldGhlciBhIHBhcmVudCB0eXBl IGhhcyBhIGdpdmVuIGV4dGVuZGVkQXR0cmlidXRlLApAQCAtOTkzLDggKzk4OSw2IEBAIEVORAog ICAgIH0KIAogICAgIG15ICRyZXN1bHQ7Ci0gICAgbXkgJHdyYXBwZXI7Ci0KICAgICBpZiAoJGF0 dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJFdmVudExpc3RlbmVyIiAmJiAkZGF0YU5vZGUt Pm5hbWUgZXEgIkRPTVdpbmRvdyIpIHsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICBpZiAoIWltcC0+ZG9jdW1lbnQoKSlcbiIpOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiICAgICAgICByZXR1cm4gdjhVbmRlZmluZWQoKTtcbiIpOwpAQCAtMjI2NSw3ICsy MjU5LDYgQEAgc3ViIEdlbmVyYXRlU2luZ2xlQmF0Y2hlZEF0dHJpYnV0ZQogICAgIG15ICRnZXR0 ZXI7CiAgICAgbXkgJHNldHRlcjsKICAgICBteSAkcHJvcEF0dHIgPSAidjg6Ok5vbmUiOwotICAg IG15ICRoYXNDdXN0b21TZXR0ZXIgPSAwOwogCiAgICAgIyBDaGVjayBhdHRyaWJ1dGVzLgogICAg IGlmICgkYXR0ckV4dC0+eyJOb3RFbnVtZXJhYmxlIn0pIHsKQEAgLTIzMDYsNyArMjI5OSw2IEBA IHN1YiBHZW5lcmF0ZVNpbmdsZUJhdGNoZWRBdHRyaWJ1dGUKIAogICAgICAgICAjIEN1c3RvbSBT ZXR0ZXIKICAgICAgICAgaWYgKCRhdHRyRXh0LT57IkN1c3RvbVNldHRlciJ9IHx8ICRhdHRyRXh0 LT57IlY4Q3VzdG9tU2V0dGVyIn0gfHwgJGF0dHJFeHQtPnsiQ3VzdG9tIn0gfHwgJGF0dHJFeHQt PnsiVjhDdXN0b20ifSkgewotICAgICAgICAgICAgJGhhc0N1c3RvbVNldHRlciA9IDE7CiAgICAg ICAgICAgICAkc2V0dGVyID0gIlY4JHtjdXN0b21BY2Nlc3Nvcn1BY2Nlc3NvclNldHRlciI7CiAg ICAgICAgIH0KIApAQCAtMjU4Niw5ICsyNTc4LDggQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRp b25DdXN0b21DYWxsCiB7CiAgICAgbXkgJGRhdGFOb2RlID0gc2hpZnQ7CiAgICAgbXkgJGludGVy ZmFjZU5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7Ci0gICAgbXkgJGhhc0N1c3RvbUNhbGwgPSAkZGF0 YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21DYWxsIn07CiAKLSAgICBpZiAoJGhh c0N1c3RvbUNhbGwpIHsKKyAgICBpZiAoJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsi Q3VzdG9tQ2FsbCJ9KSB7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIGRlc2MtPklu c3RhbmNlVGVtcGxhdGUoKS0+U2V0Q2FsbEFzRnVuY3Rpb25IYW5kbGVyKFY4JHtpbnRlcmZhY2VO YW1lfTo6Y2FsbEFzRnVuY3Rpb25DYWxsYmFjayk7XG4iKTsKICAgICB9CiB9CkBAIC0yNjEyLDcg KzI2MDMsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgIG15ICRuYXRpdmVUeXBl ID0gR2V0TmF0aXZlVHlwZUZvckNvbnZlcnNpb25zKCRkYXRhTm9kZSk7CiAKICAgICAjIC0gQWRk IGRlZmF1bHQgaGVhZGVyIHRlbXBsYXRlCi0gICAgcHVzaChAaW1wbEZpeGVkSGVhZGVyLCBHZW5l cmF0ZUltcGxlbWVudGF0aW9uQ29udGVudEhlYWRlcigkZGF0YU5vZGUpKTsKKyAgICBwdXNoKEBp bXBsQ29udGVudEhlYWRlciwgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbkNvbnRlbnRIZWFkZXIoJGRh dGFOb2RlKSk7CiAKICAgICBBZGRUb0ltcGxJbmNsdWRlcygiQmluZGluZ1N0YXRlLmgiKTsKICAg ICBBZGRUb0ltcGxJbmNsdWRlcygiQ29udGV4dEZlYXR1cmVzLmgiKTsKQEAgLTMxOTAsOCArMzE4 MSw4IEBAIEVORAogCiAgICAgbXkgJGNvbmRpdGlvbmFsU3RyaW5nID0gJGNvZGVHZW5lcmF0b3It PkdlbmVyYXRlQ29uZGl0aW9uYWxTdHJpbmcoJGRhdGFOb2RlKTsKICAgICBwdXNoKEBpbXBsQ29u dGVudCwgIlxuI2VuZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9u YWxTdHJpbmc7Ci0gICAgCi0gICAgIyBXZSd2ZSBhbHJlYWR5IGFkZGVkIHRoZSBoZWFkZXIgZm9y IHRoaXMgZmlsZSBpbiBpbXBsRml4ZWRIZWFkZXIsIHNvIHJlbW92ZQorCisgICAgIyBXZSd2ZSBh bHJlYWR5IGFkZGVkIHRoZSBoZWFkZXIgZm9yIHRoaXMgZmlsZSBpbiBpbXBsQ29udGVudEhlYWRl ciwgc28gcmVtb3ZlCiAgICAgIyBpdCBmcm9tIGltcGxJbmNsdWRlcyB0byBlbnN1cmUgd2UgZG9u J3QgI2luY2x1ZGUgaXQgdHdpY2UuCiAgICAgZGVsZXRlICRpbXBsSW5jbHVkZXN7IiR7djhJbnRl cmZhY2VOYW1lfS5oIn07CiB9CkBAIC0zMzA5LDcgKzMzMDAsNyBAQCBzdWIgR2VuZXJhdGVDYWxs YmFja0ltcGxlbWVudGF0aW9uCiAgICAgbXkgJHY4SW50ZXJmYWNlTmFtZSA9ICJWOCRpbnRlcmZh Y2VOYW1lIjsKIAogICAgICMgLSBBZGQgZGVmYXVsdCBoZWFkZXIgdGVtcGxhdGUKLSAgICBwdXNo KEBpbXBsRml4ZWRIZWFkZXIsIEdlbmVyYXRlSW1wbGVtZW50YXRpb25Db250ZW50SGVhZGVyKCRk YXRhTm9kZSkpOworICAgIHB1c2goQGltcGxDb250ZW50SGVhZGVyLCBHZW5lcmF0ZUltcGxlbWVu dGF0aW9uQ29udGVudEhlYWRlcigkZGF0YU5vZGUpKTsKIAogICAgIEFkZFRvSW1wbEluY2x1ZGVz KCJTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgiKTsKICAgICBBZGRUb0ltcGxJbmNsdWRlcygiVjhC aW5kaW5nLmgiKTsKQEAgLTM1MTIsNyArMzUwMyw2IEBAIHN1YiBHZW5lcmF0ZUZ1bmN0aW9uQ2Fs bFN0cmluZygpCiAgICAgfQogCiAgICAgbXkgJGluZGV4ID0gMDsKLSAgICBteSAkaGFzU2NyaXB0 U3RhdGUgPSAwOwogCiAgICAgbXkgQGFyZ3VtZW50czsKICAgICBteSAkZnVuY3Rpb25OYW1lOwpA QCAtMzg3NSw4ICszODY1LDcgQEAgc3ViIENyZWF0ZUN1c3RvbVNpZ25hdHVyZQogICAgICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAgIEFkZFRvSW1wbEluY2x1ZGVzKCIkc2Vx dWVuY2VUeXBlLmgiKTsKICAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAg ICAgICBteSAkaGVhZGVyID0gR2V0VjhIZWFkZXJOYW1lKCR0eXBlKTsKLSAgICAgICAgICAgICAg ICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoJGhlYWRlcik7CisgICAgICAgICAgICAgICAgICAgIEFk ZFRvSW1wbEluY2x1ZGVzKEdldFY4SGVhZGVyTmFtZSgkdHlwZSkpOwogICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICAkcmVzdWx0IC49ICJWOCR7dHlwZX06OkdldFJhd1RlbXBsYXRl KCkiOwogICAgICAgICAgICAgfQpAQCAtNDExNiw3ICs0MTA1LDcgQEAgc3ViIFdyaXRlRGF0YQog ICAgIG15ICRpbXBsRmlsZU5hbWUgPSAiJG91dHB1dERpci8kcHJlZml4JG5hbWUuY3BwIjsKIAog ICAgICMgVXBkYXRlIGEgLmNwcCBmaWxlIGlmIHRoZSBjb250ZW50cyBhcmUgY2hhbmdlZC4KLSAg ICBteSAkY29udGVudHMgPSBqb2luICIiLCBAaW1wbENvbnRlbnRIZWFkZXIsIEBpbXBsRml4ZWRI ZWFkZXI7CisgICAgbXkgJGNvbnRlbnRzID0gam9pbiAiIiwgQGltcGxDb250ZW50SGVhZGVyOwog CiAgICAgbXkgQGluY2x1ZGVzID0gKCk7CiAgICAgbXkgJWltcGxJbmNsdWRlQ29uZGl0aW9ucyA9 ICgpOwpAQCAtNDE1NCw3ICs0MTQzLDcgQEAgc3ViIFdyaXRlRGF0YQogICAgICRjb2RlR2VuZXJh dG9yLT5VcGRhdGVGaWxlKCRpbXBsRmlsZU5hbWUsICRjb250ZW50cyk7CiAKICAgICAlaW1wbElu Y2x1ZGVzID0gKCk7Ci0gICAgQGltcGxGaXhlZEhlYWRlciA9ICgpOworICAgIEBpbXBsQ29udGVu dEhlYWRlciA9ICgpOwogICAgIEBpbXBsQ29udGVudERlY2xzID0gKCk7CiAgICAgQGltcGxDb250 ZW50ID0gKCk7CiAKQEAgLTQyMDYsOCArNDE5NSw3IEBAIHN1YiBHZXRDb250ZXh0RW5hYmxlRnVu Y3Rpb24KICAgICB9CiAKICAgICAjIE9yIGl0IGZhbGxiYWNrcyB0byB0aGUgYXR0cmlidXRlIG5h bWUgaWYgdGhlIHBhcmFtZXRlciB2YWx1ZSBpcyBtaXNzaW5nLgotICAgIG15ICRhdHRyaWJ1dGVO YW1lID0gJHNpZ25hdHVyZS0+bmFtZTsKLSAgICByZXR1cm4gIkNvbnRleHRGZWF0dXJlczo6IiAu ICRjb2RlR2VuZXJhdG9yLT5XS19sY2ZpcnN0KCRhdHRyaWJ1dGVOYW1lKSAuICJFbmFibGVkIjsK KyAgICByZXR1cm4gIkNvbnRleHRGZWF0dXJlczo6IiAuICRjb2RlR2VuZXJhdG9yLT5XS19sY2Zp cnN0KCRzaWduYXR1cmUtPm5hbWUpIC4gIkVuYWJsZWQiOwogfQogCiBzdWIgR2V0UGFzc1JlZlB0 clR5cGUK