102637 2012-11-18 20:27:30 -0800 Web Inspector: [JSC] worker debugger shouldn't stop for "willExecuteProgram" instruction 2012-11-19 21:19:04 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 PeterHWang webkit-unassigned apavlov charles.wei ggaren keishi loislo pfeldman pmuellr timothy vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 770304 0 PeterHWang 2012-11-18 20:27:30 -0800 How to reproduce the bug: (1) Open inspector for any page including worker. (2) Choose "Pause on start", and trigger the worker in the page. (3) The worker inspector shows up and stop on the first statement of JS. (4) Click "Step over next" button, you have to click two times to let the pointer move to next statement. The root reason is worker inspector first stops for the "willExecuteProgram" instruction, then stops for the first statement of JS code. The breakpoint for "willExecuteProgram" is reserved for some special purpose, it's always inserted in the head of any head of a piece of JS code, in normal situation it's impossible to set it manually and it shouldn't influence user's operation. But, for worker inspector "Pause on start", it's triggered and causes problem. So, I try to override the interface to let worker debugger server doesn't stop for "willExecuteProgram". 770308 1 174883 PeterHWang 2012-11-18 20:39:27 -0800 Created attachment 174883 Patch 771328 2 174883 webkit.review.bot 2012-11-19 18:04:33 -0800 Comment on attachment 174883 Patch Clearing flags on attachment: 174883 Committed r135224: <http://trac.webkit.org/changeset/135224> 771329 3 webkit.review.bot 2012-11-19 18:04:37 -0800 All reviewed patches have been landed. Closing bug. 771464 4 174883 yurys 2012-11-19 21:19:04 -0800 Comment on attachment 174883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174883&action=review > Source/WebCore/ChangeLog:10 > + No new DRT test case. Sorry, so far it seems impossible to write a case to controle the popupped You can write protocol test for it that wouldn't depend on the inspector UI. See LayoutTests/inspector-protocol 174883 2012-11-18 20:39:27 -0800 2012-11-19 21:19:04 -0800 Patch bug-102637-20121119123651.patch text/plain 6707 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxZjU5YjE0NDEwYTBl ZTMyNDgyNzg0NTFiNWNjOGJkZWRmZmEwMS4uNzJmNzNlZDgyNGIxODdkMTI5M2YyZmZmYzc5ZjFl ODVlMDQyMjg3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTExLTE4ICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogW0pTQ10gd29ya2VyIGRlYnVnZ2VyIHNob3VsZG4ndCBzdG9wIGZvciAid2lsbEV4 ZWN1dGVQcm9ncmFtIiBpbnN0cnVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT3ZlcnJpZGUgdGhlIGludGVyZmFjZSAid2lsbEV4ZWN1dGVQcm9n cmFtIiB0byBsZXQgV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIgdG8gYXZvaWQgdG8gc3RvcCBmb3Ig aXQuCisKKyAgICAgICAgTm8gbmV3IERSVCB0ZXN0IGNhc2UuIFNvcnJ5LCBzbyBmYXIgaXQgc2Vl bXMgaW1wb3NzaWJsZSB0byB3cml0ZSBhIGNhc2UgdG8gY29udHJvbGUgdGhlIHBvcHVwcGVkCisg ICAgICAgIHdvcmtlciBpbnNwZWN0b3Igd2luZG93LgorCisgICAgICAgICogYmluZGluZ3MvanMv U2NyaXB0RGVidWdTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RGVidWdTZXJ2 ZXI6OmNyZWF0ZUNhbGxGcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHREZWJ1Z1NlcnZl cjo6Y2FsbEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjp3aWxs RXhlY3V0ZVByb2dyYW0pOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVy Lmg6CisgICAgICAgIChTY3JpcHREZWJ1Z1NlcnZlcik6CisgICAgICAgICogYmluZGluZ3MvanMv V29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyU2Ny aXB0RGVidWdTZXJ2ZXI6OndpbGxFeGVjdXRlUHJvZ3JhbSk6CisgICAgICAgIChXZWJDb3JlKToK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHREZWJ1Z1NlcnZlci5oOgorICAgICAg ICAoV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIpOgorCiAyMDEyLTExLTEyICBTaGlueWEgS2F3YW5h a2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBEb24ndCB1cGRhdGUgc3R5bGUg d2hlbiBhdHRhY2hpbmcgaW4gSFRNTE1ldGVyRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IDhiNzcxZWEzMDhlZDQ4MTAx MDQ4OGYxYzI4YzBkZTJiY2M5YmU0NzkuLjdkN2MxZmQ5ZTMzNmE2NzNmYTBhNGQ1MDZmMWM3ZDc5 ZDdhZDRmZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdERl YnVnU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1 Z1NlcnZlci5jcHAKQEAgLTM5NSw3ICszOTUsNyBAQCB2b2lkIFNjcmlwdERlYnVnU2VydmVyOjpk aXNwYXRjaEZ1bmN0aW9uVG9MaXN0ZW5lcnMoSmF2YVNjcmlwdEV4ZWN1dGlvbkNhbGxiYWNrCiAg ICAgbV9jYWxsaW5nTGlzdGVuZXJzID0gZmFsc2U7CiB9CiAKLXZvaWQgU2NyaXB0RGVidWdTZXJ2 ZXI6OmNyZWF0ZUNhbGxGcmFtZUFuZFBhdXNlSWZOZWVkZWQoY29uc3QgRGVidWdnZXJDYWxsRnJh bWUmIGRlYnVnZ2VyQ2FsbEZyYW1lLCBpbnRwdHJfdCBzb3VyY2VJRCwgaW50IGxpbmVOdW1iZXIs IGludCBjb2x1bW5OdW1iZXIpCit2b2lkIFNjcmlwdERlYnVnU2VydmVyOjpjcmVhdGVDYWxsRnJh bWUoY29uc3QgRGVidWdnZXJDYWxsRnJhbWUmIGRlYnVnZ2VyQ2FsbEZyYW1lLCBpbnRwdHJfdCBz b3VyY2VJRCwgaW50IGxpbmVOdW1iZXIsIGludCBjb2x1bW5OdW1iZXIpCiB7CiAgICAgVGV4dFBv c2l0aW9uIHRleHRQb3NpdGlvbihPcmRpbmFsTnVtYmVyOjpmcm9tT25lQmFzZWRJbnQobGluZU51 bWJlciksIE9yZGluYWxOdW1iZXI6OmZyb21aZXJvQmFzZWRJbnQoY29sdW1uTnVtYmVyKSk7CiAg ICAgbV9jdXJyZW50Q2FsbEZyYW1lID0gSmF2YVNjcmlwdENhbGxGcmFtZTo6Y3JlYXRlKGRlYnVn Z2VyQ2FsbEZyYW1lLCBtX2N1cnJlbnRDYWxsRnJhbWUsIHNvdXJjZUlELCB0ZXh0UG9zaXRpb24p OwpAQCAtNDAzLDcgKzQwMyw2IEBAIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmNyZWF0ZUNhbGxG cmFtZUFuZFBhdXNlSWZOZWVkZWQoY29uc3QgRGVidWdnZXJDYWxsRnJhbWUmCiAgICAgICAgIG1f bGFzdEV4ZWN1dGVkTGluZSA9IC0xOwogICAgICAgICBtX2xhc3RFeGVjdXRlZFNvdXJjZUlkID0g c291cmNlSUQ7CiAgICAgfQotICAgIHBhdXNlSWZOZWVkZWQoZGVidWdnZXJDYWxsRnJhbWUuZHlu YW1pY0dsb2JhbE9iamVjdCgpKTsKIH0KIAogdm9pZCBTY3JpcHREZWJ1Z1NlcnZlcjo6dXBkYXRl Q2FsbEZyYW1lQW5kUGF1c2VJZk5lZWRlZChjb25zdCBEZWJ1Z2dlckNhbGxGcmFtZSYgZGVidWdn ZXJDYWxsRnJhbWUsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZU51bWJlciwgaW50IGNvbHVt bk51bWJlcikKQEAgLTQ1Miw4ICs0NTEsMTAgQEAgdm9pZCBTY3JpcHREZWJ1Z1NlcnZlcjo6cGF1 c2VJZk5lZWRlZChKU0dsb2JhbE9iamVjdCogZHluYW1pY0dsb2JhbE9iamVjdCkKIAogdm9pZCBT Y3JpcHREZWJ1Z1NlcnZlcjo6Y2FsbEV2ZW50KGNvbnN0IERlYnVnZ2VyQ2FsbEZyYW1lJiBkZWJ1 Z2dlckNhbGxGcmFtZSwgaW50cHRyX3Qgc291cmNlSUQsIGludCBsaW5lTnVtYmVyLCBpbnQgY29s dW1uTnVtYmVyKQogewotICAgIGlmICghbV9wYXVzZWQpCi0gICAgICAgIGNyZWF0ZUNhbGxGcmFt ZUFuZFBhdXNlSWZOZWVkZWQoZGVidWdnZXJDYWxsRnJhbWUsIHNvdXJjZUlELCBsaW5lTnVtYmVy LCBjb2x1bW5OdW1iZXIpOworICAgIGlmICghbV9wYXVzZWQpIHsKKyAgICAgICAgY3JlYXRlQ2Fs bEZyYW1lKGRlYnVnZ2VyQ2FsbEZyYW1lLCBzb3VyY2VJRCwgbGluZU51bWJlciwgY29sdW1uTnVt YmVyKTsKKyAgICAgICAgcGF1c2VJZk5lZWRlZChkZWJ1Z2dlckNhbGxGcmFtZS5keW5hbWljR2xv YmFsT2JqZWN0KCkpOworICAgIH0KIH0KIAogdm9pZCBTY3JpcHREZWJ1Z1NlcnZlcjo6YXRTdGF0 ZW1lbnQoY29uc3QgRGVidWdnZXJDYWxsRnJhbWUmIGRlYnVnZ2VyQ2FsbEZyYW1lLCBpbnRwdHJf dCBzb3VyY2VJRCwgaW50IGxpbmVOdW1iZXIsIGludCBjb2x1bW5OdW1iZXIpCkBAIC00OTIsOCAr NDkzLDEwIEBAIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmV4Y2VwdGlvbihjb25zdCBEZWJ1Z2dl ckNhbGxGcmFtZSYgZGVidWdnZXJDYWxsRnJhbWUsIGluCiAKIHZvaWQgU2NyaXB0RGVidWdTZXJ2 ZXI6OndpbGxFeGVjdXRlUHJvZ3JhbShjb25zdCBEZWJ1Z2dlckNhbGxGcmFtZSYgZGVidWdnZXJD YWxsRnJhbWUsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZU51bWJlciwgaW50IGNvbHVtbk51 bWJlcikKIHsKLSAgICBpZiAoIW1fcGF1c2VkKQotICAgICAgICBjcmVhdGVDYWxsRnJhbWVBbmRQ YXVzZUlmTmVlZGVkKGRlYnVnZ2VyQ2FsbEZyYW1lLCBzb3VyY2VJRCwgbGluZU51bWJlciwgY29s dW1uTnVtYmVyKTsKKyAgICBpZiAoIW1fcGF1c2VkKSB7CisgICAgICAgIGNyZWF0ZUNhbGxGcmFt ZShkZWJ1Z2dlckNhbGxGcmFtZSwgc291cmNlSUQsIGxpbmVOdW1iZXIsIGNvbHVtbk51bWJlcik7 CisgICAgICAgIHBhdXNlSWZOZWVkZWQoZGVidWdnZXJDYWxsRnJhbWUuZHluYW1pY0dsb2JhbE9i amVjdCgpKTsKKyAgICB9CiB9CiAKIHZvaWQgU2NyaXB0RGVidWdTZXJ2ZXI6OmRpZEV4ZWN1dGVQ cm9ncmFtKGNvbnN0IERlYnVnZ2VyQ2FsbEZyYW1lJiBkZWJ1Z2dlckNhbGxGcmFtZSwgaW50cHRy X3Qgc291cmNlSUQsIGludCBsaW5lTnVtYmVyLCBpbnQgY29sdW1uTnVtYmVyKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmgKaW5kZXggOTlmNjQ0ZTQx NjRkMTA1YzMyY2Q0OTczZjAyNzBlNTkwOGIzNzBkMC4uZTk3ZmQ2MTg4NGE5MjlkYTNlOGU5MGRk M2IyNDljZDMyNjIzZjIwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMv U2NyaXB0RGVidWdTZXJ2ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3Jp cHREZWJ1Z1NlcnZlci5oCkBAIC0xMjcsNyArMTI3LDcgQEAgcHJvdGVjdGVkOgogICAgIHZvaWQg ZGlzcGF0Y2hEaWRQYXJzZVNvdXJjZShjb25zdCBMaXN0ZW5lclNldCYgbGlzdGVuZXJzLCBKU0M6 OlNvdXJjZVByb3ZpZGVyKiwgYm9vbCBpc0NvbnRlbnRTY3JpcHQpOwogICAgIHZvaWQgZGlzcGF0 Y2hGYWlsZWRUb1BhcnNlU291cmNlKGNvbnN0IExpc3RlbmVyU2V0JiBsaXN0ZW5lcnMsIEpTQzo6 U291cmNlUHJvdmlkZXIqLCBpbnQgZXJyb3JMaW5lLCBjb25zdCBTdHJpbmcmIGVycm9yTWVzc2Fn ZSk7CiAKLSAgICB2b2lkIGNyZWF0ZUNhbGxGcmFtZUFuZFBhdXNlSWZOZWVkZWQoY29uc3QgSlND OjpEZWJ1Z2dlckNhbGxGcmFtZSYsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZU51bWJlciwg aW50IGNvbHVtbk51bWJlcik7CisgICAgdm9pZCBjcmVhdGVDYWxsRnJhbWUoY29uc3QgSlNDOjpE ZWJ1Z2dlckNhbGxGcmFtZSYsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZU51bWJlciwgaW50 IGNvbHVtbk51bWJlcik7CiAgICAgdm9pZCB1cGRhdGVDYWxsRnJhbWVBbmRQYXVzZUlmTmVlZGVk KGNvbnN0IEpTQzo6RGVidWdnZXJDYWxsRnJhbWUmLCBpbnRwdHJfdCBzb3VyY2VJRCwgaW50IGxp bmVOdW1iZXIsIGludCBjb2x1bW5OdW1iZXIpOwogICAgIHZvaWQgcGF1c2VJZk5lZWRlZChKU0M6 OkpTR2xvYmFsT2JqZWN0KiBkeW5hbWljR2xvYmFsT2JqZWN0KTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4 IGM4NWIzYjU2MDYyN2MzODA4NWIwODlhMWU1NjAwYjVhYjhiNTIzNDcuLjRmZTc5ZWYyZTE3ZWU5 ZDNjYWJhYjg1MWI0OGNkMTEwYjE3MjM1YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1dvcmtlclNjcmlwdERlYnVnU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHREZWJ1Z1NlcnZlci5jcHAKQEAgLTYxLDYgKzYxLDEy IEBAIHZvaWQgV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKFNjcmlwdERlYnVn TGlzdGVuZXIqIGxpc3RlbmVyKQogICAgIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKDApOwogfQog Cit2b2lkIFdvcmtlclNjcmlwdERlYnVnU2VydmVyOjp3aWxsRXhlY3V0ZVByb2dyYW0oY29uc3Qg SlNDOjpEZWJ1Z2dlckNhbGxGcmFtZSYgZGVidWdnZXJDYWxsRnJhbWUsIGludHB0cl90IHNvdXJj ZUlELCBpbnQgbGluZU51bWJlciwgaW50IGNvbHVtbk51bWJlcikKK3sKKyAgICBpZiAoIW1fcGF1 c2VkKQorICAgICAgICBjcmVhdGVDYWxsRnJhbWUoZGVidWdnZXJDYWxsRnJhbWUsIHNvdXJjZUlE LCBsaW5lTnVtYmVyLCBjb2x1bW5OdW1iZXIpOworfQorCiB2b2lkIFdvcmtlclNjcmlwdERlYnVn U2VydmVyOjpyZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucyhUaW1lcjxTY3JpcHREZWJ1Z1NlcnZlcj4q KQogewogICAgIEpTQzo6SlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhID0gbV93b3JrZXJDb250ZXh0 LT5zY3JpcHQoKS0+Z2xvYmFsRGF0YSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dvcmtlclNjcmlwdERlYnVnU2VydmVyLmgKaW5kZXggMTZhMDViNDQ5ZjVhMzEyZDcy NDhmODU4ZWY5OTJhYmIzOWM1NzdkYy4uODNiNzVlZGM5Y2Y0Njg5NmFlMGY1ZjJiZjE2NjA5ZjRm YzA5NTE2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2Ny aXB0RGVidWdTZXJ2ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJT Y3JpcHREZWJ1Z1NlcnZlci5oCkBAIC02MSw2ICs2MSw4IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0 dWFsIGJvb2wgaXNDb250ZW50U2NyaXB0KEpTQzo6RXhlY1N0YXRlKikgeyByZXR1cm4gZmFsc2U7 IH0KIAorICAgIHZpcnR1YWwgdm9pZCB3aWxsRXhlY3V0ZVByb2dyYW0oY29uc3QgSlNDOjpEZWJ1 Z2dlckNhbGxGcmFtZSYsIGludHB0cl90IHNvdXJjZUlELCBpbnQgbGluZW5vLCBpbnQgY29sdW1u TnVtYmVyKTsKKwogICAgIHZpcnR1YWwgdm9pZCBydW5FdmVudExvb3BXaGlsZVBhdXNlZCgpOwog CiAgICAgV29ya2VyQ29udGV4dCogbV93b3JrZXJDb250ZXh0Owo=