102636 2012-11-18 20:01:38 -0800 Add myself to committers.py 2012-11-18 22:16:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 102638 0 vivek.vg webkit-unassigned abarth dpranke eric ojan webkit.review.bot oldest_to_newest 770296 0 vivek.vg 2012-11-18 20:01:38 -0800 Add myself to committers.py 770302 1 174882 vivek.vg 2012-11-18 20:15:16 -0800 Created attachment 174882 Patch 770311 2 174882 laszlo.gombos 2012-11-18 20:51:18 -0800 Comment on attachment 174882 Patch r=me. 770313 3 174882 webkit.review.bot 2012-11-18 20:54:03 -0800 Comment on attachment 174882 Patch Rejecting attachment 174882 from commit-queue. vivek.vg@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 770315 4 174882 webkit.review.bot 2012-11-18 21:11:51 -0800 Comment on attachment 174882 Patch Clearing flags on attachment: 174882 Committed r135104: <http://trac.webkit.org/changeset/135104> 770316 5 webkit.review.bot 2012-11-18 21:11:55 -0800 All reviewed patches have been landed. Closing bug. 770317 6 ap 2012-11-18 21:13:19 -0800 As a committer, you should be careful enough to read a comment before the block you change. Changes to committers.py do not need review. Also, a new committer should make this modification manually, to prove actually having the privilege. 770319 7 webkit.review.bot 2012-11-18 21:16:21 -0800 Re-opened since this is blocked by bug 102638 770353 8 eric 2012-11-18 22:16:00 -0800 :shrug: It's nice to do that, but I believe we have several committers who have never even committed manually. :) I doubt this was worth the rollout churn. 174882 2012-11-18 20:15:16 -0800 2012-11-18 21:11:51 -0800 Patch bug-102636-20121119094347.patch text/plain 1523 vivek.vg U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MTAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGQwOTViOTViMDZlYmRlYjA0Y2EwOGI3YWY4YjhkYzA5 ZjUxNjc2Ni4uYzM5MWU3MGJmZGY5N2MxZTg5MjQ2YzIxOWJkNzFjOWJiNDA5MGNiZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTExLTE4ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrLnZnQHNhbXN1bmcuY29tPgor CisgICAgICAgIEFkZCBteXNlbGYgdG8gY29tbWl0dGVycy5weQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG15c2VsZiB0byBjb21taXR0ZXJzLnB5 CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5w eToKKwogMjAxMi0xMS0xOCAgR2VuZXZpZXZlIE1hayAgPGdtYWtAcmltLmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gRW5hYmxlIFRvdWNoIFNsaWRlcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMucHkKaW5kZXggYTVmMDllY2UwYzY5 MzU3NTkzMDBkN2RjODc0MDY5OGVlMWY3ZmRkOC4uMjYzZTViOGYyYmE5ZGVmNDJkYTQ2OWY1M2Q3 ZWFiYzFlY2VjZTU1NCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2NvbW1pdHRlcnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2NvbW1pdHRlcnMucHkKQEAgLTQwNSw2ICs0MDUsNyBAQCBjb21taXR0ZXJzX3VuYWJs ZV90b19yZXZpZXcgPSBbCiAgICAgQ29tbWl0dGVyKCJWaWN0b3JpYSBLaXJzdCIsIFsidnJrQGNo cm9taXVtLm9yZyIsICJ2cmtAZ29vZ2xlLmNvbSJdLCAidnJrIiksCiAgICAgQ29tbWl0dGVyKCJW aW5jZW50IFNjaGVpYiIsICJzY2hlaWJAY2hyb21pdW0ub3JnIiwgInNjaGVpYiIpLAogICAgIENv bW1pdHRlcigiVml0YWx5IFJlcGVzaGtvIiwgInZpdGFseXJAY2hyb21pdW0ub3JnIiksCisgICAg Q29tbWl0dGVyKCJWaXZlayBHYWxhdGFnZSIsICJ2aXZlay52Z0BzYW1zdW5nLmNvbSIsICJ2aXZl a2ciKSwKICAgICBDb21taXR0ZXIoIldpbGxpYW0gU2llZ3Jpc3QiLCAid3NpZWdyaXN0QGFwcGxl LmNvbSIsICJ3bXMiKSwKICAgICBDb21taXR0ZXIoIlcuIEphbWVzIE1hY0xlYW4iLCAid2ptYWNs ZWFuQGNocm9taXVtLm9yZyIsICJzZXVtYXMiKSwKICAgICBDb21taXR0ZXIoIlhpYW56aHUgV2Fu ZyIsIFsid2FuZ3hpYW56aHVAY2hyb21pdW0ub3JnIiwgInBobml4d3h6QGdtYWlsLmNvbSIsICJ3 YW5neGlhbnpodUBnb29nbGUuY29tIl0sICJ3YW5neGlhbnpodSIpLAo=