102628 2012-11-18 18:10:39 -0800 min/max/step support for calendar picker on datetime/datetime-local 2012-12-01 11:56:33 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103817 0 ksakamoto webkit-unassigned dglazkov keishi tkent webkit.review.bot oldest_to_newest 770254 0 ksakamoto 2012-11-18 18:10:39 -0800 Calendar picker for datetime/datetime-local should gray out dates with no allowed values. For example, <input type=datetime min="2012-11-14T12:00Z" step="129600"> allows following values: 2012-11-14T12:00Z 2012-11-16T00:00Z 2012-11-17T12:00Z 2012-11-19T00:00Z ... Calendar picker for this input should accept only 2012-11-14, 2012-11-16, 2012-11-17, 2012-11-19, and so on. 770263 1 174874 ksakamoto 2012-11-18 18:26:49 -0800 Created attachment 174874 Patch 770289 2 174874 webkit.review.bot 2012-11-18 19:39:56 -0800 Comment on attachment 174874 Patch Attachment 174874 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14904032 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 770299 3 174874 tkent 2012-11-18 20:08:27 -0800 Comment on attachment 174874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174874&action=review > LayoutTests/platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:20 > + debug("Step without min or max."); nit: Please be consistent for quotation mark usage. Many code in this file use single quotes, but some parts use double quotes. 770342 4 174874 webkit.review.bot 2012-11-18 21:51:23 -0800 Comment on attachment 174874 Patch Clearing flags on attachment: 174874 Committed r135110: <http://trac.webkit.org/changeset/135110> 770344 5 webkit.review.bot 2012-11-18 21:51:27 -0800 All reviewed patches have been landed. Closing bug. 174874 2012-11-18 18:26:49 -0800 2012-11-18 21:51:23 -0800 Patch bug-102628-20121119112445.patch text/plain 6080 ksakamoto U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVkZjkxNDM5MzI5YmY1 ZmFhMjYwOTZjOTM4Y2QwZjY5N2RmYmY2MC4uYTE4N2YzMmYyOWJjNjVkNDA5NzE4M2Q5YWJlNzEz NTM1NzU2NGQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTE4ICBLdW5p aGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgbWluL21h eC9zdGVwIHN1cHBvcnQgZm9yIGNhbGVuZGFyIHBpY2tlciBvbiBkYXRldGltZS9kYXRldGltZS1s b2NhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAy NjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3Jh eSBvdXQgZGF0ZXMgd2l0aCBubyBhbGxvd2VkIHZhbHVlcyBvbiBjYWxlbmRhciBwaWNrZXIgZm9y IGRhdGV0aW1lL2RhdGV0aW1lLWxvY2FsCisgICAgICAgIHdoZW4gdmFsdWVzIGFyZSBsaW1pdGVk IGJ5IG1pbi9tYXgvc3RlcCBhdHRyaWJ1dGVzLgorCisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL2No cm9taXVtL2Zhc3QvZm9ybXMvY2FsZW5kYXItcGlja2VyL2NhbGVuZGFyLXBpY2tlci1kYXRldGlt ZS13aXRoLXN0ZXAuaHRtbAorCisgICAgICAgICogUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5k YXJQaWNrZXIuanM6CisgICAgICAgIChDYWxlbmRhclBpY2tlci5wcm90b3R5cGUuX3N0ZXBNaXNt YXRjaCk6CisgICAgICAgIFJldHVybnMgdHJ1ZSBpZmYgdGhlcmUgYXJlIGFueSBhbGxvd2VkIHZh bHVlcyBpbiB0aGUgZ2l2ZW4gZGF5LgorCiAyMDEyLTExLTE2ICBKb24gTGVlICA8am9ubGVlQGFw cGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgdmlzdWFsIGxvb2sgb2YgcGxhY2Vob2xkZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1Jlc291cmNlcy9wYWdlcG9wdXBzL2NhbGVuZGFyUGlj a2VyLmpzIGIvU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5kYXJQaWNr ZXIuanMKaW5kZXggMjIwMjJmMzVhY2VhNDBkNzMyMjk1OWJhNTBiMzQ4N2M2YWEwZWRlYS4uMDZj NDViMWQzMjYzZDljMzgxYWZmZTUwZmQ4Mzc2MzkxNWE0MmM5NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5kYXJQaWNrZXIuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvUmVzb3VyY2VzL3BhZ2Vwb3B1cHMvY2FsZW5kYXJQaWNrZXIuanMKQEAgLTEy MTksNyArMTIxOSw4IEBAIERheXNUYWJsZS5wcm90b3R5cGUuYXR0YWNoVG8gPSBmdW5jdGlvbihl bGVtZW50KSB7CiAgKiBAcmV0dXJuIHshYm9vbGVhbn0KICAqLwogQ2FsZW5kYXJQaWNrZXIucHJv dG90eXBlLl9zdGVwTWlzbWF0Y2ggPSBmdW5jdGlvbih2YWx1ZSkgewotICAgIHJldHVybiAodmFs dWUgLSB0aGlzLnN0ZXBCYXNlKSAlIHRoaXMuc3RlcCAhPSAwOworICAgIHZhciBuZXh0QWxsb3dl ZFZhbHVlID0gTWF0aC5jZWlsKCh2YWx1ZSAtIHRoaXMuc3RlcEJhc2UpIC8gdGhpcy5zdGVwKSAq IHRoaXMuc3RlcCArIHRoaXMuc3RlcEJhc2U7CisgICAgcmV0dXJuIG5leHRBbGxvd2VkVmFsdWUg Pj0gdmFsdWUgKyB0aGlzLnNlbGVjdGlvbkNvbnN0cnVjdG9yLkRlZmF1bHRTdGVwCiB9CiAKIC8q KgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IGZhZDg3ODA1ZDAzZjU5YTNmM2MyMTI5YmRjYThkY2Y5OThmYzc4ZGMuLjA3MjAz NzdjNzNlNzllOTA3Y2Y5ZDJhMjdmNjA0NTNhY2IzNzc3MmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxMi0xMS0xOCAgS3VuaWhpa28gU2FrYW1vdG8gIDxrc2FrYW1vdG9AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIG1pbi9tYXgvc3RlcCBzdXBwb3J0IGZvciBjYWxlbmRhciBwaWNrZXIgb24g ZGF0ZXRpbWUvZGF0ZXRpbWUtbG9jYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMjYyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFZlcmlmeSB0aGF0IGNhbGVuZGFyIHBpY2tlciBoYXMgY29ycmVjdCBh dmFpbGFibGUgZGF0ZXMgd2hlbgorICAgICAgICBtaW4vbWF4L3N0ZXAgYXR0cmlidXRlcyBhcmUg c2V0IGluIGRhdGV0aW1lIGlucHV0LgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vZmFz dC9mb3Jtcy9jYWxlbmRhci1waWNrZXIvY2FsZW5kYXItcGlja2VyLWRhdGV0aW1lLXdpdGgtc3Rl cC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL2Zhc3Qv Zm9ybXMvY2FsZW5kYXItcGlja2VyL2NhbGVuZGFyLXBpY2tlci1kYXRldGltZS13aXRoLXN0ZXAu aHRtbDogQWRkZWQuCisKIDIwMTItMTEtMTYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlbWFpbmluZyBiaXRzIG9mIFdpbjcg cmViYXNlbGluZXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9m YXN0L2Zvcm1zL2NhbGVuZGFyLXBpY2tlci9jYWxlbmRhci1waWNrZXItZGF0ZXRpbWUtd2l0aC1z dGVwLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvZm9y bXMvY2FsZW5kYXItcGlja2VyL2NhbGVuZGFyLXBpY2tlci1kYXRldGltZS13aXRoLXN0ZXAtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY4MjYxOTcwY2YzMWY1YzgxODI3Y2M0N2ZiNjNhZTA1YzUw NGRlODcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9m YXN0L2Zvcm1zL2NhbGVuZGFyLXBpY2tlci9jYWxlbmRhci1waWNrZXItZGF0ZXRpbWUtd2l0aC1z dGVwLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE1IEBACitUZXN0IGlmIHN0ZXAgbGltaXRzIGF2 YWlsYWJsZSBkYXRlcyBpbiBjYWxlbmRhciBwaWNrZXIgb24gZGF0ZXRpbWUgaW5wdXQuCisKK09u IHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxv d2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitTdGVwIHdpdGhvdXQgbWluIG9yIG1heC4KK1BB U1MgYXZhaWxhYmxlRGF0ZXNJbkN1cnJlbnRNb250aCgpLmpvaW4oIiwiKSBpcyAiMjAxMi0xMS0w MSwyMDEyLTExLTA0LDIwMTItMTEtMDgsMjAxMi0xMS0xMSwyMDEyLTExLTE1LDIwMTItMTEtMTgs MjAxMi0xMS0yMiwyMDEyLTExLTI1LDIwMTItMTEtMjkiCitTdGVwIHdoZW4gbWluIGlzIHNldC4K K1BBU1MgYXZhaWxhYmxlRGF0ZXNJbkN1cnJlbnRNb250aCgpLmpvaW4oIiwiKSBpcyAiMjAxMi0x MS0xNiwyMDEyLTExLTIwLDIwMTItMTEtMjMsMjAxMi0xMS0yNywyMDEyLTExLTMwIgorU3RlcCB3 aGVuIG1pbiBhbmQgbWF4IGFyZSBzZXQuCitQQVNTIGF2YWlsYWJsZURhdGVzSW5DdXJyZW50TW9u dGgoKS5qb2luKCIsIikgaXMgIjIwMTItMTEtMTYsMjAxMi0xMS0yMCIKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9mb3Jtcy9jYWxlbmRhci1waWNrZXIvY2FsZW5k YXItcGlja2VyLWRhdGV0aW1lLXdpdGgtc3RlcC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vZmFzdC9mb3Jtcy9jYWxlbmRhci1waWNrZXIvY2FsZW5kYXItcGlja2VyLWRhdGV0 aW1lLXdpdGgtc3RlcC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI2YWFlMTU5YzI2MmZhYjliYTI4ZDI2NzE4 YzY3OTNjNWFhOTM1MDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9mYXN0L2Zvcm1zL2NhbGVuZGFyLXBpY2tlci9jYWxlbmRhci1waWNrZXItZGF0ZXRp bWUtd2l0aC1zdGVwLmh0bWwKQEAgLTAsMCArMSw2MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi8uLi9m YXN0L2Zvcm1zL3Jlc291cmNlcy9waWNrZXItY29tbW9uLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQg c3JjPSJyZXNvdXJjZXMvY2FsZW5kYXItcGlja2VyLWNvbW1vbi5qcyI+PC9zY3JpcHQ+Cis8L2hl YWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisKKzxpbnB1dCB0eXBlPWRhdGV0aW1lIGlkPWRhdGV0aW1lIHN0ZXA9IjMwMjQwMCIv PgorCis8c2NyaXB0PgorZGVzY3JpcHRpb24oJ1Rlc3QgaWYgc3RlcCBsaW1pdHMgYXZhaWxhYmxl IGRhdGVzIGluIGNhbGVuZGFyIHBpY2tlciBvbiBkYXRldGltZSBpbnB1dC4nKTsKKworb3BlblBp Y2tlcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZGF0ZXRpbWUnKSwgdGVzdDEpOworCitmdW5j dGlvbiB0ZXN0MSgpIHsKKyAgICBkZWJ1ZygiU3RlcCB3aXRob3V0IG1pbiBvciBtYXguIik7Cisg ICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdhdmFpbGFibGVEYXRlc0luQ3VycmVudE1vbnRoKCku am9pbigiLCIpJywgJzIwMTItMTEtMDEsMjAxMi0xMS0wNCwyMDEyLTExLTA4LDIwMTItMTEtMTEs MjAxMi0xMS0xNSwyMDEyLTExLTE4LDIwMTItMTEtMjIsMjAxMi0xMS0yNSwyMDEyLTExLTI5Jyk7 CisKKyAgICAvLyBDbG9zZSBwb3B1cAorICAgIGV2ZW50U2VuZGVyLmtleURvd24oJ1x4MUInKTsK KyAgICB3YWl0VW50aWxDbG9zaW5nKHRlc3QxQWZ0ZXJDbG9zZSk7Cit9CisKK2Z1bmN0aW9uIHRl c3QxQWZ0ZXJDbG9zZSgpIHsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZGF0ZXRpbWUn KS5taW4gPSAiMjAxMi0xMS0xNlQxMjowMFoiOworICAgIAorICAgIC8vIFJlb3BlbiBwb3B1cAor ICAgIG9wZW5QaWNrZXIoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2RhdGV0aW1lJyksIHRlc3Qy KTsKK30KKworZnVuY3Rpb24gdGVzdDIoKSB7CisgICAgZGVidWcoIlN0ZXAgd2hlbiBtaW4gaXMg c2V0LiIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygnYXZhaWxhYmxlRGF0ZXNJbkN1cnJl bnRNb250aCgpLmpvaW4oIiwiKScsICcyMDEyLTExLTE2LDIwMTItMTEtMjAsMjAxMi0xMS0yMywy MDEyLTExLTI3LDIwMTItMTEtMzAnKTsKKworICAgIC8vIENsb3NlIHBvcHVwCisgICAgZXZlbnRT ZW5kZXIua2V5RG93bignXHgxQicpOworICAgIHdhaXRVbnRpbENsb3NpbmcodGVzdDJBZnRlckNs b3NlKTsKK30KKworZnVuY3Rpb24gdGVzdDJBZnRlckNsb3NlKCkgeworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdkYXRldGltZScpLm1heCA9ICIyMDEyLTExLTIwVDAwOjAwWiI7CisgICAg CisgICAgLy8gUmVvcGVuIHBvcHVwCisgICAgb3BlblBpY2tlcihkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnZGF0ZXRpbWUnKSwgdGVzdDMpOworfQorCitmdW5jdGlvbiB0ZXN0MygpIHsKKyAgICBk ZWJ1ZygiU3RlcCB3aGVuIG1pbiBhbmQgbWF4IGFyZSBzZXQuIik7CisgICAgc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCdhdmFpbGFibGVEYXRlc0luQ3VycmVudE1vbnRoKCkuam9pbigiLCIpJywgJzIw MTItMTEtMTYsMjAxMi0xMS0yMCcpOworICAgIGZpbmlzaEpTVGVzdCgpOworfQorCis8L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi8uLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=