102625 2012-11-18 17:46:50 -0800 Tighten small SharedBuffers by reserving the exact amount of space needed. 2012-11-18 18:56:49 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling koivisto webkit.review.bot oldest_to_newest 770242 0 kling 2012-11-18 17:46:50 -0800 We have a lot of SharedBuffers that are smaller than one segment (4096 bytes), and there's quite a lot of spill in the internal Vectors. 770245 1 174868 kling 2012-11-18 17:48:30 -0800 Created attachment 174868 Patch 770271 2 174868 webkit.review.bot 2012-11-18 18:56:46 -0800 Comment on attachment 174868 Patch Clearing flags on attachment: 174868 Committed r135098: <http://trac.webkit.org/changeset/135098> 770272 3 webkit.review.bot 2012-11-18 18:56:49 -0800 All reviewed patches have been landed. Closing bug. 174868 2012-11-18 17:48:30 -0800 2012-11-18 18:56:46 -0800 Patch bug-102625.diff text/plain 1404 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MmZjNzE1Li5mZWUzOGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMTEtMTggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFRpZ2h0ZW4gc21hbGwgU2hhcmVkQnVmZmVycyBieSByZXNlcnZpbmcgdGhlIGV4YWN0IGFt b3VudCBvZiBzcGFjZSBuZWVkZWQuCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEwMjYy NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVu IGFkZGluZyB0aGUgZmlyc3QgY2h1bmsgdG8gYSBzbWFsbCAoPDQwOTYgYnl0ZXMpIFNoYXJlZEJ1 ZmZlciwgcmVzZXJ2ZSB0aGUgZXhhY3QKKyAgICAgICAgYW1vdW50IG9mIHNwYWNlIG5lZWRlZCBp bnN0ZWFkIG9mIGxlYXZpbmcgaXQgdG8gVmVjdG9yPGNoYXI+OjphcHBlbmQoKS4KKworICAgICAg ICAxLjg2TUIgcHJvZ3Jlc3Npb24gb24gTWVtYnVzdGVyMy4KKworICAgICAgICAqIHBsYXRmb3Jt L1NoYXJlZEJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRCdWZmZXI6OmFwcGVu ZCk6CisKKzIwMTItMTEtMTggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAg ICAgICAgIFN0eWxlZEVsZW1lbnQ6IE1ha2UgaGFuZGxpbmcgdGhlICJzdHlsZSIgYXR0cmlidXRl IGEgbGl0dGUgZmFzdGVyLgogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMDI2MjM+CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCmluZGV4IGM3NmJlNWQuLmE0 OTgwZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcApAQCAtMTgw LDYgKzE4MCw4IEBAIHZvaWQgU2hhcmVkQnVmZmVyOjphcHBlbmQoY29uc3QgY2hhciogZGF0YSwg dW5zaWduZWQgbGVuZ3RoKQogCiAgICAgaWYgKG1fc2l6ZSA8PSBzZWdtZW50U2l6ZSkgewogICAg ICAgICAvLyBObyBuZWVkIHRvIHVzZSBzZWdtZW50cyBmb3Igc21hbGwgcmVzb3VyY2UgZGF0YQor ICAgICAgICBpZiAobV9idWZmZXIuaXNFbXB0eSgpKQorICAgICAgICAgICAgbV9idWZmZXIucmVz ZXJ2ZUluaXRpYWxDYXBhY2l0eShsZW5ndGgpOwogICAgICAgICBtX2J1ZmZlci5hcHBlbmQoZGF0 YSwgbGVuZ3RoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K