102624 2012-11-18 17:14:28 -0800 Make RenderLayer::updateLayerPosition() private 2013-12-07 11:52:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105861 125392 1 simon.fraser simon.fraser dglazkov eric simon.fraser webkit.review.bot oldest_to_newest 770233 0 simon.fraser 2012-11-18 17:14:28 -0800 Make RenderLayer::updateLayerPosition() private 770234 1 174863 simon.fraser 2012-11-18 17:18:53 -0800 Created attachment 174863 Patch 770292 2 174863 rniwa 2012-11-18 19:47:23 -0800 Comment on attachment 174863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174863&action=review Looks right to me. > Source/WebCore/dom/MouseRelatedEvent.cpp:167 > if (RenderObject* r = targetNode->renderer()) { The code right beneath this calls absoluteToLocal! 770303 3 174863 webkit.review.bot 2012-11-18 20:26:10 -0800 Comment on attachment 174863 Patch Attachment 174863 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14910026 New failing tests: fast/events/stopPropagation-submit.html 780449 4 simon.fraser 2012-11-30 15:01:39 -0800 http://trac.webkit.org/changeset/136280 798259 5 eric 2012-12-30 13:59:10 -0800 I believe this caused bug 102624 (assuming I ran git-bisect correctly). 798260 6 eric 2012-12-30 13:59:28 -0800 Sorry, I meant bug 105861. 174863 2012-11-18 17:18:53 -0800 2012-11-18 20:26:10 -0800 Patch bug-102624-20121118171644.patch text/plain 6133 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjAwZmIxNTkyYWZlNDJh MmM1YmNmNjFlZjZmNTc4NGIxMjFmZTM4Yy4uOTA1ZGViMzIxOGUxOGVkZTkxOWQzNWU5OWEzZGIw OWM3ZTQyZTAwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTExLTE4ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgUmVuZGVy TGF5ZXI6OnVwZGF0ZUxheWVyUG9zaXRpb24oKSBwcml2YXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2MjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWRlIHVwZGF0ZUxheWVyUG9zaXRpb24oKSBw cml2YXRlLiBUaGUgb25seSBleHRlcm5hbCBjYWxsZXIgd2FzCisgICAgICAgIE1vdXNlUmVsYXRl ZEV2ZW50Ojpjb21wdXRlUmVsYXRpdmVQb3NpdGlvbigpLCB3aGljaCBoYXMgbm8gYnVzaW5lc3Mg dXBkYXRpbmcKKyAgICAgICAgbGF5ZXIgcG9zaXRpb25zLiBJbiBmYWN0IGl0IGhhZCBwb3NpdGl2 ZWx5IGRhbmdlcm91cyBiZWhhdmlvcjsgZG9pbmcganVzdAorICAgICAgICBhIHN0eWxlIHVwZGF0 ZSB3aXRob3V0IGxheW91dCwgYW5kIHRoZW4gY2FsbGluZyBhYnNvbHV0ZVRvTG9jYWwoKSBhbmQg d2Fsa2luZworICAgICAgICBsYXllcnMuIEZpeGVkIGJ5IGhhdmluZyBpdCBjYWxsIHVwZGF0ZUxh eW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBy ZXZlYWxlZCBhIGJ1ZyB3aGVyZSBldmVudC5vZmZzZXRYL29mZnNldFkgY291bGQgYmUgd3Jvbmcg aW4gc29tZSBjYXNlcy4KKyAgICAgICAgZmFzdC9ldmVudHMvc3RvcFByb3BhZ2F0aW9uLXN1Ym1p dC5odG1sIGRvZXMgYSBzaW11bGF0ZWQgY2xpY2sgKHdoaWNoIGhhcworICAgICAgICBjbGllbnQg Y29vcmRpbmF0ZXMgYXQgMCwwKSwgc28gdGhlIGltYWdlIHN1Ym1pdCBjb29yZGluYXRlcyB3ZXJl IGluY29ycmVjdGx5CisgICAgICAgIDAsMC4gTm93IHRoYXQgd2UgZG8gbGF5b3V0IGJlZm9yZSBj b21wdXRpbmcgdGhlbSwgdGhleSBhcmUgY29ycmVjdGx5IHJlcG9ydGVkCisgICAgICAgIGFzIGJl aW5nIHJlbGF0aXZlIHRvIHRoZSBlbGVtZW50LgorCisgICAgICAgICogZG9tL01vdXNlUmVsYXRl ZEV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vdXNlUmVsYXRlZEV2ZW50Ojpjb21wdXRl UmVsYXRpdmVQb3NpdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVMYXllclBvc2l0aW9uc0FmdGVy U2Nyb2xsKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKyAgICAgICAgKFJl bmRlckxheWVyKToKKwogMjAxMi0xMS0xOCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIEdlbmVyYXRlTW9kdWxlKCkgZnJvbSBhbGwgY29kZSBn ZW5lcmF0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZl bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNwcAppbmRleCA4 MDFhYTY3MWQxYzc4ODgyMTExMDdkYmQxYzA2NTllYjEzMzRlNGM5Li44MTMyNmQwMGExMTg2Yjhk ODNiZDQxN2UxZDc3MmE1ZTc5ZGY4MzkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v TW91c2VSZWxhdGVkRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZVJlbGF0 ZWRFdmVudC5jcHAKQEAgLTE2MSw3ICsxNjEsNyBAQCB2b2lkIE1vdXNlUmVsYXRlZEV2ZW50Ojpj b21wdXRlUmVsYXRpdmVQb3NpdGlvbigpCiAgICAgbV9vZmZzZXRMb2NhdGlvbiA9IG1fcGFnZUxv Y2F0aW9uOwogCiAgICAgLy8gTXVzdCBoYXZlIGFuIHVwZGF0ZWQgcmVuZGVyIHRyZWUgZm9yIHRo aXMgbWF0aCB0byB3b3JrIGNvcnJlY3RseS4KLSAgICB0YXJnZXROb2RlLT5kb2N1bWVudCgpLT51 cGRhdGVTdHlsZUlmTmVlZGVkKCk7CisgICAgdGFyZ2V0Tm9kZS0+ZG9jdW1lbnQoKS0+dXBkYXRl TGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAKICAgICAvLyBBZGp1c3Qgb2Zmc2V0 TG9jYXRpb24gdG8gYmUgcmVsYXRpdmUgdG8gdGhlIHRhcmdldCdzIHBvc2l0aW9uLgogICAgIGlm IChSZW5kZXJPYmplY3QqIHIgPSB0YXJnZXROb2RlLT5yZW5kZXJlcigpKSB7CkBAIC0xNzMsMTcg KzE3MywxNSBAQCB2b2lkIE1vdXNlUmVsYXRlZEV2ZW50Ojpjb21wdXRlUmVsYXRpdmVQb3NpdGlv bigpCiAgICAgfQogCiAgICAgLy8gQWRqdXN0IGxheWVyTG9jYXRpb24gdG8gYmUgcmVsYXRpdmUg dG8gdGhlIGxheWVyLgotICAgIC8vIEZJWE1FOiBXZSdyZSBwcmV0dHkgc3VyZSB0aGlzIGlzIHRo ZSB3cm9uZyBkZWZpbml0aW9uIG9mICJsYXllci4iCi0gICAgLy8gT3VyIFJlbmRlckxheWVyIGlz IGEgbW9yZSBtb2Rlcm4gY29uY2VwdCwgYW5kIGxheWVyWC9ZIGlzIHNvbWUKLSAgICAvLyBvdGhl ciBub3Rpb24gYWJvdXQgZ3JvdXBzIG9mIGVsZW1lbnRzIChsZWZ0IG92ZXIgZnJvbSB0aGUgTmV0 c2NhcGUgNCBkYXlzPyk7Ci0gICAgLy8gd2Ugc2hvdWxkIHRlc3QgYW5kIGZpeCB0aGlzLgorICAg IC8vIEZJWE1FOiBldmVudC5sYXllclggYW5kIGV2ZW50LmxheWVyWSBhcmUgcG9vcmx5IGRlZmlu ZWQsCisgICAgLy8gYW5kIHByb2JhYmx5IGRvbid0IGFsd2F5cyBjb3JyZXNwb25kIHRvIFJlbmRl ckxheWVyIG9mZnNldHMuCisgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxODY4CiAgICAgTm9kZSogbiA9IHRhcmdldE5vZGU7CiAgICAgd2hpbGUgKG4gJiYg IW4tPnJlbmRlcmVyKCkpCiAgICAgICAgIG4gPSBuLT5wYXJlbnROb2RlKCk7CiAKICAgICBSZW5k ZXJMYXllciogbGF5ZXI7CiAgICAgaWYgKG4gJiYgKGxheWVyID0gbi0+cmVuZGVyZXIoKS0+ZW5j bG9zaW5nTGF5ZXIoKSkpIHsKLSAgICAgICAgbGF5ZXItPnVwZGF0ZUxheWVyUG9zaXRpb24oKTsK ICAgICAgICAgZm9yICg7IGxheWVyOyBsYXllciA9IGxheWVyLT5wYXJlbnQoKSkgewogICAgICAg ICAgICAgbV9sYXllckxvY2F0aW9uIC09IHRvTGF5b3V0U2l6ZShsYXllci0+bG9jYXRpb24oKSk7 CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4 IGJjNDlmZTgyMzFlNTU2NTJmZmMwYzM1NTAzMzFkNzU3OWZkOWQwMzMuLmM3YWViYTQ2NjY5YmI0 MTQzYWExNjZjNmZiY2I1YTBlNjQ3MTEwNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcApAQCAtNTMwLDcgKzUzMCw2IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0 ZUxheWVyUG9zaXRpb25zQWZ0ZXJTY3JvbGwoUmVuZGVyR2VvbWV0cnlNYXAqIGdlb21ldHJ5TWFw CiAgICAgICAgIGdlb21ldHJ5TWFwLT5wdXNoTWFwcGluZ3NUb0FuY2VzdG9yKHRoaXMsIHBhcmVu dCgpKTsKIAogICAgIGlmICgoZmxhZ3MgJiBIYXNTZWVuVmlld3BvcnRDb25zdHJhaW5lZEFuY2Vz dG9yKSB8fCByZW5kZXJlcigpLT5zdHlsZSgpLT5oYXNWaWV3cG9ydENvbnN0cmFpbmVkUG9zaXRp b24oKSkgewotICAgICAgICAvLyBGSVhNRTogSXMgaXQgd29ydGggcGFzc2luZyB0aGUgb2Zmc2V0 RnJvbVJvb3QgYXJvdW5kIGxpa2UgaW4gdXBkYXRlTGF5ZXJQb3NpdGlvbnM/CiAgICAgICAgIC8v IEZJWE1FOiBXZSBjb3VsZCB0cmFjayB0aGUgcmVwYWludCBjb250YWluZXIgYXMgd2Ugd2FsayBk b3duIHRoZSB0cmVlLgogICAgICAgICBjb21wdXRlUmVwYWludFJlY3RzKHJlbmRlcmVyKCktPmNv bnRhaW5lckZvclJlcGFpbnQoKSwgZ2VvbWV0cnlNYXApOwogICAgICAgICBmbGFncyB8PSBIYXNT ZWVuVmlld3BvcnRDb25zdHJhaW5lZEFuY2VzdG9yOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuaAppbmRleCA3MjU5Zjc5Y2Q4Mzk1OTFkZWVjMzk5NTcxMWY4NTExMzQwM2EwY2Vm Li5lZTQ4YzEyZTIxMTQwNGUxYzFlMWRhZWY1Mzk5ZmIwMWM0NzUzN2U0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaApAQCAtMzkwLDggKzM5MCw2IEBAIHB1YmxpYzoKIAog ICAgIGJvb2wgY2FuUmVuZGVyM0RUcmFuc2Zvcm1zKCkgY29uc3Q7CiAKLSAgICB2b2lkIHVwZGF0 ZUxheWVyUG9zaXRpb24oKTsKLQogICAgIGVudW0gVXBkYXRlTGF5ZXJQb3NpdGlvbnNGbGFnIHsK ICAgICAgICAgQ2hlY2tGb3JSZXBhaW50ID0gMSwKICAgICAgICAgSXNDb21wb3NpdGluZ1VwZGF0 ZVJvb3QgPSAxIDw8IDEsCkBAIC03MzEsNiArNzI5LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHVw ZGF0ZVNjcm9sbGJhcnNBZnRlclN0eWxlQ2hhbmdlKGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHls ZSk7CiAgICAgdm9pZCB1cGRhdGVTY3JvbGxiYXJzQWZ0ZXJMYXlvdXQoKTsKIAorICAgIHZvaWQg dXBkYXRlTGF5ZXJQb3NpdGlvbigpOwogICAgIHZvaWQgdXBkYXRlTGF5ZXJQb3NpdGlvbnMoUmVu ZGVyR2VvbWV0cnlNYXAqID0gMCwgVXBkYXRlTGF5ZXJQb3NpdGlvbnNGbGFncyA9IGRlZmF1bHRG bGFncyk7CiAKICAgICBlbnVtIFVwZGF0ZUxheWVyUG9zaXRpb25zQWZ0ZXJTY3JvbGxGbGFnIHsK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4OTM2M2RmZDQ0ODMwMWNkYjUwNDhlZDIyNWJmZDMyMGVkMWZkMjc5Li41YjE4ZDUy NjgwZWMzYjU0N2QwYTlhZjc1MTM5YzUzNmQxZGRiNjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTItMTEtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAg ICAgICAgTWFrZSBSZW5kZXJMYXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbigpIHByaXZhdGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjYyNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyByZXN1bHRz IHdpdGggY29ycmVjdGx5IGNvbXB1dGVkIGV2ZW50IG9mZnNldHMuCisKKyAgICAgICAgKiBmYXN0 L2V2ZW50cy9zdG9wUHJvcGFnYXRpb24tc3VibWl0LWV4cGVjdGVkLnR4dDoKKworMjAxMi0xMS0x OCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZWJh c2VsaW5lcy4KIAogICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L21lZGlhL21xLWpzLW1lZGlh LWV4Y2VwdC0wMi1leHBlY3RlZC50eHQ6CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9zdG9wUHJvcGFnYXRpb24tc3VibWl0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL3N0b3BQcm9wYWdhdGlvbi1zdWJtaXQtZXhwZWN0ZWQudHh0CmluZGV4IDU4YjJh ODJhYjMyNDE1ZWUzZTY0ODc2MzI2ZmY0M2ZlNjViOTJmYzIuLmIzZWFiYjBhMjQ1OTJkZTZlNjQ2 ZjQxZDZmZGU4NWE5MzA5MDg4MzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3N0b3BQcm9wYWdhdGlvbi1zdWJtaXQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL3N0b3BQcm9wYWdhdGlvbi1zdWJtaXQtZXhwZWN0ZWQudHh0CkBAIC0xLDIgKzEs MiBAQAogUEFTUwotP3g9MCZ5PTAKKz94PS04Jnk9LTYwCg==