102615 2012-11-18 11:48:08 -0800 Inline the StyledElement constructor. 2012-11-18 12:25:43 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102598 1 kling webkit-unassigned webkit.review.bot oldest_to_newest 770160 0 kling 2012-11-18 11:48:08 -0800 StyeldElement::StyledElement() is out of line for no good reason. 770161 1 174851 kling 2012-11-18 11:48:45 -0800 Created attachment 174851 Patch 770162 2 174851 koivisto 2012-11-18 11:50:30 -0800 Comment on attachment 174851 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174851&action=review > Source/WebCore/dom/StyledElement.h:63 > + { > + } Good job. 770167 3 174851 webkit.review.bot 2012-11-18 12:25:40 -0800 Comment on attachment 174851 Patch Clearing flags on attachment: 174851 Committed r135078: <http://trac.webkit.org/changeset/135078> 770168 4 webkit.review.bot 2012-11-18 12:25:43 -0800 All reviewed patches have been landed. Closing bug. 174851 2012-11-18 11:48:45 -0800 2012-11-18 12:25:40 -0800 Patch bug-102615.diff text/plain 2212 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyZjM1YzcwLi43N2UxYjA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTItMTEtMTggIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIElubGluZSB0aGUgU3R5bGVkRWxlbWVudCBjb25zdHJ1Y3Rvci4KKyAgICAgICAgPGh0dHA6 Ly93ZWJraXQub3JnL2IvMTAyNjE1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN0eWxlZEVsZW1lbnQgc2l0cyBiZXR3ZWVuIEVsZW1lbnQgYW5kIEhU TUxFbGVtZW50IGluIHRoZSBpbmhlcml0YW5jZSBjaGFpbiwgYW5kIGJvdGggb2YgdGhvc2UgYXJl IGlubGluZS4gCisgICAgICAgIEtub2NrcyB+MC40JSBvZiBzYW1wbGVzIG9mZiBvZiB0aGUgRE9N L0NyZWF0ZU5vZGVzIHBlcmZvcm1hbmNlIHRlc3QuCisKKyAgICAgICAgKiBkb20vU3R5bGVkRWxl bWVudC5jcHA6CisgICAgICAgICogZG9tL1N0eWxlZEVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNv cmU6OlN0eWxlZEVsZW1lbnQ6OlN0eWxlZEVsZW1lbnQpOgorCisyMDEyLTExLTE4ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBFbGVtZW50OjpwYXJzZUF0dHJp YnV0ZSgpIHNob3VsZCB0YWtlIG5hbWUgJiB2YWx1ZSBhcyBzZXBhcmF0ZSBhcmd1bWVudHMuCiAg ICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEwMjYwOD4KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxl ZEVsZW1lbnQuY3BwCmluZGV4IGI4ZjBiZDkuLjk4N2QxYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU3R5 bGVkRWxlbWVudC5jcHAKQEAgLTEzNSwxMSArMTM1LDYgQEAgdm9pZCBTdHlsZWRFbGVtZW50Ojp1 cGRhdGVTdHlsZUF0dHJpYnV0ZSgpIGNvbnN0CiAgICAgICAgIGNvbnN0X2Nhc3Q8U3R5bGVkRWxl bWVudCo+KHRoaXMpLT5zZXRTeW5jaHJvbml6ZWRMYXp5QXR0cmlidXRlKHN0eWxlQXR0ciwgaW5s aW5lU3R5bGUtPmFzVGV4dCgpKTsKIH0KIAotU3R5bGVkRWxlbWVudDo6U3R5bGVkRWxlbWVudChj b25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBEb2N1bWVudCogZG9jdW1lbnQsIENvbnN0cnVjdGlv blR5cGUgdHlwZSkKLSAgICA6IEVsZW1lbnQobmFtZSwgZG9jdW1lbnQsIHR5cGUpCi17Ci19Ci0K IFN0eWxlZEVsZW1lbnQ6On5TdHlsZWRFbGVtZW50KCkKIHsKICAgICBpZiAoUHJvcGVydHlTZXRD U1NTdHlsZURlY2xhcmF0aW9uKiBjc3NvbVdyYXBwZXIgPSBpbmxpbmVTdHlsZUNTU09NV3JhcHBl cigpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmgKaW5kZXggMmZiNmM5Ny4uMjY2YjQyZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vU3R5bGVkRWxlbWVudC5oCkBAIC01Nyw3ICs1NywxMCBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIGNvbGxlY3RTdHlsZUZvclByZXNlbnRhdGlvbkF0dHJpYnV0ZShj b25zdCBBdHRyaWJ1dGUmLCBTdHlsZVByb3BlcnR5U2V0KikgeyB9CiAKIHByb3RlY3RlZDoKLSAg ICBTdHlsZWRFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCosIENvbnN0cnVj dGlvblR5cGUpOworICAgIFN0eWxlZEVsZW1lbnQoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwg RG9jdW1lbnQqIGRvY3VtZW50LCBDb25zdHJ1Y3Rpb25UeXBlIHR5cGUpCisgICAgICAgIDogRWxl bWVudChuYW1lLCBkb2N1bWVudCwgdHlwZSkKKyAgICB7CisgICAgfQogCiAgICAgdmlydHVhbCB2 b2lkIGF0dHJpYnV0ZUNoYW5nZWQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGNvbnN0IEF0b21pY1N0 cmluZyYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBwYXJzZUF0dHJpYnV0ZShjb25zdCBR dWFsaWZpZWROYW1lJiwgY29uc3QgQXRvbWljU3RyaW5nJikgT1ZFUlJJREU7Cg==