102612 2012-11-18 08:24:52 -0800 [chromium] add WebCursorInfo::imageScaleFactor 2012-11-18 10:47:08 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99493 1 rbyers rbyers abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 770122 0 rbyers 2012-11-18 08:24:52 -0800 Splitting the chromium API change out from bug 99493 in order to decouple the webkit and chromium sides of this work. 770124 1 174847 rbyers 2012-11-18 08:27:42 -0800 Created attachment 174847 Patch 770126 2 webkit.review.bot 2012-11-18 08:28:57 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 770132 3 174847 abarth 2012-11-18 08:45:14 -0800 Comment on attachment 174847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review > Source/WebKit/chromium/src/WebCursorInfo.cpp:44 > + imageScaleFactor = 1; You should initialize this variable in an initializer list, like you've done in the header. 770139 4 174849 rbyers 2012-11-18 09:22:12 -0800 Created attachment 174849 Patch 770141 5 rbyers 2012-11-18 09:23:43 -0800 (In reply to comment #3) > (From update of attachment 174847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174847&action=review > > > Source/WebKit/chromium/src/WebCursorInfo.cpp:44 > > + imageScaleFactor = 1; > > You should initialize this variable in an initializer list, like you've done in the header. Thanks. I moved the initialization of all variables in this ctor to an initializer list in order to be consistent. 770144 6 174849 abarth 2012-11-18 10:10:00 -0800 Comment on attachment 174849 Patch great 770148 7 174849 buildbot 2012-11-18 10:18:13 -0800 Comment on attachment 174849 Patch Attachment 174849 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14893089 New failing tests: inspector-protocol/nmi-webaudio.html 770155 8 174849 webkit.review.bot 2012-11-18 10:47:05 -0800 Comment on attachment 174849 Patch Clearing flags on attachment: 174849 Committed r135076: <http://trac.webkit.org/changeset/135076> 770156 9 webkit.review.bot 2012-11-18 10:47:08 -0800 All reviewed patches have been landed. Closing bug. 174847 2012-11-18 08:27:42 -0800 2012-11-18 09:22:09 -0800 Patch bug-102612-20121118112534.patch text/plain 2126 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhhY2VhZGI5OThmYjE1NjVjMWRmYWI3NDdhNjVkMThhMzRhNGJhNTYuLjMzMDU3OTE5YmJhMWRl MTk0MzQ4ODdjMjZkNGQzNGM2NWM3MTcyNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTEtMTggIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRkIFdlYkN1cnNvckluZm86OmltYWdlU2NhbGVG YWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjYxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBjdXJzb3IgaW1hZ2Ugc2NhbGUgZmFjdG9yIChjdXJyZW50bHkgYWx3YXlzIDEpIHRvIGNocm9t aXVtIEFQSSwgaW4gcHJlcGFyYXRpb24gZm9yCisgICAgICAgIGhpZ2gtZHBpIGN1cnNvciBzdXBw b3J0IGluIGJ1ZyA5OTQ5My4KKworICAgICAgICAqIHB1YmxpYy9XZWJDdXJzb3JJbmZvLmg6Cisg ICAgICAgIChXZWJLaXQ6OldlYkN1cnNvckluZm86OldlYkN1cnNvckluZm8pOgorICAgICAgICAq IHNyYy9XZWJDdXJzb3JJbmZvLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ3Vyc29ySW5mbzo6 V2ViQ3Vyc29ySW5mbyk6CisKIDIwMTItMTEtMTcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmll dy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkN1cnNvckluZm8uaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkN1cnNvckluZm8uaAppbmRleCBjYzhi YzU5YmQxZTAwZDgwNjcyNmU0YWI2MmVhZjk4ZTk0MDBkOGI5Li4yOTgyYjZjNTMzMTQ4NmE5OTI2 YTc1ZDJkMjkwYmUzYTcyMTBlOGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJDdXJzb3JJbmZvLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ3Vyc29ySW5mby5oCkBAIC05NSw2ICs5NSw3IEBAIHN0cnVjdCBXZWJDdXJzb3JJbmZv IHsKIAogICAgIFR5cGUgdHlwZTsKICAgICBXZWJQb2ludCBob3RTcG90OworICAgIGZsb2F0IGlt YWdlU2NhbGVGYWN0b3I7CiAgICAgV2ViSW1hZ2UgY3VzdG9tSW1hZ2U7CiAKICNpZmRlZiBXSU4z MgpAQCAtMTA3LDYgKzEwOCw3IEBAIHN0cnVjdCBXZWJDdXJzb3JJbmZvIHsKIAogICAgIGV4cGxp Y2l0IFdlYkN1cnNvckluZm8oVHlwZSB0eXBlID0gVHlwZVBvaW50ZXIpCiAgICAgICAgIDogdHlw ZSh0eXBlKQorICAgICAgICAsIGltYWdlU2NhbGVGYWN0b3IoMSkKICAgICB7CiAjaWZkZWYgV0lO MzIKICAgICAgICAgZXh0ZXJuYWxIYW5kbGUgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViQ3Vyc29ySW5mby5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJDdXJzb3JJbmZvLmNwcAppbmRleCA2MGJlNWRiY2FmMTBmMDEwYWEyNjgzZDdlYWU2 YTliNzM0MDA3ZGE3Li5hODkxODdjMjE4Y2NjNjdmYzJiYTE5MTc4NWNkODQ0MDNmZGRhYjQ2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDdXJzb3JJbmZvLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDdXJzb3JJbmZvLmNwcApAQCAtNDEs NiArNDEsNyBAQCBXZWJDdXJzb3JJbmZvOjpXZWJDdXJzb3JJbmZvKGNvbnN0IEN1cnNvciYgY3Vy c29yKQogewogICAgIHR5cGUgPSBzdGF0aWNfY2FzdDxUeXBlPihjdXJzb3IudHlwZSgpKTsKICAg ICBob3RTcG90ID0gY3Vyc29yLmhvdFNwb3QoKTsKKyAgICBpbWFnZVNjYWxlRmFjdG9yID0gMTsK ICAgICBjdXN0b21JbWFnZSA9IGN1cnNvci5pbWFnZSgpOwogI2lmZGVmIFdJTjMyCiAgICAgZXh0 ZXJuYWxIYW5kbGUgPSAwOwo= 174849 2012-11-18 09:22:12 -0800 2012-11-18 10:47:04 -0800 Patch bug-102612-20121118122004.patch text/plain 2354 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhhY2VhZGI5OThmYjE1NjVjMWRmYWI3NDdhNjVkMThhMzRhNGJhNTYuLjMzMDU3OTE5YmJhMWRl MTk0MzQ4ODdjMjZkNGQzNGM2NWM3MTcyNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTEtMTggIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRkIFdlYkN1cnNvckluZm86OmltYWdlU2NhbGVG YWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjYxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBjdXJzb3IgaW1hZ2Ugc2NhbGUgZmFjdG9yIChjdXJyZW50bHkgYWx3YXlzIDEpIHRvIGNocm9t aXVtIEFQSSwgaW4gcHJlcGFyYXRpb24gZm9yCisgICAgICAgIGhpZ2gtZHBpIGN1cnNvciBzdXBw b3J0IGluIGJ1ZyA5OTQ5My4KKworICAgICAgICAqIHB1YmxpYy9XZWJDdXJzb3JJbmZvLmg6Cisg ICAgICAgIChXZWJLaXQ6OldlYkN1cnNvckluZm86OldlYkN1cnNvckluZm8pOgorICAgICAgICAq IHNyYy9XZWJDdXJzb3JJbmZvLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ3Vyc29ySW5mbzo6 V2ViQ3Vyc29ySW5mbyk6CisKIDIwMTItMTEtMTcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmll dy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkN1cnNvckluZm8uaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkN1cnNvckluZm8uaAppbmRleCBjYzhi YzU5YmQxZTAwZDgwNjcyNmU0YWI2MmVhZjk4ZTk0MDBkOGI5Li4yOTgyYjZjNTMzMTQ4NmE5OTI2 YTc1ZDJkMjkwYmUzYTcyMTBlOGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJDdXJzb3JJbmZvLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViQ3Vyc29ySW5mby5oCkBAIC05NSw2ICs5NSw3IEBAIHN0cnVjdCBXZWJDdXJzb3JJbmZv IHsKIAogICAgIFR5cGUgdHlwZTsKICAgICBXZWJQb2ludCBob3RTcG90OworICAgIGZsb2F0IGlt YWdlU2NhbGVGYWN0b3I7CiAgICAgV2ViSW1hZ2UgY3VzdG9tSW1hZ2U7CiAKICNpZmRlZiBXSU4z MgpAQCAtMTA3LDYgKzEwOCw3IEBAIHN0cnVjdCBXZWJDdXJzb3JJbmZvIHsKIAogICAgIGV4cGxp Y2l0IFdlYkN1cnNvckluZm8oVHlwZSB0eXBlID0gVHlwZVBvaW50ZXIpCiAgICAgICAgIDogdHlw ZSh0eXBlKQorICAgICAgICAsIGltYWdlU2NhbGVGYWN0b3IoMSkKICAgICB7CiAjaWZkZWYgV0lO MzIKICAgICAgICAgZXh0ZXJuYWxIYW5kbGUgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViQ3Vyc29ySW5mby5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJDdXJzb3JJbmZvLmNwcAppbmRleCA2MGJlNWRiY2FmMTBmMDEwYWEyNjgzZDdlYWU2 YTliNzM0MDA3ZGE3Li4wOTgxZTQ2NjU3YTNhNjQ2OWUwN2I0NjI2MGM0Nzg0NTFlYTNkMGEyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDdXJzb3JJbmZvLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDdXJzb3JJbmZvLmNwcApAQCAtMzgs MTMgKzM4LDE0IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogbmFtZXNwYWNlIFdlYktpdCB7 CiAKIFdlYkN1cnNvckluZm86OldlYkN1cnNvckluZm8oY29uc3QgQ3Vyc29yJiBjdXJzb3IpCi17 Ci0gICAgdHlwZSA9IHN0YXRpY19jYXN0PFR5cGU+KGN1cnNvci50eXBlKCkpOwotICAgIGhvdFNw b3QgPSBjdXJzb3IuaG90U3BvdCgpOwotICAgIGN1c3RvbUltYWdlID0gY3Vyc29yLmltYWdlKCk7 CisgICAgOiB0eXBlKHN0YXRpY19jYXN0PFR5cGU+KGN1cnNvci50eXBlKCkpKQorICAgICwgaG90 U3BvdChjdXJzb3IuaG90U3BvdCgpKQorICAgICwgaW1hZ2VTY2FsZUZhY3RvcigxKQorICAgICwg Y3VzdG9tSW1hZ2UoY3Vyc29yLmltYWdlKCkpCiAjaWZkZWYgV0lOMzIKLSAgICBleHRlcm5hbEhh bmRsZSA9IDA7CisgICAgLCBleHRlcm5hbEhhbmRsZSgwKQogI2VuZGlmCit7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYktpdAo=