102609 2012-11-17 22:35:55 -0800 Don't say there are dirty overlay scrollbars when they are clipped out 2012-11-17 23:11:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin eric simon.fraser webkit.review.bot oldest_to_newest 770082 0 simon.fraser 2012-11-17 22:35:55 -0800 We should detect when the overlay scrollbars are clipped out, and not do a second paint pass in that case. 770085 1 174842 simon.fraser 2012-11-17 22:42:17 -0800 Created attachment 174842 Patch 770086 2 simon.fraser 2012-11-17 22:46:09 -0800 <rdar://problem/12725623> 770090 3 174842 beidson 2012-11-17 22:58:22 -0800 Comment on attachment 174842 Patch Seems reasonable. 770092 4 simon.fraser 2012-11-17 23:11:18 -0800 http://trac.webkit.org/changeset/135064 174842 2012-11-17 22:42:17 -0800 2012-11-17 22:58:22 -0800 Patch bug-102609-20121117224010.patch text/plain 6971 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNhZTMyYWU0ODY0MjJk YjQxNzQ4YTllY2I3NDM0NzBiMmYxYTY1YS4uYjRkYWM3YWYzY2FmNTdjMzgxNjBiZWNkNGQyZGFm ZGU2OWI4YTNmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTExLTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIERvbid0IHNheSB0 aGVyZSBhcmUgZGlydHkgb3ZlcmxheSBzY3JvbGxiYXJzIHdoZW4gdGhleSBhcmUgY2xpcHBlZCBv dXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjYw OQorCisgICAgICAgIFBhaW50aW5nIG92ZXJsYXkgc2Nyb2xsYmFycyBpbnZvbHZlcyBhIHNlY29u ZCBwYWludGluZyBwYXNzIG92ZXIgdGhlIGVudGlyZQorICAgICAgICBSZW5kZXJMYXllciBzdWJ0 cmVlIGZvciBhIGNvbXBvc2l0aW5nIGxheWVyLCB3aGljaCBjYW4gYmUgdmVyeSBleHBlbnNpdmUu CisgICAgICAgIAorICAgICAgICBBdm9pZCB0aGlzIHdoZW4gcG9zc2libGUgYnkgZGV0ZWN0aW5n IHdoZW4gb3ZlcmZsb3cgY29udHJvbHMgYXJlIG5vdCBpbgorICAgICAgICB0aGUgZGFtYWdlIHJl Y3QuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyTGF5ZXI6OnJlY3RGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKTogQ29tcHV0ZSBh IGxvY2FsIHJlY3QKKyAgICAgICAgZm9yIHRoZSBob3Jpem9udGFsIHNjcm9sbGJhci4KKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpyZWN0Rm9yVmVydGljYWxTY3JvbGxiYXIpOiBDb21w dXRlIGEgbG9jYWwgcmVjdAorICAgICAgICBmb3IgdGhlIHZlcnRpY2FsIHNjcm9sbGJhci4KKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpwb3NpdGlvbk92ZXJmbG93Q29udHJvbHMpOiBV c2UgcmVjdEZvckhvcml6b250YWxTY3JvbGxiYXIoKQorICAgICAgICBhbmQgcmVjdEZvclZlcnRp Y2FsU2Nyb2xsYmFyKCkuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6b3ZlcmZsb3dD b250cm9sc0ludGVyc2VjdFJlY3QpOiBSZXR1cm4gdHJ1ZSBpZiBhbnkKKyAgICAgICAgb2YgdGhl IHByZXNlbnQgb3ZlcmZsb3cgY29udHJvbHMgaW50ZXJzZWN0IHRoZSBnaXZlbiBsb2NhbCByZWN0 LgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnBhaW50T3ZlcmZsb3dDb250cm9scyk6 IEJhaWwgaWYgdGhlIGRhbWFnZSByZWN0CisgICAgICAgIGRvZXNuJ3QgaW50ZXJzZWN0IGFueSBv ZiB0aGUgb3ZlcmZsb3cgY29udHJvbHMuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVy Lmg6CisgICAgICAgIChSZW5kZXJMYXllcik6CisKKzIwMTItMTEtMTcgIFNpbW9uIEZyYXNlciAg PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgUmVkdWNlIHRoZSBjcmF6eSBudW1i ZXIgb2YgcGFyYW1ldGVycyB0byBSZW5kZXJMYXllciBjbGlwLXJlY3QgZnVuY3Rpb25zCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2MDQKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKaW5kZXggMWUzMzY1NmFlNGY0Mzc0 ODU5NDk1ZjE0MWYyYzg0MjUyYjY0ZjNjNS4uNWIyOGEyZDJmZTg3NmUyNjRiMmNjN2ZlY2NjMDZl OWZkZmI3M2EzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBA IC0yMjczLDYgKzIyNzMsMzQgQEAgSW50UG9pbnQgUmVuZGVyTGF5ZXI6OmN1cnJlbnRNb3VzZVBv c2l0aW9uKCkgY29uc3QKICAgICByZXR1cm4gcmVuZGVyZXIoKS0+ZnJhbWUoKSA/IHJlbmRlcmVy KCktPmZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5jdXJyZW50TW91c2VQb3NpdGlvbigpIDogSW50 UG9pbnQoKTsKIH0KIAorSW50UmVjdCBSZW5kZXJMYXllcjo6cmVjdEZvckhvcml6b250YWxTY3Jv bGxiYXIoY29uc3QgSW50UmVjdCYgYm9yZGVyQm94UmVjdCkgY29uc3QKK3sKKyAgICBpZiAoIW1f aEJhcikKKyAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKKworICAgIGNvbnN0IFJlbmRlckJveCog Ym94ID0gcmVuZGVyQm94KCk7CisgICAgY29uc3QgSW50UmVjdCYgc2Nyb2xsQ29ybmVyID0gc2Ny b2xsQ29ybmVyUmVjdCgpOworCisgICAgcmV0dXJuIEludFJlY3QoaG9yaXpvbnRhbFNjcm9sbGJh clN0YXJ0KGJvcmRlckJveFJlY3QueCgpKSwKKyAgICAgICAgYm9yZGVyQm94UmVjdC5tYXhZKCkg LSBib3gtPmJvcmRlckJvdHRvbSgpIC0gbV9oQmFyLT5oZWlnaHQoKSwKKyAgICAgICAgYm9yZGVy Qm94UmVjdC53aWR0aCgpIC0gKGJveC0+Ym9yZGVyTGVmdCgpICsgYm94LT5ib3JkZXJSaWdodCgp KSAtIHNjcm9sbENvcm5lci53aWR0aCgpLAorICAgICAgICBtX2hCYXItPmhlaWdodCgpKTsKK30K KworSW50UmVjdCBSZW5kZXJMYXllcjo6cmVjdEZvclZlcnRpY2FsU2Nyb2xsYmFyKGNvbnN0IElu dFJlY3QmIGJvcmRlckJveFJlY3QpIGNvbnN0Cit7CisgICAgaWYgKCFtX3ZCYXIpCisgICAgICAg IHJldHVybiBJbnRSZWN0KCk7CisKKyAgICBjb25zdCBSZW5kZXJCb3gqIGJveCA9IHJlbmRlckJv eCgpOworICAgIGNvbnN0IEludFJlY3QmIHNjcm9sbENvcm5lciA9IHNjcm9sbENvcm5lclJlY3Qo KTsKKworICAgIHJldHVybiBJbnRSZWN0KHZlcnRpY2FsU2Nyb2xsYmFyU3RhcnQoYm9yZGVyQm94 UmVjdC54KCksIGJvcmRlckJveFJlY3QubWF4WCgpKSwKKyAgICAgICAgYm9yZGVyQm94UmVjdC55 KCkgKyBib3gtPmJvcmRlclRvcCgpLAorICAgICAgICBtX3ZCYXItPndpZHRoKCksCisgICAgICAg IGJvcmRlckJveFJlY3QuaGVpZ2h0KCkgLSAoYm94LT5ib3JkZXJUb3AoKSArIGJveC0+Ym9yZGVy Qm90dG9tKCkpIC0gc2Nyb2xsQ29ybmVyLmhlaWdodCgpKTsKK30KKwogTGF5b3V0VW5pdCBSZW5k ZXJMYXllcjo6dmVydGljYWxTY3JvbGxiYXJTdGFydChpbnQgbWluWCwgaW50IG1heFgpIGNvbnN0 CiB7CiAgICAgY29uc3QgUmVuZGVyQm94KiBib3ggPSByZW5kZXJCb3goKTsKQEAgLTI0OTUsMTgg KzI1MjMsMTggQEAgdm9pZCBSZW5kZXJMYXllcjo6cG9zaXRpb25PdmVyZmxvd0NvbnRyb2xzKGNv bnN0IEludFNpemUmIG9mZnNldEZyb21Sb290KQogICAgIGNvbnN0IEludFJlY3QgYm9yZGVyQm94 ID0gYm94LT5waXhlbFNuYXBwZWRCb3JkZXJCb3hSZWN0KCk7CiAgICAgY29uc3QgSW50UmVjdCYg c2Nyb2xsQ29ybmVyID0gc2Nyb2xsQ29ybmVyUmVjdCgpOwogICAgIEludFJlY3QgYWJzQm91bmRz KGJvcmRlckJveC5sb2NhdGlvbigpICsgb2Zmc2V0RnJvbVJvb3QsIGJvcmRlckJveC5zaXplKCkp OwotICAgIGlmIChtX3ZCYXIpCi0gICAgICAgIG1fdkJhci0+c2V0RnJhbWVSZWN0KEludFJlY3Qo dmVydGljYWxTY3JvbGxiYXJTdGFydChhYnNCb3VuZHMueCgpLCBhYnNCb3VuZHMubWF4WCgpKSwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhYnNCb3VuZHMueSgpICsgYm94 LT5ib3JkZXJUb3AoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX3ZC YXItPndpZHRoKCksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWJzQm91 bmRzLmhlaWdodCgpIC0gKGJveC0+Ym9yZGVyVG9wKCkgKyBib3gtPmJvcmRlckJvdHRvbSgpKSAt IHNjcm9sbENvcm5lci5oZWlnaHQoKSkpOwotCi0gICAgaWYgKG1faEJhcikKLSAgICAgICAgbV9o QmFyLT5zZXRGcmFtZVJlY3QoSW50UmVjdChob3Jpem9udGFsU2Nyb2xsYmFyU3RhcnQoYWJzQm91 bmRzLngoKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWJzQm91bmRz Lm1heFkoKSAtIGJveC0+Ym9yZGVyQm90dG9tKCkgLSBtX2hCYXItPmhlaWdodCgpLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFic0JvdW5kcy53aWR0aCgpIC0gKGJveC0+ Ym9yZGVyTGVmdCgpICsgYm94LT5ib3JkZXJSaWdodCgpKSAtIHNjcm9sbENvcm5lci53aWR0aCgp LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1faEJhci0+aGVpZ2h0KCkp KTsKLQorICAgIGlmIChtX3ZCYXIpIHsKKyAgICAgICAgSW50UmVjdCB2QmFyUmVjdCA9IHJlY3RG b3JWZXJ0aWNhbFNjcm9sbGJhcihib3JkZXJCb3gpOworICAgICAgICB2QmFyUmVjdC5tb3ZlKG9m ZnNldEZyb21Sb290KTsKKyAgICAgICAgbV92QmFyLT5zZXRGcmFtZVJlY3QodkJhclJlY3QpOwor ICAgIH0KKyAgICAKKyAgICBpZiAobV9oQmFyKSB7CisgICAgICAgIEludFJlY3QgaEJhclJlY3Qg PSByZWN0Rm9ySG9yaXpvbnRhbFNjcm9sbGJhcihib3JkZXJCb3gpOworICAgICAgICBoQmFyUmVj dC5tb3ZlKG9mZnNldEZyb21Sb290KTsKKyAgICAgICAgbV9oQmFyLT5zZXRGcmFtZVJlY3QoaEJh clJlY3QpOworICAgIH0KKyAgICAKICAgICBpZiAobV9zY3JvbGxDb3JuZXIpCiAgICAgICAgIG1f c2Nyb2xsQ29ybmVyLT5zZXRGcmFtZVJlY3Qoc2Nyb2xsQ29ybmVyKTsKICAgICBpZiAobV9yZXNp emVyKQpAQCAtMjY5Nyw2ICsyNzI1LDI1IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9s bEluZm9BZnRlckxheW91dCgpCiAjZW5kaWYKIH0KIAorYm9vbCBSZW5kZXJMYXllcjo6b3ZlcmZs b3dDb250cm9sc0ludGVyc2VjdFJlY3QoY29uc3QgSW50UmVjdCYgbG9jYWxSZWN0KQoreworICAg IGNvbnN0IEludFJlY3QgYm9yZGVyQm94ID0gcmVuZGVyQm94KCktPnBpeGVsU25hcHBlZEJvcmRl ckJveFJlY3QoKTsKKworICAgIGlmIChyZWN0Rm9ySG9yaXpvbnRhbFNjcm9sbGJhcihib3JkZXJC b3gpLmludGVyc2VjdHMobG9jYWxSZWN0KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBp ZiAocmVjdEZvclZlcnRpY2FsU2Nyb2xsYmFyKGJvcmRlckJveCkuaW50ZXJzZWN0cyhsb2NhbFJl Y3QpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGlmIChzY3JvbGxDb3JuZXJSZWN0KCku aW50ZXJzZWN0cyhsb2NhbFJlY3QpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAKKyAgICBp ZiAocmVzaXplckNvcm5lclJlY3QodGhpcywgYm9yZGVyQm94KS5pbnRlcnNlY3RzKGxvY2FsUmVj dCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lk IFJlbmRlckxheWVyOjpwYWludE92ZXJmbG93Q29udHJvbHMoR3JhcGhpY3NDb250ZXh0KiBjb250 ZXh0LCBjb25zdCBJbnRQb2ludCYgcGFpbnRPZmZzZXQsIGNvbnN0IEludFJlY3QmIGRhbWFnZVJl Y3QsIGJvb2wgcGFpbnRpbmdPdmVybGF5Q29udHJvbHMpCiB7CiAgICAgLy8gRG9uJ3QgZG8gYW55 dGhpbmcgaWYgd2UgaGF2ZSBubyBvdmVyZmxvdy4KQEAgLTI3MTYsNiArMjc2MywxMSBAQCB2b2lk IFJlbmRlckxheWVyOjpwYWludE92ZXJmbG93Q29udHJvbHMoR3JhcGhpY3NDb250ZXh0KiBjb250 ZXh0LCBjb25zdCBJbnRQb2ludAogICAgICAgICBpZiAoKG1faEJhciAmJiBsYXllckZvckhvcml6 b250YWxTY3JvbGxiYXIoKSkgfHwgKG1fdkJhciAmJiBsYXllckZvclZlcnRpY2FsU2Nyb2xsYmFy KCkpKQogICAgICAgICAgICAgcmV0dXJuOwogI2VuZGlmCisgICAgICAgIEludFJlY3QgbG9jYWxE YW1nZVJlY3QgPSBkYW1hZ2VSZWN0OworICAgICAgICBsb2NhbERhbWdlUmVjdC5tb3ZlQnkoLXBh aW50T2Zmc2V0KTsKKyAgICAgICAgaWYgKCFvdmVyZmxvd0NvbnRyb2xzSW50ZXJzZWN0UmVjdChs b2NhbERhbWdlUmVjdCkpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgUmVuZGVyVmll dyogcmVuZGVyVmlldyA9IHJlbmRlcmVyKCktPnZpZXcoKTsKIAogICAgICAgICBSZW5kZXJMYXll ciogcGFpbnRpbmdSb290ID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgK aW5kZXggY2VlMGU2ZWRhMGZmMWVlYTQ3M2I3M2MyMDMwOWNlMzFhYjAxNTljYi4uMjFlZmQ4Y2Y0 ZDY1MjY0ZTM5MzFkMzhkMDkzNjIzYmFmOWQ1MWIxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmgKQEAgLTkzMCw5ICs5MzAsMTQgQEAgcHJpdmF0ZToKICAgICBMYXlvdXRV bml0IG92ZXJmbG93TGVmdCgpIGNvbnN0OwogICAgIExheW91dFVuaXQgb3ZlcmZsb3dSaWdodCgp IGNvbnN0OwogCisgICAgSW50UmVjdCByZWN0Rm9ySG9yaXpvbnRhbFNjcm9sbGJhcihjb25zdCBJ bnRSZWN0JiBib3JkZXJCb3hSZWN0KSBjb25zdDsKKyAgICBJbnRSZWN0IHJlY3RGb3JWZXJ0aWNh bFNjcm9sbGJhcihjb25zdCBJbnRSZWN0JiBib3JkZXJCb3hSZWN0KSBjb25zdDsKKwogICAgIExh eW91dFVuaXQgdmVydGljYWxTY3JvbGxiYXJTdGFydChpbnQgbWluWCwgaW50IG1heFgpIGNvbnN0 OwogICAgIExheW91dFVuaXQgaG9yaXpvbnRhbFNjcm9sbGJhclN0YXJ0KGludCBtaW5YKSBjb25z dDsKIAorICAgIGJvb2wgb3ZlcmZsb3dDb250cm9sc0ludGVyc2VjdFJlY3QoY29uc3QgSW50UmVj dCYgbG9jYWxSZWN0KTsKKwogcHJvdGVjdGVkOgogICAgIC8vIFRoZSBiaXRmaWVsZHMgYXJlIHVw IGhlcmUgc28gdGhleSB3aWxsIGZhbGwgaW50byB0aGUgcGFkZGluZyBmcm9tIFNjcm9sbGFibGVB cmVhIG9uIDY0LWJpdC4KIAo=