102606 2012-11-17 22:24:20 -0800 Simulated mouse events should return an accurate offset. 2012-11-18 00:04:36 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 98318 1 jonlee jonlee andersca ap beidson mitz sam webkit-bug-importer oldest_to_newest 770079 0 jonlee 2012-11-17 22:24:20 -0800 The offset returned by simulated mouse events is the same as the page event because we skip recalculation of the offset for simulated events. The check for this bit has been in the code since the KDE days, I believe. I think this check should be removed because that offset is now calculated from scratch and cached, whereas back in those days the offset was assigned directly to the event instance, and therefore it was inappropriate to make additional adjustments to the value. See changelist 14916: http://trac.webkit.org/changeset/14916 770087 1 jonlee 2012-11-17 22:49:42 -0800 <rdar://problem/12725627> 770089 2 174843 jonlee 2012-11-17 22:58:00 -0800 Created attachment 174843 Patch 770091 3 174843 beidson 2012-11-17 23:08:01 -0800 Comment on attachment 174843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review > Source/WebCore/ChangeLog:10 > + Remove an old check to avoid adjusting the offset location, because we now recalculate the > + offset from scratch and cache it. It took me awhile to realize what you meant here. I thought you were implying that this change also made us cache the offset. Maybe clarify something like: "Originally we did the isSimulated check. Then sometime later, we started caching the offset. I realized that caching the offset made the isSimulated check irrelevant, so lets remove it" 770094 4 jonlee 2012-11-17 23:50:00 -0800 (In reply to comment #3) > (From update of attachment 174843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174843&action=review > > > Source/WebCore/ChangeLog:10 > > + Remove an old check to avoid adjusting the offset location, because we now recalculate the > > + offset from scratch and cache it. > > It took me awhile to realize what you meant here. I thought you were implying that this change also made us cache the offset. > > Maybe clarify something like: > "Originally we did the isSimulated check. Then sometime later, we started caching the offset. I realized that caching the offset made the isSimulated check irrelevant, so lets remove it" Yes, this needs better explanation. i will clarify in the submitted changelog. 770096 5 jonlee 2012-11-18 00:04:36 -0800 Committed r135065: <http://trac.webkit.org/changeset/135065> 174843 2012-11-17 22:58:00 -0800 2012-11-17 23:08:01 -0800 Patch bug-102606-20121117225553.patch text/plain 2492 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ1YTY4ZDgxZjJiMzRi YWU2N2RhYjRjODNhMDE0ZDRiZjlhZmZiOS4uYmI5MjZhNWEzN2ZjNWU1MTZmYTE3OGZhOGIwMmIx YTY0ODFiNzQ3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE3ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBTaW11bGF0ZWQgbW91c2UgZXZlbnRz IHNob3VsZCByZXR1cm4gYW4gYWNjdXJhdGUgb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2MDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzEyNzI1NjI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZSBhbiBvbGQgY2hlY2sgdG8gYXZvaWQgYWRqdXN0aW5nIHRoZSBvZmZzZXQgbG9j YXRpb24sIGJlY2F1c2Ugd2Ugbm93IHJlY2FsY3VsYXRlIHRoZQorICAgICAgICBvZmZzZXQgZnJv bSBzY3JhdGNoIGFuZCBjYWNoZSBpdC4KKworICAgICAgICBUZXN0cyBhcmUgbm90IHBvc3NpYmxl IGJlY2F1c2UgYWxsIHVzZXMgb2Ygc2ltdWxhdGVkIG1vdXNlIGV2ZW50cyBwcm92aWRlIG5vIHVu ZGVybHlpbmcKKyAgICAgICAgZXZlbnQsIHNvIHRoZSBvZmZzZXQgaXMgbmV2ZXIgcmVjYWxjdWxh dGVkLgorCisgICAgICAgICogZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1vdXNlUmVsYXRlZEV2ZW50Ojpjb21wdXRlUmVsYXRpdmVQb3NpdGlvbik6IFJlbW92 ZSB0aGUgbV9pc1NpbXVsYXRlZCBjaGVjay4KKwogMjAxMi0xMS0xNyAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1NvdXBdIENyZWRlbnRpYWxTdG9y YWdlIHNob3VsZCBvbmx5IGJlIHVzZWQgZm9yIEhUVFAtZmFtaWx5IHJlcXVlc3RzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2ZW50LmNwcAppbmRleCA3ZDQwZjVkMDY4NTA1NWYyN2Iz ZmEwODJlZDYxMWM3ZDY2ZTU2MzQ1Li44MDFhYTY3MWQxYzc4ODgyMTExMDdkYmQxYzA2NTllYjEz MzRlNGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZVJlbGF0ZWRFdmVudC5jcHAKQEAgLTE2 NCwxNCArMTY0LDEyIEBAIHZvaWQgTW91c2VSZWxhdGVkRXZlbnQ6OmNvbXB1dGVSZWxhdGl2ZVBv c2l0aW9uKCkKICAgICB0YXJnZXROb2RlLT5kb2N1bWVudCgpLT51cGRhdGVTdHlsZUlmTmVlZGVk KCk7CiAKICAgICAvLyBBZGp1c3Qgb2Zmc2V0TG9jYXRpb24gdG8gYmUgcmVsYXRpdmUgdG8gdGhl IHRhcmdldCdzIHBvc2l0aW9uLgotICAgIGlmICghaXNTaW11bGF0ZWQoKSkgewotICAgICAgICBp ZiAoUmVuZGVyT2JqZWN0KiByID0gdGFyZ2V0Tm9kZS0+cmVuZGVyZXIoKSkgewotICAgICAgICAg ICAgRmxvYXRQb2ludCBsb2NhbFBvcyA9IHItPmFic29sdXRlVG9Mb2NhbChhYnNvbHV0ZUxvY2F0 aW9uKCksIFVzZVRyYW5zZm9ybXMgfCBTbmFwT2Zmc2V0Rm9yVHJhbnNmb3Jtcyk7Ci0gICAgICAg ICAgICBtX29mZnNldExvY2F0aW9uID0gcm91bmRlZExheW91dFBvaW50KGxvY2FsUG9zKTsKLSAg ICAgICAgICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gMSAvIChwYWdlWm9vbUZhY3Rvcih0aGlzKSAq IGZyYW1lU2NhbGVGYWN0b3IodGhpcykpOwotICAgICAgICAgICAgaWYgKHNjYWxlRmFjdG9yICE9 IDEuMGYpCi0gICAgICAgICAgICAgICAgbV9vZmZzZXRMb2NhdGlvbi5zY2FsZShzY2FsZUZhY3Rv ciwgc2NhbGVGYWN0b3IpOwotICAgICAgICB9CisgICAgaWYgKFJlbmRlck9iamVjdCogciA9IHRh cmdldE5vZGUtPnJlbmRlcmVyKCkpIHsKKyAgICAgICAgRmxvYXRQb2ludCBsb2NhbFBvcyA9IHIt PmFic29sdXRlVG9Mb2NhbChhYnNvbHV0ZUxvY2F0aW9uKCksIFVzZVRyYW5zZm9ybXMgfCBTbmFw T2Zmc2V0Rm9yVHJhbnNmb3Jtcyk7CisgICAgICAgIG1fb2Zmc2V0TG9jYXRpb24gPSByb3VuZGVk TGF5b3V0UG9pbnQobG9jYWxQb3MpOworICAgICAgICBmbG9hdCBzY2FsZUZhY3RvciA9IDEgLyAo cGFnZVpvb21GYWN0b3IodGhpcykgKiBmcmFtZVNjYWxlRmFjdG9yKHRoaXMpKTsKKyAgICAgICAg aWYgKHNjYWxlRmFjdG9yICE9IDEuMGYpCisgICAgICAgICAgICBtX29mZnNldExvY2F0aW9uLnNj YWxlKHNjYWxlRmFjdG9yLCBzY2FsZUZhY3Rvcik7CiAgICAgfQogCiAgICAgLy8gQWRqdXN0IGxh eWVyTG9jYXRpb24gdG8gYmUgcmVsYXRpdmUgdG8gdGhlIGxheWVyLgo=