102597 2012-11-17 14:05:45 -0800 Simplify bounds computation for the RenderView's layer 2012-11-23 09:13:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser andersca bdakin eric simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 770006 0 simon.fraser 2012-11-17 14:05:45 -0800 The RenderView's layer should just be the size of the FrameView contents. Right now, we traverse the entire layer tree to compute its bounds, which is crazy. We also end up applying any page scale, which makes this layer larger than necessary. 770037 1 174834 simon.fraser 2012-11-17 17:03:49 -0800 Created attachment 174834 Patch 770088 2 simon.fraser 2012-11-17 22:49:59 -0800 <rdar://problem/12725628> 774608 3 simon.fraser 2012-11-23 09:13:35 -0800 http://trac.webkit.org/changeset/135059 174834 2012-11-17 17:03:49 -0800 2012-11-17 17:04:55 -0800 Patch bug-102597-20121117170143.patch text/plain 5150 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGEwNjZmYjMxZjkxYmVj MTY5NjY5NjVjY2UyNzJjMjE0ODA0YmJkMC4uYWZlZGMzMDNkNjliYmMxODBiZDljZDM3ZGI5NmQz MGE2NzFhM2Y2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTExLTE3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFNpbXBsaWZ5IGJv dW5kcyBjb21wdXRhdGlvbiBmb3IgdGhlIFJlbmRlclZpZXcncyBsYXllcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcHV0aW5nIHRoZSBib3VuZHMg b2YgdGhlIG1haW4gbGF5ZXIgKHRoYXQgb2YgdGhlIFJlbmRlclZpZXcpIHVzZWQgdG8gZG8KKyAg ICAgICAgYSBmdWxsIFJlbmRlckxheWVyIHdhbGssIHRha2luZyB0aGUgdW5pb24gb2YgdGhlIGJv dW5kcyBvZiBhbGwgdGhlIHN1YmxheWVycywKKyAgICAgICAgd2hpY2ggaXMgdmVyeSBleHBlbnNp dmUgb24gbGFyZ2UgcGFnZXMuCisgICAgICAgIAorICAgICAgICBGb3IgdGhlIFJlbmRlclZpZXcg d2UgY2FuIGF2b2lkIHRoYXQgZW50aXJlbHkgYW5kIGp1c3QgdXNlIHRoZSBSZW5kZXJWaWV3J3MK KyAgICAgICAgZG9jdW1lbnQgcmVjdC4gU2luY2UgcGFnZSBzY2FsaW5nIGhhcHBlbnMgYXMgYSB0 cmFuc2Zvcm0gb24gdGhpcyBsYXllciwKKyAgICAgICAgd2Ugd2FudCB0aGUgdW5zY2FsZWQgZG9j dW1lbnQgcmVjdC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZHMpOgorCisyMDEy LTExLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAg IER1bXAgdGhlIHRpbGUgY2FjaGUgZXh0ZW50IGluIGxheW91dCB0ZXN0cwogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjAwCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDJjNjQ3NjA3ODUzM2MwNjViZTY3NTIw ZDc0NzJkYjk3MTg0NTRjNzUuLmIxMmFmZTM1NjQ3ZjdmOTU3YzVjZTMzZDA2N2ZiMTQ1ODU3ZWNl ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtNDQyMyw3 ICs0NDIzLDE0IEBAIEludFJlY3QgUmVuZGVyTGF5ZXI6OmNhbGN1bGF0ZUxheWVyQm91bmRzKGNv bnN0IFJlbmRlckxheWVyKiBhbmNlc3RvckxheWVyLCBjb25zCiAgICAgICAgIHJldHVybiBJbnRS ZWN0KCk7CiAKICAgICBSZW5kZXJMYXllck1vZGVsT2JqZWN0KiByZW5kZXJlciA9IHRoaXMtPnJl bmRlcmVyKCk7CisKKyAgICBpZiAoaXNSb290TGF5ZXIoKSkgeworICAgICAgICAvLyBUaGUgcm9v dCBsYXllciBpcyBhbHdheXMganVzdCB0aGUgc2l6ZSBvZiB0aGUgZG9jdW1lbnQuCisgICAgICAg IHJldHVybiByZW5kZXJlci0+dmlldygpLT51bnNjYWxlZERvY3VtZW50UmVjdCgpOworICAgIH0K KwogICAgIExheW91dFJlY3QgYm91bmRpbmdCb3hSZWN0ID0gbG9jYWxCb3VuZGluZ0JveCgpOwor CiAgICAgaWYgKHJlbmRlcmVyLT5pc0JveCgpKQogICAgICAgICB0b1JlbmRlckJveChyZW5kZXJl ciktPmZsaXBGb3JXcml0aW5nTW9kZShib3VuZGluZ0JveFJlY3QpOwogICAgIGVsc2UKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBkMDIzNTY2YzllZWVjMDlkY2YzZWZmMmFiMjA0NTAyMmNhYTVjOGNiLi4zNjcwZTVkZjQxZDcy MTI4NTI5YjM3ODMzYTM0ZjI1ZmE1MzJlNjA4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTIt MTEtMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAg U2ltcGxpZnkgYm91bmRzIGNvbXB1dGF0aW9uIGZvciB0aGUgUmVuZGVyVmlldydzIGxheWVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI1OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9ncmVzc2lv bnMgYXMgYSByZXN1bHQgb2YgdGhpcyBjaGFuZ2U6CisKKyAgICAgICAgKiBjb21wb3NpdGluZy9s YXllci1jcmVhdGlvbi9maXhlZC1wb3NpdGlvbi1vdXQtb2Ytdmlldy1leHBlY3RlZC50eHQ6IFRo ZSBoZWlnaHQKKyAgICAgICAgaXMgbm93IHRoZSBwYWdlIGhlaWdodCwgc2luY2UgdGhlIHBhZ2Ug aXMgc2Nyb2xsYWJsZS4KKyAgICAgICAgKiBjb21wb3NpdGluZy90aWxpbmcvdGlsZS1jYWNoZS16 b29tZWQtZXhwZWN0ZWQudHh0OiBUaGUgbWFpbiBsYXllciBub3cgaXMgbm90CisgICAgICAgIGFm ZmVjdGVkIGJ5IHRoZSBwYWdlIHNjYWxlIHRyYW5zZm9ybS4KKyAgICAgICAgKiBwbGF0Zm9ybS9t YWMvY29tcG9zaXRpbmcvdGlsaW5nL3RpbGUtY2FjaGUtem9vbWVkLWV4cGVjdGVkLnR4dDogRGl0 dG8uCisKKzIwMTItMTEtMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CisKICAgICAgICAgUmViYXNlbGluZSB0aHJlZSB0ZXN0cyBhZmZlY3RlZCBieSB0aGUgZHVtcGlu ZyBvZiB0aWxlIGdyaWQgZXh0ZW50LgogCiAgICAgICAgICogcGxhdGZvcm0vbWFjL2NvbXBvc2l0 aW5nL3RpbGluZy9yb3RhdGVkLXRpbGVkLWNsYW1wZWQtZXhwZWN0ZWQudHh0OgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vZml4ZWQtcG9zaXRpb24t b3V0LW9mLXZpZXctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvbGF5ZXIt Y3JlYXRpb24vZml4ZWQtcG9zaXRpb24tb3V0LW9mLXZpZXctZXhwZWN0ZWQudHh0CmluZGV4IDc1 OTJhNTIwMzFjYWNhOTI5OTM0NGNiYmE4OTM5ZDAwZGUzODY4ZjIuLmI1M2U3NGY2ZDRjOTQ5ZDY1 YmJhNTYxZDVlNDc0NjNiOWVlNWQzYWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0 aW5nL2xheWVyLWNyZWF0aW9uL2ZpeGVkLXBvc2l0aW9uLW91dC1vZi12aWV3LWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9sYXllci1jcmVhdGlvbi9maXhlZC1wb3Np dGlvbi1vdXQtb2Ytdmlldy1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw3IEBACiAgIChib3VuZHMg Nzg1LjAwIDEwMjEuMDApCiAgIChjaGlsZHJlbiAxCiAgICAgKEdyYXBoaWNzTGF5ZXIKLSAgICAg IChib3VuZHMgNzg1LjAwIDYwMC4wMCkKKyAgICAgIChib3VuZHMgNzg1LjAwIDEwMjEuMDApCiAg ICAgICAoY2hpbGRyZW4gMQogICAgICAgICAoR3JhcGhpY3NMYXllcgogICAgICAgICAgIChib3Vu ZHMgNzg1LjAwIDEwMjEuMDApCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy90 aWxpbmcvdGlsZS1jYWNoZS16b29tZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvdGlsaW5nL3RpbGUtY2FjaGUtem9vbWVkLWV4cGVjdGVkLnR4dAppbmRleCAwYjRlNjNm NzBiY2M1ZThiN2M2MzdjNjFiNDQ5MjZmYWZmZWYwMmRjLi4zMDUxYzk5ZTEyMzE5YjA5MjVkYjEw OGQzMTZiODJhNWZkNjk0YmI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy90 aWxpbmcvdGlsZS1jYWNoZS16b29tZWQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Nv bXBvc2l0aW5nL3RpbGluZy90aWxlLWNhY2hlLXpvb21lZC1leHBlY3RlZC50eHQKQEAgLTQsNyAr NCw3IEBACiAgIChjaGlsZHJlbiAxCiAgICAgKEdyYXBoaWNzTGF5ZXIKICAgICAgIChhbmNob3Ig MC4wMCAwLjAwKQotICAgICAgKGJvdW5kcyAzMDkyLjAwIDY2NDAuMDApCisgICAgICAoYm91bmRz IDEyMDguMDAgMjU5NC4wMCkKICAgICAgICh0cmFuc2Zvcm0gWzEuNjAgMC4wMCAwLjAwIDAuMDBd IFswLjAwIDEuNjAgMC4wMCAwLjAwXSBbMC4wMCAwLjAwIDEuMDAgMC4wMF0gWzAuMDAgMC4wMCAw LjAwIDEuMDBdKQogICAgICAgKHZpc2libGUgcmVjdCAwLjAwLCAwLjAwIDQ5MC42MyB4IDM2NS42 MykKICAgICAgIChjaGlsZHJlbiAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvY29tcG9zaXRpbmcvdGlsaW5nL3RpbGUtY2FjaGUtem9vbWVkLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9jb21wb3NpdGluZy90aWxpbmcvdGlsZS1jYWNoZS16b29t ZWQtZXhwZWN0ZWQudHh0CmluZGV4IGM1MmZjMjgxYzQ1OTRmMTEzYWM0ZTVmODYyOWY5NmY3NDJk ODhkYzUuLmVlZWFjMzE2ODc2NTgzMDY2N2Q2ZjcyYzc4YTJiYTE0ZTJmMTVmZmEgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9jb21wb3NpdGluZy90aWxpbmcvdGlsZS1jYWNo ZS16b29tZWQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9jb21w b3NpdGluZy90aWxpbmcvdGlsZS1jYWNoZS16b29tZWQtZXhwZWN0ZWQudHh0CkBAIC00LDcgKzQs NyBAQAogICAoY2hpbGRyZW4gMQogICAgIChHcmFwaGljc0xheWVyCiAgICAgICAoYW5jaG9yIDAu MDAgMC4wMCkKLSAgICAgIChib3VuZHMgMzA5MS4wMCA2NjQwLjAwKQorICAgICAgKGJvdW5kcyAx MjA4LjAwIDI1OTQuMDApCiAgICAgICAodHJhbnNmb3JtIFsxLjYwIDAuMDAgMC4wMCAwLjAwXSBb MC4wMCAxLjYwIDAuMDAgMC4wMF0gWzAuMDAgMC4wMCAxLjAwIDAuMDBdIFswLjAwIDAuMDAgMC4w MCAxLjAwXSkKICAgICAgICh2aXNpYmxlIHJlY3QgMC4wMCwgMC4wMCA0OTAuNjMgeCAzNjUuNjMp CiAgICAgICAoY2hpbGRyZW4gMQo=