102590 2012-11-17 08:36:39 -0800 Web Inspector: Remove unused ConsoleMessage constructor. 2012-11-18 21:41:22 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mkwst mkwst apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 769949 0 mkwst 2012-11-17 08:36:39 -0800 'ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& m, const String& responseUrl, unsigned long requestIdentifier)' is unused, so far as I can tell. 769950 1 174819 mkwst 2012-11-17 08:45:21 -0800 Created attachment 174819 Patch 769951 2 webkit.review.bot 2012-11-17 08:47:31 -0800 Attachment 174819 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 770169 3 174853 mkwst 2012-11-18 12:27:21 -0800 Created attachment 174853 Patch 770326 4 174853 bfulgham 2012-11-18 21:35:52 -0800 Comment on attachment 174853 Patch Yay! Dead code removal. R=me. 770330 5 174853 webkit.review.bot 2012-11-18 21:41:18 -0800 Comment on attachment 174853 Patch Clearing flags on attachment: 174853 Committed r135107: <http://trac.webkit.org/changeset/135107> 770331 6 webkit.review.bot 2012-11-18 21:41:22 -0800 All reviewed patches have been landed. Closing bug. 174819 2012-11-17 08:45:21 -0800 2012-11-18 12:27:16 -0800 Patch bug-102590-20121117174314.patch text/plain 2638 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ1YTY4ZDgxZjJiMzRi YWU2N2RhYjRjODNhMDE0ZDRiZjlhZmZiOS4uNGVhYWM4YjRkNTJjNTgyNDg5OWQzYTk3MmRjYmY3 NWVhNDk2Yjg5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTE3ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVt b3ZlIHVudXNlZCBDb25zb2xlTWVzc2FnZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjU5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisJCQkJV2UgY3VycmVudGx5IGhhdmUgYSBDb25zb2xlTWVz c2FnZSBjb25zdHJ1Y3RvciB0aGF0J3MgdW51c2VkLiBMZXQncworCQkJCWtpbGwgaXQuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwOgorICAgICAgICAqIGluc3BlY3Rv ci9Db25zb2xlTWVzc2FnZS5oOgorICAgICAgICAoQ29uc29sZU1lc3NhZ2UpOgorCQkJCSAgICBS ZW1vdmluZyBhbiB1bnVzZWQgY29uc3RydWN0b3IgdmFyaWFudC4KKwogMjAxMi0xMS0xNyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1NvdXBdIENy ZWRlbnRpYWxTdG9yYWdlIHNob3VsZCBvbmx5IGJlIHVzZWQgZm9yIEhUVFAtZmFtaWx5IHJlcXVl c3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2Uu Y3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmNwcAppbmRleCA1 YTg3MzYyMmI2Y2U3MzZlZjBhN2FjZGIyYzM3YTdkNWQ0ODUxY2ZmLi43MDM5ODQ3ZGY2OGJiNjg1 YjgxZTBjNWJjMjg0Yjg0YzYyNmE4YzJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9D b25zb2xlTWVzc2FnZS5jcHAKQEAgLTc4LDE4ICs3OCw2IEBAIENvbnNvbGVNZXNzYWdlOjpDb25z b2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHMsIE1lc3NhZ2VUeXBlIHQsIE1lc3NhZ2VMZXZlbCBs LCBjCiAgICAgbV9jYWxsU3RhY2sgPSBjYWxsU3RhY2s7CiB9CiAKLUNvbnNvbGVNZXNzYWdlOjpD b25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHMsIE1lc3NhZ2VUeXBlIHQsIE1lc3NhZ2VMZXZl bCBsLCBjb25zdCBTdHJpbmcmIG0sIGNvbnN0IFN0cmluZyYgcmVzcG9uc2VVcmwsIHVuc2lnbmVk IGxvbmcgcmVxdWVzdElkZW50aWZpZXIpCi0gICAgOiBtX3NvdXJjZShzKQotICAgICwgbV90eXBl KHQpCi0gICAgLCBtX2xldmVsKGwpCi0gICAgLCBtX21lc3NhZ2UobSkKLSAgICAsIG1fdXJsKHJl c3BvbnNlVXJsKQotICAgICwgbV9saW5lKDApCi0gICAgLCBtX3JlcGVhdENvdW50KDEpCi0gICAg LCBtX3JlcXVlc3RJZChJZGVudGlmaWVyc0ZhY3Rvcnk6OnJlcXVlc3RJZChyZXF1ZXN0SWRlbnRp ZmllcikpCi17Ci19Ci0KIENvbnNvbGVNZXNzYWdlOjp+Q29uc29sZU1lc3NhZ2UoKQogewogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmggYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAppbmRleCAwN2VmYTE3NjI0 ZTg3NDY4MWNlNWU4YmE5NmI2ZmRkYzljMjY2MTdhLi4wMDY4YzllNTE3NTcwNjc2OTQ5ZTczZWJi ZDc3YzRlZTFjZmYxMmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29u c29sZU1lc3NhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3Nh Z2UuaApAQCAtNTMsNyArNTMsNiBAQCBjbGFzcyBDb25zb2xlTWVzc2FnZSB7CiBwdWJsaWM6CiAg ICAgQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJjZSwgTWVzc2FnZVR5cGUsIE1lc3NhZ2VMZXZl bCwgY29uc3QgU3RyaW5nJiBtLCBjb25zdCBTdHJpbmcmIHUsIHVuc2lnbmVkIGxpLCB1bnNpZ25l ZCBsb25nIHJlcXVlc3RJZGVudGlmaWVyID0gMCk7CiAgICAgQ29uc29sZU1lc3NhZ2UoTWVzc2Fn ZVNvdXJjZSwgTWVzc2FnZVR5cGUsIE1lc3NhZ2VMZXZlbCwgY29uc3QgU3RyaW5nJiBtLCBQYXNz UmVmUHRyPFNjcmlwdEFyZ3VtZW50cz4sIFBhc3NSZWZQdHI8U2NyaXB0Q2FsbFN0YWNrPiwgdW5z aWduZWQgbG9uZyByZXF1ZXN0SWRlbnRpZmllciA9IDApOwotICAgIENvbnNvbGVNZXNzYWdlKE1l c3NhZ2VTb3VyY2UsIE1lc3NhZ2VUeXBlLCBNZXNzYWdlTGV2ZWwsIGNvbnN0IFN0cmluZyYgbSwg Y29uc3QgU3RyaW5nJiByZXNwb25zZVVybCwgdW5zaWduZWQgbG9uZyByZXF1ZXN0SWRlbnRpZmll cik7CiAgICAgfkNvbnNvbGVNZXNzYWdlKCk7CiAKICAgICB2b2lkIGFkZFRvRnJvbnRlbmQoSW5z cGVjdG9yRnJvbnRlbmQ6OkNvbnNvbGUqLCBJbmplY3RlZFNjcmlwdE1hbmFnZXIqLCBib29sIGdl bmVyYXRlUHJldmlldyk7Cg== 174853 2012-11-18 12:27:21 -0800 2012-11-18 21:41:18 -0800 Patch bug-102590-20121118212512.patch text/plain 2650 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ1YTY4ZDgxZjJiMzRi YWU2N2RhYjRjODNhMDE0ZDRiZjlhZmZiOS4uOTcwN2QwOWUwN2YyNTYyNmJiZjQyOGZkNzQyZjVk MzU4N2M5ZjM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTE4ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVt b3ZlIHVudXNlZCBDb25zb2xlTWVzc2FnZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjU5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBoYXZlIGEgQ29uc29s ZU1lc3NhZ2UgY29uc3RydWN0b3IgdGhhdCdzIHVudXNlZC4gTGV0J3MKKyAgICAgICAga2lsbCBp dC4KKworICAgICAgICAqIGluc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5jcHA6CisgICAgICAgICog aW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmg6CisgICAgICAgIChDb25zb2xlTWVzc2FnZSk6Cisg ICAgICAgICAgICBSZW1vdmluZyBhbiB1bnVzZWQgY29uc3RydWN0b3IgdmFyaWFudC4KKwogMjAx Mi0xMS0xNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW1NvdXBdIENyZWRlbnRpYWxTdG9yYWdlIHNob3VsZCBvbmx5IGJlIHVzZWQgZm9yIEhUVFAt ZmFtaWx5IHJlcXVlc3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29u c29sZU1lc3NhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdl LmNwcAppbmRleCA1YTg3MzYyMmI2Y2U3MzZlZjBhN2FjZGIyYzM3YTdkNWQ0ODUxY2ZmLi43MDM5 ODQ3ZGY2OGJiNjg1YjgxZTBjNWJjMjg0Yjg0YzYyNmE4YzJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5jcHAKQEAgLTc4LDE4ICs3OCw2IEBAIENvbnNvbGVN ZXNzYWdlOjpDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHMsIE1lc3NhZ2VUeXBlIHQsIE1l c3NhZ2VMZXZlbCBsLCBjCiAgICAgbV9jYWxsU3RhY2sgPSBjYWxsU3RhY2s7CiB9CiAKLUNvbnNv bGVNZXNzYWdlOjpDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlIHMsIE1lc3NhZ2VUeXBlIHQs IE1lc3NhZ2VMZXZlbCBsLCBjb25zdCBTdHJpbmcmIG0sIGNvbnN0IFN0cmluZyYgcmVzcG9uc2VV cmwsIHVuc2lnbmVkIGxvbmcgcmVxdWVzdElkZW50aWZpZXIpCi0gICAgOiBtX3NvdXJjZShzKQot ICAgICwgbV90eXBlKHQpCi0gICAgLCBtX2xldmVsKGwpCi0gICAgLCBtX21lc3NhZ2UobSkKLSAg ICAsIG1fdXJsKHJlc3BvbnNlVXJsKQotICAgICwgbV9saW5lKDApCi0gICAgLCBtX3JlcGVhdENv dW50KDEpCi0gICAgLCBtX3JlcXVlc3RJZChJZGVudGlmaWVyc0ZhY3Rvcnk6OnJlcXVlc3RJZChy ZXF1ZXN0SWRlbnRpZmllcikpCi17Ci19Ci0KIENvbnNvbGVNZXNzYWdlOjp+Q29uc29sZU1lc3Nh Z2UoKQogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnNvbGVN ZXNzYWdlLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAppbmRl eCAwN2VmYTE3NjI0ZTg3NDY4MWNlNWU4YmE5NmI2ZmRkYzljMjY2MTdhLi4wMDY4YzllNTE3NTcw Njc2OTQ5ZTczZWJiZDc3YzRlZTFjZmYxMmFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv Q29uc29sZU1lc3NhZ2UuaApAQCAtNTMsNyArNTMsNiBAQCBjbGFzcyBDb25zb2xlTWVzc2FnZSB7 CiBwdWJsaWM6CiAgICAgQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJjZSwgTWVzc2FnZVR5cGUs IE1lc3NhZ2VMZXZlbCwgY29uc3QgU3RyaW5nJiBtLCBjb25zdCBTdHJpbmcmIHUsIHVuc2lnbmVk IGxpLCB1bnNpZ25lZCBsb25nIHJlcXVlc3RJZGVudGlmaWVyID0gMCk7CiAgICAgQ29uc29sZU1l c3NhZ2UoTWVzc2FnZVNvdXJjZSwgTWVzc2FnZVR5cGUsIE1lc3NhZ2VMZXZlbCwgY29uc3QgU3Ry aW5nJiBtLCBQYXNzUmVmUHRyPFNjcmlwdEFyZ3VtZW50cz4sIFBhc3NSZWZQdHI8U2NyaXB0Q2Fs bFN0YWNrPiwgdW5zaWduZWQgbG9uZyByZXF1ZXN0SWRlbnRpZmllciA9IDApOwotICAgIENvbnNv bGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2UsIE1lc3NhZ2VUeXBlLCBNZXNzYWdlTGV2ZWwsIGNvbnN0 IFN0cmluZyYgbSwgY29uc3QgU3RyaW5nJiByZXNwb25zZVVybCwgdW5zaWduZWQgbG9uZyByZXF1 ZXN0SWRlbnRpZmllcik7CiAgICAgfkNvbnNvbGVNZXNzYWdlKCk7CiAKICAgICB2b2lkIGFkZFRv RnJvbnRlbmQoSW5zcGVjdG9yRnJvbnRlbmQ6OkNvbnNvbGUqLCBJbmplY3RlZFNjcmlwdE1hbmFn ZXIqLCBib29sIGdlbmVyYXRlUHJldmlldyk7Cg==