10259 2006-08-04 12:48:03 -0700 REGRESSION: Leaks reported by buildbot 2007-02-01 15:44:21 -0800 1 1 1 Unclassified WebKit WebCore Misc. 420+ Mac OS X 10.4 RESOLVED FIXED InRadar P1 Normal --- 1 ggaren webkit-unassigned darin oldest_to_newest 51809 0 ggaren 2006-08-04 12:48:03 -0700 149 Node 11 RenderObject 1 Frame 39 KJS::Node Looks like this began with r15791 (???). Index: WebCore/ChangeLog =================================================================== --- WebCore/ChangeLog (revision 15790) +++ WebCore/ChangeLog (revision 15792) @@ -1,3 +1,16 @@ +2006-08-03 David Hyatt <hyatt@apple.com> + + Fix for bug 10229, don't bother trying to clear when no floats are + present. I suspect there's still a bug in the math that follows, but + this fix is safer in that it just does the obvious thing (and doesn't + compute any clearance if no floats are even around). + + Reviewed by maciej + + * ChangeLog: + * rendering/RenderBlock.cpp: + (WebCore::RenderBlock::getClearDelta): + 2006-08-03 Justin Garcia <justin.garcia@apple.com> Reviewed by harrison 51810 1 ggaren 2006-08-04 12:51:09 -0700 Dave says that this change just replaced a function call with its implementation, so it looks like the buildbot is blaming this change for an independent leak. 51851 2 darin 2006-08-05 09:09:08 -0700 Here's what I see: 1) many leaks of the InlineBox created by RenderListMarker::createInlineBox -- this leak *does* seem like it was caused by a recent change 2) a failure in test dom/html/level2/html/HTMLBaseElement02.html 3) an entire frame leak as Geoff's reporting here -- not sure what caused this 51891 3 darin 2006-08-05 16:11:59 -0700 (In reply to comment #2) > 1) many leaks of the InlineBox created by RenderListMarker::createInlineBox > -- this leak *does* seem like it was caused by a recent change I'm trying and having trouble reproducing this locally. 51896 4 darin 2006-08-05 16:29:52 -0700 Now I can reproduce it fine. 51897 5 9896 darin 2006-08-05 17:09:46 -0700 Created attachment 9896 patch that fixes some of the biggest leaks I see 51944 6 9896 ggaren 2006-08-06 11:07:56 -0700 Comment on attachment 9896 patch that fixes some of the biggest leaks I see Patch looks good to me, but I'll wait for Hyatt. What do you think about changing this: + if (!handle) { + delete this; + return false; + } return true; to this: if (handle) return true; ? 51946 7 darin 2006-08-06 11:12:02 -0700 (In reply to comment #6) > What do you think about changing this: > > + if (!handle) { > + delete this; > + return false; > + } > > return true; > > to this: > > if (handle) > return true; > > ? Seems OK. I handled the error case first because I think of it as the exceptional case, but I can see sharing the code instead. 52536 8 9896 hyatt 2006-08-14 11:41:11 -0700 Comment on attachment 9896 patch that fixes some of the biggest leaks I see r=me 52540 9 9896 darin 2006-08-14 12:08:20 -0700 Comment on attachment 9896 patch that fixes some of the biggest leaks I see Committed revision 15857. Clearing review flag so we can use this bug to track fixing the rest of the leaks (including the ones that Geoff was originally talking about, I think). 33340 10 slewis 2007-01-22 16:39:40 -0800 In Radar <rdar://problem/4946778> 29134 11 mrowe 2007-02-01 15:44:21 -0800 The leaks reported here are long-gone. A new bug should be opened for any new leaks that are noticed. 9896 2006-08-05 17:09:46 -0700 2006-08-14 12:08:20 -0700 patch that fixes some of the biggest leaks I see LeakPatch.txt text/plain 2125 darin SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tCShyZXZpc2lv biAxNTgwOSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbWFjL1Jlc291cmNlTG9hZGVyTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC01OCwxOCArNTgsMTkgQEAgUmVzb3VyY2VMb2FkZXI6On5SZXNvdXJj ZUxvYWRlcigpCiAKIGJvb2wgUmVzb3VyY2VMb2FkZXI6OnN0YXJ0KERvY0xvYWRlciogZG9jTG9h ZGVyKQogewotICAgIEZyYW1lTWFjICpmcmFtZSA9IE1hYyhkb2NMb2FkZXItPmZyYW1lKCkpOwot ICAgIAorICAgIEZyYW1lTWFjKiBmcmFtZSA9IE1hYyhkb2NMb2FkZXItPmZyYW1lKCkpOworCiAg ICAgaWYgKCFmcmFtZSkgewogICAgICAgICBkZWxldGUgdGhpczsKICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgIH0KLSAgICAKKwogICAgIFdlYkNvcmVGcmFtZUJyaWRnZSogYnJpZGdlID0gZnJh bWUtPmJyaWRnZSgpOwogCiAgICAgZnJhbWUtPmRpZFRlbGxCcmlkZ2VBYm91dExvYWQodXJsKCku dXJsKCkpOwogCiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOworCiAgICAgV2ViQ29y ZVJlc291cmNlTG9hZGVySW1wKiByZXNvdXJjZUxvYWRlciA9IFtbV2ViQ29yZVJlc291cmNlTG9h ZGVySW1wIGFsbG9jXSBpbml0V2l0aEpvYjp0aGlzXTsKIAogICAgIGlkIDxXZWJDb3JlUmVzb3Vy Y2VIYW5kbGU+IGhhbmRsZTsKQEAgLTg2LDEwICs4NywxOCBAQCBib29sIFJlc291cmNlTG9hZGVy OjpzdGFydChEb2NMb2FkZXIqIGRvCiAgICAgICAgIGhhbmRsZSA9IFticmlkZ2Ugc3RhcnRMb2Fk aW5nUmVzb3VyY2U6cmVzb3VyY2VMb2FkZXIgd2l0aE1ldGhvZDptZXRob2QoKSBVUkw6dXJsKCku Z2V0TlNVUkwoKSBjdXN0b21IZWFkZXJzOmhlYWRlckRpY3RdOwogICAgIFtyZXNvdXJjZUxvYWRl ciBzZXRIYW5kbGU6aGFuZGxlXTsKICAgICBbcmVzb3VyY2VMb2FkZXIgcmVsZWFzZV07Ci0gICAg cmV0dXJuIGhhbmRsZSAhPSBuaWw7Ci0gICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKKwor ICAgIGlmICghaGFuZGxlKSB7CisgICAgICAgIGRlbGV0ZSB0aGlzOworICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQogCiAgICAgcmV0dXJuIHRydWU7CisKKyAgICBFTkRfQkxPQ0tfT0JKQ19F WENFUFRJT05TOworCisgICAgZGVsZXRlIHRoaXM7CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2 b2lkIFJlc291cmNlTG9hZGVyOjphc3NlbWJsZVJlc3BvbnNlSGVhZGVycygpIGNvbnN0CkluZGV4 OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb250YWluZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckNvbnRhaW5lci5jcHAJKHJldmlzaW9uIDE1ODA5KQorKysg V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ29udGFpbmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTY5LDEwICsxNjksMTIgQEAgUmVuZGVyT2JqZWN0KiBSZW5kZXJDb250YWluZXI6OnJlbW92ZUNo aQogICAgIGlmICghZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpKSB7CiAgICAgICAgIG9sZENoaWxk LT5zZXROZWVkc0xheW91dEFuZE1pbk1heFJlY2FsYygpOwogICAgICAgICBvbGRDaGlsZC0+cmVw YWludCgpOworICAgIH0KICAgICAgICAgCi0gICAgICAgIC8vIElmIHdlIGhhdmUgYSBsaW5lIGJv eCB3cmFwcGVyLCBkZWxldGUgaXQuCi0gICAgICAgIG9sZENoaWxkLT5kZWxldGVMaW5lQm94V3Jh cHBlcigpOworICAgIC8vIElmIHdlIGhhdmUgYSBsaW5lIGJveCB3cmFwcGVyLCBkZWxldGUgaXQu CisgICAgb2xkQ2hpbGQtPmRlbGV0ZUxpbmVCb3hXcmFwcGVyKCk7CiAKKyAgICBpZiAoIWRvY3Vt ZW50QmVpbmdEZXN0cm95ZWQoKSkgewogICAgICAgICAvLyBLZWVwIG91ciBsYXllciBoaWVyYXJj aHkgdXBkYXRlZC4KICAgICAgICAgb2xkQ2hpbGQtPnJlbW92ZUxheWVycyhlbmNsb3NpbmdMYXll cigpKTsKICAgICAgICAgCg==