102588 2012-11-17 07:36:40 -0800 Remove 8-bit related assertion from NetscapePluginModuleX11. 2012-11-19 07:15:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco kbalazs msaboff ossy webkit.review.bot oldest_to_newest 769943 0 rakuco 2012-11-17 07:36:40 -0800 Remove 8-bit related assertion from NetscapePluginModuleX11. 769944 1 174818 rakuco 2012-11-17 07:38:38 -0800 Created attachment 174818 Patch 769946 2 kbalazs 2012-11-17 07:42:16 -0800 Oops, I forgot to remove the assert :-) LGTM. 770058 3 174818 webkit.review.bot 2012-11-17 19:41:21 -0800 Comment on attachment 174818 Patch Rejecting attachment 174818 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 2 diffs from patch file(s). patching file Source/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp Hunk #1 FAILED at 160. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Andreas Kl..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14859936 770720 4 ossy 2012-11-19 07:15:24 -0800 Landed in r135057. 174818 2012-11-17 07:38:38 -0800 2012-11-19 07:15:35 -0800 Patch bug-102588-20121117173631.patch text/plain 1672 rakuco SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTA0NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE3ICBSYXBoYWVs IEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAg ICAgIFJlbW92ZSA4LWJpdCByZWxhdGVkIGFzc2VydGlvbiBmcm9tIE5ldHNjYXBlUGx1Z2luTW9k dWxlWDExLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyNTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rm9sbG93LXVwIHRvIHIxMzUwNDM6IHNpbmNlIFN0cmluZzo6ZnJvbVVURjgoKSBpcyBub3QgZ3Vh cmFudGVlZAorICAgICAgICB0byBnaXZlIHVzIGEgMTYtYml0IHN0cmluZywgdGhlIGFzc2VydGlv biBpbgorICAgICAgICB0cnVuY2F0ZVRvU2luZ2xlTGluZSgpIHdpbGwgZmFpbCBpbiB0aGF0IGNh c2UuCisKKyAgICAgICAgVGhpcyBzaG91bGQgbWFrZSB0aGUgRUZMIFdLMiBEZWJ1ZyBib3Qgc3Rv cCBmYWlsaW5nIGFsbAorICAgICAgICBwbHVnaW4tcmVsYXRlZCB0ZXN0cyBiZWNhdXNlICJXZWJL aXQgVGVzdCBQbHVnaW4iIGlzIHJldHVybmVkIGFzCisgICAgICAgIGFuIDgtYml0IHN0cmluZy4K KworICAgICAgICAqIFNoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpbk1v ZHVsZVgxMS5jcHA6CisgICAgICAgIChXZWJLaXQ6OnRydW5jYXRlVG9TaW5nbGVMaW5lKToKKwog MjAxMi0xMS0xNyAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgOGJpdC11bmF3YXJlIFN0cmluZyB1c2FnZSBpbiBOZXRzY2FwZVBsdWdpbk1vZHVsZVgxMS5j cHAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL05ldHNjYXBlL3gxMS9OZXRz Y2FwZVBsdWdpbk1vZHVsZVgxMS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hh cmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcAkocmV2 aXNpb24gMTM1MDQ1KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUv eDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYwLDgg KzE2MCw2IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW5Nb2R1bGU6OmRldGVybWluZVF1aXIKIAogc3Rh dGljIFN0cmluZyB0cnVuY2F0ZVRvU2luZ2xlTGluZShjb25zdCBTdHJpbmcmIHN0cmluZykKIHsK LSAgICBBU1NFUlRfQVJHKHN0cmluZywgIXN0cmluZy5pczhCaXQoKSk7Ci0KICAgICB1bnNpZ25l ZCBvbGRMZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7CiAgICAgVUNoYXIqIGJ1ZmZlcjsKICAgICBT dHJpbmcgc3RyaW5nQnVmZmVyKFN0cmluZ0ltcGw6OmNyZWF0ZVVuaW5pdGlhbGl6ZWQob2xkTGVu Z3RoICsgMSwgYnVmZmVyKSk7Cg==