102579 2012-11-16 20:53:34 -0800 [mac] Enable scaled cursors 2012-12-18 14:27:34 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 99493 1 rbyers bdakin ap bdakin mitz rbyers simon.fraser webkit-bug-importer oldest_to_newest 769875 0 rbyers 2012-11-16 20:53:34 -0800 Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you? Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image. 775716 1 bdakin 2012-11-26 11:34:57 -0800 (In reply to comment #0) > Set ENABLE(MOUSE_CURSOR_SCALE) on Mac port so that high-dpi custom mouse cursors can be used > > Beth, I have no experience with Mac development (and I'm not sure when exactly you'd want to enable this feature), can I give this piece to you? Once bug 99493 lands, the remaining work for Mac should be trivial - just set MOUSE_CURSOR_SCALE and update WebCore/platform/mac/CursorMac.mm to use the imageScaleFactor value when setting a custom cursor image. Sure, thank you. 785547 2 webkit-bug-importer 2012-12-06 19:08:54 -0800 <rdar://problem/12832295> 794036 3 180023 bdakin 2012-12-18 14:15:08 -0800 Created attachment 180023 Patch 794041 4 180023 dino 2012-12-18 14:19:13 -0800 Comment on attachment 180023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180023&action=review > Source/WebCore/ChangeLog:10 > + defined, and we need to initialize m_imageScaleFactor in the Cursor constructors. > + * Configurations/FeatureDefines.xcconfig: Nit: blank line between here. 794051 5 bdakin 2012-12-18 14:27:34 -0800 Thanks, Dean! http://trac.webkit.org/changeset/138069 180023 2012-12-18 14:15:08 -0800 2012-12-18 14:19:13 -0800 Patch for-review.txt text/plain 7413 bdakin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM4MDY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTEyLTE4ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTc5CisgICAgICAgIFtt YWNdIEVuYWJsZSBzY2FsZWQgY3Vyc29ycworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25m aWc6CisKIDIwMTItMTItMTggIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXN0cmljdGlvbnMgb24gb3ZlcnNpemUgQ29waWVkQmxvY2sgYWxsb2Nh dGlvbnMgc2hvdWxkIGJlIHJlbGF4ZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25m aWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcJKHJl dmlzaW9uIDEzNzk0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMTE0LDcgKzExNCw3IEBA IEVOQUJMRV9NRURJQV9TVEFUSVNUSUNTID0gOwogRU5BQkxFX01FVEVSX0VMRU1FTlQgPSBFTkFC TEVfTUVURVJfRUxFTUVOVDsKIEVOQUJMRV9NSFRNTCA9IDsKIEVOQUJMRV9NSUNST0RBVEEgPSA7 Ci1FTkFCTEVfTU9VU0VfQ1VSU09SX1NDQUxFID0gOworRU5BQkxFX01PVVNFX0NVUlNPUl9TQ0FM RSA9IEVOQUJMRV9NT1VTRV9DVVJTT1JfU0NBTEU7CiBFTkFCTEVfTVVUQVRJT05fT0JTRVJWRVJT ID0gRU5BQkxFX01VVEFUSU9OX09CU0VSVkVSUzsKIEVOQUJMRV9OQVZJR0FUT1JfQ09OVEVOVF9V VElMUyA9IDsKIEVOQUJMRV9OT1RJRklDQVRJT05TID0gJChFTkFCTEVfTk9USUZJQ0FUSU9OU18k KFBMQVRGT1JNX05BTUUpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODA2NykKKysrIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDEyLTEyLTE4ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTc5CisgICAgICAgIFttYWNd IEVuYWJsZSBzY2FsZWQgY3Vyc29ycworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vdCBtdWNoIGlzIHJlcXVpcmVkIHRvIGdldCB0aGlzIHR1cm5lZCBv bi4gV2UganVzdCBuZWVkIHRoZSBmZWF0dXJlIHRvIGJlIAorICAgICAgICBkZWZpbmVkLCBhbmQg d2UgbmVlZCB0byBpbml0aWFsaXplIG1faW1hZ2VTY2FsZUZhY3RvciBpbiB0aGUgQ3Vyc29yIGNv bnN0cnVjdG9ycy4KKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2Nv bmZpZzoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1tOgorICAgICAgICAoV2Vi Q29yZTo6Q3Vyc29yOjpDdXJzb3IpOgorICAgICAgICAoV2ViQ29yZTo6Q3Vyc29yOjpvcGVyYXRv cj0pOgorCiAyMDEyLTEyLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgW01hY10gQWRkIEJ1aWxkIFBoYXNlIHRvIENoZWNrIEhlYWRlcnMgZm9yIElu YXBwcm9wcmlhdGUgTWFjcm9zIChQbGF0Zm9ybS5oIG1hY3JvcykKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCShy ZXZpc2lvbiAxMzc5NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9GZWF0dXJl RGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMTE0LDcgKzExNCw3IEBAIEVOQUJM RV9NRURJQV9TVEFUSVNUSUNTID0gOwogRU5BQkxFX01FVEVSX0VMRU1FTlQgPSBFTkFCTEVfTUVU RVJfRUxFTUVOVDsKIEVOQUJMRV9NSFRNTCA9IDsKIEVOQUJMRV9NSUNST0RBVEEgPSA7Ci1FTkFC TEVfTU9VU0VfQ1VSU09SX1NDQUxFID0gOworRU5BQkxFX01PVVNFX0NVUlNPUl9TQ0FMRSA9IEVO QUJMRV9NT1VTRV9DVVJTT1JfU0NBTEU7CiBFTkFCTEVfTVVUQVRJT05fT0JTRVJWRVJTID0gRU5B QkxFX01VVEFUSU9OX09CU0VSVkVSUzsKIEVOQUJMRV9OQVZJR0FUT1JfQ09OVEVOVF9VVElMUyA9 IDsKIEVOQUJMRV9OT1RJRklDQVRJT05TID0gJChFTkFCTEVfTk9USUZJQ0FUSU9OU18kKFBMQVRG T1JNX05BTUUpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DdXJzb3JNYWMu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0N1cnNvck1hYy5t bQkocmV2aXNpb24gMTM3OTQ5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0N1cnNv ck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzQwLDYgKzM0MCw3IEBAIEN1cnNvcjo6Q3Vyc29y KGNvbnN0IEN1cnNvciYgb3RoZXIpCiAgICAgOiBtX3R5cGUob3RoZXIubV90eXBlKQogICAgICwg bV9pbWFnZShvdGhlci5tX2ltYWdlKQogICAgICwgbV9ob3RTcG90KG90aGVyLm1faG90U3BvdCkK KyAgICAsIG1faW1hZ2VTY2FsZUZhY3RvcihvdGhlci5tX2ltYWdlU2NhbGVGYWN0b3IpCiAgICAg LCBtX3BsYXRmb3JtQ3Vyc29yKG90aGVyLm1fcGxhdGZvcm1DdXJzb3IpCiB7CiB9CkBAIC0zNDks NiArMzUwLDcgQEAgQ3Vyc29yJiBDdXJzb3I6Om9wZXJhdG9yPShjb25zdCBDdXJzb3ImIAogICAg IG1fdHlwZSA9IG90aGVyLm1fdHlwZTsKICAgICBtX2ltYWdlID0gb3RoZXIubV9pbWFnZTsKICAg ICBtX2hvdFNwb3QgPSBvdGhlci5tX2hvdFNwb3Q7CisgICAgbV9pbWFnZVNjYWxlRmFjdG9yID0g b3RoZXIubV9pbWFnZVNjYWxlRmFjdG9yOwogICAgIG1fcGxhdGZvcm1DdXJzb3IgPSBvdGhlci5t X3BsYXRmb3JtQ3Vyc29yOwogICAgIHJldHVybiAqdGhpczsKIH0KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzODA2NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTE4ICBCZXRoIERha2luICA8YmRha2luQGFwcGxl LmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAyNTc5CisgICAgICAgIFttYWNdIEVuYWJsZSBzY2FsZWQgY3Vyc29ycworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvRmVh dHVyZURlZmluZXMueGNjb25maWc6CisKIDIwMTItMTItMTggIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBBZGQgQnVpbGQgUGhhc2UgdG8gQ2hl Y2sgSGVhZGVycyBmb3IgSW5hcHByb3ByaWF0ZSBNYWNyb3MgKFBsYXRmb3JtLmggbWFjcm9zKQpJ bmRleDogU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25m aWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURl ZmluZXMueGNjb25maWcJKHJldmlzaW9uIDEzNzk0OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NvbmZp Z3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0xMTQs NyArMTE0LDcgQEAgRU5BQkxFX01FRElBX1NUQVRJU1RJQ1MgPSA7CiBFTkFCTEVfTUVURVJfRUxF TUVOVCA9IEVOQUJMRV9NRVRFUl9FTEVNRU5UOwogRU5BQkxFX01IVE1MID0gOwogRU5BQkxFX01J Q1JPREFUQSA9IDsKLUVOQUJMRV9NT1VTRV9DVVJTT1JfU0NBTEUgPSA7CitFTkFCTEVfTU9VU0Vf Q1VSU09SX1NDQUxFID0gRU5BQkxFX01PVVNFX0NVUlNPUl9TQ0FMRTsKIEVOQUJMRV9NVVRBVElP Tl9PQlNFUlZFUlMgPSBFTkFCTEVfTVVUQVRJT05fT0JTRVJWRVJTOwogRU5BQkxFX05BVklHQVRP Ul9DT05URU5UX1VUSUxTID0gOwogRU5BQkxFX05PVElGSUNBVElPTlMgPSAkKEVOQUJMRV9OT1RJ RklDQVRJT05TXyQoUExBVEZPUk1fTkFNRSkpOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNp b24gMTM4MDY3KQorKysgU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTItMTggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUu Y29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDI1NzkKKyAgICAgICAgW21hY10gRW5hYmxlIHNjYWxlZCBjdXJzb3JzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9GZWF0 dXJlRGVmaW5lcy54Y2NvbmZpZzoKKwogMjAxMi0xMi0xNiAgTGV2aSBXZWludHJhdWIgIDxsZXZp d0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUHVzaCBwaXhlbCBzbmFwcGluZyBsb2dpYyBpbnRv IFRyYW5zZm9ybVN0YXRlCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9Db25maWd1cmF0aW9ucy9G ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9D b25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkocmV2aXNpb24gMTM3OTQ5KQor KysgU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25m aWcJKHdvcmtpbmcgY29weSkKQEAgLTExNCw3ICsxMTQsNyBAQCBFTkFCTEVfTUVESUFfU1RBVElT VElDUyA9IDsKIEVOQUJMRV9NRVRFUl9FTEVNRU5UID0gRU5BQkxFX01FVEVSX0VMRU1FTlQ7CiBF TkFCTEVfTUhUTUwgPSA7CiBFTkFCTEVfTUlDUk9EQVRBID0gOwotRU5BQkxFX01PVVNFX0NVUlNP Ul9TQ0FMRSA9IDsKK0VOQUJMRV9NT1VTRV9DVVJTT1JfU0NBTEUgPSBFTkFCTEVfTU9VU0VfQ1VS U09SX1NDQUxFOwogRU5BQkxFX01VVEFUSU9OX09CU0VSVkVSUyA9IEVOQUJMRV9NVVRBVElPTl9P QlNFUlZFUlM7CiBFTkFCTEVfTkFWSUdBVE9SX0NPTlRFTlRfVVRJTFMgPSA7CiBFTkFCTEVfTk9U SUZJQ0FUSU9OUyA9ICQoRU5BQkxFX05PVElGSUNBVElPTlNfJChQTEFURk9STV9OQU1FKSk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzgwNjcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMi0xOCAgQmV0aCBEYWtpbiAgPGJkYWtp bkBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMjU3OQorICAgICAgICBbbWFjXSBFbmFibGUgc2NhbGVkIGN1cnNvcnMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbi1za2lwIHRoZXNl IHRlc3RzIG5vdyB0aGF0IHRoZSBmZWF0dXJlIGlzIGVuYWJsZWQuCisgICAgICAgICogcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMTItMTggIERvbWluaWMgTWF6em9uaSAg PGRtYXp6b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBVbnJldmlld2VkIGdh cmRlbmluZy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z CShyZXZpc2lvbiAxMzc5NDkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMTIzNSwxMCArMTIzNSw2IEBAIHdlYmtpdC5vcmcv Yi82NzQzNCBbIERlYnVnIF0gZmFzdC9ibG9jay8KICMgTW91bnRhaW4gTGlvbiBhbmQgcHJpb3Ig ZG8gbm90IHN1cHBvcnQgY3VzdG9tIG1lZGlhIGRhdGEgbG9hZGluZwogQnVnKGplcm5vYmxlKSBb IE1vdW50YWluTGlvbiBMaW9uIFNub3dMZW9wYXJkIF0gbWVkaWEvdmlkZW8tc3JjLWJsb2IuaHRt bAogCi0jIE5lZWRzIEVOQUJMRShNT1VTRV9DVVJTT1JfU0NBTEUpCi13ZWJraXQub3JnL2IvMTAy NTc5IGZhc3QvY3NzL2N1cnNvci1wYXJzaW5nLWltYWdlLXNldC5odG1sIFsgRmFpbHVyZSBdCi13 ZWJraXQub3JnL2IvMTAyNTc5IGZhc3QvZXZlbnRzL21vdXNlLWN1cnNvci1pbWFnZS1zZXQuaHRt bCBbIEZhaWx1cmUgXQotCiAjIE1vdW50YWluIExpb24gYW5kIHByaW9yIGRvIG5vdCBhbGxvdyBh Y2Nlc3MgdG8gaW4tYmFuZCB0ZXh0IHRyYWNrcwogd2Via2l0Lm9yZy9iLzEwMzY2MyBbIE1vdW50 YWluTGlvbiBMaW9uIFNub3dMZW9wYXJkIF0gbWVkaWEvdHJhY2svdHJhY2staW4tYmFuZC5odG1s CiAK