102572 2012-11-16 16:56:32 -0800 Don't blind all the things. 2012-11-27 10:41:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 769779 0 oliver 2012-11-16 16:56:32 -0800 Don't blind all the things. 775773 1 176046 oliver 2012-11-26 12:29:41 -0800 Created attachment 176046 Patch 775782 2 176046 darin 2012-11-26 12:37:06 -0800 Comment on attachment 176046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176046&action=review > Source/JavaScriptCore/ChangeLog:12 > + (MacroAssembler): Please delete bogus lines like this from change log. > Source/JavaScriptCore/assembler/MacroAssembler.h:843 > + bool shouldConsiderBlinding() Should be a static member function? > Source/JavaScriptCore/assembler/MacroAssembler.h:847 > bool shouldBlindDouble(double value) Should be a static member function? > Source/JavaScriptCore/assembler/MacroAssembler.h:895 > + if (~value <= 0xff) > + return false; No explanation of this change in the change log. > Source/JavaScriptCore/assembler/MacroAssembler.h:954 > + if (~value <= 0xff) > + return false; No explanation of this change in the change log. > Source/JavaScriptCore/assembler/MacroAssembler.h:1089 > + if (~value <= 0xff) > + return false; No explanation of this change in the change log. 775811 3 176046 barraclough 2012-11-26 13:13:37 -0800 Comment on attachment 176046 Patch r=me, please add changelog comment re blinding small negative value. 775816 4 oliver 2012-11-26 13:21:17 -0800 Committed r135757: <http://trac.webkit.org/changeset/135757> 776912 5 176046 darin 2012-11-27 10:03:02 -0800 Comment on attachment 176046 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176046&action=review >> Source/JavaScriptCore/assembler/MacroAssembler.h:843 >> + bool shouldConsiderBlinding() > > Should be a static member function? Why is this a non-static member function instead of a static one? >> Source/JavaScriptCore/assembler/MacroAssembler.h:847 >> bool shouldBlindDouble(double value) > > Should be a static member function? Why is this a non-static member function instead of a static one? 776956 6 oliver 2012-11-27 10:41:33 -0800 (In reply to comment #5) > (From update of attachment 176046 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176046&action=review > > >> Source/JavaScriptCore/assembler/MacroAssembler.h:843 > >> + bool shouldConsiderBlinding() > > > > Should be a static member function? > > Why is this a non-static member function instead of a static one? > > >> Source/JavaScriptCore/assembler/MacroAssembler.h:847 > >> bool shouldBlindDouble(double value) > > > > Should be a static member function? > > Why is this a non-static member function instead of a static one? Because they use member functions 176046 2012-11-26 12:29:41 -0800 2012-11-27 10:03:02 -0800 Patch bug-102572-20121126122719.patch text/plain 3655 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YWVhNWExMGY1MzA1YjQzMmQ2MzllMDIyZGFmYjNkZjRlYmZlOTljLi5iNzA2YTBlYWYyNmYxOTU2 MGViODQxYmRhODZiNGQ3YmEzMTNmYjk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0xMS0yNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIERvbid0IGJsaW5kIGFsbCB0aGUgdGhpbmdzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTcyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbG9uZ2VyIGJsaW5kIGFsbCB0aGUgY29u c3RhbnRzIGluIHRoZSBpbnN0cnVjdGlvbiBzdHJlYW0uICBXZSB1c2UgYQorICAgICAgICBzaW1w bGUgbm9uLWRldGVybWluaXN0aWMgZmlsdGVyIHRvIGF2b2lkIGJsaW5kaW5nIGV2ZXJ5dGhpbmcu CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgKE1hY3Jv QXNzZW1ibGVyKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXI6OnNob3VsZENvbnNpZGVy QmxpbmRpbmcpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlcjo6c2hvdWxkQmxpbmQpOgor CiAyMDEyLTExLTI2ICBKdWxpZW4gQlJJQU5DRUFVICAgPGpicmlhbmNlYXVAbmRzLmNvbT4KIAog ICAgICAgICBbc2g0XSBKYXZhU2NyaXB0Q29yZSBKSVQgYnVpbGQgaXMgYnJva2VuIHNpbmNlIHIx MzUzMzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXIuaAppbmRleCBkY2ZkZDQ4NzhiZDg3ZmY5Y2M0OGY0MTAwYzI5ZGMyMDU3MTRmYzcwLi5kZTMx Y2MyZTRmYTY4ZmM3NTJiZDM1Y2FlMWQ2NzNhM2EwMmNmYjUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCkBAIC04MzksMjYgKzgzOSwz MCBAQCBwdWJsaWM6CiAgICAgdXNpbmcgTWFjcm9Bc3NlbWJsZXJCYXNlOjphbmQ2NDsKICAgICB1 c2luZyBNYWNyb0Fzc2VtYmxlckJhc2U6OmNvbnZlcnRJbnQzMlRvRG91YmxlOwogICAgIHVzaW5n IE1hY3JvQXNzZW1ibGVyQmFzZTo6c3RvcmU2NDsKLSAgICAKKyAgICBzdGF0aWMgY29uc3QgdW5z aWduZWQgQmxpbmRpbmdNb2R1bHVzID0gNjQ7CisgICAgYm9vbCBzaG91bGRDb25zaWRlckJsaW5k aW5nKCkKKyAgICB7CisgICAgICAgIHJldHVybiAhKHJhbmRvbSgpICYgKEJsaW5kaW5nTW9kdWx1 cyAtIDEpKTsKKyAgICB9CiAgICAgYm9vbCBzaG91bGRCbGluZERvdWJsZShkb3VibGUgdmFsdWUp CiAgICAgewogICAgICAgICAvLyBEb24ndCB0cnVzdCBOYU4gb3IgKy8tSW5maW5pdHkKICAgICAg ICAgaWYgKCFpc2Zpbml0ZSh2YWx1ZSkpCi0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAg ICAgICAgIHJldHVybiBzaG91bGRDb25zaWRlckJsaW5kaW5nKCk7CiAKICAgICAgICAgLy8gVHJ5 IHRvIGZvcmNlIG5vcm1hbGlzYXRpb24sIGFuZCBjaGVjayB0aGF0IHRoZXJlJ3Mgbm8gY2hhbmdl CiAgICAgICAgIC8vIGluIHRoZSBiaXQgcGF0dGVybgogICAgICAgICBpZiAoYml0d2lzZV9jYXN0 PHVpbnQ2NF90Pih2YWx1ZSAqIDEuMCkgIT0gYml0d2lzZV9jYXN0PHVpbnQ2NF90Pih2YWx1ZSkp Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybiBzaG91bGRDb25z aWRlckJsaW5kaW5nKCk7CiAKICAgICAgICAgdmFsdWUgPSBhYnModmFsdWUpOwogICAgICAgICAv LyBPbmx5IGFsbG93IGEgbGltaXRlZCBzZXQgb2YgZnJhY3Rpb25hbCBjb21wb25lbnRzCiAgICAg ICAgIGRvdWJsZSBzY2FsZWRWYWx1ZSA9IHZhbHVlICogODsKICAgICAgICAgaWYgKHNjYWxlZFZh bHVlIC8gOCAhPSB2YWx1ZSkKLSAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgICAgICAgICAg cmV0dXJuIHNob3VsZENvbnNpZGVyQmxpbmRpbmcoKTsKICAgICAgICAgZG91YmxlIGZyYWMgPSBz Y2FsZWRWYWx1ZSAtIGZsb29yKHNjYWxlZFZhbHVlKTsKICAgICAgICAgaWYgKGZyYWMgIT0gMC4w KQotICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgICAgICByZXR1cm4gc2hvdWxkQ29u c2lkZXJCbGluZGluZygpOwogCiAgICAgICAgIHJldHVybiB2YWx1ZSA+IDB4ZmY7CiAgICAgfQpA QCAtODg3LDggKzg5MSwxNCBAQCBwdWJsaWM6CiAgICAgICAgIGRlZmF1bHQ6IHsKICAgICAgICAg ICAgIGlmICh2YWx1ZSA8PSAweGZmKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICAgICAgICAgIGlmICh+dmFsdWUgPD0gMHhmZikKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgICAgIH0KICAgICAgICAgfQorCisgICAgICAgIGlmICghc2hvdWxkQ29uc2lkZXJC bGluZGluZygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgICAgIHJldHVybiBz aG91bGRCbGluZEZvclNwZWNpZmljQXJjaCh2YWx1ZSk7CiAgICAgfQogICAgIApAQCAtOTQwLDYg Kzk1MCw5IEBAIHB1YmxpYzoKICAgICAgICAgZGVmYXVsdDogewogICAgICAgICAgICAgaWYgKHZh bHVlIDw9IDB4ZmYpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAg aWYgKH52YWx1ZSA8PSAweGZmKQorICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg ICAgICAgICAgSlNWYWx1ZSBqc1ZhbHVlID0gSlNWYWx1ZTo6ZGVjb2RlKHZhbHVlKTsKICAgICAg ICAgICAgIGlmIChqc1ZhbHVlLmlzSW50MzIoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gc2hv dWxkQmxpbmQoSW1tMzIoanNWYWx1ZS5hc0ludDMyKCkpKTsKQEAgLTk1MCw2ICs5NjMsMTAgQEAg cHVibGljOgogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQogICAgICAg ICB9CisKKyAgICAgICAgaWYgKCFzaG91bGRDb25zaWRlckJsaW5kaW5nKCkpCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisKICAgICAgICAgcmV0dXJuIHNob3VsZEJsaW5kRm9yU3BlY2lmaWNB cmNoKHZhbHVlKTsKICAgICB9CiAgICAgCkBAIC0xMDY4LDcgKzEwODUsMTMgQEAgcHVibGljOgog ICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgaWYgKHZhbHVlIDw9IDB4ZmYpCiAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgaWYgKH52YWx1ZSA8PSAweGZmKQor ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQorCisgICAgICAgIGlmICgh c2hvdWxkQ29uc2lkZXJCbGluZGluZygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAg ICAgICAgIHJldHVybiBzaG91bGRCbGluZEZvclNwZWNpZmljQXJjaCh2YWx1ZSk7CiAjZW5kaWYK ICAgICB9Cg==