102551 2012-11-16 12:34:16 -0800 [CMake] Add support for winflexbison distribution 2012-11-26 11:13:59 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97592 1 paroga paroga gyuyoung.kim laszlo.gombos mxie rakuco rwlbuis webkit.review.bot oldest_to_newest 769577 0 paroga 2012-11-16 12:34:16 -0800 [CMake] Add support for winflexbison distribution 769582 1 174746 paroga 2012-11-16 12:39:29 -0800 Created attachment 174746 Patch 770218 2 174746 laszlo.gombos 2012-11-18 16:22:31 -0800 Comment on attachment 174746 Patch r=me. It looks to me that all cmake based ports can have this change. It would be great to get a confirmation from the Blackberry port before committing the patch. 774568 3 laszlo.gombos 2012-11-23 08:02:35 -0800 Rob or any of the BB folks - is this change ok for the BlackBerry port ? I just want to check if this would cause any regression before landing it. 774582 4 mxie 2012-11-23 08:38:48 -0800 Just ran a test build with your patch, and the BlackBerry port builds fine. Please go ahead and submit your patch :) 774594 5 174746 laszlo.gombos 2012-11-23 08:49:36 -0800 Comment on attachment 174746 Patch Thanks Ming. 774597 6 174746 webkit.review.bot 2012-11-23 08:55:18 -0800 Comment on attachment 174746 Patch Clearing flags on attachment: 174746 Committed r135621: <http://trac.webkit.org/changeset/135621> 774598 7 webkit.review.bot 2012-11-23 08:55:23 -0800 All reviewed patches have been landed. Closing bug. 774736 8 laszlo.gombos 2012-11-23 18:05:24 -0800 Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks ! 775694 9 paroga 2012-11-26 11:13:59 -0800 (In reply to comment #8) > Patrick, please let us know if you had a chance to update the buildbot now that this patch is landed. Thanks ! I already updated the binaries, but found an additional problem now. CMake does not recognice the version of win_flex, since it has a different output style. I'm already in contact with the win_flex developer and working on a CMake patch. If the patch is so importet for you I can make some changes in the installed CMake version to work around this problem for now. :-/ 174746 2012-11-16 12:39:29 -0800 2012-11-23 08:55:18 -0800 Patch bug-102551.patch text/plain 1701 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4Mzg2NjBmLi4xZmM4NWNl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMTEtMTYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NNYWtlXSBBZGQgc3VwcG9ydCBmb3Igd2luZmxleGJpc29uIGRpc3RyaWJ1dGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTUxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgR251 V2luMzIgZG9lcyBub3QgcHJvdmlkZSByZWNlbnQgdmVyc2lvbnMgb2YgYmlzaW9uIGFuZCBmbGV4 IHN1cHBvcnRpbmcKKyAgICAgICAgdGhlIGFsdGVybmF0aXZlIHdpbmZsZXhiaXNvbiBkaXN0cmli dXRpb24gaXMgdGhlIHByZWZlcmVkIG9wdGlvbi4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9X ZWJLaXRNYWNyb3MuY21ha2U6CisKIDIwMTItMTAtMTYgIFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZA bW90b3JvbGEuY29tPgogCiAgICAgICAgIFByZS1wcm9jZXNzIENTU0dyYW1tYXIueSBiZWZvcmUg cnVubmluZyB0aHJvdWdoIGJpc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dlYktpdE1h Y3Jvcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXggOWJhOTg4 Zi4uMmRkZWE3NyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQor KysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCkBAIC0xNDksMTEgKzE0OSwxNiBA QCBFTkRNQUNSTyAoKQogCiAKIE1BQ1JPIChHRU5FUkFURV9HUkFNTUFSIF9wcmVmaXggX2lucHV0 IF9vdXRwdXRfaGVhZGVyIF9vdXRwdXRfc291cmNlIF9mZWF0dXJlcykKKyAgICAjIFRoaXMgaXMg YSB3b3JrYXJvdW5kIGZvciB3aW5mbGV4Ymlzb24sIHdoaWNoIGRvZXMgbm90IHdvcmsgY29ycmV0 bHkgd2hlbgorICAgICMgcnVuIGluIGEgZGlmZmVyZW50IHdvcmtpbmcgZGlyZWN0b3J5IHRoYW4g dGhlIGluc3RhbGxhdGlvbiBkaXJlY3RvcnkuCisgICAgR0VUX0ZJTEVOQU1FX0NPTVBPTkVOVChf d29ya2luZ19kaXJlY3RvcnkgJHtCSVNPTl9FWEVDVVRBQkxFfSBQQVRIKQorCiAgICAgQUREX0NV U1RPTV9DT01NQU5EKAogICAgICAgICBPVVRQVVQgJHtfb3V0cHV0X2hlYWRlcn0gJHtfb3V0cHV0 X3NvdXJjZX0KICAgICAgICAgTUFJTl9ERVBFTkRFTkNZICR7X2lucHV0fQogICAgICAgICBERVBF TkRTICR7X2lucHV0fQogICAgICAgICBDT01NQU5EICR7UEVSTF9FWEVDVVRBQkxFfSAtSSAke1dF QkNPUkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzICR7V0VCQ09SRV9ESVJ9L2Nzcy9tYWtlZ3JhbW1h ci5wbCAtLW91dHB1dERpciAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0gLS1leHRyYURl ZmluZXMgIiR7X2ZlYXR1cmVzfSIgLS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJF UFJPQ0VTU09SfSIgLS1iaXNvbiAiJHtCSVNPTl9FWEVDVVRBQkxFfSIgLS1zeW1ib2xzUHJlZml4 ICR7X3ByZWZpeH0gJHtfaW5wdXR9CisgICAgICAgIFdPUktJTkdfRElSRUNUT1JZICR7X3dvcmtp bmdfZGlyZWN0b3J5fQogICAgICAgICBWRVJCQVRJTSkKIEVORE1BQ1JPICgpCiAK