102545 2012-11-16 11:57:46 -0800 Enable media stream on Android for Chromium 2012-12-18 11:59:23 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Android Android RESOLVED FIXED WebExposed P2 Normal --- 1 wjia wjia abarth eric jknotten peter tony webkit.review.bot oldest_to_newest 769542 0 wjia 2012-11-16 11:57:46 -0800 This is part of effort to support WebRTC in Chrome on Android. 770325 1 174886 wjia 2012-11-18 21:34:17 -0800 Created attachment 174886 Patch 770630 2 peter 2012-11-19 05:17:21 -0800 This will expose the feature, but will it actually work already? If I remember correctly, the run-time flag for media stream support defaults to being enabled, so unless it does work it'll break feature detection. I'd also like to know what kind of impact this has on the binary size. Together with WebRTC (and any needed non-ffmpeg components), it could add a significant amount of data. The leading WebRTC issue on Chromium for Android can be found at http://crbug.com/156384. I'll reply to the one you filed (http://crbug.com/161417) so we can have this discussion on the Chromium tracker instead. 770724 3 wjia 2012-11-19 07:17:48 -0800 It takes many steps to make WebRTC work on Android. This is the first one which enables all necessary components to build. MEDIA_STREAM in WebKit is just one of the needed components. After that, we need to make sure all components work and add the missing components such as video capture device. Regarding code size, that's a known issue. I'd have PM to discuss size issue. 770825 4 174886 abarth 2012-11-19 09:51:29 -0800 Comment on attachment 174886 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174886&action=review > Source/WebKit/chromium/features.gypi:166 > + 'ENABLE_MEDIA_STREAM=1', You should move this outside the conditional block since it isn't conditional anymore. 770827 5 abarth 2012-11-19 09:52:29 -0800 I'd like Peter to give and LGTM before we land this patch to make sure that he's happy with the change. 770828 6 abarth 2012-11-19 09:52:57 -0800 s/and/an/ 770843 7 175001 wjia 2012-11-19 10:25:08 -0800 Created attachment 175001 Patch 773013 8 175001 peter 2012-11-21 09:17:28 -0800 Comment on attachment 175001 Patch I'm removing r? for now. We're holding off with enabling Media Stream until after the Chrome 25 branch point. Thank you for uploading this patch, Wei Jia! We'll be able to land this later on. 791653 9 179491 wjia 2012-12-14 09:12:28 -0800 Created attachment 179491 Patch 791667 10 wjia 2012-12-14 09:39:08 -0800 Peter, The 3rd patch (id=179491) tries to set ENABLE_MEDIA_STREAM based on enable_webrtc. This puts all webrtc related stuff under one single flag. On Android, enable_webrtc is set to 0. So ENABLE_MEDIA_STREAM is set to 0, too. This will not change chromium on Android. 792817 11 179491 peter 2012-12-17 10:15:20 -0800 Comment on attachment 179491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=179491&action=review This seems good to me, with one minor nit. Thank you! > Source/WebKit/chromium/ChangeLog:8 > + Put all webrtc related stuff under one flag "enable_webrtc". nit: Could you clarify in the ChangeLog that the "enable_webrtc" flag is enabled for Linux, Mac and Windows builds, but disabled for Android? 792822 12 179764 wjia 2012-12-17 10:23:07 -0800 Created attachment 179764 Patch 792823 13 wjia 2012-12-17 10:24:40 -0800 Source/WebKit/chromium/ChangeLog has been updated according to the comment. 793813 14 peter 2012-12-18 10:41:52 -0800 +Eric for review. 793876 15 eric 2012-12-18 11:32:09 -0800 I lean on tc for all my gyp reviews. :) But this LGTM too. 793900 16 179764 webkit.review.bot 2012-12-18 11:59:19 -0800 Comment on attachment 179764 Patch Clearing flags on attachment: 179764 Committed r138049: <http://trac.webkit.org/changeset/138049> 793901 17 webkit.review.bot 2012-12-18 11:59:23 -0800 All reviewed patches have been landed. Closing bug. 174886 2012-11-18 21:34:17 -0800 2012-11-19 10:25:06 -0800 Patch bug-102545-20121118213208.patch text/plain 1213 wjia SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzUxMDYpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTExLTE4ICBXZWkgSmlhICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg RW5hYmxlIG1lZGlhIHN0cmVhbSBvbiBBbmRyb2lkIGZvciBDaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IEVOQUJMRV9NRURJQV9TVFJF QU0gdG8gMSBvbiBBbmRyb2lkIGJ5IGRlZmF1bHQgaW4gb3JkZXIgdG8gc3VwcG9ydCBXZWJSVEMg aW4gQ2hyb21pdW0gb24gQW5kcm9pZC4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisKIDIw MTItMTEtMTggIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzUwNDcuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL2ZlYXR1cmVzLmd5cGkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1 bS9mZWF0dXJlcy5neXBpCShyZXZpc2lvbiAxMzUxMDMpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL2ZlYXR1cmVzLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTE2Myw3ICsxNjMsNyBAQAogICAg ICAgICAgICdFTkFCTEVfSU5QVVRfVFlQRV9XRUVLPTAnLAogICAgICAgICAgICdFTkFCTEVfTEVH QUNZX05PVElGSUNBVElPTlM9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTEn LAotICAgICAgICAgICdFTkFCTEVfTUVESUFfU1RSRUFNPTAnLAorICAgICAgICAgICdFTkFCTEVf TUVESUFfU1RSRUFNPTEnLAogICAgICAgICAgICdFTkFCTEVfTk9USUZJQ0FUSU9OUz0wJywKICAg ICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0xJywKICAgICAgICAgICAnRU5BQkxF X1BBR0VfUE9QVVA9MCcsCg== 175001 2012-11-19 10:25:08 -0800 2012-12-14 09:12:27 -0800 Patch bug-102545-20121119102259.patch text/plain 1739 wjia SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzUxNzIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTExLTE4ICBXZWkgSmlhICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg RW5hYmxlIG1lZGlhIHN0cmVhbSBvbiBBbmRyb2lkIGZvciBDaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IEVOQUJMRV9NRURJQV9TVFJF QU0gdG8gMSBvbiBBbmRyb2lkIGJ5IGRlZmF1bHQgaW4gb3JkZXIgdG8gc3VwcG9ydCBXZWJSVEMg aW4gQ2hyb21pdW0gb24gQW5kcm9pZC4KKworICAgICAgICAqIGZlYXR1cmVzLmd5cGk6CisKIDIw MTItMTEtMTkgIFZpbmNlbnQgU2NoZWliICA8c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbQ2hyb21pdW1dIFJlbW92ZSBXZWJLaXQ6OldlYlJ1bnRpbWVGZWF0dXJlczo6ZW5hYmxlUG9p bnRlckxvY2suCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCShyZXZpc2lv biAxMzUxNzIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHdvcmtp bmcgY29weSkKQEAgLTg2LDYgKzg2LDcgQEAKICAgICAgICdFTkFCTEVfTUFUSE1MPTEnLAogICAg ICAgJ0VOQUJMRV9NRURJQV9TT1VSQ0U9MScsCiAgICAgICAnRU5BQkxFX01FRElBX1NUQVRJU1RJ Q1M9MScsCisgICAgICAnRU5BQkxFX01FRElBX1NUUkVBTT0xJywKICAgICAgICdFTkFCTEVfTUVU RVJfRUxFTUVOVD0xJywKICAgICAgICdFTkFCTEVfTUhUTUw9MScsCiAgICAgICAnRU5BQkxFX01J Q1JPREFUQT0wJywKQEAgLTE2NCw3ICsxNjUsNiBAQAogICAgICAgICAgICdFTkFCTEVfSU5QVVRf VFlQRV9XRUVLPTAnLAogICAgICAgICAgICdFTkFCTEVfTEVHQUNZX05PVElGSUNBVElPTlM9MCcs CiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTEnLAotICAgICAgICAgICdFTkFCTEVf TUVESUFfU1RSRUFNPTAnLAogICAgICAgICAgICdFTkFCTEVfTk9USUZJQ0FUSU9OUz0wJywKICAg ICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0xJywKICAgICAgICAgICAnRU5BQkxF X1BBR0VfUE9QVVA9MCcsCkBAIC0xODgsNyArMTg4LDYgQEAKICAgICAgICAgICAnRU5BQkxFX0lO UFVUX01VTFRJUExFX0ZJRUxEU19VST0xJywKICAgICAgICAgICAnRU5BQkxFX0xFR0FDWV9OT1RJ RklDQVRJT05TPTEnLAogICAgICAgICAgICdFTkFCTEVfTUVESUFfQ0FQVFVSRT0wJywKLSAgICAg ICAgICAnRU5BQkxFX01FRElBX1NUUkVBTT0xJywKICAgICAgICAgICAnRU5BQkxFX05PVElGSUNB VElPTlM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MCcsCiAgICAg ICAgICAgJ0VOQUJMRV9QQUdFX1BPUFVQPTEnLAo= 179491 2012-12-14 09:12:28 -0800 2012-12-17 10:23:05 -0800 Patch bug-102545-20121214090948.patch text/plain 1678 wjia SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzc3NDkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTEyLTE0ICBXZWkgSmlhICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg RW5hYmxlIG1lZGlhIHN0cmVhbSBvbiBBbmRyb2lkIGZvciBDaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHV0IGFsbCB3ZWJydGMgcmVsYXRl ZCBzdHVmZiB1bmRlciBvbmUgZmxhZyAiZW5hYmxlX3dlYnJ0YyIuCisKKyAgICAgICAgKiBmZWF0 dXJlcy5neXBpOgorCiAyMDEyLTEyLTE0ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KSW5kZXg6IFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDEzNzc0OSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtODYsNiAr ODYsNyBAQAogICAgICAgJ0VOQUJMRV9NQVRITUw9MScsCiAgICAgICAnRU5BQkxFX01FRElBX1NP VVJDRT0xJywKICAgICAgICdFTkFCTEVfTUVESUFfU1RBVElTVElDUz0xJywKKyAgICAgICdFTkFC TEVfTUVESUFfU1RSRUFNPTwoZW5hYmxlX3dlYnJ0YyknLAogICAgICAgJ0VOQUJMRV9NRVRFUl9F TEVNRU5UPTEnLAogICAgICAgJ0VOQUJMRV9NSFRNTD0xJywKICAgICAgICdFTkFCTEVfTUlDUk9E QVRBPTAnLApAQCAtMTY4LDcgKzE2OSw2IEBACiAgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBF X1dFRUs9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9MRUdBQ1lfTk9USUZJQ0FUSU9OUz0wJywKICAg ICAgICAgICAnRU5BQkxFX01FRElBX0NBUFRVUkU9MScsCi0gICAgICAgICAgJ0VOQUJMRV9NRURJ QV9TVFJFQU09MCcsCiAgICAgICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTAnLAogICAgICAg ICAgICdFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEnLAogICAgICAgICAgICdFTkFCTEVfUEFH RV9QT1BVUD0wJywKQEAgLTE5Miw3ICsxOTIsNiBAQAogICAgICAgICAgICdFTkFCTEVfSU5QVVRf TVVMVElQTEVfRklFTERTX1VJPTEnLAogICAgICAgICAgICdFTkFCTEVfTEVHQUNZX05PVElGSUNB VElPTlM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTAnLAotICAgICAgICAg ICdFTkFCTEVfTUVESUFfU1RSRUFNPTEnLAogICAgICAgICAgICdFTkFCTEVfTk9USUZJQ0FUSU9O Uz0xJywKICAgICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKICAgICAgICAg ICAnRU5BQkxFX1BBR0VfUE9QVVA9MScsCg== 179764 2012-12-17 10:23:07 -0800 2012-12-18 11:59:18 -0800 Patch bug-102545-20121217102025.patch text/plain 1795 wjia SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzc5MTcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEyLTE0ICBXZWkgSmlhICA8d2ppYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg RW5hYmxlIG1lZGlhIHN0cmVhbSBvbiBBbmRyb2lkIGZvciBDaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHV0IGFsbCB3ZWJydGMgcmVsYXRl ZCBzdHVmZiB1bmRlciBvbmUgZmxhZyAiZW5hYmxlX3dlYnJ0YyIgd2hpY2ggaXMgc2V0IHRvIDEK KyAgICAgICAgb24gTGludXgvV2luZG93cy9NYWMgYW5kIDAgb24gQW5kcm9pZC4KKworICAgICAg ICAqIGZlYXR1cmVzLmd5cGk6CisKIDIwMTItMTItMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW2Nocm9taXVtXSBtYWtl IHRvb2xiYXIgcmVuZGVyIHdpdGggTW91bnRhaW4gTGlvbi1mcmllbmRseSBjb2xvcnMKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHJldmlzaW9uIDEzNzkxNykKKysrIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtODYs NiArODYsNyBAQAogICAgICAgJ0VOQUJMRV9NQVRITUw9MScsCiAgICAgICAnRU5BQkxFX01FRElB X1NPVVJDRT0xJywKICAgICAgICdFTkFCTEVfTUVESUFfU1RBVElTVElDUz0xJywKKyAgICAgICdF TkFCTEVfTUVESUFfU1RSRUFNPTwoZW5hYmxlX3dlYnJ0YyknLAogICAgICAgJ0VOQUJMRV9NRVRF Ul9FTEVNRU5UPTEnLAogICAgICAgJ0VOQUJMRV9NSFRNTD0xJywKICAgICAgICdFTkFCTEVfTUlD Uk9EQVRBPTAnLApAQCAtMTY3LDcgKzE2OCw2IEBACiAgICAgICAgICAgJ0VOQUJMRV9JTlBVVF9U WVBFX1dFRUs9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9MRUdBQ1lfTk9USUZJQ0FUSU9OUz0wJywK ICAgICAgICAgICAnRU5BQkxFX01FRElBX0NBUFRVUkU9MScsCi0gICAgICAgICAgJ0VOQUJMRV9N RURJQV9TVFJFQU09MCcsCiAgICAgICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTAnLAogICAg ICAgICAgICdFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEnLAogICAgICAgICAgICdFTkFCTEVf UEFHRV9QT1BVUD0wJywKQEAgLTE5MSw3ICsxOTEsNiBAQAogICAgICAgICAgICdFTkFCTEVfSU5Q VVRfTVVMVElQTEVfRklFTERTX1VJPTEnLAogICAgICAgICAgICdFTkFCTEVfTEVHQUNZX05PVElG SUNBVElPTlM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTAnLAotICAgICAg ICAgICdFTkFCTEVfTUVESUFfU1RSRUFNPTEnLAogICAgICAgICAgICdFTkFCTEVfTk9USUZJQ0FU SU9OUz0xJywKICAgICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKICAgICAg ICAgICAnRU5BQkxFX1BBR0VfUE9QVVA9MScsCg==