102540 2012-11-16 11:11:12 -0800 Checkerboard flicker when pinch zooming out on google.com/nwshp 2012-11-16 13:01:41 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 manyoso manyoso mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 769476 0 manyoso 2012-11-16 11:11:12 -0800 This happens because the tile matrix is changing while the pinch zoom is continuing. 769477 1 manyoso 2012-11-16 11:11:52 -0800 I'm going to fix this by disabling updates to the backingstore tile matrix when backingstore updates are disabled. This will prevent changes to the tile matrix when we are in the middle of a pinch zoom which can cause checkebroard flickering. 769484 2 174723 manyoso 2012-11-16 11:14:36 -0800 Created attachment 174723 Patch 769603 3 174723 webkit.review.bot 2012-11-16 13:01:36 -0800 Comment on attachment 174723 Patch Clearing flags on attachment: 174723 Committed r134990: <http://trac.webkit.org/changeset/134990> 769604 4 webkit.review.bot 2012-11-16 13:01:41 -0800 All reviewed patches have been landed. Closing bug. 174723 2012-11-16 11:14:36 -0800 2012-11-16 13:01:36 -0800 Patch webkit_245827_v2.patch text/plain 7330 manyoso Y29tbWl0IDc5YzU4NDUzZThlZTRmOTI3NjhlMTY2Yjk3MTI3YjhhNzk3YWY1NWMKQXV0aG9yOiBB ZGFtIFRyZWF0IDxhdHJlYXRAcmltLmNvbT4KRGF0ZTogICBGcmkgTm92IDE2IDExOjA1OjExIDIw MTIgLTA1MDAKCiAgICAyMDEyLTExLTE2ICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAg ICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAKICAgICAgICAg ICAgRGlzYWJsZSB1cGRhdGVzIHRvIHRoZSBiYWNraW5nc3RvcmUgdGlsZSBtYXRyaXggd2hlbiBi YWNraW5nc3RvcmUgdXBkYXRlcwogICAgICAgICAgICBhcmUgZGlzYWJsZWQuICBUaGlzIHByZXZl bnRzIGNoYW5nZXMgdG8gdGhlIHRpbGUgbWF0cml4IHdoZW4gd2UgYXJlIGluIHRoZQogICAgICAg ICAgICBtaWRkbGUgb2YgYSBwaW5jaCB6b29tIHdoaWNoIGNhbiBjYXVzZSBjaGVja2Vicm9hcmQg ZmxpY2tlcmluZy4KICAgIAogICAgICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmUuY3BwOgogICAg ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpCYWNraW5n U3RvcmVQcml2YXRlKToKICAgICAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0 b3JlUHJpdmF0ZTo6cmVzdW1lQmFja2luZ1N0b3JlVXBkYXRlcyk6CiAgICAgICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OnNldEJhY2tpbmdTdG9yZVJlY3Qp OgogICAgICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpy ZW5kZXIpOgogICAgICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmVfcC5oOgogICAgICAgICAgICAo QmFja2luZ1N0b3JlUHJpdmF0ZSk6CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCmluZGV4IDk1YmFjN2UuLmQyYjMwOGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKQEAgLTE5OCw2ICsxOTgsNyBAQCBC YWNraW5nU3RvcmVQcml2YXRlOjpCYWNraW5nU3RvcmVQcml2YXRlKCkKICAgICAsIG1fcmVzdW1l T3BlcmF0aW9uKEJhY2tpbmdTdG9yZTo6Tm9uZSkKICAgICAsIG1fc3VzcGVuZFJlbmRlckpvYnMo ZmFsc2UpCiAgICAgLCBtX3N1c3BlbmRSZWd1bGFyUmVuZGVySm9icyhmYWxzZSkKKyAgICAsIG1f dGlsZU1hdHJpeE5lZWRzVXBkYXRlKGZhbHNlKQogICAgICwgbV9pc1Njcm9sbGluZ09yWm9vbWlu ZyhmYWxzZSkKICAgICAsIG1fd2ViUGFnZSgwKQogICAgICwgbV9jbGllbnQoMCkKQEAgLTMwNCwx OCArMzA1LDIzIEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6c3VzcGVuZFNjcmVlblVwZGF0 ZXMoKQogCiB2b2lkIEJhY2tpbmdTdG9yZVByaXZhdGU6OnJlc3VtZUJhY2tpbmdTdG9yZVVwZGF0 ZXMoKQogewotICAgIGJvb2wgaXNTdXNwZW5kZWQgPSBhdG9taWNfYWRkX3ZhbHVlKCZtX3N1c3Bl bmRCYWNraW5nU3RvcmVVcGRhdGVzLCAwKSA+PSAxOwotICAgIEFTU0VSVChpc1N1c3BlbmRlZCk7 Ci0gICAgaWYgKCFpc1N1c3BlbmRlZCkgeworICAgIHVuc2lnbmVkIGN1cnJlbnRWYWx1ZSA9IGF0 b21pY19hZGRfdmFsdWUoJm1fc3VzcGVuZEJhY2tpbmdTdG9yZVVwZGF0ZXMsIDApOworICAgIEFT U0VSVChjdXJyZW50VmFsdWUgPj0gMSk7CisgICAgaWYgKGN1cnJlbnRWYWx1ZSA8IDEpIHsKICAg ICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OmxvZ0Fsd2F5cyhCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6TG9nTGV2ZWxDcml0aWNhbCwKICAgICAgICAgICAgICJDYWxsIG1pc21hdGNoOiBCYWNraW5n c3RvcmUgaGFzbid0IGJlZW4gc3VzcGVuZGVkLCB0aGVyZWZvcmUgd29uJ3QgcmVzdW1lISIpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgLy8gU2V0IGEgZmxhZyBpbmRpY2F0aW5nIHRo YXQgd2UncmUgYWJvdXQgdG8gcmVzdW1lIGJhY2tpbmdzdG9yZSB1cGRhdGVzIGFuZAorICAgIC8v IHRoZSB0aWxlIG1hdHJpeCBzaG91bGQgYmUgdXBkYXRlZCBhcyBhIGNvbnNlcXVlbmNlIGJ5IHRo ZSBmaXJzdCByZW5kZXIKKyAgICAvLyBqb2IgdGhhdCBoYXBwZW5zIGFmdGVyIHRoaXMgcmVzdW1w dGlvbiBvZiBiYWNraW5nc3RvcmUgdXBkYXRlcy4KKyAgICBpZiAoY3VycmVudFZhbHVlID09IDEp CisgICAgICAgIHNldFRpbGVNYXRyaXhOZWVkc1VwZGF0ZSgpOworCiAgICAgYXRvbWljX3N1Yigm bV9zdXNwZW5kQmFja2luZ1N0b3JlVXBkYXRlcywgMSk7CiB9CiAKLQogdm9pZCBCYWNraW5nU3Rv cmVQcml2YXRlOjpyZXN1bWVTY3JlZW5VcGRhdGVzKEJhY2tpbmdTdG9yZTo6UmVzdW1lVXBkYXRl T3BlcmF0aW9uIG9wKQogewogICAgIEFTU0VSVChtX3N1c3BlbmRTY3JlZW5VcGRhdGVzKTsKQEAg LTcxNSw2ICs3MjEsOSBAQCB2b2lkIEJhY2tpbmdTdG9yZVByaXZhdGU6OnNldEJhY2tpbmdTdG9y ZVJlY3QoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGJhY2tpbmdTdAogICAgICAgICByZXR1cm47 CiAgICAgfQogCisgICAgaWYgKG1fc3VzcGVuZEJhY2tpbmdTdG9yZVVwZGF0ZXMpCisgICAgICAg IHJldHVybjsKKwogICAgIFBsYXRmb3JtOjpJbnRSZWN0IGN1cnJlbnRCYWNraW5nU3RvcmVSZWN0 ID0gZnJvbnRTdGF0ZSgpLT5iYWNraW5nU3RvcmVSZWN0KCk7CiAgICAgZG91YmxlIGN1cnJlbnRT Y2FsZSA9IGZyb250U3RhdGUoKS0+c2NhbGUoKTsKIApAQCAtMTA1Myw2ICsxMDYyLDExIEBAIGJv b2wgQmFja2luZ1N0b3JlUHJpdmF0ZTo6cmVuZGVyKGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBy ZWN0KQogICAgIGlmICghaXNBY3RpdmUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAg Ly8gVGhpcyBpcyB0aGUgZmlyc3QgcmVuZGVyIGpvYiB0aGF0IGhhcyBiZWVuIHBlcmZvcm1lZCBz aW5jZSByZXN1bXB0aW9uIG9mCisgICAgLy8gYmFja2luZ3N0b3JlIHVwZGF0ZXMgYW5kIHRoZSB0 aWxlIG1hdHJpeCBuZWVkcyB1cGRhdGluZyBzaW5jZSB3ZSBzdXNwZW5kCisgICAgLy8gdGlsZSBt YXRyaXggdXBkYXRpbmcgd2l0aCBiYWNraW5nc3RvcmUgdXBkYXRlcworICAgIHVwZGF0ZVRpbGVN YXRyaXhJZk5lZWRlZCgpOworCiAgICAgVGlsZVJlY3RMaXN0IHRpbGVSZWN0TGlzdCA9IG1hcEZy b21UcmFuc2Zvcm1lZENvbnRlbnRzVG9UaWxlcyhyZWN0KTsKICAgICBpZiAodGlsZVJlY3RMaXN0 LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTE2MSw2ICsxMTc1LDcgQEAg dm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpyZXF1ZXN0TGF5b3V0SWZOZWVkZWQoKSBjb25zdAog CiBib29sIEJhY2tpbmdTdG9yZVByaXZhdGU6OnJlbmRlclZpc2libGVDb250ZW50cygpCiB7Cisg ICAgdXBkYXRlVGlsZU1hdHJpeElmTmVlZGVkKCk7CiAgICAgUGxhdGZvcm06OkludFJlY3QgcmVu ZGVyUmVjdCA9IHNob3VsZERpcmVjdFJlbmRlcmluZ1RvV2luZG93KCkgPyB2aXNpYmxlQ29udGVu dHNSZWN0KCkgOiB2aXNpYmxlVGlsZXNSZWN0KCk7CiAgICAgaWYgKHJlbmRlcihyZW5kZXJSZWN0 KSkgewogICAgICAgICBtX3JlbmRlclF1ZXVlLT5jbGVhcihyZW5kZXJSZWN0LCB0cnVlIC8qY2xl YXJSZWd1bGFyUmVuZGVySm9icyovKTsKQEAgLTExNzEsNiArMTE4Niw3IEBAIGJvb2wgQmFja2lu Z1N0b3JlUHJpdmF0ZTo6cmVuZGVyVmlzaWJsZUNvbnRlbnRzKCkKIAogYm9vbCBCYWNraW5nU3Rv cmVQcml2YXRlOjpyZW5kZXJCYWNraW5nU3RvcmUoKQogeworICAgIHVwZGF0ZVRpbGVNYXRyaXhJ Zk5lZWRlZCgpOwogICAgIHJldHVybiByZW5kZXIoZnJvbnRTdGF0ZSgpLT5iYWNraW5nU3RvcmVS ZWN0KCkpOwogfQogCkBAIC0xOTc2LDEyICsxOTkyLDE4IEBAIHZvaWQgQmFja2luZ1N0b3JlUHJp dmF0ZTo6dXBkYXRlVGlsZU1hdHJpeElmTmVlZGVkKCkKIHsKICAgICBBU1NFUlQoQmxhY2tCZXJy eTo6UGxhdGZvcm06OndlYktpdFRocmVhZE1lc3NhZ2VDbGllbnQoKS0+aXNDdXJyZW50VGhyZWFk KCkpOwogCisgICAgaWYgKCFtX3RpbGVNYXRyaXhOZWVkc1VwZGF0ZSkKKyAgICAgICAgcmV0dXJu OworCisgICAgbV90aWxlTWF0cml4TmVlZHNVcGRhdGUgPSBmYWxzZTsKKwogICAgIC8vIFRoaXMg d2lsbCB1cGRhdGUgdGhlIHRpbGUgbWF0cml4LgogICAgIHNjcm9sbEJhY2tpbmdTdG9yZSgwLCAw KTsKIH0KIAogdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpjb250ZW50c1NpemVDaGFuZ2VkKGNv bnN0IFBsYXRmb3JtOjpJbnRTaXplJikKIHsKKyAgICBzZXRUaWxlTWF0cml4TmVlZHNVcGRhdGUo KTsKICAgICB1cGRhdGVUaWxlTWF0cml4SWZOZWVkZWQoKTsKIH0KIApAQCAtMjA1MCw2ICsyMDcy LDcgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjp0cmFuc2Zvcm1DaGFuZ2VkKCkKIHZvaWQg QmFja2luZ1N0b3JlUHJpdmF0ZTo6b3JpZW50YXRpb25DaGFuZ2VkKCkKIHsKICAgICBBU1NFUlQo QmxhY2tCZXJyeTo6UGxhdGZvcm06OndlYktpdFRocmVhZE1lc3NhZ2VDbGllbnQoKS0+aXNDdXJy ZW50VGhyZWFkKCkpOworICAgIHNldFRpbGVNYXRyaXhOZWVkc1VwZGF0ZSgpOwogICAgIHVwZGF0 ZVRpbGVNYXRyaXhJZk5lZWRlZCgpOwogICAgIGNyZWF0ZVZpc2libGVUaWxlQnVmZmVyKCk7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZV9w LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZV9wLmgKaW5kZXgg YjlhNmU3Yi4uNDU1MjE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9CYWNraW5nU3RvcmVfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFj a2luZ1N0b3JlX3AuaApAQCAtMjgyLDYgKzI4Miw3IEBAIHB1YmxpYzoKICAgICBUaWxlUmVjdExp c3QgbWFwRnJvbVRyYW5zZm9ybWVkQ29udGVudHNUb1RpbGVzKGNvbnN0IFBsYXRmb3JtOjpJbnRS ZWN0JikgY29uc3Q7CiAgICAgVGlsZVJlY3RMaXN0IG1hcEZyb21UcmFuc2Zvcm1lZENvbnRlbnRz VG9UaWxlcyhjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYsIEJhY2tpbmdTdG9yZUdlb21ldHJ5Kikg Y29uc3Q7CiAKKyAgICB2b2lkIHNldFRpbGVNYXRyaXhOZWVkc1VwZGF0ZSgpIHsgbV90aWxlTWF0 cml4TmVlZHNVcGRhdGUgPSB0cnVlOyB9CiAgICAgdm9pZCB1cGRhdGVUaWxlTWF0cml4SWZOZWVk ZWQoKTsKIAogICAgIC8vIENhbGxlZCBieSBXZWJQYWdlUHJpdmF0ZTo6bm90aWZ5VHJhbnNmb3Jt ZWRDb250ZW50c1NpemVDaGFuZ2VkLgpAQCAtMzY0LDYgKzM2NSw3IEBAIHB1YmxpYzoKIAogICAg IGJvb2wgbV9zdXNwZW5kUmVuZGVySm9iczsKICAgICBib29sIG1fc3VzcGVuZFJlZ3VsYXJSZW5k ZXJKb2JzOworICAgIGJvb2wgbV90aWxlTWF0cml4TmVlZHNVcGRhdGU7CiAgICAgYm9vbCBtX2lz U2Nyb2xsaW5nT3Jab29taW5nOwogICAgIFdlYlBhZ2UqIG1fd2ViUGFnZTsKICAgICBCYWNraW5n U3RvcmVDbGllbnQqIG1fY2xpZW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXgg MzMzMDgwMy4uYjIzYjEzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDUg KzEsMzEgQEAKIDIwMTItMTEtMTYgIEFkYW0gVHJlYXQgIDxhdHJlYXRAcmltLmNvbT4KIAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTQwCisgICAg ICAgIFtCbGFja0JlcnJ5XSBDaGVja2VyYm9hcmQgZmxpY2tlciB3aGVuIHBpbmNoIHpvb21pbmcg b3V0IG9uIGdvb2dsZS5jb20vbndzaHAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgUFIgMjQ1ODI3CisKKyAgICAgICAgRGlzYWJsZSB1cGRhdGVzIHRvIHRo ZSBiYWNraW5nc3RvcmUgdGlsZSBtYXRyaXggd2hlbiBiYWNraW5nc3RvcmUgdXBkYXRlcworICAg ICAgICBhcmUgZGlzYWJsZWQuICBUaGlzIHByZXZlbnRzIGNoYW5nZXMgdG8gdGhlIHRpbGUgbWF0 cml4IHdoZW4gd2UgYXJlIGluIHRoZQorICAgICAgICBtaWRkbGUgb2YgYSBwaW5jaCB6b29tIHdo aWNoIGNhbiBjYXVzZSBjaGVja2Vicm9hcmQgZmxpY2tlcmluZy4KKworICAgICAgICAqIEFwaS9C YWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3Rv cmVQcml2YXRlOjpCYWNraW5nU3RvcmVQcml2YXRlKToKKyAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6cmVzdW1lQmFja2luZ1N0b3JlVXBkYXRlcyk6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OnNldEJhY2tp bmdTdG9yZVJlY3QpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQ cml2YXRlOjpyZW5kZXIpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3Rv cmVQcml2YXRlOjpyZW5kZXJWaXNpYmxlQ29udGVudHMpOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpyZW5kZXJCYWNraW5nU3RvcmUpOgorICAgICAg ICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjp1cGRhdGVUaWxlTWF0 cml4SWZOZWVkZWQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQ cml2YXRlOjpjb250ZW50c1NpemVDaGFuZ2VkKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktp dDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6b3JpZW50YXRpb25DaGFuZ2VkKToKKyAgICAgICAgKiBB cGkvQmFja2luZ1N0b3JlX3AuaDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlUHJpdmF0ZTo6c2V0VGlsZU1hdHJpeE5lZWRzVXBkYXRlKToKKyAgICAgICAgKEJhY2tp bmdTdG9yZVByaXZhdGUpOgorCisyMDEyLTExLTE2ICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5j b20+CisKICAgICAgICAgW0JsYWNrQmVycnldIEZpeCByZWdyZXNzaW9uIGNhdXNpbmcgY2hlY2tl cmJvYXJkIGZsaWNrZXIgYWZ0ZXIgYXBwIHdha2UtdXAKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjUyNgogCg==