102535 2012-11-16 10:49:26 -0800 [Chromium] Need spellcheck suggestions even if continuous check is off. 2012-11-20 19:14:01 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 groby groby morrita webkit.review.bot oldest_to_newest 769444 0 groby 2012-11-16 10:49:26 -0800 A list of spelling suggestions should appear in the contextual menu when right clicking on incorrect words, even if "Check Spelling While Typing" is off. (See http://crbug.com/161030) (Unrelated note: Should there be a "WebKit Chromium" component?) 769445 1 174720 groby 2012-11-16 10:51:36 -0800 Created attachment 174720 Patch 771986 2 174720 groby 2012-11-20 10:33:10 -0800 Comment on attachment 174720 Patch Can I have a cq+, please? 772351 3 morrita 2012-11-20 18:11:13 -0800 > (From update of attachment 174720 [details]) > Can I have a cq+, please? Done. 772380 4 174720 webkit.review.bot 2012-11-20 19:13:58 -0800 Comment on attachment 174720 Patch Clearing flags on attachment: 174720 Committed r135342: <http://trac.webkit.org/changeset/135342> 772381 5 webkit.review.bot 2012-11-20 19:14:01 -0800 All reviewed patches have been landed. Closing bug. 174720 2012-11-16 10:51:36 -0800 2012-11-20 19:13:58 -0800 Patch bug-102535-20121116104933.patch text/plain 2020 groby U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFmOTY1MzY4OGZhNTkwOWVkZjdmOGExZTVhOWMyZDcwZGUzNzZiZGUuLjIyMDNjOWY1MDJmMTJi YjY1MDM2NzI4MzllMDA3MTEyZDMyZjI3ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMTYgIFJhY2hlbCBCbHVtICA8Z3JvYnlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gTmVlZCBzcGVsbGNoZWNrIHN1Z2dlc3Rpb25zIGV2 ZW4gaWYgY29udGludW91cyBjaGVjayBpcyBvZmYuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdGhlIGNvbnRleHQgbWVudSBhbHdheXMg aGFzIHN1Z2dlc3Rpb25zIGZvciBtaXNzcGVsbGVkIHdvcmRzLgorCisgICAgICAgICogc3JjL0Nv bnRleHRNZW51Q2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvbnRleHRNZW51Q2xp ZW50SW1wbDo6Z2V0Q3VzdG9tTWVudUZyb21EZWZhdWx0SXRlbXMpOgorCiAyMDEyLTExLTE0ICBK b3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBS ZW1vdmUgbWFnaWMgbnVtYmVycyBpbiByZWNvcmQgY29tcGFyYXRvciwgaGFuZGxlIG1pc3Npbmcg Y2FzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVD bGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xp ZW50SW1wbC5jcHAKaW5kZXggOTU1NDYwMDcyYmI4MWE1NTI2ZDkxY2JjMTQ0MzQ4NThlYWMyZGRh My4uMmNmZTkwYTNmYmU0YjJlY2MwZWMyNzEyNjI0MDU4ZTgzZDA2ZGI4MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCkBA IC0yOTgsOCArMjk4LDkgQEAgUGxhdGZvcm1NZW51RGVzY3JpcHRpb24gQ29udGV4dE1lbnVDbGll bnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcygKICAgICAgICAgICAgICAgICAg ICAgICAgIHNlbGVjdGVkRnJhbWUtPnNlbGVjdGlvbigpLT5zZXRTZWxlY3Rpb24oc2VsZWN0aW9u LCBXb3JkR3JhbnVsYXJpdHkpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KLSAg ICAgICAgfSBlbHNlIGlmIChtX3dlYlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9y KCktPmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkKCkpIHsKLSAgICAgICAgICAgIGRh dGEuaXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IHRydWU7CisgICAgICAgIH0gZWxzZSB7CisgICAg ICAgICAgICBkYXRhLmlzU3BlbGxDaGVja2luZ0VuYWJsZWQgPSAKKyAgICAgICAgICAgICAgICBt X3dlYlZpZXctPmZvY3VzZWRXZWJDb3JlRnJhbWUoKS0+ZWRpdG9yKCktPmlzQ29udGludW91c1Nw ZWxsQ2hlY2tpbmdFbmFibGVkKCk7CiAgICAgICAgICAgICAvLyBTcGVsbGNoZWNraW5nIG1pZ2h0 IGJlIGVuYWJsZWQgZm9yIHRoZSBmaWVsZCwgYnV0IGNvdWxkIGJlIGRpc2FibGVkIG9uIHRoZSBu b2RlLgogICAgICAgICAgICAgaWYgKG1fd2ViVmlldy0+Zm9jdXNlZFdlYkNvcmVGcmFtZSgpLT5l ZGl0b3IoKS0+aXNTcGVsbENoZWNraW5nRW5hYmxlZEluRm9jdXNlZE5vZGUoKSkgewogICAgICAg ICAgICAgICAgIGRhdGEubWlzc3BlbGxlZFdvcmQgPSBzZWxlY3RNaXNzcGVsbGVkV29yZChkZWZh dWx0TWVudSwgc2VsZWN0ZWRGcmFtZSk7Cg==