102531 2012-11-16 09:56:43 -0800 [EFL][WK2] Web Inspector crashes if evas_gl is not available 2012-11-19 13:48:26 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 769392 0 yael 2012-11-16 09:56:43 -0800 We need to teach Web Inspector to fallback gracefully to the software path when evas_gl engine is not available. A patch is coming. 769395 1 174713 yael 2012-11-16 10:00:14 -0800 Created attachment 174713 Patch 770950 2 174713 kenneth 2012-11-19 12:38:42 -0800 Comment on attachment 174713 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93 > + if (!m_inspectorWindow) I would add comment here // Gracefully fall back to software if evas_gl engine is not available. 770984 3 175032 yael 2012-11-19 13:11:49 -0800 Created attachment 175032 Patch (In reply to comment #2) > (From update of attachment 174713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review > > > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93 > > + if (!m_inspectorWindow) > > I would add comment here // Gracefully fall back to software if evas_gl engine is not available. Thank you for the review, I added the comment. I am not adding a warning as was done for the view, since Evas already gives a warning. 770986 4 175033 yael 2012-11-19 13:16:34 -0800 Created attachment 175033 Patch Forgot to update the reviewer name. 771002 5 175033 webkit.review.bot 2012-11-19 13:48:21 -0800 Comment on attachment 175033 Patch Clearing flags on attachment: 175033 Committed r135194: <http://trac.webkit.org/changeset/135194> 771003 6 webkit.review.bot 2012-11-19 13:48:26 -0800 All reviewed patches have been landed. Closing bug. 174713 2012-11-16 10:00:14 -0800 2012-11-19 13:11:49 -0800 Patch 102531.patch text/plain 1606 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVj dG9yUHJveHlFZmwuY3BwCShyZXZpc2lvbiAxMzQ4NjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTAs OSArOTAsMTAgQEAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIGRlZmluZWQg SEFWRV9FQ09SRV9YCiAgICAgY29uc3QgY2hhciogZW5naW5lID0gIm9wZW5nbF94MTEiOwogICAg IG1faW5zcGVjdG9yV2luZG93ID0gZWNvcmVfZXZhc19uZXcoZW5naW5lLCAwLCAwLCBpbml0aWFs V2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQsIDApOwotI2Vsc2UKLSAgICBtX2luc3Bl Y3RvcldpbmRvdyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIGluaXRpYWxXaW5kb3dXaWR0aCwg aW5pdGlhbFdpbmRvd0hlaWdodCwgMCk7CisgICAgaWYgKCFtX2luc3BlY3RvcldpbmRvdykKICNl bmRpZgorICAgICAgICBtX2luc3BlY3RvcldpbmRvdyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAs IGluaXRpYWxXaW5kb3dXaWR0aCwgaW5pdGlhbFdpbmRvd0hlaWdodCwgMCk7CisKICAgICBpZiAo IW1faW5zcGVjdG9yV2luZG93KQogICAgICAgICByZXR1cm4gMDsKIApJbmRleDogU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwko cmV2aXNpb24gMTM0ODY4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMTYgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy b25AaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gV2ViIEluc3BlY3RvciBjcmFzaGVz IGlmIGV2YXNfZ2wgaXMgbm90IGF2YWlsYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGVhY2ggV2ViIEluc3BlY3RvciB0byBmYWxsYmFjayBncmFj ZWZ1bGx5IHRvIHRoZSBzb2Z0d2FyZSBwYXRoIHdoZW4gZXZhc19nbCBlbmdpbmUgaXMgbm90IGF2 YWlsYWJsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJ bnNwZWN0b3JQYWdlKToKKwogMjAxMi0xMS0xNSAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBj b21wYW55MTAwLm5ldD4KIAogICAgICAgICBDb29yZGluYXRlZCBHcmFwaGljczogQSBNaW5vciBv cHRpbWl6YXRpb24gb2YgY2FsY3VsYXRpbmcgdHJhbnNmb3JtcyBpbiBDb29yZGluYWdlZEdyYXBo aWNzTGF5ZXIuCg== 175032 2012-11-19 13:11:49 -0800 2012-11-19 13:16:34 -0800 Patch 102531.patch text/plain 1637 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVj dG9yUHJveHlFZmwuY3BwCShyZXZpc2lvbiAxMzUwNTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTAs OSArOTAsMTEgQEAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIGRlZmluZWQg SEFWRV9FQ09SRV9YCiAgICAgY29uc3QgY2hhciogZW5naW5lID0gIm9wZW5nbF94MTEiOwogICAg IG1faW5zcGVjdG9yV2luZG93ID0gZWNvcmVfZXZhc19uZXcoZW5naW5lLCAwLCAwLCBpbml0aWFs V2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQsIDApOwotI2Vsc2UKLSAgICBtX2luc3Bl Y3RvcldpbmRvdyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIGluaXRpYWxXaW5kb3dXaWR0aCwg aW5pdGlhbFdpbmRvd0hlaWdodCwgMCk7CisKKyAgICAvLyBHcmFjZWZ1bGx5IGZhbGwgYmFjayB0 byBzb2Z0d2FyZSBpZiBldmFzX2dsIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlLgorICAgIGlmICgh bV9pbnNwZWN0b3JXaW5kb3cpCiAjZW5kaWYKKyAgICAgICAgbV9pbnNwZWN0b3JXaW5kb3cgPSBl Y29yZV9ldmFzX25ldygwLCAwLCAwLCBpbml0aWFsV2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dI ZWlnaHQsIDApOwogICAgIGlmICghbV9pbnNwZWN0b3JXaW5kb3cpCiAgICAgICAgIHJldHVybiAw OwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzUwNTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0xOSAgWWFl bCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBX ZWIgSW5zcGVjdG9yIGNyYXNoZXMgaWYgZXZhc19nbCBpcyBub3QgYXZhaWxhYmxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI1MzEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZWFjaCBXZWIgSW5zcGVj dG9yIHRvIGZhbGxiYWNrIGdyYWNlZnVsbHkgdG8gdGhlIHNvZnR3YXJlIHBhdGggd2hlbiBldmFz X2dsIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlLgorCisgICAgICAgICogVUlQcm9jZXNzL2VmbC9X ZWJJbnNwZWN0b3JQcm94eUVmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclBy b3h5OjpwbGF0Zm9ybUNyZWF0ZUluc3BlY3RvclBhZ2UpOgorCiAyMDEyLTExLTE3ICBCYWxhenMg S2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICA4Yml0LXVuYXdhcmUgU3Ry aW5nIHVzYWdlIGluIE5ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNwcAo= 175033 2012-11-19 13:16:34 -0800 2012-11-19 13:48:21 -0800 Patch 102531.patch text/plain 1649 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNTA1MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE5ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFdlYiBJ bnNwZWN0b3IgY3Jhc2hlcyBpZiBldmFzX2dsIGlzIG5vdCBhdmFpbGFibGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjUzMQorCisgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgorCisgICAgICAgIFRlYWNoIFdl YiBJbnNwZWN0b3IgdG8gZmFsbGJhY2sgZ3JhY2VmdWxseSB0byB0aGUgc29mdHdhcmUgcGF0aCB3 aGVuIGV2YXNfZ2wgZW5naW5lIGlzIG5vdCBhdmFpbGFibGUuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5z cGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSk6CisKIDIwMTItMTEtMTcg IEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIDhiaXQtdW5h d2FyZSBTdHJpbmcgdXNhZ2UgaW4gTmV0c2NhcGVQbHVnaW5Nb2R1bGVYMTEuY3BwCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5 RWZsLmNwcAkocmV2aXNpb24gMTM1MDUxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2Vm bC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkwLDkgKzkwLDEx IEBACiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKSAmJiBkZWZpbmVkIEhBVkVfRUNP UkVfWAogICAgIGNvbnN0IGNoYXIqIGVuZ2luZSA9ICJvcGVuZ2xfeDExIjsKICAgICBtX2luc3Bl Y3RvcldpbmRvdyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgaW5pdGlhbFdpbmRvd1dp ZHRoLCBpbml0aWFsV2luZG93SGVpZ2h0LCAwKTsKLSNlbHNlCi0gICAgbV9pbnNwZWN0b3JXaW5k b3cgPSBlY29yZV9ldmFzX25ldygwLCAwLCAwLCBpbml0aWFsV2luZG93V2lkdGgsIGluaXRpYWxX aW5kb3dIZWlnaHQsIDApOworCisgICAgLy8gR3JhY2VmdWxseSBmYWxsIGJhY2sgdG8gc29mdHdh cmUgaWYgZXZhc19nbCBlbmdpbmUgaXMgbm90IGF2YWlsYWJsZS4KKyAgICBpZiAoIW1faW5zcGVj dG9yV2luZG93KQogI2VuZGlmCisgICAgICAgIG1faW5zcGVjdG9yV2luZG93ID0gZWNvcmVfZXZh c19uZXcoMCwgMCwgMCwgaW5pdGlhbFdpbmRvd1dpZHRoLCBpbml0aWFsV2luZG93SGVpZ2h0LCAw KTsKICAgICBpZiAoIW1faW5zcGVjdG9yV2luZG93KQogICAgICAgICByZXR1cm4gMDsKIAo=