102526 2012-11-16 09:11:20 -0800 Fix regression causing checkerboard flicker after app wake-up 2012-11-16 11:48:43 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 manyoso manyoso mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 769339 0 manyoso 2012-11-16 09:11:20 -0800 PR 245027 The webkit patch for 219976 introduced an undesirable behavior change resulting in a regression where there was checkerboard flickering on resuming from an inactive application state. This patch restores the previous behavior and fixes the regression. Reviewed internally by Jakob. 769341 1 174705 manyoso 2012-11-16 09:12:29 -0800 Created attachment 174705 Patch 769345 2 webkit.review.bot 2012-11-16 09:15:59 -0800 Attachment 174705 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BackingStore...." exit_code: 1 Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 769376 3 174710 manyoso 2012-11-16 09:47:52 -0800 Created attachment 174710 v2 Fixed the changelog 769532 4 174710 webkit.review.bot 2012-11-16 11:48:40 -0800 Comment on attachment 174710 v2 Clearing flags on attachment: 174710 Committed r134978: <http://trac.webkit.org/changeset/134978> 769534 5 webkit.review.bot 2012-11-16 11:48:43 -0800 All reviewed patches have been landed. Closing bug. 174705 2012-11-16 09:12:29 -0800 2012-11-16 09:47:52 -0800 Patch webkit_245027_v2.patch text/plain 2549 manyoso Y29tbWl0IDY3NmI5ODE4YjRmMzBhMzY0NzM4ZjA4ZmFiNmQxNGI3ZTcwM2RiOTIKQXV0aG9yOiBB ZGFtIFRyZWF0IDxhdHJlYXRAcmltLmNvbT4KRGF0ZTogICBGcmkgTm92IDE2IDExOjQyOjE1IDIw MTIgLTA1MDAKCiAgICAyMDEyLTExLTE2ICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAg ICAKICAgICAgICAgICAgUFIgMjQ1MDI3CiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCiAgICAKICAgICAgICAgICAgVGhlIHdlYmtpdCBwYXRjaCBmb3IgMjE5OTc2 IGludHJvZHVjZWQgYW4gdW5kZXNpcmFibGUgYmVoYXZpb3IgY2hhbmdlCiAgICAgICAgICAgIHJl c3VsdGluZyBpbiBhIHJlZ3Jlc3Npb24gd2hlcmUgdGhlcmUgd2FzIGNoZWNrZXJib2FyZCBmbGlj a2VyaW5nIG9uCiAgICAgICAgICAgIHJlc3VtaW5nIGZyb20gYW4gaW5hY3RpdmUgYXBwbGljYXRp b24gc3RhdGUuICBUaGlzIHBhdGNoIHJlc3RvcmVzIHRoZQogICAgICAgICAgICBwcmV2aW91cyBi ZWhhdmlvciBhbmQgZml4ZXMgdGhlIHJlZ3Jlc3Npb24uCiAgICAKICAgICAgICAgICAgKiBBcGkv QmFja2luZ1N0b3JlLmNwcDoKICAgICAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlOjpjcmVhdGVCYWNraW5nU3RvcmVNZW1vcnkpOgogICAgICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpCYWNraW5nU3RvcmU6OnJlbGVhc2VCYWNraW5nU3RvcmVNZW1vcnkpOgoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBjMWFi NTc4Li40MDBkM2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5n U3RvcmUuY3BwCkBAIC0yNzM0LDExICsyNzM0LDEzIEBAIHZvaWQgQmFja2luZ1N0b3JlOjpjcmVh dGVCYWNraW5nU3RvcmVNZW1vcnkoKQogICAgIGlmIChCYWNraW5nU3RvcmVQcml2YXRlOjpzX2N1 cnJlbnRCYWNraW5nU3RvcmVPd25lciA9PSBkLT5tX3dlYlBhZ2UpCiAgICAgICAgIFN1cmZhY2VQ b29sOjpnbG9iYWxTdXJmYWNlUG9vbCgpLT5jcmVhdGVCdWZmZXJzKCk7CiAgICAgcmVzdW1lQmFj a2luZ1N0b3JlVXBkYXRlcygpOworICAgIHJlc3VtZVNjcmVlblVwZGF0ZXMoQmFja2luZ1N0b3Jl OjpSZW5kZXJBbmRCbGl0KTsKIH0KIAogdm9pZCBCYWNraW5nU3RvcmU6OnJlbGVhc2VCYWNraW5n U3RvcmVNZW1vcnkoKQogewogICAgIHN1c3BlbmRCYWNraW5nU3RvcmVVcGRhdGVzKCk7CisgICAg c3VzcGVuZFNjcmVlblVwZGF0ZXMoKTsKICAgICBpZiAoQmFja2luZ1N0b3JlUHJpdmF0ZTo6c19j dXJyZW50QmFja2luZ1N0b3JlT3duZXIgPT0gZC0+bV93ZWJQYWdlKQogICAgICAgICBTdXJmYWNl UG9vbDo6Z2xvYmFsU3VyZmFjZVBvb2woKS0+cmVsZWFzZUJ1ZmZlcnMoKTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGIxMjQxZWIuLjNkYzVlN2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE2ICBBZGFtIFRyZWF0 ICA8YXRyZWF0QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEZpeCByZWdyZXNzaW9u IGNhdXNpbmcgY2hlY2tlcmJvYXJkIGZsaWNrZXIgYWZ0ZXIgYXBwIHdha2UtdXAKKyAgICAgICAg TmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICBQUiAyNDUwMjcKKworICAgICAgICBUaGUgd2Via2l0IHBhdGNoIGZv ciAyMTk5NzYgaW50cm9kdWNlZCBhbiB1bmRlc2lyYWJsZSBiZWhhdmlvciBjaGFuZ2UKKyAgICAg ICAgcmVzdWx0aW5nIGluIGEgcmVncmVzc2lvbiB3aGVyZSB0aGVyZSB3YXMgY2hlY2tlcmJvYXJk IGZsaWNrZXJpbmcgb24KKyAgICAgICAgcmVzdW1pbmcgZnJvbSBhbiBpbmFjdGl2ZSBhcHBsaWNh dGlvbiBzdGF0ZS4gIFRoaXMgcGF0Y2ggcmVzdG9yZXMgdGhlCisgICAgICAgIHByZXZpb3VzIGJl aGF2aW9yIGFuZCBmaXhlcyB0aGUgcmVncmVzc2lvbi4KKworICAgICAgICAqIEFwaS9CYWNraW5n U3RvcmUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmU6OmNy ZWF0ZUJhY2tpbmdTdG9yZU1lbW9yeSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJh Y2tpbmdTdG9yZTo6cmVsZWFzZUJhY2tpbmdTdG9yZU1lbW9yeSk6CisKIDIwMTItMTEtMTQgIEFu ZHkgQ2hlbiAgPGFuZGNoZW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIEZv Y3VzQmFzZWQgY29udGV4dCBub2RlIGRldGVjdGlvbiBzdHJhdGVneQo= 174710 2012-11-16 09:47:52 -0800 2012-11-16 11:48:39 -0800 v2 webkit_245027_v3.patch text/plain 2570 manyoso Y29tbWl0IDEwNzZjNWU2YTM2YjJmODM1Mjk3OGUwMGVjODEyMTg3M2E5YTQ1ZWYKQXV0aG9yOiBB ZGFtIFRyZWF0IDxhdHJlYXRAcmltLmNvbT4KRGF0ZTogICBGcmkgTm92IDE2IDExOjQyOjE1IDIw MTIgLTA1MDAKCiAgICAyMDEyLTExLTE2ICBBZGFtIFRyZWF0ICA8YXRyZWF0QHJpbS5jb20+CiAg ICAKICAgICAgICAgICAgUFIgMjQ1MDI3CiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCiAgICAKICAgICAgICAgICAgVGhlIHdlYmtpdCBwYXRjaCBmb3IgMjE5OTc2 IGludHJvZHVjZWQgYW4gdW5kZXNpcmFibGUgYmVoYXZpb3IgY2hhbmdlCiAgICAgICAgICAgIHJl c3VsdGluZyBpbiBhIHJlZ3Jlc3Npb24gd2hlcmUgdGhlcmUgd2FzIGNoZWNrZXJib2FyZCBmbGlj a2VyaW5nIG9uCiAgICAgICAgICAgIHJlc3VtaW5nIGZyb20gYW4gaW5hY3RpdmUgYXBwbGljYXRp b24gc3RhdGUuICBUaGlzIHBhdGNoIHJlc3RvcmVzIHRoZQogICAgICAgICAgICBwcmV2aW91cyBi ZWhhdmlvciBhbmQgZml4ZXMgdGhlIHJlZ3Jlc3Npb24uCiAgICAKICAgICAgICAgICAgKiBBcGkv QmFja2luZ1N0b3JlLmNwcDoKICAgICAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlOjpjcmVhdGVCYWNraW5nU3RvcmVNZW1vcnkpOgogICAgICAgICAgICAoQmxhY2tCZXJy eTo6V2ViS2l0OjpCYWNraW5nU3RvcmU6OnJlbGVhc2VCYWNraW5nU3RvcmVNZW1vcnkpOgoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBjMWFi NTc4Li40MDBkM2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5n U3RvcmUuY3BwCkBAIC0yNzM0LDExICsyNzM0LDEzIEBAIHZvaWQgQmFja2luZ1N0b3JlOjpjcmVh dGVCYWNraW5nU3RvcmVNZW1vcnkoKQogICAgIGlmIChCYWNraW5nU3RvcmVQcml2YXRlOjpzX2N1 cnJlbnRCYWNraW5nU3RvcmVPd25lciA9PSBkLT5tX3dlYlBhZ2UpCiAgICAgICAgIFN1cmZhY2VQ b29sOjpnbG9iYWxTdXJmYWNlUG9vbCgpLT5jcmVhdGVCdWZmZXJzKCk7CiAgICAgcmVzdW1lQmFj a2luZ1N0b3JlVXBkYXRlcygpOworICAgIHJlc3VtZVNjcmVlblVwZGF0ZXMoQmFja2luZ1N0b3Jl OjpSZW5kZXJBbmRCbGl0KTsKIH0KIAogdm9pZCBCYWNraW5nU3RvcmU6OnJlbGVhc2VCYWNraW5n U3RvcmVNZW1vcnkoKQogewogICAgIHN1c3BlbmRCYWNraW5nU3RvcmVVcGRhdGVzKCk7CisgICAg c3VzcGVuZFNjcmVlblVwZGF0ZXMoKTsKICAgICBpZiAoQmFja2luZ1N0b3JlUHJpdmF0ZTo6c19j dXJyZW50QmFja2luZ1N0b3JlT3duZXIgPT0gZC0+bV93ZWJQYWdlKQogICAgICAgICBTdXJmYWNl UG9vbDo6Z2xvYmFsU3VyZmFjZVBvb2woKS0+cmVsZWFzZUJ1ZmZlcnMoKTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGIxMjQxZWIuLjMzMzA4MDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE2ICBBZGFtIFRyZWF0 ICA8YXRyZWF0QHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEZpeCByZWdyZXNzaW9u IGNhdXNpbmcgY2hlY2tlcmJvYXJkIGZsaWNrZXIgYWZ0ZXIgYXBwIHdha2UtdXAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjUyNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBQUiAyNDUwMjcKKworICAgICAg ICBUaGUgd2Via2l0IHBhdGNoIGZvciAyMTk5NzYgaW50cm9kdWNlZCBhbiB1bmRlc2lyYWJsZSBi ZWhhdmlvciBjaGFuZ2UKKyAgICAgICAgcmVzdWx0aW5nIGluIGEgcmVncmVzc2lvbiB3aGVyZSB0 aGVyZSB3YXMgY2hlY2tlcmJvYXJkIGZsaWNrZXJpbmcgb24KKyAgICAgICAgcmVzdW1pbmcgZnJv bSBhbiBpbmFjdGl2ZSBhcHBsaWNhdGlvbiBzdGF0ZS4gIFRoaXMgcGF0Y2ggcmVzdG9yZXMgdGhl CisgICAgICAgIHByZXZpb3VzIGJlaGF2aW9yIGFuZCBmaXhlcyB0aGUgcmVncmVzc2lvbi4KKwor ICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpCYWNraW5nU3RvcmU6OmNyZWF0ZUJhY2tpbmdTdG9yZU1lbW9yeSk6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZTo6cmVsZWFzZUJhY2tpbmdTdG9yZU1lbW9y eSk6CisKIDIwMTItMTEtMTQgIEFuZHkgQ2hlbiAgPGFuZGNoZW5AcmltLmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gQWRkIEZvY3VzQmFzZWQgY29udGV4dCBub2RlIGRldGVjdGlvbiBzdHJh dGVneQo=