102518 2012-11-16 08:12:00 -0800 [BlackBerry] Use proper keycode value for space instead of hardcoded value. 2012-11-16 08:58:23 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 769287 0 mifenton 2012-11-16 08:12:00 -0800 SSIA. 769293 1 174689 mifenton 2012-11-16 08:17:05 -0800 Created attachment 174689 Patch 769305 2 174689 rwlbuis 2012-11-16 08:23:38 -0800 Comment on attachment 174689 Patch Makes sense. 769333 3 174689 webkit.review.bot 2012-11-16 08:58:20 -0800 Comment on attachment 174689 Patch Clearing flags on attachment: 174689 Committed r134957: <http://trac.webkit.org/changeset/134957> 769334 4 webkit.review.bot 2012-11-16 08:58:23 -0800 All reviewed patches have been landed. Closing bug. 174689 2012-11-16 08:17:05 -0800 2012-11-16 08:58:20 -0800 Patch 0001-2012-11-16-Mike-Fenton-mifenton-rim.com.patch text/plain 2779 mifenton RnJvbSA0NDM5YWRmYjM1ZjNhZmUxOTY2YzMxNWEzMjc4NmM3MjFlZmQwODk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog RnJpLCAxNiBOb3YgMjAxMiAwOToyNzoyNCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMTEt MTYgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgTmVlZCBhIHNob3J0 IGRlc2NyaXB0aW9uIChPT1BTISkuCiAgICAgICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgoK ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgUmVtb3ZlIGhhcmQg Y29kZWQgdmFsdWUgZm9yIHNwYWNlLgoKICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OnNldFRl eHQpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9J bnB1dEhhbmRsZXIuY3BwICAgICAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3Zjc0NDUxLi45OWQ3MGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMi0xMS0xNiAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29t PgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgcHJvcGVyIGtleWNvZGUgdmFsdWUgZm9yIHNw YWNlIGluc3RlYWQgb2YgaGFyZGNvZGVkIHZhbHVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGhhcmQgY29kZWQgdmFsdWUgZm9yIHNwYWNl LgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgR2VuIE1hay4KKworICAgICAgICAq IFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6SW5wdXRIYW5kbGVyOjpzZXRUZXh0KToKKwogMjAxMi0xMS0xNSAgQW5kcmV3IExvICA8 YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBbmltYXRlIGNoYW5nZXMgdG8g dmlld3BvcnQgZHVlIHRvIGlucHV0IGZvY3VzIGNoYW5nZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA1 NTUzM2U0Li4zNjIyZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTIyMDUsNyArMjIwNSw3IEBAIGJv b2wgSW5wdXRIYW5kbGVyOjpzZXRUZXh0KHNwYW5uYWJsZV9zdHJpbmdfdCogc3Bhbm5hYmxlU3Ry aW5nKQogICAgIC8vIFJlbW92ZSBpdCBhbmQgYXBwbHkgaXQgYXMgYSBrZXlwcmVzcyBsYXRlci4K ICAgICAvLyBVcHN0cmVhbSBXZWJraXQgYnVnIGNyZWF0ZWQgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcwODIzCiAgICAgYm9vbCByZXF1aXJlc1NwYWNlS2V5UHJlc3Mg PSBmYWxzZTsKLSAgICBpZiAodGV4dExlbmd0aCA+IDAgJiYgdGV4dFRvSW5zZXJ0W3RleHRMZW5n dGggLSAxXSA9PSAzMiAvKiBzcGFjZSAqLykgeworICAgIGlmICh0ZXh0TGVuZ3RoID4gMCAmJiB0 ZXh0VG9JbnNlcnRbdGV4dExlbmd0aCAtIDFdID09IEtFWUNPREVfU1BBQ0UpIHsKICAgICAgICAg cmVxdWlyZXNTcGFjZUtleVByZXNzID0gdHJ1ZTsKICAgICAgICAgdGV4dExlbmd0aC0tOwogICAg ICAgICB0ZXh0VG9JbnNlcnQucmVtb3ZlKHRleHRMZW5ndGgsIDEpOwpAQCAtMjIyNyw3ICsyMjI3 LDcgQEAgYm9vbCBJbnB1dEhhbmRsZXI6OnNldFRleHQoc3Bhbm5hYmxlX3N0cmluZ190KiBzcGFu bmFibGVTdHJpbmcpCiAgICAgfQogCiAgICAgaWYgKHJlcXVpcmVzU3BhY2VLZXlQcmVzcykKLSAg ICAgICAgaGFuZGxlS2V5Ym9hcmRJbnB1dChQbGF0Zm9ybTo6S2V5Ym9hcmRFdmVudCgzMiAvKiBz cGFjZSAqLywgUGxhdGZvcm06OktleWJvYXJkRXZlbnQ6OktleURvd24sIDApLCB0cnVlIC8qIGNo YW5nZUlzUGFydE9mQ29tcG9zaXRpb24gKi8pOworICAgICAgICBoYW5kbGVLZXlib2FyZElucHV0 KFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50KEtFWUNPREVfU1BBQ0UsIFBsYXRmb3JtOjpLZXlib2Fy ZEV2ZW50OjpLZXlEb3duLCAwKSwgdHJ1ZSAvKiBjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uICov KTsKIAogICAgIElucHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6c2V0VGV4dCBS ZXF1ZXN0IGJlaW5nIHByb2Nlc3NlZC4gVGV4dCBhZnRlciBwcm9jZXNzaW5nICclcyciLCBlbGVt ZW50VGV4dCgpLmxhdGluMSgpLmRhdGEoKSk7CiAKLS0gCjEuNy45LjUKCg==