102499 2012-11-16 06:22:57 -0800 [V8] Remove GetTypeFromSignature() from CodeGeneratorV8.pm 2012-11-18 15:52:51 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 769200 0 haraken 2012-11-16 06:22:57 -0800 [V8] Remove GetTypeFromSignature() from CodeGeneratorV8.pm 769202 1 174669 haraken 2012-11-16 06:23:44 -0800 Created attachment 174669 Patch 769362 2 174669 abarth 2012-11-16 09:35:06 -0800 Comment on attachment 174669 Patch Thanks for untwisting this ridiculous code. 770205 3 174669 webkit.review.bot 2012-11-18 15:52:48 -0800 Comment on attachment 174669 Patch Clearing flags on attachment: 174669 Committed r135087: <http://trac.webkit.org/changeset/135087> 770206 4 webkit.review.bot 2012-11-18 15:52:51 -0800 All reviewed patches have been landed. Closing bug. 174669 2012-11-16 06:23:44 -0800 2012-11-18 15:52:48 -0800 Patch bug-102499-20121116232139.patch text/plain 7285 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlYmI3YzJmYWUwMzc4 ZjQzY2M5ZGI1YmEzMTE0MzQwZmJmM2NkNi4uMjViMWVjNGRiYjM2YTYzNWNhYTRlYWIxMDAyZjE0 ZjM5Yjk0NmJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTE2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBH ZXRUeXBlRnJvbVNpZ25hdHVyZSgpIGZyb20gQ29kZUdlbmVyYXRvclY4LnBtCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0OTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdl IGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y VjgucG06CisgICAgICAgIChHZW5lcmF0ZU5vcm1hbEF0dHJHZXR0ZXIpOgorICAgICAgICAoR2Vu ZXJhdGVOb3JtYWxBdHRyU2V0dGVyKToKKyAgICAgICAgKEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNr RXhwcmVzc2lvbik6CisgICAgICAgIChHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjayk6CisgICAgICAg IChHZW5lcmF0ZUZ1bmN0aW9uQ2FsbFN0cmluZyk6CisgICAgICAgIChHZXROYXRpdmVUeXBlRnJv bVNpZ25hdHVyZSk6CisgICAgICAgIChUcmFuc2xhdGVQYXJhbWV0ZXIpOgorICAgICAgICAoVHlw ZUNhbkZhaWxDb252ZXJzaW9uKToKKyAgICAgICAgKEpTVmFsdWVUb05hdGl2ZSk6CisgICAgICAg IChOYXRpdmVUb0pTVmFsdWUpOgorCiAyMDEyLTExLTE2ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNo YWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbmRlckdyaWQgc2hvdWxkIGhhdmUgYSBm dW5jdGlvbiB0byByZXNvbHZlIGdyaWQgcG9zaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggNDQ3MDkwODg2ZmU3NGU5 ZDMxZTNhYTM1MzM5ZWFjYTM4N2M3YzEyNi4uZjcyNzMyZDU4NDI2YmVkYTg5ZDg3MTUyMTA3MDM4 ZjM1NGMwYTJlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KQEAgLTkxNCw3ICs5MTQsNyBAQCBzdWIgR2VuZXJhdGVOb3JtYWxB dHRyR2V0dGVyCiAgICAgbXkgJGludGVyZmFjZU5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7CiAgICAg bXkgJGF0dHJFeHQgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlczsK ICAgICBteSAkYXR0ck5hbWUgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPm5hbWU7Ci0gICAgbXkg JGF0dHJUeXBlID0gR2V0VHlwZUZyb21TaWduYXR1cmUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlKTsK KyAgICBteSAkYXR0clR5cGUgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGU7CiAgICAgJGNv ZGVHZW5lcmF0b3ItPkFzc2VydE5vdFNlcXVlbmNlVHlwZSgkYXR0clR5cGUpOwogICAgIG15ICRu YXRpdmVUeXBlID0gR2V0TmF0aXZlVHlwZUZyb21TaWduYXR1cmUoJGF0dHJpYnV0ZS0+c2lnbmF0 dXJlLCAtMSk7CiAKQEAgLTEwMDYsNyArMTAwNiw3IEBAIEVORAogICAgICAgICBwdXNoKEBpbXBs Q29udGVudERlY2xzLCAiICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwO1xuIik7CiAgICAgfQogCi0g ICAgbXkgJHJldHVyblR5cGUgPSBHZXRUeXBlRnJvbVNpZ25hdHVyZSgkYXR0cmlidXRlLT5zaWdu YXR1cmUpOworICAgIG15ICRyZXR1cm5UeXBlID0gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBl OwogICAgIG15ICRnZXR0ZXJTdHJpbmc7CiAKICAgICBpZiAoJGdldHRlclN0cmluZ1VzZXNJbXAp IHsKQEAgLTEyMTgsNyArMTIxOCw3IEBAIHN1YiBHZW5lcmF0ZU5vcm1hbEF0dHJTZXR0ZXIKICAg ICAjIFBlciB0aGUgV2ViIElETCBhbmQgRUNNQVNjcmlwdCBzcGVjaWZpY2F0aW9ucywgaW5jb21p bmcgdmFsdWVzIGNhbiBhbHdheXMgYmUgY29udmVydGVkIHRvIGJvdGgKICAgICAjIHN0cmluZ3Mg YW5kIG51bWJlcnMsIHNvIGRvIG5vdCB0aHJvdyBUeXBlRXJyb3IgaWYgdGhlIGF0dHJpYnV0ZSBp cyBvZiB0aGVzZSB0eXBlcy4KICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiU3RyaWN0VHlwZUNoZWNraW5nIn0pIHsKLSAgICAgICAgbXkgJGFyZ1R5 cGUgPSBHZXRUeXBlRnJvbVNpZ25hdHVyZSgkYXR0cmlidXRlLT5zaWduYXR1cmUpOworICAgICAg ICBteSAkYXJnVHlwZSA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+dHlwZTsKICAgICAgICAgaWYg KElzV3JhcHBlclR5cGUoJGFyZ1R5cGUpKSB7CiAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVu dERlY2xzLCAiICAgIGlmICghaXNVbmRlZmluZWRPck51bGwodmFsdWUpICYmICFWOCR7YXJnVHlw ZX06Okhhc0luc3RhbmNlKHZhbHVlKSkge1xuIik7CiAgICAgICAgICAgICBwdXNoKEBpbXBsQ29u dGVudERlY2xzLCAiICAgICAgICB0aHJvd1R5cGVFcnJvcigwLCBpbmZvLkdldElzb2xhdGUoKSk7 XG4iKTsKQEAgLTEyNDksNyArMTI0OSw3IEBAIEVORAogICAgICR7aW50ZXJmYWNlTmFtZX0qIGlt cCA9IFY4JHtpbnRlcmZhY2VOYW1lfTo6dG9OYXRpdmUoaW5mby5Ib2xkZXIoKSk7CiBFTkQKICAg ICB9IGVsc2UgewotICAgICAgICBteSAkYXR0clR5cGUgPSBHZXRUeXBlRnJvbVNpZ25hdHVyZSgk YXR0cmlidXRlLT5zaWduYXR1cmUpOworICAgICAgICBteSAkYXR0clR5cGUgPSAkYXR0cmlidXRl LT5zaWduYXR1cmUtPnR5cGU7CiAgICAgICAgIG15ICRyZWZsZWN0ID0gJGF0dHJpYnV0ZS0+c2ln bmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiUmVmbGVjdCJ9OwogICAgICAgICBpZiAoJHJl ZmxlY3QgJiYgSXNOb2RlU3ViVHlwZSgkZGF0YU5vZGUpICYmICRjb2RlR2VuZXJhdG9yLT5Jc1N0 cmluZ1R5cGUoJGF0dHJUeXBlKSkgewogICAgICAgICAgICAgIyBHZW5lcmF0ZSBzdXBlci1jb21w YWN0IGNhbGwgZm9yIHJlZ3VsYXIgYXR0cmlidXRlIHNldHRlcjoKQEAgLTEyOTIsNyArMTI5Miw3 IEBAIEVORAogICAgIH0KIAogICAgIG15ICRyZXN1bHQgPSAidiI7Ci0gICAgbXkgJHJldHVyblR5 cGUgPSBHZXRUeXBlRnJvbVNpZ25hdHVyZSgkYXR0cmlidXRlLT5zaWduYXR1cmUpOworICAgIG15 ICRyZXR1cm5UeXBlID0gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlOwogICAgIGlmIChJc1Jl ZlB0clR5cGUoJHJldHVyblR5cGUpICYmICEkY29kZUdlbmVyYXRvci0+R2V0QXJyYXlUeXBlKCRy ZXR1cm5UeXBlKSkgewogICAgICAgICAkcmVzdWx0ID0gIldURjo6Z2V0UHRyKCIgLiAkcmVzdWx0 IC4gIikiOwogICAgIH0KQEAgLTE0NDUsNyArMTQ0NSw3IEBAIHN1YiBHZW5lcmF0ZVBhcmFtZXRl cnNDaGVja0V4cHJlc3Npb24KICAgICBmb3JlYWNoIG15ICRwYXJhbWV0ZXIgKEB7JGZ1bmN0aW9u LT5wYXJhbWV0ZXJzfSkgewogICAgICAgICBsYXN0IGlmICRwYXJhbWV0ZXJJbmRleCA+PSAkbnVt UGFyYW1ldGVyczsKICAgICAgICAgbXkgJHZhbHVlID0gImFyZ3NbJHBhcmFtZXRlckluZGV4XSI7 Ci0gICAgICAgIG15ICR0eXBlID0gR2V0VHlwZUZyb21TaWduYXR1cmUoJHBhcmFtZXRlcik7Cisg ICAgICAgIG15ICR0eXBlID0gJHBhcmFtZXRlci0+dHlwZTsKIAogICAgICAgICAjIE9ubHkgRE9N U3RyaW5nIG9yIHdyYXBwZXIgdHlwZXMgYXJlIGNoZWNrZWQuCiAgICAgICAgICMgRm9yIERPTVN0 cmluZyB3aXRoIFN0cmljdFR5cGVDaGVja2luZyBvbmx5IE51bGwsIFVuZGVmaW5lZCBhbmQgT2Jq ZWN0CkBAIC0xODQ3LDcgKzE4NDcsNyBAQCBzdWIgR2VuZXJhdGVQYXJhbWV0ZXJzQ2hlY2sKICAg ICAgICAgICAgICAgICAkbmF0aXZlRWxlbWVudFR5cGUgLj0gIiAiOwogICAgICAgICAgICAgfQog Ci0gICAgICAgICAgICBteSAkYXJnVHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRwYXJhbWV0 ZXIpOworICAgICAgICAgICAgbXkgJGFyZ1R5cGUgPSAkcGFyYW1ldGVyLT50eXBlOwogICAgICAg ICAgICAgaWYgKElzV3JhcHBlclR5cGUoJGFyZ1R5cGUpKSB7CiAgICAgICAgICAgICAgICAgJHBh cmFtZXRlckNoZWNrU3RyaW5nIC49ICIgICAgVmVjdG9yPCRuYXRpdmVFbGVtZW50VHlwZT4gJHBh cmFtZXRlck5hbWU7XG4iOwogICAgICAgICAgICAgICAgICRwYXJhbWV0ZXJDaGVja1N0cmluZyAu PSAiICAgIGZvciAoaW50IGkgPSAkcGFyYW1JbmRleDsgaSA8IGFyZ3MuTGVuZ3RoKCk7ICsraSkg e1xuIjsKQEAgLTE4NzAsNyArMTg3MCw3IEBAIHN1YiBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjawog ICAgICAgICAgICAgIyB0eXBlcy4KICAgICAgICAgICAgIGlmICgkZnVuY3Rpb24tPnNpZ25hdHVy ZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlN0cmljdFR5cGVDaGVja2luZyJ9KSB7CiAgICAgICAg ICAgICAgICAgbXkgJGFyZ1ZhbHVlID0gImFyZ3NbJHBhcmFtSW5kZXhdIjsKLSAgICAgICAgICAg ICAgICBteSAkYXJnVHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRwYXJhbWV0ZXIpOworICAg ICAgICAgICAgICAgIG15ICRhcmdUeXBlID0gJHBhcmFtZXRlci0+dHlwZTsKICAgICAgICAgICAg ICAgICBpZiAoSXNXcmFwcGVyVHlwZSgkYXJnVHlwZSkpIHsKICAgICAgICAgICAgICAgICAgICAg JHBhcmFtZXRlckNoZWNrU3RyaW5nIC49ICIgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPiAkcGFyYW1J bmRleCAmJiAhaXNVbmRlZmluZWRPck51bGwoJGFyZ1ZhbHVlKSAmJiAhVjgke2FyZ1R5cGV9OjpI YXNJbnN0YW5jZSgkYXJnVmFsdWUpKVxuIjsKICAgICAgICAgICAgICAgICAgICAgJHBhcmFtZXRl ckNoZWNrU3RyaW5nIC49ICIgICAgICAgIHJldHVybiB0aHJvd1R5cGVFcnJvcigwLCBhcmdzLkdl dElzb2xhdGUoKSk7XG4iOwpAQCAtMzU1Myw3ICszNTUzLDcgQEAgc3ViIEdlbmVyYXRlRnVuY3Rp b25DYWxsU3RyaW5nKCkKICAgICBteSAlcmVwbGFjZW1lbnRzID0gQF87CiAKICAgICBteSAkbmFt ZSA9ICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5uYW1lOwotICAgIG15ICRyZXR1cm5UeXBlID0gR2V0 VHlwZUZyb21TaWduYXR1cmUoJGZ1bmN0aW9uLT5zaWduYXR1cmUpOworICAgIG15ICRyZXR1cm5U eXBlID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPnR5cGU7CiAgICAgbXkgJG5hdGl2ZVJldHVyblR5 cGUgPSBHZXROYXRpdmVUeXBlKCRyZXR1cm5UeXBlLCAwKTsKICAgICBteSAkcmVzdWx0ID0gIiI7 CiAKQEAgLTM2NjMsMjEgKzM2NjMsMTIgQEAgc3ViIEdlbmVyYXRlRnVuY3Rpb25DYWxsU3RyaW5n KCkKICAgICByZXR1cm4gJHJlc3VsdDsKIH0KIAotCi1zdWIgR2V0VHlwZUZyb21TaWduYXR1cmUK LXsKLSAgICBteSAkc2lnbmF0dXJlID0gc2hpZnQ7Ci0KLSAgICByZXR1cm4gJHNpZ25hdHVyZS0+ dHlwZTsKLX0KLQotCiBzdWIgR2V0TmF0aXZlVHlwZUZyb21TaWduYXR1cmUKIHsKICAgICBteSAk c2lnbmF0dXJlID0gc2hpZnQ7CiAgICAgbXkgJHBhcmFtZXRlckluZGV4ID0gc2hpZnQ7CiAKLSAg ICBteSAkdHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOworICAgIG15ICR0 eXBlID0gJHNpZ25hdHVyZS0+dHlwZTsKIAogICAgIGlmICgkdHlwZSBlcSAidW5zaWduZWQgbG9u ZyIgYW5kICRzaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJJc0luZGV4In0pIHsKICAg ICAgICAgIyBTcGVjaWFsLWNhc2UgaW5kZXggYXJndW1lbnRzIGJlY2F1c2Ugd2UgbmVlZCB0byBj aGVjayB0aGF0IHRoZXkgYXJlbid0IDwgMC4KQEAgLTM4MDEsMTUgKzM3OTIsMTQgQEAgc3ViIFRy YW5zbGF0ZVBhcmFtZXRlcgogCiAgICAgIyBUaGUgSURMIHVzZXMgc29tZSBwc2V1ZG8tdHlwZXMg d2hpY2ggZG9uJ3QgcmVhbGx5IGV4aXN0LgogICAgIGlmICgkc2lnbmF0dXJlLT50eXBlIGVxICJU aW1lb3V0SGFuZGxlciIpIHsKLSAgICAgICRzaWduYXR1cmUtPnR5cGUoIkRPTVN0cmluZyIpOwor ICAgICAgICAkc2lnbmF0dXJlLT50eXBlKCJET01TdHJpbmciKTsKICAgICB9CiB9CiAKIHN1YiBU eXBlQ2FuRmFpbENvbnZlcnNpb24KIHsKICAgICBteSAkc2lnbmF0dXJlID0gc2hpZnQ7Ci0KLSAg ICBteSAkdHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOworICAgIG15ICR0 eXBlID0gJHNpZ25hdHVyZS0+dHlwZTsKIAogICAgIEFkZFRvSW1wbEluY2x1ZGVzKCJFeGNlcHRp b25Db2RlLmgiKSBpZiAkdHlwZSBlcSAiQXR0ciI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEg IkF0dHIiOwpAQCAtMzgyMiw3ICszODEyLDcgQEAgc3ViIEpTVmFsdWVUb05hdGl2ZQogICAgIG15 ICR2YWx1ZSA9IHNoaWZ0OwogICAgIG15ICRnZXRJc29sYXRlID0gc2hpZnQ7CiAKLSAgICBteSAk dHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOworICAgIG15ICR0eXBlID0g JHNpZ25hdHVyZS0+dHlwZTsKIAogICAgIHJldHVybiAiJHZhbHVlIiBpZiAkdHlwZSBlcSAiSlNP YmplY3QiOwogICAgIHJldHVybiAiJHZhbHVlLT5Cb29sZWFuVmFsdWUoKSIgaWYgJHR5cGUgZXEg ImJvb2xlYW4iOwpAQCAtNDA4Myw3ICs0MDczLDcgQEAgc3ViIE5hdGl2ZVRvSlNWYWx1ZQogICAg IG15ICRnZXRDcmVhdGlvbkNvbnRleHRBcmcgPSAkZ2V0Q3JlYXRpb25Db250ZXh0ID8gIiwgJGdl dENyZWF0aW9uQ29udGV4dCIgOiAiIjsKICAgICBteSAkZ2V0SXNvbGF0ZSA9IHNoaWZ0OwogICAg IG15ICRnZXRJc29sYXRlQXJnID0gJGdldElzb2xhdGUgPyAiLCAkZ2V0SXNvbGF0ZSIgOiAiIjsK LSAgICBteSAkdHlwZSA9IEdldFR5cGVGcm9tU2lnbmF0dXJlKCRzaWduYXR1cmUpOworICAgIG15 ICR0eXBlID0gJHNpZ25hdHVyZS0+dHlwZTsKIAogICAgIHJldHVybiAoJGdldElzb2xhdGUgPyAi djhCb29sZWFuKCR2YWx1ZSwgJGdldElzb2xhdGUpIiA6ICJ2OEJvb2xlYW4oJHZhbHVlKSIpIGlm ICR0eXBlIGVxICJib29sZWFuIjsKICAgICByZXR1cm4gInY4VW5kZWZpbmVkKCkiIGlmICR0eXBl IGVxICJ2b2lkIjsgICAgICMgZXF1aXZhbGVudCB0byB2OFVuZGVmaW5lZCgpCg==