102497 2012-11-16 06:17:21 -0800 [V8] Get rid of unused functions and inline redundant functions in CodeGeneratorV8.pm 2012-11-18 15:43:06 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 769192 0 haraken 2012-11-16 06:17:21 -0800 [V8] Get rid of unused functions and inline redundant functions in CodeGeneratorV8.pm 769193 1 174665 haraken 2012-11-16 06:18:18 -0800 Created attachment 174665 Patch 770200 2 174665 webkit.review.bot 2012-11-18 15:43:03 -0800 Comment on attachment 174665 Patch Clearing flags on attachment: 174665 Committed r135084: <http://trac.webkit.org/changeset/135084> 770201 3 webkit.review.bot 2012-11-18 15:43:06 -0800 All reviewed patches have been landed. Closing bug. 174665 2012-11-16 06:18:18 -0800 2012-11-18 15:43:03 -0800 Patch bug-102497-20121116231613.patch text/plain 3854 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlYmI3YzJmYWUwMzc4 ZjQzY2M5ZGI1YmEzMTE0MzQwZmJmM2NkNi4uODg3YTcyMDMzN2Y0MTMyNDNkNmZlOGZhZjQwYWZl MGU1YTQ0YTMzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE2ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEdldCByaWQg b2YgdW51c2VkIGZ1bmN0aW9ucyBhbmQgaW5saW5lIHJlZHVuZGFudCBmdW5jdGlvbnMgaW4gQ29k ZUdlbmVyYXRvclY4LnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDI0OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAgICAgIChHZW5lcmF0ZURvbWFp blNhZmVGdW5jdGlvbkdldHRlcik6CisgICAgICAgIChHZW5lcmF0ZU5vcm1hbEF0dHJHZXR0ZXIp OgorICAgICAgICAoR2VuZXJhdGVGdW5jdGlvbkNhbGxTdHJpbmcpOgorCiAyMDEyLTExLTE2ICBK dWxpZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbmRl ckdyaWQgc2hvdWxkIGhhdmUgYSBmdW5jdGlvbiB0byByZXNvbHZlIGdyaWQgcG9zaXRpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K aW5kZXggNDQ3MDkwODg2ZmU3NGU5ZDMxZTNhYTM1MzM5ZWFjYTM4N2M3YzEyNi4uY2E3YTJlZTNj YjUwNTMwZGY4YWU5MjI1MWJlMWQxODE0MDZjNjg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTI4LDggKzI4LDYgQEAg cGFja2FnZSBDb2RlR2VuZXJhdG9yVjg7CiAKIHVzZSBzdHJpY3Q7CiAKLXVzZSBEaWdlc3Q6Ok1E NTsKLQogdXNlIGNvbnN0YW50IEZpbGVOYW1lUHJlZml4ID0+ICJWOCI7CiAKIG15ICRjb2RlR2Vu ZXJhdG9yOwpAQCAtNzkwLDEyICs3ODgsNiBAQCBzdWIgSXNOb2RlU3ViVHlwZQogICAgIHJldHVy biBJc1N1YlR5cGUoJGRhdGFOb2RlLCAiTm9kZSIpOwogfQogCi1zdWIgSXNWaXNpYmxlQWNyb3Nz T3JpZ2lucwotewotICAgIG15ICRkYXRhTm9kZSA9IHNoaWZ0OwotICAgIHJldHVybiAkZGF0YU5v ZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDaGVja1NlY3VyaXR5In0gJiYgISgkZGF0YU5vZGUt Pm5hbWUgZXEgIkRPTVdpbmRvdyIpOwotfQotCiBzdWIgSXNDb25zdHJ1Y3RhYmxlCiB7CiAgICAg bXkgJGRhdGFOb2RlID0gc2hpZnQ7CkBAIC04MjMsNyArODE1LDggQEAgc3ViIEdlbmVyYXRlRG9t YWluU2FmZUZ1bmN0aW9uR2V0dGVyCiAgICAgICAgICRzaWduYXR1cmUgPSAidjg6OkxvY2FsPHY4 OjpTaWduYXR1cmU+KCkiOwogICAgIH0KIAotICAgIG15ICRuZXdUZW1wbGF0ZVN0cmluZyA9IEdl bmVyYXRlTmV3RnVuY3Rpb25UZW1wbGF0ZSgkZnVuY3Rpb24sICRpbnRlcmZhY2VOYW1lLCAkc2ln bmF0dXJlKTsKKyAgICBteSAkY2FsbGJhY2sgPSBHZXRGdW5jdGlvblRlbXBsYXRlQ2FsbGJhY2tO YW1lKCRmdW5jdGlvbiwgJGludGVyZmFjZU5hbWUpOworICAgIG15ICRuZXdUZW1wbGF0ZVN0cmlu ZyA9ICJ2ODo6RnVuY3Rpb25UZW1wbGF0ZTo6TmV3KCRjYWxsYmFjaywgdjhVbmRlZmluZWQoKSwg JHNpZ25hdHVyZSkiOwogCiAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIkZyYW1lLmgiKTsKICAgICBw dXNoKEBpbXBsQ29udGVudERlY2xzLCA8PEVORCk7CkBAIC0xMTYxLDcgKzExNTQsNyBAQCBFTkQK ICAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoJGF0dHJUeXBlLiIuaCIpOwogICAgICAgICBwdXNo KEBpbXBsQ29udGVudERlY2xzLCAiICAgIHJldHVybiB0b1Y4RmFzdCgkcmVzdWx0LCBpbmZvLCBp bXApO1xuIik7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICAiIC4gUmV0dXJuTmF0aXZlVG9KU1ZhbHVlKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZSwgJHJl c3VsdCwgImluZm8uSG9sZGVyKCkiLCAiaW5mby5HZXRJc29sYXRlKCkiKS4iO1xuIik7CisgICAg ICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgcmV0dXJuICIgLiBOYXRpdmVUb0pTVmFs dWUoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLCAkcmVzdWx0LCAiaW5mby5Ib2xkZXIoKSIsICJpbmZv LkdldElzb2xhdGUoKSIpLiI7XG4iKTsKICAgICB9CiAKICAgICBwdXNoKEBpbXBsQ29udGVudERl Y2xzLCAifVxuXG4iKTsgICMgZW5kIG9mIGdldHRlcgpAQCAtMTM5NCwxNiArMTM4Nyw2IEBAIHN1 YiBHZXRGdW5jdGlvblRlbXBsYXRlQ2FsbGJhY2tOYW1lCiAgICAgfQogfQogCi1zdWIgR2VuZXJh dGVOZXdGdW5jdGlvblRlbXBsYXRlCi17Ci0gICAgbXkgJGZ1bmN0aW9uID0gc2hpZnQ7Ci0gICAg bXkgJGludGVyZmFjZU5hbWUgPSBzaGlmdDsKLSAgICBteSAkc2lnbmF0dXJlID0gc2hpZnQ7Ci0K LSAgICBteSAkY2FsbGJhY2sgPSBHZXRGdW5jdGlvblRlbXBsYXRlQ2FsbGJhY2tOYW1lKCRmdW5j dGlvbiwgJGludGVyZmFjZU5hbWUpOwotICAgIHJldHVybiAidjg6OkZ1bmN0aW9uVGVtcGxhdGU6 Ok5ldygkY2FsbGJhY2ssIHY4VW5kZWZpbmVkKCksICRzaWduYXR1cmUpIjsKLX0KLQogc3ViIEdl bmVyYXRlRXZlbnRMaXN0ZW5lckNhbGxiYWNrCiB7CiAgICAgbXkgJGludGVyZmFjZU5hbWUgPSBz aGlmdDsKQEAgLTM2NTgsNyArMzY0MSw3IEBAIHN1YiBHZW5lcmF0ZUZ1bmN0aW9uQ2FsbFN0cmlu ZygpCiAgICAgfQogCiAgICAgJHJldHVybiAuPSAiLnJlbGVhc2UoKSIgaWYgKCRyZXR1cm5Jc1Jl Zik7Ci0gICAgJHJlc3VsdCAuPSAkaW5kZW50IC4gUmV0dXJuTmF0aXZlVG9KU1ZhbHVlKCRmdW5j dGlvbi0+c2lnbmF0dXJlLCAkcmV0dXJuLCAiYXJncy5Ib2xkZXIoKSIsICJhcmdzLkdldElzb2xh dGUoKSIpIC4gIjtcbiI7CisgICAgJHJlc3VsdCAuPSAkaW5kZW50IC4gInJldHVybiAiIC4gTmF0 aXZlVG9KU1ZhbHVlKCRmdW5jdGlvbi0+c2lnbmF0dXJlLCAkcmV0dXJuLCAiYXJncy5Ib2xkZXIo KSIsICJhcmdzLkdldElzb2xhdGUoKSIpIC4gIjtcbiI7CiAKICAgICByZXR1cm4gJHJlc3VsdDsK IH0KQEAgLTQxNjcsMTEgKzQxNTAsNiBAQCBzdWIgTmF0aXZlVG9KU1ZhbHVlCiAgICAgcmV0dXJu ICJ0b1Y4KCR2YWx1ZSRnZXRDcmVhdGlvbkNvbnRleHRBcmckZ2V0SXNvbGF0ZUFyZykiOwogfQog Ci1zdWIgUmV0dXJuTmF0aXZlVG9KU1ZhbHVlCi17Ci0gICAgcmV0dXJuICJyZXR1cm4gIiAuIE5h dGl2ZVRvSlNWYWx1ZShAXyk7Ci19Ci0KICMgSW50ZXJuYWwgaGVscGVyCiBzdWIgV3JpdGVEYXRh CiB7CkBAIC00MjkzLDEyICs0MjcxLDQgQEAgc3ViIEdldFBhc3NSZWZQdHJUeXBlCiAgICAgcmV0 dXJuICJQYXNzUmVmUHRyPCR7Y2xhc3NOYW1lfSR7YW5nbGVCcmFja2V0U3BhY2V9PiI7CiB9CiAK LXN1YiBEZWJ1Z1ByaW50Ci17Ci0gICAgbXkgJG91dHB1dCA9IHNoaWZ0OwotCi0gICAgcHJpbnQg JG91dHB1dDsKLSAgICBwcmludCAiXG4iOwotfQotCiAxOwo=