102488 2012-11-16 05:32:01 -0800 Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded. 2012-11-16 06:38:55 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas.bug eustas.bug apavlov caseq eustas.bug keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 769148 0 eustas.bug 2012-11-16 05:32:01 -0800 Panels are lazily loaded / instantiated. Panel constructors register keyboard shortcuts. When user open shortcuts screen all panel should be loaded. Otherwise some shortcuts will be missing. 769153 1 174653 eustas.bug 2012-11-16 05:34:19 -0800 Created attachment 174653 Patch 769212 2 174653 webkit.review.bot 2012-11-16 06:38:52 -0800 Comment on attachment 174653 Patch Clearing flags on attachment: 174653 Committed r134944: <http://trac.webkit.org/changeset/134944> 769213 3 webkit.review.bot 2012-11-16 06:38:55 -0800 All reviewed patches have been landed. Closing bug. 174653 2012-11-16 05:34:19 -0800 2012-11-16 06:38:52 -0800 Patch bug-102488-20121116173214.patch text/plain 4270 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRkMjE3MDkxZGI1YTgw YzhkN2Q0MjhhYzczODhiZDcxYWM4MDg3Zi4uODhjMTY0OTM4Y2ExZThmYzc5MmZjNmJmMTFiMDA1 OTgzOWVhNWQ0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTE2ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBXb3JrYXJvdW5kIHRvIHNob3cgc2hvcnRjdXRzIGZvciBwYW5lbHMgdGhhdCBoYXNu J3QgYmVlbiBsb2FkZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDI0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQYW5lbHMgYXJlIGxhemlseSBsb2FkZWQgLyBpbnN0YW50aWF0ZWQuCisgICAgICAg IFBhbmVsIGNvbnN0cnVjdG9ycyByZWdpc3RlciBrZXlib2FyZCBzaG9ydGN1dHMuCisKKyAgICAg ICAgV2hlbiB1c2VyIG9wZW4gc2hvcnRjdXRzIHNjcmVlbiBhbGwgcGFuZWwgc2hvdWxkIGJlIGxv YWRlZC4KKyAgICAgICAgT3RoZXJ3aXNlIHNvbWUgc2hvcnRjdXRzIHdpbGwgYmUgbWlzc2luZy4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2hvcnRjdXRzU2NyZWVuLmpzOiBBZGRl ZCBjYWxsYmFjayBpbnZva2F0aW9uLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzOgorICAgICAgICBQcm92aWRlZCBjYWxsYmFjayB0aGF0IGxvYWRzIGFsbCBwYW5l bHMuCisKIDIwMTItMTEtMTYgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzQ2OTQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nob3J0Y3V0c1NjcmVlbi5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2hvcnRjdXRzU2NyZWVuLmpz CmluZGV4IDljMDhiZjllNDMyYTJiZDU2MDI3NmMzZWY5ODYwZTc0MGMzNmRiOTkuLjhhN2NhMTA4 OTU0ZTc2ODA5ZmRlYjIxN2FlMGI0ZDM2ODhhZDZlZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2hvcnRjdXRzU2NyZWVuLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2hvcnRjdXRzU2NyZWVuLmpzCkBAIC0zMSw5ICsz MSwxMCBAQAogLyoqCiAgKiBAY29uc3RydWN0b3IKICAqLwotV2ViSW5zcGVjdG9yLlNob3J0Y3V0 c1NjcmVlbiA9IGZ1bmN0aW9uKCkKK1dlYkluc3BlY3Rvci5TaG9ydGN1dHNTY3JlZW4gPSBmdW5j dGlvbihmaW5pc2hTaG9ydGN1dHNSZWdpc3RyYXRpb25DYWxsYmFjaykKIHsKICAgICB0aGlzLl9z ZWN0aW9ucyA9IHt9OworICAgIHRoaXMuX2ZpbmlzaFNob3J0Y3V0c1JlZ2lzdHJhdGlvbkNhbGxi YWNrID0gZmluaXNoU2hvcnRjdXRzUmVnaXN0cmF0aW9uQ2FsbGJhY2s7CiB9CiAKIFdlYkluc3Bl Y3Rvci5TaG9ydGN1dHNTY3JlZW4ucHJvdG90eXBlID0gewpAQCAtNDcsNiArNDgsMTAgQEAgV2Vi SW5zcGVjdG9yLlNob3J0Y3V0c1NjcmVlbi5wcm90b3R5cGUgPSB7CiAKICAgICBjcmVhdGVTaG9y dGN1dHNUYWJWaWV3OiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICBpZiAodGhpcy5fZmluaXNo U2hvcnRjdXRzUmVnaXN0cmF0aW9uQ2FsbGJhY2spCisgICAgICAgICAgICB0aGlzLl9maW5pc2hT aG9ydGN1dHNSZWdpc3RyYXRpb25DYWxsYmFjaygpOworICAgICAgICBkZWxldGUgdGhpcy5fZmlu aXNoU2hvcnRjdXRzUmVnaXN0cmF0aW9uQ2FsbGJhY2s7CisKICAgICAgICAgdmFyIG9yZGVyZWRT ZWN0aW9ucyA9IFtdOwogICAgICAgICBmb3IgKHZhciBzZWN0aW9uIGluIHRoaXMuX3NlY3Rpb25z KQogICAgICAgICAgICAgb3JkZXJlZFNlY3Rpb25zLnB1c2godGhpcy5fc2VjdGlvbnNbc2VjdGlv bl0pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5q cwppbmRleCBkOWUxODAxMTBlOTUwNzBlOGIxNjI1NWY0MTI4YzhkNDA0NzJjNmI2Li5kYzEzYTNl ZjE5MTI1NjhiZGYyYWEwOWViOTcyMmFmOGI1MzhmYWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwpAQCAtMzc5LDEwICszNzksMTEgQEAg V2ViSW5zcGVjdG9yLmRvTG9hZGVkRG9uZSA9IGZ1bmN0aW9uKCkKIAogV2ViSW5zcGVjdG9yLl9k b0xvYWRlZERvbmVXaXRoQ2FwYWJpbGl0aWVzID0gZnVuY3Rpb24oKQogewotICAgIFdlYkluc3Bl Y3Rvci5zaG9ydGN1dHNTY3JlZW4gPSBuZXcgV2ViSW5zcGVjdG9yLlNob3J0Y3V0c1NjcmVlbigp OwotICAgIHRoaXMuX3JlZ2lzdGVyU2hvcnRjdXRzKCk7CisgICAgdmFyIHBhbmVsRGVzY3JpcHRv cnMgPSB0aGlzLl9wYW5lbERlc2NyaXB0b3JzKCk7CisgICAgV2ViSW5zcGVjdG9yLnNob3J0Y3V0 c1NjcmVlbiA9IG5ldyBXZWJJbnNwZWN0b3IuU2hvcnRjdXRzU2NyZWVuKHRoaXMuX3JlZ2lzdGVy U2hvcnRjdXRzLmJpbmQodGhpcywgcGFuZWxEZXNjcmlwdG9ycykpOwogCiAgICAgLy8gc2V0IG9y ZGVyIG9mIHNvbWUgc2VjdGlvbnMgZXhwbGljaXRseQorICAgIFdlYkluc3BlY3Rvci5zaG9ydGN1 dHNTY3JlZW4uc2VjdGlvbihXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFsbCBQYW5lbHMiKSk7CiAg ICAgV2ViSW5zcGVjdG9yLnNob3J0Y3V0c1NjcmVlbi5zZWN0aW9uKFdlYkluc3BlY3Rvci5VSVN0 cmluZygiQ29uc29sZSIpKTsKICAgICBXZWJJbnNwZWN0b3Iuc2hvcnRjdXRzU2NyZWVuLnNlY3Rp b24oV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJFbGVtZW50cyBQYW5lbCIpKTsKIApAQCAtNDQ3LDcg KzQ0OCw2IEBAIFdlYkluc3BlY3Rvci5fZG9Mb2FkZWREb25lV2l0aENhcGFiaWxpdGllcyA9IGZ1 bmN0aW9uKCkKIAogICAgIHRoaXMudG9vbGJhciA9IG5ldyBXZWJJbnNwZWN0b3IuVG9vbGJhcigp OwogICAgIFdlYkluc3BlY3Rvci5zdGFydEJhdGNoVXBkYXRlKCk7Ci0gICAgdmFyIHBhbmVsRGVz Y3JpcHRvcnMgPSB0aGlzLl9wYW5lbERlc2NyaXB0b3JzKCk7CiAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBwYW5lbERlc2NyaXB0b3JzLmxlbmd0aDsgKytpKQogICAgICAgICBXZWJJbnNwZWN0b3Iu aW5zcGVjdG9yVmlldy5hZGRQYW5lbChwYW5lbERlc2NyaXB0b3JzW2ldKTsKICAgICBXZWJJbnNw ZWN0b3IuZW5kQmF0Y2hVcGRhdGUoKTsKQEAgLTYxMyw3ICs2MTMsNyBAQCBXZWJJbnNwZWN0b3Iu b3BlblJlc291cmNlID0gZnVuY3Rpb24ocmVzb3VyY2VVUkwsIGluUmVzb3VyY2VzUGFuZWwpCiAg ICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5vcGVuSW5OZXdUYWIocmVzb3VyY2VVUkwpOwog fQogCi1XZWJJbnNwZWN0b3IuX3JlZ2lzdGVyU2hvcnRjdXRzID0gZnVuY3Rpb24oKQorV2ViSW5z cGVjdG9yLl9yZWdpc3RlclNob3J0Y3V0cyA9IGZ1bmN0aW9uKHBhbmVsRGVzY3JpcHRvcnMpCiB7 CiAgICAgdmFyIHNob3J0Y3V0ID0gV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQ7CiAgICAg dmFyIHNlY3Rpb24gPSBXZWJJbnNwZWN0b3Iuc2hvcnRjdXRzU2NyZWVuLnNlY3Rpb24oV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJBbGwgUGFuZWxzIikpOwpAQCAtNjQ4LDYgKzY0OCw5IEBAIFdlYklu c3BlY3Rvci5fcmVnaXN0ZXJTaG9ydGN1dHMgPSBmdW5jdGlvbigpCiAKICAgICB2YXIgZ29Ub1No b3J0Y3V0ID0gV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nLmNyZWF0ZVNob3J0Y3V0KCk7CiAg ICAgc2VjdGlvbi5hZGRLZXkoZ29Ub1Nob3J0Y3V0Lm5hbWUsIFdlYkluc3BlY3Rvci5VSVN0cmlu ZygiR28gdG8gbGluZSIpKTsKKworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcGFuZWxEZXNjcmlw dG9ycy5sZW5ndGg7ICsraSkKKyAgICAgICAgcGFuZWxEZXNjcmlwdG9yc1tpXS5wYW5lbCgpOwog fQogCiBXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0gZnVuY3Rpb24oZXZlbnQpCg==