102485 2012-11-16 05:14:07 -0800 Factorize the creation of primitive values with a pair into a function. 2012-11-16 09:42:47 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard cmarcelo kling koivisto macpherson webkit.review.bot oldest_to_newest 769138 0 menard 2012-11-16 05:14:07 -0800 Factorize the creation of primitive values with a pair into a function. 769139 1 174650 menard 2012-11-16 05:16:37 -0800 Created attachment 174650 Patch 769158 2 174650 webkit.review.bot 2012-11-16 05:37:51 -0800 Comment on attachment 174650 Patch Clearing flags on attachment: 174650 Committed r134937: <http://trac.webkit.org/changeset/134937> 769159 3 webkit.review.bot 2012-11-16 05:37:55 -0800 All reviewed patches have been landed. Closing bug. 769369 4 174650 darin 2012-11-16 09:42:47 -0800 Comment on attachment 174650 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174650&action=review > Source/WebCore/css/CSSParser.cpp:190 > +static PassRefPtr<CSSPrimitiveValue> createPrimitiveValuePair(PassRefPtr<CSSPrimitiveValue> first, PassRefPtr<CSSPrimitiveValue> second) But not inlined? 174650 2012-11-16 05:16:37 -0800 2012-11-16 09:42:47 -0800 Patch bug-102485-20121116101432.patch text/plain 5151 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVkMzA2MGZkMzlmN2I1 MmEyMDExYjc0YzE0MzgzOTRhNGM2Y2I3ZS4uZTY0OTQzYTE2MGJmYjRmZDEyYWI3YWRiNTc4MTlk MmEyNmM1Yjg4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTE2ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRmFjdG9yaXplIHRoZSBj cmVhdGlvbiBvZiBwcmltaXRpdmUgdmFsdWVzIHdpdGggYSBwYWlyIGludG8gYSBmdW5jdGlvbi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwYXR0 ZXJuIGlzIGFscmVhZHkgZXhpc3RpbmcgaW4gdmFyaW91cyBjYWxsIHNpdGVzIGluc2lkZSBDU1NQ YXJzZXIKKyAgICAgICAgYW5kIG1vcmUgd2lsbCBiZSBhZGRlZCBpbiB0aGUgZnV0dXJlIChzZWUg YnVnIDEwMjEwNCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogSXQncyBhIHJlZmFjdG9yaW5n IG9ubHksIHRoZSB0ZXN0cyBzaG91bGQgY292ZXIgaXQuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFy c2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlUHJp bWl0aXZlVmFsdWVQYWlyKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VWYWx1 ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRmlsbFNpemUpOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUJvcmRlckltYWdlUmVwZWF0KToKKyAgICAgICAg KFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VCb3JkZXJSYWRpdXMpOgorICAgICAgICAoV2ViQ29y ZTo6Q1NTUGFyc2VyOjpwYXJzZUNvdW50ZXIpOgorCiAyMDEyLTExLTE2ICBNYXJqYSBIw7ZsdHTD pCAgPG1hcmphQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgaW5pdGlhdG9yIHRvIENhY2hl ZFJlc291cmNlUmVxdWVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMDZlZjU0Mzg1 YTdlZGU3NGNlYWJhNmIwNzgxMmJiYTVmYTgyMTIzNC4uYzUyMGEzMTA3MTA0NGY2ODk3ZTJhNWI2 NGIzNjcwMTVlOTEyMTI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTE4Niw3ICsx ODYsMTIgQEAgc3RhdGljIGJvb2wgaGFzUHJlZml4KGNvbnN0IGNoYXIqIHN0cmluZywgdW5zaWdu ZWQgbGVuZ3RoLCBjb25zdCBjaGFyKiBwcmVmaXgpCiAgICAgfQogICAgIHJldHVybiBmYWxzZTsK IH0KLSAgICAKKworc3RhdGljIFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGNyZWF0ZVBy aW1pdGl2ZVZhbHVlUGFpcihQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBmaXJzdCwgUGFz c1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gc2Vjb25kKQoreworICAgIHJldHVybiBjc3NWYWx1 ZVBvb2woKS5jcmVhdGVWYWx1ZShQYWlyOjpjcmVhdGUoZmlyc3QsIHNlY29uZCkpOworfQorCiBj b25zdCBDU1NQYXJzZXJDb250ZXh0JiBzdHJpY3RDU1NQYXJzZXJDb250ZXh0KCkKIHsKICAgICBE RUZJTkVfU1RBVElDX0xPQ0FMKENTU1BhcnNlckNvbnRleHQsIHN0cmljdENvbnRleHQsIChDU1NT dHJpY3RNb2RlKSk7CkBAIC0yMjI3LDkgKzIyMzIsNyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VW YWx1ZShDU1NQcm9wZXJ0eUlEIHByb3BJZCwgYm9vbCBpbXBvcnRhbnQpCiAgICAgICAgIH0gZWxz ZQogICAgICAgICAgICAgcGFyc2VkVmFsdWUyID0gcGFyc2VkVmFsdWUxOwogCi0gICAgICAgIFJl ZlB0cjxQYWlyPiBwYWlyID0gUGFpcjo6Y3JlYXRlKHBhcnNlZFZhbHVlMS5yZWxlYXNlKCksIHBh cnNlZFZhbHVlMi5yZWxlYXNlKCkpOwotICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+ IHZhbCA9IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHBhaXIucmVsZWFzZSgpKTsKLSAgICAg ICAgYWRkUHJvcGVydHkocHJvcElkLCB2YWwucmVsZWFzZSgpLCBpbXBvcnRhbnQpOworICAgICAg ICBhZGRQcm9wZXJ0eShwcm9wSWQsIGNyZWF0ZVByaW1pdGl2ZVZhbHVlUGFpcihwYXJzZWRWYWx1 ZTEucmVsZWFzZSgpLCBwYXJzZWRWYWx1ZTIucmVsZWFzZSgpKSwgaW1wb3J0YW50KTsKICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfQogICAgIGNhc2UgQ1NTUHJvcGVydHlUYWJTaXplOgpAQCAt Mzc4NCw3ICszNzg3LDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gQ1NTUGFyc2VyOjpwYXJzZUZp bGxTaXplKENTU1Byb3BlcnR5SUQgcHJvcElkLCBib29sJiBhbGxvd0MKIAogICAgIGlmICghcGFy c2VkVmFsdWUyKQogICAgICAgICByZXR1cm4gcGFyc2VkVmFsdWUxOwotICAgIHJldHVybiBjc3NW YWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShQYWlyOjpjcmVhdGUocGFyc2VkVmFsdWUxLnJlbGVhc2Uo KSwgcGFyc2VkVmFsdWUyLnJlbGVhc2UoKSkpOworICAgIHJldHVybiBjcmVhdGVQcmltaXRpdmVW YWx1ZVBhaXIocGFyc2VkVmFsdWUxLnJlbGVhc2UoKSwgcGFyc2VkVmFsdWUyLnJlbGVhc2UoKSk7 CiB9CiAKIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUZpbGxQcm9wZXJ0eShDU1NQcm9wZXJ0eUlEIHBy b3BJZCwgQ1NTUHJvcGVydHlJRCYgcHJvcElkMSwgQ1NTUHJvcGVydHlJRCYgcHJvcElkMiwKQEAg LTYxODEsNyArNjE4NCw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUJvcmRlckltYWdlUmVwZWF0 KFJlZlB0cjxDU1NWYWx1ZT4mIHJlc3VsdCkKICAgICB9IGVsc2UKICAgICAgICAgc2Vjb25kVmFs dWUgPSBmaXJzdFZhbHVlOwogCi0gICAgcmVzdWx0ID0gY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFs dWUoUGFpcjo6Y3JlYXRlKGZpcnN0VmFsdWUsIHNlY29uZFZhbHVlKSk7CisgICAgcmVzdWx0ID0g Y3JlYXRlUHJpbWl0aXZlVmFsdWVQYWlyKGZpcnN0VmFsdWUsIHNlY29uZFZhbHVlKTsKICAgICBy ZXR1cm4gdHJ1ZTsKIH0KIApAQCAtNjQ3NiwxMCArNjQ3OSwxMCBAQCBib29sIENTU1BhcnNlcjo6 cGFyc2VCb3JkZXJSYWRpdXMoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1wb3J0YW50KQog ICAgICAgICBjb21wbGV0ZUJvcmRlclJhZGlpKHJhZGlpWzFdKTsKIAogICAgIEltcGxpY2l0U2Nv cGUgaW1wbGljaXRTY29wZSh0aGlzLCBQcm9wZXJ0eUltcGxpY2l0KTsKLSAgICBhZGRQcm9wZXJ0 eShDU1NQcm9wZXJ0eUJvcmRlclRvcExlZnRSYWRpdXMsIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZh bHVlKFBhaXI6OmNyZWF0ZShyYWRpaVswXVswXS5yZWxlYXNlKCksIHJhZGlpWzFdWzBdLnJlbGVh c2UoKSkpLCBpbXBvcnRhbnQpOwotICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Qm9yZGVyVG9w UmlnaHRSYWRpdXMsIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKFBhaXI6OmNyZWF0ZShyYWRp aVswXVsxXS5yZWxlYXNlKCksIHJhZGlpWzFdWzFdLnJlbGVhc2UoKSkpLCBpbXBvcnRhbnQpOwot ICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Qm9yZGVyQm90dG9tUmlnaHRSYWRpdXMsIGNzc1Zh bHVlUG9vbCgpLmNyZWF0ZVZhbHVlKFBhaXI6OmNyZWF0ZShyYWRpaVswXVsyXS5yZWxlYXNlKCks IHJhZGlpWzFdWzJdLnJlbGVhc2UoKSkpLCBpbXBvcnRhbnQpOwotICAgIGFkZFByb3BlcnR5KENT U1Byb3BlcnR5Qm9yZGVyQm90dG9tTGVmdFJhZGl1cywgY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFs dWUoUGFpcjo6Y3JlYXRlKHJhZGlpWzBdWzNdLnJlbGVhc2UoKSwgcmFkaWlbMV1bM10ucmVsZWFz ZSgpKSksIGltcG9ydGFudCk7CisgICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlCb3JkZXJUb3BM ZWZ0UmFkaXVzLCBjcmVhdGVQcmltaXRpdmVWYWx1ZVBhaXIocmFkaWlbMF1bMF0ucmVsZWFzZSgp LCByYWRpaVsxXVswXS5yZWxlYXNlKCkpLCBpbXBvcnRhbnQpOworICAgIGFkZFByb3BlcnR5KENT U1Byb3BlcnR5Qm9yZGVyVG9wUmlnaHRSYWRpdXMsIGNyZWF0ZVByaW1pdGl2ZVZhbHVlUGFpcihy YWRpaVswXVsxXS5yZWxlYXNlKCksIHJhZGlpWzFdWzFdLnJlbGVhc2UoKSksIGltcG9ydGFudCk7 CisgICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlCb3JkZXJCb3R0b21SaWdodFJhZGl1cywgY3Jl YXRlUHJpbWl0aXZlVmFsdWVQYWlyKHJhZGlpWzBdWzJdLnJlbGVhc2UoKSwgcmFkaWlbMV1bMl0u cmVsZWFzZSgpKSwgaW1wb3J0YW50KTsKKyAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUJvcmRl ckJvdHRvbUxlZnRSYWRpdXMsIGNyZWF0ZVByaW1pdGl2ZVZhbHVlUGFpcihyYWRpaVswXVszXS5y ZWxlYXNlKCksIHJhZGlpWzFdWzNdLnJlbGVhc2UoKSksIGltcG9ydGFudCk7CiAgICAgcmV0dXJu IHRydWU7CiB9CiAKQEAgLTY1MzcsOCArNjU0MCw4IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUNv dW50ZXIoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGludCBkZWZhdWx0VmFsdWUsIGJvb2wgaW1wb3J0 CiAgICAgICAgICAgICAgICAgICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7CiAgICAgICAgICAgICAg ICAgfQogCi0gICAgICAgICAgICAgICAgbGlzdC0+YXBwZW5kKGNzc1ZhbHVlUG9vbCgpLmNyZWF0 ZVZhbHVlKFBhaXI6OmNyZWF0ZShjb3VudGVyTmFtZS5yZWxlYXNlKCksCi0gICAgICAgICAgICAg ICAgICAgIGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKGksIENTU1ByaW1pdGl2ZVZhbHVlOjpD U1NfTlVNQkVSKSkpKTsKKyAgICAgICAgICAgICAgICBsaXN0LT5hcHBlbmQoY3JlYXRlUHJpbWl0 aXZlVmFsdWVQYWlyKGNvdW50ZXJOYW1lLnJlbGVhc2UoKSwKKyAgICAgICAgICAgICAgICAgICAg Y3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoaSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1C RVIpKSk7CiAgICAgICAgICAgICAgICAgc3RhdGUgPSBJRDsKICAgICAgICAgICAgICAgICBjb250 aW51ZTsKICAgICAgICAgICAgIH0K