102468 2012-11-16 00:22:29 -0800 Simulated events instances do not all have the same underlying event 2012-11-17 22:10:16 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Mac OS X 10.8 RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee andersca ap beidson mitz sam webkit-bug-importer oldest_to_newest 768989 0 jonlee 2012-11-16 00:22:29 -0800 I believe this is a bug in how simulated events are constructed. The PassRefPtr with the underlying event is included as an argument for the mouse down, up, and click events. But the PassRefPtr loses its underlying pointer after the first simulated mouse down event because it gets assigned to that event's private m_underlyingEvent variable. We therefore send NULL to the other events. 769007 1 jonlee 2012-11-16 00:58:30 -0800 <rdar://problem/12716331> 769023 2 174630 jonlee 2012-11-16 01:16:13 -0800 Created attachment 174630 Patch 769315 3 mitz 2012-11-16 08:38:50 -0800 Please follow the advice of <http://www.webkit.org/coding/RefPtr.html> and rename the function parameter prpUnderlyingEvent, and transfer to a RefPtr with the old name at the beginning of the function. 769335 4 beidson 2012-11-16 08:58:32 -0800 (In reply to comment #3) > Please follow the advice of <http://www.webkit.org/coding/RefPtr.html> and rename the function parameter prpUnderlyingEvent, and transfer to a RefPtr with the old name at the beginning of the function. Yay! Idioms!!! 769336 5 174630 beidson 2012-11-16 08:59:10 -0800 Comment on attachment 174630 Patch Yay idioms! (do the prp thing) 769371 6 ap 2012-11-16 09:45:21 -0800 A better solution (and one you should use) would be to change the argument type form PassRefPtr to a plain pointer. 769374 7 beidson 2012-11-16 09:47:22 -0800 (In reply to comment #6) > A better solution (and one you should use) would be to change the argument type form PassRefPtr to a plain pointer. Great point - ownership (a reference) is not actually being passed in this case, and the arguments to the 3 callees are all plain ptrs. 769378 8 174711 jonlee 2012-11-16 09:49:12 -0800 Created attachment 174711 Patch 769399 9 174711 ap 2012-11-16 10:06:08 -0800 Comment on attachment 174711 Patch Please do use plain pointers. 769550 10 174736 jonlee 2012-11-16 12:02:54 -0800 Created attachment 174736 Patch 769638 11 jonlee 2012-11-16 13:42:17 -0800 Committed 134995: http://trac.webkit.org/changeset/134995 769639 12 174736 webkit.review.bot 2012-11-16 13:42:20 -0800 Comment on attachment 174736 Patch Attachment 174736 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14878003 770078 13 jonlee 2012-11-17 22:10:16 -0800 Chromium fix in r135000. 174630 2012-11-16 01:16:13 -0800 2012-11-16 09:49:10 -0800 Patch bug-102468-20121116011409.patch text/plain 3112 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3YTliZTk4OTQ1NGRh NTZkMmY5OTM2MjBjMGIxZGU4NTFkYWY3YS4uOWNiNWZmYTVjOGYxMTc0MjJjNjg2NDdjYzRmNzY1 MzZmMzU3ODRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTE2ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBTaW11bGF0ZWQgZXZlbnRzIGluc3Rh bmNlcyBkbyBub3QgYWxsIGhhdmUgdGhlIHNhbWUgdW5kZXJseWluZyBldmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNDY4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMjcxNjMzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgUGFzc1JlZlB0ciB3aXRoIHRoZSB1bmRlcmx5aW5nIGV2ZW50 IGlzIGluY2x1ZGVkIGFzIGFuIGFyZ3VtZW50IGZvciB0aGUgbW91c2UKKyAgICAgICAgZG93biwg dXAsIGFuZCBjbGljayBldmVudHMuIEJ1dCB0aGUgUGFzc1JlZlB0ciBsb3NlcyBpdHMgdW5kZXJs eWluZyBwb2ludGVyIGFmdGVyCisgICAgICAgIHRoZSBmaXJzdCBzaW11bGF0ZWQgbW91c2UgZG93 biBldmVudCBiZWNhdXNlIGl0IGdldHMgYXNzaWduZWQgdG8gdGhhdCBldmVudCdzCisgICAgICAg IHByaXZhdGUgbV91bmRlcmx5aW5nRXZlbnQgdmFyaWFibGUuIFdlIHRoZXJlZm9yZSBzZW5kIE5V TEwgdG8gdGhlIG90aGVyIGV2ZW50cy4KKworICAgICAgICBBIGxheW91dCB0ZXN0IGlzIG5vdCBw b3NzaWJsZSB0byBwdXQgdG9nZXRoZXIgYmVjYXVzZSB0aGUgY2FsbCBzaXRlcyB0aGF0IHVzZSBz aW11bGF0ZWQKKyAgICAgICAgZXZlbnRzIHdpdGggYW4gdW5kZXJseWluZyBldmVudCBkbyBub3Qg c2VuZCBtb3VzZSBldmVudHMsIGFuZCB0aG9zZSB0aGF0IHNlbmQgbW91c2UKKyAgICAgICAgZXZl bnRzIGhhdmUgYSBOVUxMIHVuZGVybHlpbmcgZXZlbnQuCisKKyAgICAgICAgKiBkb20vRXZlbnRE aXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0 Y2hTaW11bGF0ZWRDbGljayk6IEhvbGQgdGhlIHVuZGVybHlpbmcgZXZlbnQKKyAgICAgICAgbG9j YWxseSwgYW5kIGluc3RlYWQgY3JlYXRlIG5ldyBQYXNzUmVmUHRyJ3Mgd2l0aCB0aGUgcmF3IHBv aW50ZXIuCisKIDIwMTItMTEtMTUgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAg ICAgIENoYW5nZSB2aXN1YWwgbG9vayBvZiBwbGFjZWhvbGRlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZl bnREaXNwYXRjaGVyLmNwcAppbmRleCBiM2M2MzlhYzgzNDYzNjA1YjQ1YmI3M2YwZGE0YmMzY2Y4 YzQ1ZDBiLi5kNDhhODFmNGMxZTVhMjJmYjNmMWJiYTBkZjkyNWYzZDg4MGEwNDdhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcApAQCAtMjIwLDE2ICsyMjAsMTcgQEAgdm9p ZCBFdmVudERpc3BhdGNoZXI6OmRpc3BhdGNoU2ltdWxhdGVkQ2xpY2soTm9kZSogbm9kZSwgUGFz c1JlZlB0cjxFdmVudD4gdW5kZXIKIAogICAgIGdOb2Rlc0Rpc3BhdGNoaW5nU2ltdWxhdGVkQ2xp Y2tzLT5hZGQobm9kZSk7CiAKKyAgICBSZWZQdHI8RXZlbnQ+IGhvbGRVbmRlcmx5aW5nRXZlbnQg PSB1bmRlcmx5aW5nRXZlbnQ7CiAgICAgLy8gc2VuZCBtb3VzZWRvd24gYW5kIG1vdXNldXAgYmVm b3JlIHRoZSBjbGljaywgaWYgcmVxdWVzdGVkCiAgICAgaWYgKHNlbmRNb3VzZUV2ZW50cykKLSAg ICAgICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2ltdWxhdGVkTW91c2VF dmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVudCwgbm9kZS0+ZG9jdW1lbnQo KS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJseWluZ0V2ZW50KSk7CisgICAgICAgIEV2ZW50RGlzcGF0 Y2hlcihub2RlKS5kaXNwYXRjaEV2ZW50KFNpbXVsYXRlZE1vdXNlRXZlbnQ6OmNyZWF0ZShldmVu dE5hbWVzKCkubW91c2Vkb3duRXZlbnQsIG5vZGUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCks IGhvbGRVbmRlcmx5aW5nRXZlbnQuZ2V0KCkpKTsKICAgICBub2RlLT5zZXRBY3RpdmUodHJ1ZSwg c2hvd1ByZXNzZWRMb29rKTsKICAgICBpZiAoc2VuZE1vdXNlRXZlbnRzKQotICAgICAgICBFdmVu dERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVh dGUoZXZlbnROYW1lcygpLm1vdXNldXBFdmVudCwgbm9kZS0+ZG9jdW1lbnQoKS0+ZGVmYXVsdFZp ZXcoKSwgdW5kZXJseWluZ0V2ZW50KSk7CisgICAgICAgIEV2ZW50RGlzcGF0Y2hlcihub2RlKS5k aXNwYXRjaEV2ZW50KFNpbXVsYXRlZE1vdXNlRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkubW91 c2V1cEV2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCBob2xkVW5kZXJseWlu Z0V2ZW50LmdldCgpKSk7CiAgICAgbm9kZS0+c2V0QWN0aXZlKGZhbHNlKTsKIAogICAgIC8vIGFs d2F5cyBzZW5kIGNsaWNrCi0gICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQo U2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50LCBub2Rl LT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRlcmx5aW5nRXZlbnQpKTsKKyAgICBFdmVu dERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVh dGUoZXZlbnROYW1lcygpLmNsaWNrRXZlbnQsIG5vZGUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3 KCksIGhvbGRVbmRlcmx5aW5nRXZlbnQuZ2V0KCkpKTsKIAogICAgIGdOb2Rlc0Rpc3BhdGNoaW5n U2ltdWxhdGVkQ2xpY2tzLT5yZW1vdmUobm9kZSk7CiB9Cg== 174711 2012-11-16 09:49:12 -0800 2012-11-16 12:02:52 -0800 Patch bug-102468-20121116094708.patch text/plain 4428 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3YTliZTk4OTQ1NGRh NTZkMmY5OTM2MjBjMGIxZGU4NTFkYWY3YS4uYjkwMTMwNDA1NjVlYWM0NGE2ODFhZWQzZTI1MGU1 NTI1YWQ0NWUyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTExLTE2ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBTaW11bGF0ZWQgZXZlbnRzIGluc3Rh bmNlcyBkbyBub3QgYWxsIGhhdmUgdGhlIHNhbWUgdW5kZXJseWluZyBldmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNDY4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMjcxNjMzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgUGFzc1JlZlB0ciB3aXRoIHRoZSB1bmRlcmx5aW5nIGV2ZW50 IGlzIGluY2x1ZGVkIGFzIGFuIGFyZ3VtZW50IGZvciB0aGUgbW91c2UKKyAgICAgICAgZG93biwg dXAsIGFuZCBjbGljayBldmVudHMuIEJ1dCB0aGUgUGFzc1JlZlB0ciBsb3NlcyBpdHMgdW5kZXJs eWluZyBwb2ludGVyIGFmdGVyCisgICAgICAgIHRoZSBmaXJzdCBzaW11bGF0ZWQgbW91c2UgZG93 biBldmVudCBiZWNhdXNlIGl0IGdldHMgYXNzaWduZWQgdG8gdGhhdCBldmVudCdzCisgICAgICAg IHByaXZhdGUgbV91bmRlcmx5aW5nRXZlbnQgdmFyaWFibGUuIFdlIHRoZXJlZm9yZSBzZW5kIE5V TEwgdG8gdGhlIG90aGVyIGV2ZW50cy4KKworICAgICAgICBBIGxheW91dCB0ZXN0IGlzIG5vdCBw b3NzaWJsZSB0byBwdXQgdG9nZXRoZXIgYmVjYXVzZSB0aGUgY2FsbCBzaXRlcyB0aGF0IHVzZSBz aW11bGF0ZWQKKyAgICAgICAgZXZlbnRzIHdpdGggYW4gdW5kZXJseWluZyBldmVudCBkbyBub3Qg c2VuZCBtb3VzZSBldmVudHMsIGFuZCB0aG9zZSB0aGF0IHNlbmQgbW91c2UKKyAgICAgICAgZXZl bnRzIGhhdmUgYSBOVUxMIHVuZGVybHlpbmcgZXZlbnQuCisKKyAgICAgICAgKiBkb20vRXZlbnRE aXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0 Y2hTaW11bGF0ZWRDbGljayk6IEhvbGQgdGhlIHVuZGVybHlpbmcgZXZlbnQKKyAgICAgICAgbG9j YWxseSwgYW5kIGluc3RlYWQgY3JlYXRlIG5ldyBQYXNzUmVmUHRyJ3Mgd2l0aCB0aGUgcmF3IHBv aW50ZXIuCisgICAgICAgICogZG9tL0V2ZW50RGlzcGF0Y2hlci5oOgorCiAyMDEyLTExLTE1ICBK b24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgdmlzdWFsIGxvb2sg b2YgcGxhY2Vob2xkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3Bh dGNoZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKaW5kZXgg YjNjNjM5YWM4MzQ2MzYwNWI0NWJiNzNmMGRhNGJjM2NmOGM0NWQwYi4uMDQyY2VlZjZiODJhYjcy MjRiNmZlY2I2MjAyOWQwNzljNTkxMTE2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50RGlzcGF0Y2hlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0 Y2hlci5jcHAKQEAgLTIwOCw4ICsyMDgsMTAgQEAgdm9pZCBFdmVudERpc3BhdGNoZXI6OmRpc3Bh dGNoU2NvcGVkRXZlbnQoTm9kZSogbm9kZSwgUGFzc1JlZlB0cjxFdmVudERpc3BhdGNoTWUKICAg ICBTY29wZWRFdmVudFF1ZXVlOjppbnN0YW5jZSgpLT5lbnF1ZXVlRXZlbnREaXNwYXRjaE1lZGlh dG9yKG1lZGlhdG9yKTsKIH0KIAotdm9pZCBFdmVudERpc3BhdGNoZXI6OmRpc3BhdGNoU2ltdWxh dGVkQ2xpY2soTm9kZSogbm9kZSwgUGFzc1JlZlB0cjxFdmVudD4gdW5kZXJseWluZ0V2ZW50LCBi b29sIHNlbmRNb3VzZUV2ZW50cywgYm9vbCBzaG93UHJlc3NlZExvb2spCit2b2lkIEV2ZW50RGlz cGF0Y2hlcjo6ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhOb2RlKiBub2RlLCBQYXNzUmVmUHRyPEV2 ZW50PiBwcnBVbmRlcmx5aW5nRXZlbnQsIGJvb2wgc2VuZE1vdXNlRXZlbnRzLCBib29sIHNob3dQ cmVzc2VkTG9vaykKIHsKKyAgICBSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdFdmVudCA9IHBycFVu ZGVybHlpbmdFdmVudDsKKwogICAgIGlmIChub2RlLT5kaXNhYmxlZCgpKQogICAgICAgICByZXR1 cm47CiAKQEAgLTIyMiwxNCArMjI0LDE0IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRj aFNpbXVsYXRlZENsaWNrKE5vZGUqIG5vZGUsIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVyCiAKICAg ICAvLyBzZW5kIG1vdXNlZG93biBhbmQgbW91c2V1cCBiZWZvcmUgdGhlIGNsaWNrLCBpZiByZXF1 ZXN0ZWQKICAgICBpZiAoc2VuZE1vdXNlRXZlbnRzKQotICAgICAgICBFdmVudERpc3BhdGNoZXIo bm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1l cygpLm1vdXNlZG93bkV2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1bmRl cmx5aW5nRXZlbnQpKTsKKyAgICAgICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZl bnQoU2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5tb3VzZWRvd25FdmVu dCwgbm9kZS0+ZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJseWluZ0V2ZW50LmdldCgp KSk7CiAgICAgbm9kZS0+c2V0QWN0aXZlKHRydWUsIHNob3dQcmVzc2VkTG9vayk7CiAgICAgaWYg KHNlbmRNb3VzZUV2ZW50cykKLSAgICAgICAgRXZlbnREaXNwYXRjaGVyKG5vZGUpLmRpc3BhdGNo RXZlbnQoU2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5tb3VzZXVwRXZl bnQsIG5vZGUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCksIHVuZGVybHlpbmdFdmVudCkpOwor ICAgICAgICBFdmVudERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVudChTaW11bGF0ZWRNb3Vz ZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLm1vdXNldXBFdmVudCwgbm9kZS0+ZG9jdW1lbnQo KS0+ZGVmYXVsdFZpZXcoKSwgdW5kZXJseWluZ0V2ZW50LmdldCgpKSk7CiAgICAgbm9kZS0+c2V0 QWN0aXZlKGZhbHNlKTsKIAogICAgIC8vIGFsd2F5cyBzZW5kIGNsaWNrCi0gICAgRXZlbnREaXNw YXRjaGVyKG5vZGUpLmRpc3BhdGNoRXZlbnQoU2ltdWxhdGVkTW91c2VFdmVudDo6Y3JlYXRlKGV2 ZW50TmFtZXMoKS5jbGlja0V2ZW50LCBub2RlLT5kb2N1bWVudCgpLT5kZWZhdWx0VmlldygpLCB1 bmRlcmx5aW5nRXZlbnQpKTsKKyAgICBFdmVudERpc3BhdGNoZXIobm9kZSkuZGlzcGF0Y2hFdmVu dChTaW11bGF0ZWRNb3VzZUV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmNsaWNrRXZlbnQsIG5v ZGUtPmRvY3VtZW50KCktPmRlZmF1bHRWaWV3KCksIHVuZGVybHlpbmdFdmVudC5nZXQoKSkpOwog CiAgICAgZ05vZGVzRGlzcGF0Y2hpbmdTaW11bGF0ZWRDbGlja3MtPnJlbW92ZShub2RlKTsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuaAppbmRleCA1YmZlYWQwZDBlNmNiZTBiODAw MzRkNDIyNWE2MGUzMjRkZmFjODM5Li5hNzU1MmVhNWU2ZDYxZDRlNzVhMzQ0ZGYyMTZiNWI1YjU1 ZGY0MGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5oCkBAIC03Miw3ICs3Miw3 IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBkaXNwYXRjaEV2ZW50KE5vZGUqLCBQYXNzUmVm UHRyPEV2ZW50RGlzcGF0Y2hNZWRpYXRvcj4pOwogICAgIHN0YXRpYyB2b2lkIGRpc3BhdGNoU2Nv cGVkRXZlbnQoTm9kZSosIFBhc3NSZWZQdHI8RXZlbnREaXNwYXRjaE1lZGlhdG9yPik7CiAKLSAg ICBzdGF0aWMgdm9pZCBkaXNwYXRjaFNpbXVsYXRlZENsaWNrKE5vZGUqLCBQYXNzUmVmUHRyPEV2 ZW50PiB1bmRlcmx5aW5nRXZlbnQsIGJvb2wgc2VuZE1vdXNlRXZlbnRzLCBib29sIHNob3dQcmVz c2VkTG9vayk7CisgICAgc3RhdGljIHZvaWQgZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhOb2RlKiwg UGFzc1JlZlB0cjxFdmVudD4gcHJwVW5kZXJseWluZ0V2ZW50LCBib29sIHNlbmRNb3VzZUV2ZW50 cywgYm9vbCBzaG93UHJlc3NlZExvb2spOwogCiAgICAgYm9vbCBkaXNwYXRjaEV2ZW50KFBhc3NS ZWZQdHI8RXZlbnQ+KTsKICAgICB2b2lkIGFkanVzdFJlbGF0ZWRUYXJnZXQoRXZlbnQqLCBQYXNz UmVmUHRyPEV2ZW50VGFyZ2V0PiBwcnBSZWxhdGVkVGFyZ2V0KTsK 174736 2012-11-16 12:02:54 -0800 2012-11-16 13:42:20 -0800 Patch bug-102468-20121116120050.patch text/plain 4689 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3YTliZTk4OTQ1NGRh NTZkMmY5OTM2MjBjMGIxZGU4NTFkYWY3YS4uMzA1M2RiMzk1OGUwYzk4YjJmNzgyNWVkNTBhZmRi ZDUyNzBjOTBjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTExLTE2ICBKb24g TGVlICA8am9ubGVlQGFwcGxlLmNvbT4KKworICAgICAgICBTaW11bGF0ZWQgZXZlbnRzIGluc3Rh bmNlcyBkbyBub3QgYWxsIGhhdmUgdGhlIHNhbWUgdW5kZXJseWluZyBldmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNDY4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xMjcxNjMzMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgUGFzc1JlZlB0ciB3aXRoIHRoZSB1bmRlcmx5aW5nIGV2ZW50 IGlzIGluY2x1ZGVkIGFzIGFuIGFyZ3VtZW50IGZvciB0aGUgbW91c2UKKyAgICAgICAgZG93biwg dXAsIGFuZCBjbGljayBldmVudHMuIEJ1dCB0aGUgUGFzc1JlZlB0ciBsb3NlcyBpdHMgdW5kZXJs eWluZyBwb2ludGVyIGFmdGVyCisgICAgICAgIHRoZSBmaXJzdCBzaW11bGF0ZWQgbW91c2UgZG93 biBldmVudCBiZWNhdXNlIGl0IGdldHMgYXNzaWduZWQgdG8gdGhhdCBldmVudCdzCisgICAgICAg IHByaXZhdGUgbV91bmRlcmx5aW5nRXZlbnQgdmFyaWFibGUuIFdlIHRoZXJlZm9yZSBzZW5kIE5V TEwgdG8gdGhlIG90aGVyIGV2ZW50cy4KKworICAgICAgICBUaGUgZml4IGlzIGZvciB0aGlzIGFu ZCByZWxhdGVkIGZ1bmN0aW9ucyB0byBwYXNzIHRoZSByYXcgcG9pbnRlci4KKworICAgICAgICBB IGxheW91dCB0ZXN0IGlzIG5vdCBwb3NzaWJsZSB0byBwdXQgdG9nZXRoZXIgYmVjYXVzZSB0aGUg Y2FsbCBzaXRlcyB0aGF0IHVzZSBzaW11bGF0ZWQKKyAgICAgICAgZXZlbnRzIHdpdGggYW4gdW5k ZXJseWluZyBldmVudCBkbyBub3Qgc2VuZCBtb3VzZSBldmVudHMsIGFuZCB0aG9zZSB0aGF0IHNl bmQgbW91c2UKKyAgICAgICAgZXZlbnRzIGhhdmUgYSBOVUxMIHVuZGVybHlpbmcgZXZlbnQuCisK KyAgICAgICAgKiBkb20vRXZlbnREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2 ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayk6IFJlcXVpcmUgcGFzc2luZyBp biB0aGUgcmF3IHBvaW50ZXIuCisgICAgICAgICogZG9tL0V2ZW50RGlzcGF0Y2hlci5oOgorICAg ICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmRpc3BhdGNoU2lt dWxhdGVkQ2xpY2spOiBEaXR0by4KKyAgICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDEyLTExLTE1 ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgdmlzdWFsIGxv b2sgb2YgcGxhY2Vob2xkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERp c3BhdGNoZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKaW5k ZXggYjNjNjM5YWM4MzQ2MzYwNWI0NWJiNzNmMGRhNGJjM2NmOGM0NWQwYi4uNjU0MDk1ODZhZDQ3 MWJkYjJmYWVjZmI4MjUyZDMyMDQwNjU5OWE0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlz cGF0Y2hlci5jcHAKQEAgLTIwOCw3ICsyMDgsNyBAQCB2b2lkIEV2ZW50RGlzcGF0Y2hlcjo6ZGlz cGF0Y2hTY29wZWRFdmVudChOb2RlKiBub2RlLCBQYXNzUmVmUHRyPEV2ZW50RGlzcGF0Y2hNZQog ICAgIFNjb3BlZEV2ZW50UXVldWU6Omluc3RhbmNlKCktPmVucXVldWVFdmVudERpc3BhdGNoTWVk aWF0b3IobWVkaWF0b3IpOwogfQogCi12b2lkIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hTaW11 bGF0ZWRDbGljayhOb2RlKiBub2RlLCBQYXNzUmVmUHRyPEV2ZW50PiB1bmRlcmx5aW5nRXZlbnQs IGJvb2wgc2VuZE1vdXNlRXZlbnRzLCBib29sIHNob3dQcmVzc2VkTG9vaykKK3ZvaWQgRXZlbnRE aXNwYXRjaGVyOjpkaXNwYXRjaFNpbXVsYXRlZENsaWNrKE5vZGUqIG5vZGUsIEV2ZW50KiB1bmRl cmx5aW5nRXZlbnQsIGJvb2wgc2VuZE1vdXNlRXZlbnRzLCBib29sIHNob3dQcmVzc2VkTG9vaykK IHsKICAgICBpZiAobm9kZS0+ZGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5oIGIvU291cmNlL1dlYkNvcmUv ZG9tL0V2ZW50RGlzcGF0Y2hlci5oCmluZGV4IDViZmVhZDBkMGU2Y2JlMGI4MDAzNGQ0MjI1YTYw ZTMyNGRmYWM4MzkuLmU3M2QzMTY4MDE2ZWIzMTBkOWUzY2U4MzY5YTNlNzAwNjU1OGYyNGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmgKQEAgLTcyLDcgKzcyLDcgQEAgcHVibGlj OgogICAgIHN0YXRpYyBib29sIGRpc3BhdGNoRXZlbnQoTm9kZSosIFBhc3NSZWZQdHI8RXZlbnRE aXNwYXRjaE1lZGlhdG9yPik7CiAgICAgc3RhdGljIHZvaWQgZGlzcGF0Y2hTY29wZWRFdmVudChO b2RlKiwgUGFzc1JlZlB0cjxFdmVudERpc3BhdGNoTWVkaWF0b3I+KTsKIAotICAgIHN0YXRpYyB2 b2lkIGRpc3BhdGNoU2ltdWxhdGVkQ2xpY2soTm9kZSosIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVy bHlpbmdFdmVudCwgYm9vbCBzZW5kTW91c2VFdmVudHMsIGJvb2wgc2hvd1ByZXNzZWRMb29rKTsK KyAgICBzdGF0aWMgdm9pZCBkaXNwYXRjaFNpbXVsYXRlZENsaWNrKE5vZGUqLCBFdmVudCogdW5k ZXJseWluZ0V2ZW50LCBib29sIHNlbmRNb3VzZUV2ZW50cywgYm9vbCBzaG93UHJlc3NlZExvb2sp OwogCiAgICAgYm9vbCBkaXNwYXRjaEV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+KTsKICAgICB2b2lk IGFkanVzdFJlbGF0ZWRUYXJnZXQoRXZlbnQqLCBQYXNzUmVmUHRyPEV2ZW50VGFyZ2V0PiBwcnBS ZWxhdGVkVGFyZ2V0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCBmYjkzNmZjYTJlMGIyYmVlMWIxYThk ZmU2ZjJiODg5OWVmNjM1MTRhLi5mY2I2OTM1ZDAwZjdjNTVhZmI0M2IxYzg0YjUxYTFkYmM4Nzdm ZTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC0yNjE0LDkgKzI2MTQsOSBAQCBib29sIE5vZGU6OmRp c3BhdGNoR2VzdHVyZUV2ZW50KGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBldmVudCkKIH0K ICNlbmRpZgogCi12b2lkIE5vZGU6OmRpc3BhdGNoU2ltdWxhdGVkQ2xpY2soUGFzc1JlZlB0cjxF dmVudD4gZXZlbnQsIGJvb2wgc2VuZE1vdXNlRXZlbnRzLCBib29sIHNob3dQcmVzc2VkTG9vaykK K3ZvaWQgTm9kZTo6ZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhFdmVudCogdW5kZXJseWluZ0V2ZW50 LCBib29sIHNlbmRNb3VzZUV2ZW50cywgYm9vbCBzaG93UHJlc3NlZExvb2spCiB7Ci0gICAgRXZl bnREaXNwYXRjaGVyOjpkaXNwYXRjaFNpbXVsYXRlZENsaWNrKHRoaXMsIGV2ZW50LCBzZW5kTW91 c2VFdmVudHMsIHNob3dQcmVzc2VkTG9vayk7CisgICAgRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRj aFNpbXVsYXRlZENsaWNrKHRoaXMsIHVuZGVybHlpbmdFdmVudCwgc2VuZE1vdXNlRXZlbnRzLCBz aG93UHJlc3NlZExvb2spOwogfQogCiBib29sIE5vZGU6OmRpc3BhdGNoQmVmb3JlTG9hZEV2ZW50 KGNvbnN0IFN0cmluZyYgc291cmNlVVJMKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9t L05vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggZDA0MTc1MjI3ZDMwNzk4 OTI5YWYwNzQwYWZiOGVmNGMyYjViYzE3Yy4uNDY2MmVhYWNjYmY1NmRiNjlkMTUzNzExYWI5ZWVh NmU2NWUyODYzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCkBAIC02NDAsNyArNjQwLDcgQEAgcHVibGljOgogI2lm IEVOQUJMRShHRVNUVVJFX0VWRU5UUykKICAgICBib29sIGRpc3BhdGNoR2VzdHVyZUV2ZW50KGNv bnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50Jik7CiAjZW5kaWYKLSAgICB2b2lkIGRpc3BhdGNoU2lt dWxhdGVkQ2xpY2soUGFzc1JlZlB0cjxFdmVudD4gdW5kZXJseWluZ0V2ZW50LCBib29sIHNlbmRN b3VzZUV2ZW50cyA9IGZhbHNlLCBib29sIHNob3dQcmVzc2VkTG9vayA9IHRydWUpOworICAgIHZv aWQgZGlzcGF0Y2hTaW11bGF0ZWRDbGljayhFdmVudCogdW5kZXJseWluZ0V2ZW50LCBib29sIHNl bmRNb3VzZUV2ZW50cyA9IGZhbHNlLCBib29sIHNob3dQcmVzc2VkTG9vayA9IHRydWUpOwogICAg IGJvb2wgZGlzcGF0Y2hCZWZvcmVMb2FkRXZlbnQoY29uc3QgU3RyaW5nJiBzb3VyY2VVUkwpOwog CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoRm9jdXNFdmVudChQYXNzUmVmUHRyPE5vZGU+IG9s ZEZvY3VzZWROb2RlKTsK