102446 2012-11-15 16:36:07 -0800 Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. 2012-11-26 13:45:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson allan.jensen cmarcelo menard tony webkit.review.bot oldest_to_newest 768661 0 macpherson 2012-11-15 16:36:07 -0800 Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. 768663 1 174555 macpherson 2012-11-15 16:38:08 -0800 Created attachment 174555 Patch 768952 2 174555 ap 2012-11-15 23:02:47 -0800 Comment on attachment 174555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174555&action=review > Source/WebCore/ChangeLog:8 > + !m_parentNode || !value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law). Would it make sense to ASSERT it? 770196 3 174555 macpherson 2012-11-18 15:09:28 -0800 Comment on attachment 174555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174555&action=review >> Source/WebCore/ChangeLog:8 >> + !m_parentNode || !value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law). > > Would it make sense to ASSERT it? Not really. It's a mathematical certainty. This is likely a case where the original author was simply unaware of isInherit. 772126 4 174555 allan.jensen 2012-11-20 13:43:01 -0800 Comment on attachment 174555 Patch Looks good to me. Not everyday you see mathematical proven patches. 775828 5 174555 tony 2012-11-26 13:34:32 -0800 Comment on attachment 174555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174555&action=review >>> Source/WebCore/ChangeLog:8 >>> + !m_parentNode || !value->isInheritedValue() is equivalent to !isInherit (by De Morgan's law). >> >> Would it make sense to ASSERT it? > > Not really. It's a mathematical certainty. This is likely a case where the original author was simply unaware of isInherit. FWIW, refactoring could cause this to get out of sync, so I don't think it would hurt. That said, we don't do that for other cases in the switch, so it's probably not a big deal. 775842 6 174555 webkit.review.bot 2012-11-26 13:44:57 -0800 Comment on attachment 174555 Patch Clearing flags on attachment: 174555 Committed r135760: <http://trac.webkit.org/changeset/135760> 775843 7 webkit.review.bot 2012-11-26 13:45:00 -0800 All reviewed patches have been landed. Closing bug. 174555 2012-11-15 16:38:08 -0800 2012-11-26 13:44:57 -0800 Patch bug-102446-20121116113605.patch text/plain 1641 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjgxZTgxMDJlZjQ1NGM4 MDA1NzQ5ZDhiMDMxMWViMTVhM2IxZWQ2Mi4uYWU2ZTE2MDBmNDliZGIwMzIyMzJlYjY1N2ZhZmM2 NzQzNDhkNjM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE1ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBT dHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5IHVzZSBpc0luaGVyaXQgaW4gQ1NTUHJvcGVydHlX ZWJraXRNYXJxdWVlIGluc3RlYWQgb2YgY2FsY3VsYXRpbmcgZXF1aXZhbGVudCBpbi1wbGFjZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICFtX3BhcmVu dE5vZGUgfHwgIXZhbHVlLT5pc0luaGVyaXRlZFZhbHVlKCkgaXMgZXF1aXZhbGVudCB0byAhaXNJ bmhlcml0IChieSBEZSBNb3JnYW4ncyBsYXcpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAvIGNv ZGUgaXMgcHJvdmFibHkgZXF1aXZhbGVudC4KKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkpOgor CiAyMDEyLTExLTE1ICBFbGxpb3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIE11dGF0aW9uT2JzZXJ2ZXIgd3JhcHBlciBzaG91bGQgbm90IGJlIGNvbGxlY3RlZCB3 aGlsZSBzdGlsbCBvYnNlcnZpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAppbmRl eCBjZWIyZWI4MTI1NTZlZGNiZDNhNDg1ZTU0NWRjMmY2NDBmZWU0MmJlLi44ZGM5MjVmZTA5MTk1 NTRjZjk1NDYyOWQwY2RjMTIyMjlhMmQ3NmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j c3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2 ZXIuY3BwCkBAIC0zMjMyLDcgKzMyMzIsNyBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJv cGVydHkoQ1NTUHJvcGVydHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAgICAgICAgICAgbV9z dHlsZS0+cmVzZXRDb2x1bW5SdWxlKCk7CiAgICAgICAgIHJldHVybjsKICAgICBjYXNlIENTU1By b3BlcnR5V2Via2l0TWFycXVlZToKLSAgICAgICAgaWYgKCFtX3BhcmVudE5vZGUgfHwgIXZhbHVl LT5pc0luaGVyaXRlZFZhbHVlKCkpCisgICAgICAgIGlmICghaXNJbmhlcml0KQogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICBtX3N0eWxlLT5zZXRNYXJxdWVlRGlyZWN0aW9uKG1fcGFyZW50 U3R5bGUtPm1hcnF1ZWVEaXJlY3Rpb24oKSk7CiAgICAgICAgIG1fc3R5bGUtPnNldE1hcnF1ZWVJ bmNyZW1lbnQobV9wYXJlbnRTdHlsZS0+bWFycXVlZUluY3JlbWVudCgpKTsK