102445 2012-11-15 16:34:35 -0800 DFG should copy propagate trivially no-op ConvertThis 2012-11-15 22:20:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 102327 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 768658 0 fpizlo 2012-11-15 16:34:35 -0800 Patch forthcoming. 768672 1 174556 fpizlo 2012-11-15 16:43:22 -0800 Created attachment 174556 the patch 768683 2 174556 oliver 2012-11-15 16:49:49 -0800 Comment on attachment 174556 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=174556&action=review > Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:713 > ASSERT_NOT_REACHED(); CRASH()? 768685 3 fpizlo 2012-11-15 16:52:17 -0800 (In reply to comment #2) > (From update of attachment 174556 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174556&action=review > > > Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:713 > > ASSERT_NOT_REACHED(); > > CRASH()? I will change. 768937 4 fpizlo 2012-11-15 22:20:48 -0800 Landed in http://trac.webkit.org/changeset/134896 174556 2012-11-15 16:43:22 -0800 2012-11-15 16:49:49 -0800 the patch convertthis.patch text/plain 7685 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM0ODU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA CisyMDEyLTExLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBjb3B5IHByb3BhZ2F0ZSB0cml2aWFsbHkgbm8tb3AgQ29udmVydFRoaXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQ0NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcHkgcHJvcGFn YXRpb24gaXMgYWx3YXlzIGEgZ29vZCB0aGluZywgc2luY2UgaXQgcmV2ZWFscyBtdXN0LWFsaWFz IHJlbGF0aW9uc2hpcHMKKyAgICAgICAgdG8gdGhlIENGQSBhbmQgQ1NFLiBUaGlzIGFjY29tcGxp c2hlcyBjb3B5IHByb3BhZ2F0aW9uIGZvciBDb252ZXJ0VGhpcyBieSBmaXJzdAorICAgICAgICBj b252ZXJ0aW5nIGl0IHRvIGFuIElkZW50aXR5IG5vZGUgKHdoaWNoIGlzIGRvbmUgYnkgdGhlIGNv bnN0YW50IGZvbGRlciBzaW5jZSBpdAorICAgICAgICBoYXMgYWNjZXNzIHRvIENGQSByZXN1bHRz KSBhbmQgdGhlbiBwZXJmb3JtaW5nIHN1YnN0aXR1dGlvbiBvZiByZWZlcmVuY2VzIHRvCisgICAg ICAgIElkZW50aXR5IHdpdGggcmVmZXJlbmNlcyB0byBJZGVudGl0eSdzIGNodWxkIGluIHRoZSBD U0UuCisgICAgICAgIAorICAgICAgICBJJ20gbm90IGFpbWluZyBmb3IgYSBiaWcgc3BlZWQtdXAg aGVyZTsgSSBqdXN0IHRoaW5rIHRoYXQgdGhpcyB3aWxsIGJlIHVzZWZ1bCBmb3IKKyAgICAgICAg dGhlIHdvcmsgb24gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMy Ny4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6 REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRlKToKKyAgICAgICAgKiBkZmcvREZHQ1NFUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkNTRVBoYXNlOjpwZXJmb3JtTm9kZUNTRSk6CisgICAg ICAgICogZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1BoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpDb25zdGFudEZvbGRpbmdQaGFzZTo6Zm9sZENvbnN0YW50cyk6CisgICAgICAgICogZGZnL0RG R05vZGVUeXBlLmg6CisgICAgICAgIChERkcpOgorICAgICAgICAqIGRmZy9ERkdQcmVkaWN0aW9u UHJvcGFnYXRpb25QaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6UHJlZGljdGlvblByb3Bh Z2F0aW9uUGhhc2U6OnByb3BhZ2F0ZSk6CisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklU MzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToK KyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDEyLTExLTE0ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgU3RydWN0dXJlIHNob3VsZCBiZSBhYmxlIHRv IGVhc2lseSB0ZWxsIGlmIHRoZSBwcm90b3R5cGUgY2hhaW4gbWlnaHQgaW50ZXJjZXB0IGEgc3Rv cmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRl LmNwcAkocmV2aXNpb24gMTM0ODM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdB YnN0cmFjdFN0YXRlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU3LDYgKzI1NywxMiBAQCBib29s IEFic3RyYWN0U3RhdGU6OmV4ZWN1dGUodW5zaWduZWQgaW5kCiAgICAgICAgIG5vZGUuc2V0Q2Fu RXhpdChmYWxzZSk7CiAgICAgICAgIGJyZWFrOwogICAgIH0KKyAgICAgICAgCisgICAgY2FzZSBJ ZGVudGl0eTogeworICAgICAgICBmb3JOb2RlKG5vZGVJbmRleCkgPSBmb3JOb2RlKG5vZGUuY2hp bGQxKCkpOworICAgICAgICBub2RlLnNldENhbkV4aXQoZmFsc2UpOworICAgICAgICBicmVhazsK KyAgICB9CiAgICAgICAgICAgICAKICAgICBjYXNlIEdldExvY2FsOiB7CiAgICAgICAgIFZhcmlh YmxlQWNjZXNzRGF0YSogdmFyaWFibGVBY2Nlc3NEYXRhID0gbm9kZS52YXJpYWJsZUFjY2Vzc0Rh dGEoKTsKQEAgLTEyNDYsNiArMTI1Miw3IEBAIGJvb2wgQWJzdHJhY3RTdGF0ZTo6ZXhlY3V0ZSh1 bnNpZ25lZCBpbmQKICAgICAgICAgICAgIC8vIGJlIGhpdCwgYnV0IHRoZW4gYWdhaW4sIHlvdSBu ZXZlciBrbm93LgogICAgICAgICAgICAgZGVzdGluYXRpb24gPSBzb3VyY2U7CiAgICAgICAgICAg ICBub2RlLnNldENhbkV4aXQoZmFsc2UpOworICAgICAgICAgICAgbV9mb3VuZENvbnN0YW50cyA9 IHRydWU7IC8vIFRlbGwgdGhlIGNvbnN0YW50IGZvbGRlciB0byB0dXJuIHRoaXMgaW50byBJZGVu dGl0eS4KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDU0VQaGFzZS5jcHAJKHJldmlzaW9uIDEzNDgzNikK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMDQzLDYgKzEwNDMsMTAgQEAgcHJpdmF0ZToKICAgICAgICAgCiAgICAgICAgIHN3 aXRjaCAobm9kZS5vcCgpKSB7CiAgICAgICAgIAorICAgICAgICBjYXNlIElkZW50aXR5OgorICAg ICAgICAgICAgc2V0UmVwbGFjZW1lbnQobm9kZS5jaGlsZDEoKS5pbmRleCgpKTsKKyAgICAgICAg ICAgIGJyZWFrOworICAgICAgICAgICAgCiAgICAgICAgIC8vIEhhbmRsZSB0aGUgcHVyZSBub2Rl cy4gVGhlc2Ugbm9kZXMgbmV2ZXIgaGF2ZSBhbnkgc2lkZS1lZmZlY3RzLgogICAgICAgICBjYXNl IEJpdEFuZDoKICAgICAgICAgY2FzZSBCaXRPcjoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhhc2UuY3BwCShyZXZpc2lvbiAx MzQ4MzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NvbnN0YW50Rm9sZGluZ1Bo YXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDYgKzEzMiwxMyBAQCBwcml2YXRlOgogICAg ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIAorICAg ICAgICAgICAgY2FzZSBDb252ZXJ0VGhpczogeworICAgICAgICAgICAgICAgIGlmICghaXNPYmpl Y3RTcGVjdWxhdGlvbihtX3N0YXRlLmZvck5vZGUobm9kZS5jaGlsZDEoKSkubV90eXBlKSkKKyAg ICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgbm9kZS5zZXRPcEFuZERl ZmF1bHRGbGFncyhJZGVudGl0eSk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICB9CisgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdOb2RlVHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTm9kZVR5cGUuaAkocmV2aXNpb24gMTM0ODM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdOb2RlVHlwZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0MywxMSBAQCBuYW1l c3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAgICAgLyogY29kZSBibG9jay4gKi9cCiAgICAg bWFjcm8oV2Vha0pTQ29uc3RhbnQsIE5vZGVSZXN1bHRKUyB8IE5vZGVEb2VzTm90RXhpdCkgXAog ICAgIFwKKyAgICAvKiBNYXJrZXIgdG8gaW5kaWNhdGUgdGhhdCBhbiBvcGVyYXRpb24gd2FzIG9w dGltaXplZCBlbnRpcmVseSBhbmQgYWxsIHRoYXQgaXMgbGVmdCAqL1wKKyAgICAvKiBpcyB0byBt YWtlIG9uZSBub2RlIGFsaWFzIGFub3RoZXIuIENTRSB3aWxsIGxhdGVyIHVzdWFsbHkgZWxpbWlu YXRlIHRoaXMgbm9kZSwgKi9cCisgICAgLyogdGhvdWdoIGl0IG1heSBjaG9vc2Ugbm90IHRvIGlm IGl0IHdvdWxkIGNvcnJ1cHQgcHJlZGljdGlvbnMgKHZlcnkgcmFyZSkuICovXAorICAgIG1hY3Jv KElkZW50aXR5LCBOb2RlUmVzdWx0SlMgfCBOb2RlRG9lc05vdEV4aXQpIFwKKyAgICBcCiAgICAg LyogTm9kZXMgZm9yIGhhbmRsaW5nIGZ1bmN0aW9ucyAoYm90aCBhcyBjYWxsIGFuZCBhcyBjb25z dHJ1Y3QpLiAqL1wKICAgICBtYWNybyhDb252ZXJ0VGhpcywgTm9kZVJlc3VsdEpTKSBcCiAgICAg bWFjcm8oQ3JlYXRlVGhpcywgTm9kZVJlc3VsdEpTKSAvKiBOb3RlIHRoaXMgaXMgbm90IE11c3RH ZW5lcmF0ZSBzaW5jZSB3ZSdyZSByZXR1cm5pbmcgaXQgYW55d2F5LiAqLyBcCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Qcm9w YWdhdGlvblBoYXNlLmNwcAkocmV2aXNpb24gMTM0ODM2KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdQcmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTcwNiw3ICs3MDYsOCBAQCBwcml2YXRlOgogICAgICAgICBjYXNlIFBoYW50b21Bcmd1bWVu dHM6CiAgICAgICAgIGNhc2UgQ2hlY2tBcnJheToKICAgICAgICAgY2FzZSBBcnJheWlmeToKLSAg ICAgICAgY2FzZSBBcnJheWlmeVRvU3RydWN0dXJlOiB7CisgICAgICAgIGNhc2UgQXJyYXlpZnlU b1N0cnVjdHVyZToKKyAgICAgICAgY2FzZSBJZGVudGl0eTogewogICAgICAgICAgICAgLy8gVGhp cyBub2RlIHNob3VsZCBuZXZlciBiZSB2aXNpYmxlIGF0IHRoaXMgc3RhZ2Ugb2YgY29tcGlsYXRp b24uIEl0IGlzCiAgICAgICAgICAgICAvLyBpbnNlcnRlZCBieSBmaXh1cCgpLCB3aGljaCBmb2xs b3dzIHRoaXMgcGhhc2UuCiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMy XzY0LmNwcAkocmV2aXNpb24gMTM0ODM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEyOSw2ICsyMTI5 LDE4IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAg aW5pdENvbnN0YW50SW5mbyhtX2NvbXBpbGVJbmRleCk7CiAgICAgICAgIGJyZWFrOwogCisgICAg Y2FzZSBJZGVudGl0eTogeworICAgICAgICAvLyBUaGlzIGNvdWxkIGJlIGRvbmUgYSBsb3QgYmV0 dGVyLiBXZSB0YWtlIHRoZSBjaGVhcCB3YXkgb3V0IGJlY2F1c2UgSWRlbnRpdHkKKyAgICAgICAg Ly8gaXMgb25seSBnb2luZyB0byBzdGljayBhcm91bmQgYWZ0ZXIgQ1NFIGlmIHdlIGhhZCBwcmVk aWN0aW9uIHdlaXJkbmVzcy4KKyAgICAgICAgSlNWYWx1ZU9wZXJhbmQgb3BlcmFuZCh0aGlzLCBu b2RlLmNoaWxkMSgpKTsKKyAgICAgICAgR1BSVGVtcG9yYXJ5IHJlc3VsdFRhZyh0aGlzKTsKKyAg ICAgICAgR1BSVGVtcG9yYXJ5IHJlc3VsdFBheWxvYWQodGhpcyk7CisgICAgICAgIG1faml0Lm1v dmUob3BlcmFuZC50YWdHUFIoKSwgcmVzdWx0VGFnLmdwcigpKTsKKyAgICAgICAgbV9qaXQubW92 ZShvcGVyYW5kLnBheWxvYWRHUFIoKSwgcmVzdWx0UGF5bG9hZC5ncHIoKSk7CisgICAgICAgIGpz VmFsdWVSZXN1bHQocmVzdWx0VGFnLmdwcigpLCByZXN1bHRQYXlsb2FkLmdwcigpLCBtX2NvbXBp bGVJbmRleCk7CisgICAgICAgIGJyZWFrOworICAgIH0KKwogICAgIGNhc2UgR2V0TG9jYWw6IHsK ICAgICAgICAgU3BlY3VsYXRlZFR5cGUgcHJlZGljdGlvbiA9IG5vZGUudmFyaWFibGVBY2Nlc3NE YXRhKCktPnByZWRpY3Rpb24oKTsKICAgICAgICAgQWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBibG9j aygpLT52YWx1ZXNBdEhlYWQub3BlcmFuZChub2RlLmxvY2FsKCkpOwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCShyZXZpc2lv biAxMzQ4MzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklU NjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTMwLDYgKzIxMzAsMTYgQEAgdm9pZCBTcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAgICAgICBtX2ppdC5hZGRXZWFrUmVmZXJl bmNlKG5vZGUud2Vha0NvbnN0YW50KCkpOwogICAgICAgICBpbml0Q29uc3RhbnRJbmZvKG1fY29t cGlsZUluZGV4KTsKICAgICAgICAgYnJlYWs7CisgICAgICAgIAorICAgIGNhc2UgSWRlbnRpdHk6 IHsKKyAgICAgICAgLy8gVGhpcyBjb3VsZCBiZSBkb25lIGEgbG90IGJldHRlci4gV2UgdGFrZSB0 aGUgY2hlYXAgd2F5IG91dCBiZWNhdXNlIElkZW50aXR5CisgICAgICAgIC8vIGlzIG9ubHkgZ29p bmcgdG8gc3RpY2sgYXJvdW5kIGFmdGVyIENTRSBpZiB3ZSBoYWQgcHJlZGljdGlvbiB3ZWlyZG5l c3MuCisgICAgICAgIEpTVmFsdWVPcGVyYW5kIG9wZXJhbmQodGhpcywgbm9kZS5jaGlsZDEoKSk7 CisgICAgICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhpcywgb3BlcmFuZCk7CisgICAgICAgIG1f aml0Lm1vdmUob3BlcmFuZC5ncHIoKSwgcmVzdWx0LmdwcigpKTsKKyAgICAgICAganNWYWx1ZVJl c3VsdChyZXN1bHQuZ3ByKCksIG1fY29tcGlsZUluZGV4KTsKKyAgICAgICAgYnJlYWs7CisgICAg fQogCiAgICAgY2FzZSBHZXRMb2NhbDogewogICAgICAgICBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0 aW9uID0gbm9kZS52YXJpYWJsZUFjY2Vzc0RhdGEoKS0+cHJlZGljdGlvbigpOwo=