102444 2012-11-15 16:23:39 -0800 [Chromium-Android] Stack overflow in MediaControlsChromiumAndroid.cpp 2012-11-16 10:13:38 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth dino eric.carlson feature-media-reviews qinmin silviapf webkit.review.bot oldest_to_newest 768631 0 wangxianzhu 2012-11-15 16:23:39 -0800 PassRefPtr<MediaControls> MediaControls::create(Document* document) { return MediaControlsChromiumAndroid::create(document); } MediaControls::create calls itself. The 'create' should be 'createControls'. 768652 1 174553 wangxianzhu 2012-11-15 16:31:26 -0800 Created attachment 174553 Patch 768656 2 qinmin 2012-11-15 16:33:23 -0800 lgtm 768657 3 silviapf 2012-11-15 16:33:51 -0800 Thanks, lgtm 769342 4 wangxianzhu 2012-11-16 09:13:32 -0800 @dino and @eric.calson, can you r+? 769406 5 174553 webkit.review.bot 2012-11-16 10:13:35 -0800 Comment on attachment 174553 Patch Clearing flags on attachment: 174553 Committed r134963: <http://trac.webkit.org/changeset/134963> 769407 6 webkit.review.bot 2012-11-16 10:13:38 -0800 All reviewed patches have been landed. Closing bug. 174553 2012-11-15 16:31:26 -0800 2012-11-16 10:13:34 -0800 Patch bug-102444-20121115162923.patch text/plain 1629 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTY4NjRmMzRkOGE3ZmQ0 MzI3MzQ4NWFhMjU0OWQ5NjZlNGQxMWUxZC4uZjE5ZDBjZGEwNjRjYzAwZDY4ZGE1NmE4ZjI4MTEz NDFhOTJlMzY4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTE1ICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVt LUFuZHJvaWRdIFN0YWNrIG92ZXJmbG93IGluIE1lZGlhQ29udHJvbHNDaHJvbWl1bUFuZHJvaWQu Y3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0 NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMuIEhhdmUgYmVlbiBjb3ZlcmVkIGJ5IG1hbnkgZXhpc3RpbmcgbGF5b3V0IHRlc3Rz LgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sc0Nocm9taXVtQW5kcm9pZC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xzOjpjcmVhdGUpOiBDYWxscyBjcmVh dGVDb250cm9scyBpbnN0ZWFkIG9mIGl0c2VsZi4KKwogMjAxMi0xMS0xNSAgSm9lIE1hc29uICA8 am1hc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIERvbid0IGFzc2VydCB3aGVu IG5vdGlmeUF1dGhSZWNlaXZlZCBpcyBjYWxsZWQgd2l0aCBhIGRpZmZlcmVudCBhdXRoIHR5cGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbHNDaHJv bWl1bUFuZHJvaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9s c0Nocm9taXVtQW5kcm9pZC5jcHAKaW5kZXggZjNiYzVhZWU2N2U5ZjAwYjg4MjI3N2ZkZTVlYTM2 MDViODdjMjA0Ny4uNmM5ZWFkZmJmYzdlMjM2Njc2ODAyOTk0ODYzZGQ4ZGJiNGEyNGFhMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sc0Nocm9taXVt QW5kcm9pZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9s c0Nocm9taXVtQW5kcm9pZC5jcHAKQEAgLTU1LDcgKzU1LDcgQEAgTWVkaWFDb250cm9sc0Nocm9t aXVtQW5kcm9pZDo6TWVkaWFDb250cm9sc0Nocm9taXVtQW5kcm9pZChEb2N1bWVudCogZG9jdW1l bnQpCiAKIFBhc3NSZWZQdHI8TWVkaWFDb250cm9scz4gTWVkaWFDb250cm9sczo6Y3JlYXRlKERv Y3VtZW50KiBkb2N1bWVudCkKIHsKLSAgICByZXR1cm4gTWVkaWFDb250cm9sc0Nocm9taXVtQW5k cm9pZDo6Y3JlYXRlKGRvY3VtZW50KTsKKyAgICByZXR1cm4gTWVkaWFDb250cm9sc0Nocm9taXVt QW5kcm9pZDo6Y3JlYXRlQ29udHJvbHMoZG9jdW1lbnQpOwogfQogCiBQYXNzUmVmUHRyPE1lZGlh Q29udHJvbHNDaHJvbWl1bUFuZHJvaWQ+IE1lZGlhQ29udHJvbHNDaHJvbWl1bUFuZHJvaWQ6OmNy ZWF0ZUNvbnRyb2xzKERvY3VtZW50KiBkb2N1bWVudCkK