102438 2012-11-15 15:11:29 -0800 [Gtk] navigator.plugins contains too many plugin entries. First one are garbages 2013-01-02 15:32:20 -0800 1 1 1 Unclassified WebKit Platform 525.x (Safari 3.2) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier dglazkov gustavo rniwa webkit.review.bot xan.lopez oldest_to_newest 768551 0 a.renevier 2012-11-15 15:11:29 -0800 Hi, if I have 3 plugins, navigator.plugins.length will be 6 navigator.plugins[0], navigator.plugins[1] and navigator.plugins[2] will contain objets with null name, description or filename. So, it looks like first half of navigator.plugins array contains wrong empty objects. 768572 1 174534 a.renevier 2012-11-15 15:29:45 -0800 Created attachment 174534 Patch patch proposal 768668 2 174534 webkit.review.bot 2012-11-15 16:41:47 -0800 Comment on attachment 174534 Patch Attachment 174534 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14860009 New failing tests: plugins/navigator-plugins.html 769462 3 174534 buildbot 2012-11-16 11:01:02 -0800 Comment on attachment 174534 Patch Attachment 174534 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14858548 New failing tests: plugins/navigator-plugins.html 769465 4 174534 a.renevier 2012-11-16 11:02:40 -0800 Comment on attachment 174534 Patch Of course, the test could only pass if the test system have the same number of plugins as me. 769683 5 174763 a.renevier 2012-11-16 14:37:08 -0800 Created attachment 174763 Patch updated patch 780706 6 174763 xan.lopez 2012-12-01 02:59:26 -0800 Comment on attachment 174763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174763&action=review Looks good, r- with just a couple of minor comments. > Source/WebKit/gtk/WebCoreSupport/PlatformStrategiesGtk.cpp:87 > + outPlugins.resize(0); If you look at PluginData::initPlugins() there's an ASSERT(m_plugins.isEmpty()) before calling this method, so I think we can just get rid of the resize(0) too, the vector will be empty always. > LayoutTests/plugins/navigator-plugins.html:29 > +</body> Hrm, it seems this could just be a pure js test in plugins/script-tests no? Look at navigator-mimeTypes-length.js for instance. 782821 7 177530 a.renevier 2012-12-04 12:48:33 -0800 Created attachment 177530 Patch updated patch 783586 8 177530 xan.lopez 2012-12-05 03:14:36 -0800 Comment on attachment 177530 Patch Looks good to me, thanks. 783813 9 177530 webkit.review.bot 2012-12-05 09:10:29 -0800 Comment on attachment 177530 Patch Clearing flags on attachment: 177530 Committed r136697: <http://trac.webkit.org/changeset/136697> 783815 10 webkit.review.bot 2012-12-05 09:10:33 -0800 All reviewed patches have been landed. Closing bug. 798984 11 rniwa 2013-01-02 15:29:55 -0800 The test added by this patch has been failing on Mac WebKit2: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=plugins%2Fnavigator-plugins.html --- /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/plugins/navigator-plugins-expected.txt +++ /Volumes/Data/slave/mountainlion-release-tests-wk2/build/layout-test-results/plugins/navigator-plugins-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS hasInvalidPlugin is false +FAIL hasInvalidPlugin should be false. Was true. PASS successfullyParsed is true TEST COMPLETE 798994 12 rniwa 2013-01-02 15:32:20 -0800 Filed https://bugs.webkit.org/show_bug.cgi?id=105960 to track the test failure. 174534 2012-11-15 15:29:45 -0800 2012-11-16 14:37:06 -0800 Patch bug-102438-20121115152742.patch text/plain 4506 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMzBhNjQwOWNk ZmY0MzY4MGU0YzJhNTg2YTdiN2IyMzA5M2U0MzdjOC4uZDlhZDYzOTIyNmQwZWY4YTVmNTJlNDA2 ZTRlYWU5ZjRjOGYyMzExNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTExLTE1ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0d0a10gbmF2aWdhdG9yLnBsdWdpbnMgY29udGFpbnMgdG9vIG1hbnkgcGx1Z2lu IGVudHJpZXMuIEZpcnN0IG9uZSBhcmUgZ2FyYmFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGdldFBsdWdpbkluZm8sIG91dFBsdWdpbnMgaXMg cmVzaXplZCB0byBwbHVnaW5zLnNpemUgYW5kIHRoZW4sCisgICAgICAgIHBsdWdpbnMgYXJlIGFw cGVuZGVkIHRvIGl0LiBTbyBhdCB0aGUgZW5kLCBvdXRQbHVnaW5zIHdpbGwgYmUgdHdpY2UKKyAg ICAgICAgdG9vIGxhcmdlLCBhbmQgZmlyc3QgaGFsZiB3aWxsIGNvbnRhaW4gbnVsbCBvYmplY3Rz LiBUbyBmaXggdGhhdCwKKyAgICAgICAgcmVzaXplIG91dFBsdWdpbnMgdG8gMCBiZWZvcmUgYXBw ZW5kaW5nIHBsdWdpbnMgdG8gaXQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QbGF0Zm9y bVN0cmF0ZWdpZXNHdGsuY3BwOgorICAgICAgICAoUGxhdGZvcm1TdHJhdGVnaWVzR3RrOjpnZXRQ bHVnaW5JbmZvKToKKwogMjAxMi0xMC0wMSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBz aXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHdGtdIHRvbyBsb25nIGZ1bmN0aW9uIGluIGFu aW1hdGlvbiBzY3JpcHQgY2F1c2UgcmVwYWludCB0byBuZXZlciBoYXBwZW4uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNHdGsu Y3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGxhdGZvcm1TdHJhdGVnaWVz R3RrLmNwcAppbmRleCAwMGE3MDYyYzljZTJlYzNhNWEyNjc4ODE2OWE5YTVmNmIwMjMwODg2Li42 OTQwNjgyNGRjZTRmYzAxYTIzNGRlOWNkYjQ2NzVjMDIxYjY3YmFlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNHdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1BsYXRmb3JtU3RyYXRlZ2llc0d0 ay5jcHAKQEAgLTg0LDcgKzg0LDcgQEAgdm9pZCBQbGF0Zm9ybVN0cmF0ZWdpZXNHdGs6OmdldFBs dWdpbkluZm8oY29uc3QgUGFnZSogcGFnZSwgVmVjdG9yPFBsdWdpbkluZm8+JgogewogICAgIFBs dWdpbkRhdGFiYXNlKiBkYXRhYmFzZSA9IFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQbHVnaW5z KCk7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdpblBhY2thZ2UqPiAmcGx1Z2lucyA9IGRhdGFiYXNl LT5wbHVnaW5zKCk7Ci0gICAgb3V0UGx1Z2lucy5yZXNpemUocGx1Z2lucy5zaXplKCkpOworICAg IG91dFBsdWdpbnMucmVzaXplKDApOwogCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBwbHVn aW5zLnNpemUoKTsgKytpKSB7CiAgICAgICAgIFBsdWdpblBhY2thZ2UqIHBhY2thZ2UgPSBwbHVn aW5zW2ldOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDA2MDUzMzk2NjM4ZWQ1YzUxMTlkMDdlNjE4ZTVmN2ZkMmRhOTNiOTMu LmEwOTg2Njc0NjNkYjk0MDM3MDUzYjQ2ZmQ0MjJiYmU1YjY2MjhlZTIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxMi0xMS0xNSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNh bXN1bmcuY29tPgorCisgICAgICAgIFtHdGtdIG5hdmlnYXRvci5wbHVnaW5zIGNvbnRhaW5zIHRv byBtYW55IHBsdWdpbiBlbnRyaWVzLiBGaXJzdCBvbmUgYXJlIGdhcmJhZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNr IHRoYXQgbmF2aWdhdG9yLnBsdWdpbnMgb25seSBjb250YWluIHZhbGlkIHBsdWdpbgorICAgICAg ICBvYmplY3RzLgorCisgICAgICAgICogcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lucy1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsdWdpbnMvbmF2aWdhdG9yLXBsdWdpbnMuaHRtbDog QWRkZWQuCisKIDIwMTItMTAtMjkgIEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5z YW1zdW5nLmNvbT4KIAogICAgICAgICBpbmNvbnNpc3RlbmN5IGluIGRyYXdJbWFnZSB3aXRoIHRh cmdldCByZWN0IG5lZ2F0aXZlIGRpbWVuc2lvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bHVnaW5zL25hdmlnYXRvci1wbHVnaW5zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsdWdp bnMvbmF2aWdhdG9yLXBsdWdpbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmExZWY5MDM0M2Rm ZjkzNzQ3NTg3MjU4MWVlMjljZDk5MGI2NTY5YTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wbHVnaW5zL25hdmlnYXRvci1wbHVnaW5zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE1 IEBACitDaGVjayB0aGF0IG5hdmlnYXRvci5wbHVnaW5zIGRvZXMgbm90IGNvbnRhaW4gZW1wdHkg cGx1Z2luIG9iamVjdHMKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgISFw bHVnaW4uZGVzY3JpcHRpb24gfHwgISFwbHVnaW4ubmFtZSB8fCAhIXBsdWdpbi5maWxlbmFtZSBp cyB0cnVlCitQQVNTICEhcGx1Z2luLmRlc2NyaXB0aW9uIHx8ICEhcGx1Z2luLm5hbWUgfHwgISFw bHVnaW4uZmlsZW5hbWUgaXMgdHJ1ZQorUEFTUyAhIXBsdWdpbi5kZXNjcmlwdGlvbiB8fCAhIXBs dWdpbi5uYW1lIHx8ICEhcGx1Z2luLmZpbGVuYW1lIGlzIHRydWUKK1BBU1MgISFwbHVnaW4uZGVz Y3JpcHRpb24gfHwgISFwbHVnaW4ubmFtZSB8fCAhIXBsdWdpbi5maWxlbmFtZSBpcyB0cnVlCitQ QVNTICEhcGx1Z2luLmRlc2NyaXB0aW9uIHx8ICEhcGx1Z2luLm5hbWUgfHwgISFwbHVnaW4uZmls ZW5hbWUgaXMgdHJ1ZQorUEFTUyAhIXBsdWdpbi5kZXNjcmlwdGlvbiB8fCAhIXBsdWdpbi5uYW1l IHx8ICEhcGx1Z2luLmZpbGVuYW1lIGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5z L25hdmlnYXRvci1wbHVnaW5zLmh0bWwgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL25hdmlnYXRvci1w bHVnaW5zLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTI1MTUwZDVjMjJlOWY1ZDNjMjQ1NWY4YzhlNmVhM2Iz NjEzZGY3NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvbmF2aWdhdG9y LXBsdWdpbnMuaHRtbApAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0v L0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxz Y3JpcHQ+CisKK2Rlc2NyaXB0aW9uKAorICAgICJDaGVjayB0aGF0IG5hdmlnYXRvci5wbHVnaW5z IGRvZXMgbm90IGNvbnRhaW4gZW1wdHkgcGx1Z2luIG9iamVjdHMiCispOworZm9yICh2YXIgaSA9 IDA7IGkgPCBuYXZpZ2F0b3IucGx1Z2lucy5sZW5ndGg7ICsraSkgeworICAgIHZhciBwbHVnaW4g PSBuYXZpZ2F0b3IucGx1Z2luc1tpXTsKKyAgICBzaG91bGRCZVRydWUoIiEhcGx1Z2luLmRlc2Ny aXB0aW9uIHx8ICEhcGx1Z2luLm5hbWUgfHwgISFwbHVnaW4uZmlsZW5hbWUiKTsKK30KKworc3Vj Y2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4K 174763 2012-11-16 14:37:08 -0800 2012-12-04 12:48:31 -0800 Patch bug-102438-20121116143502.patch text/plain 4213 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMzBhNjQwOWNk ZmY0MzY4MGU0YzJhNTg2YTdiN2IyMzA5M2U0MzdjOC4uZDlhZDYzOTIyNmQwZWY4YTVmNTJlNDA2 ZTRlYWU5ZjRjOGYyMzExNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTExLTE1ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0d0a10gbmF2aWdhdG9yLnBsdWdpbnMgY29udGFpbnMgdG9vIG1hbnkgcGx1Z2lu IGVudHJpZXMuIEZpcnN0IG9uZSBhcmUgZ2FyYmFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGdldFBsdWdpbkluZm8sIG91dFBsdWdpbnMgaXMg cmVzaXplZCB0byBwbHVnaW5zLnNpemUgYW5kIHRoZW4sCisgICAgICAgIHBsdWdpbnMgYXJlIGFw cGVuZGVkIHRvIGl0LiBTbyBhdCB0aGUgZW5kLCBvdXRQbHVnaW5zIHdpbGwgYmUgdHdpY2UKKyAg ICAgICAgdG9vIGxhcmdlLCBhbmQgZmlyc3QgaGFsZiB3aWxsIGNvbnRhaW4gbnVsbCBvYmplY3Rz LiBUbyBmaXggdGhhdCwKKyAgICAgICAgcmVzaXplIG91dFBsdWdpbnMgdG8gMCBiZWZvcmUgYXBw ZW5kaW5nIHBsdWdpbnMgdG8gaXQuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9QbGF0Zm9y bVN0cmF0ZWdpZXNHdGsuY3BwOgorICAgICAgICAoUGxhdGZvcm1TdHJhdGVnaWVzR3RrOjpnZXRQ bHVnaW5JbmZvKToKKwogMjAxMi0xMC0wMSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBz aXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHdGtdIHRvbyBsb25nIGZ1bmN0aW9uIGluIGFu aW1hdGlvbiBzY3JpcHQgY2F1c2UgcmVwYWludCB0byBuZXZlciBoYXBwZW4uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNHdGsu Y3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGxhdGZvcm1TdHJhdGVnaWVz R3RrLmNwcAppbmRleCAwMGE3MDYyYzljZTJlYzNhNWEyNjc4ODE2OWE5YTVmNmIwMjMwODg2Li42 OTQwNjgyNGRjZTRmYzAxYTIzNGRlOWNkYjQ2NzVjMDIxYjY3YmFlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNHdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1BsYXRmb3JtU3RyYXRlZ2llc0d0 ay5jcHAKQEAgLTg0LDcgKzg0LDcgQEAgdm9pZCBQbGF0Zm9ybVN0cmF0ZWdpZXNHdGs6OmdldFBs dWdpbkluZm8oY29uc3QgUGFnZSogcGFnZSwgVmVjdG9yPFBsdWdpbkluZm8+JgogewogICAgIFBs dWdpbkRhdGFiYXNlKiBkYXRhYmFzZSA9IFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQbHVnaW5z KCk7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdpblBhY2thZ2UqPiAmcGx1Z2lucyA9IGRhdGFiYXNl LT5wbHVnaW5zKCk7Ci0gICAgb3V0UGx1Z2lucy5yZXNpemUocGx1Z2lucy5zaXplKCkpOworICAg IG91dFBsdWdpbnMucmVzaXplKDApOwogCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBwbHVn aW5zLnNpemUoKTsgKytpKSB7CiAgICAgICAgIFBsdWdpblBhY2thZ2UqIHBhY2thZ2UgPSBwbHVn aW5zW2ldOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDA2MDUzMzk2NjM4ZWQ1YzUxMTlkMDdlNjE4ZTVmN2ZkMmRhOTNiOTMu LmEwOTg2Njc0NjNkYjk0MDM3MDUzYjQ2ZmQ0MjJiYmU1YjY2MjhlZTIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxMi0xMS0xNSAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNh bXN1bmcuY29tPgorCisgICAgICAgIFtHdGtdIG5hdmlnYXRvci5wbHVnaW5zIGNvbnRhaW5zIHRv byBtYW55IHBsdWdpbiBlbnRyaWVzLiBGaXJzdCBvbmUgYXJlIGdhcmJhZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNr IHRoYXQgbmF2aWdhdG9yLnBsdWdpbnMgb25seSBjb250YWluIHZhbGlkIHBsdWdpbgorICAgICAg ICBvYmplY3RzLgorCisgICAgICAgICogcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lucy1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsdWdpbnMvbmF2aWdhdG9yLXBsdWdpbnMuaHRtbDog QWRkZWQuCisKIDIwMTItMTAtMjkgIEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5z YW1zdW5nLmNvbT4KIAogICAgICAgICBpbmNvbnNpc3RlbmN5IGluIGRyYXdJbWFnZSB3aXRoIHRh cmdldCByZWN0IG5lZ2F0aXZlIGRpbWVuc2lvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bHVnaW5zL25hdmlnYXRvci1wbHVnaW5zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsdWdp bnMvbmF2aWdhdG9yLXBsdWdpbnMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIwODRiOGIzNzE2 ZGJiYWM0ZjJkOWQ2MzBjYjJjYzQ5MGJlODczOGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9wbHVnaW5zL25hdmlnYXRvci1wbHVnaW5zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEw IEBACitDaGVjayB0aGF0IG5hdmlnYXRvci5wbHVnaW5zIGRvZXMgbm90IGNvbnRhaW4gZW1wdHkg cGx1Z2luIG9iamVjdHMKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgaGFz SW52YWxpZFBsdWdpbiBpcyBmYWxzZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQor CitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsdWdpbnMvbmF2aWdh dG9yLXBsdWdpbnMuaHRtbCBiL0xheW91dFRlc3RzL3BsdWdpbnMvbmF2aWdhdG9yLXBsdWdpbnMu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4xYjAyNDM5N2QxYjAxMTM0MGQxMTU1ZWQwNjc3MmVjY2EzNDYxNGVh Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lu cy5odG1sCkBAIC0wLDAgKzEsMzAgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8v RFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBp ZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4K KworZGVzY3JpcHRpb24oCisgICAgIkNoZWNrIHRoYXQgbmF2aWdhdG9yLnBsdWdpbnMgZG9lcyBu b3QgY29udGFpbiBlbXB0eSBwbHVnaW4gb2JqZWN0cyIKKyk7CisKK3ZhciBoYXNJbnZhbGlkUGx1 Z2luID0gZmFsc2U7Citmb3IgKHZhciBpID0gMDsgaSA8IG5hdmlnYXRvci5wbHVnaW5zLmxlbmd0 aDsgKytpKSB7CisgICAgdmFyIHBsdWdpbiA9IG5hdmlnYXRvci5wbHVnaW5zW2ldOworICAgIGlm ICghcGx1Z2luLmRlc2NyaXB0aW9uIHx8ICFwbHVnaW4ubmFtZSB8fCAhcGx1Z2luLmZpbGVuYW1l KSB7CisgICAgICAgIGhhc0ludmFsaWRQbHVnaW4gPSB0cnVlOworICAgICAgICBicmVhazsKKyAg ICB9Cit9CitzaG91bGRCZUZhbHNlKCJoYXNJbnZhbGlkUGx1Z2luIik7CisKK3N1Y2Nlc3NmdWxs eVBhcnNlZCA9IHRydWU7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVz b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 177530 2012-12-04 12:48:33 -0800 2012-12-05 09:10:29 -0800 Patch bug-102438-20121204124557.patch text/plain 4609 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMzBhNjQwOWNk ZmY0MzY4MGU0YzJhNTg2YTdiN2IyMzA5M2U0MzdjOC4uMGJjYzBlZmRhOWI2NzkwMjQ1MDFlMDQx Y2E2MTU5MGY4NjUwNWUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTEyLTA0ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0d0a10gbmF2aWdhdG9yLnBsdWdpbnMgY29udGFpbnMgdG9vIG1hbnkgcGx1Z2lu IGVudHJpZXMuIEZpcnN0IG9uZSBhcmUgZ2FyYmFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjQzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGdldFBsdWdpbkluZm8sIG91dFBsdWdpbnMgaXMg cmVzaXplZCB0byBwbHVnaW5zLnNpemUgYW5kIHRoZW4sCisgICAgICAgIHBsdWdpbnMgYXJlIGFw cGVuZGVkIHRvIGl0LiBTbyBhdCB0aGUgZW5kLCBvdXRQbHVnaW5zIHdpbGwgYmUgdHdpY2UKKyAg ICAgICAgdG9vIGxhcmdlLCBhbmQgZmlyc3QgaGFsZiB3aWxsIGNvbnRhaW4gbnVsbCBvYmplY3Rz LiBBcyBvdXRQbHVnaW5zCisgICAgICAgIHNpemUgaXMgMCB3aGVuIGNhbGxpbmcgZ2V0UGx1Z2lu SW5mbywgd2UgZG9uJ3QgbmVlZCB0byByZXNpemUgaXQuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9QbGF0Zm9ybVN0cmF0ZWdpZXNHdGsuY3BwOgorICAgICAgICAoUGxhdGZvcm1TdHJhdGVn aWVzR3RrOjpnZXRQbHVnaW5JbmZvKToKKwogMjAxMi0xMC0wMSAgQXJuYXVkIFJlbmV2aWVyICA8 YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFtHdGtdIHRvbyBsb25nIGZ1 bmN0aW9uIGluIGFuaW1hdGlvbiBzY3JpcHQgY2F1c2UgcmVwYWludCB0byBuZXZlciBoYXBwZW4u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0 cmF0ZWdpZXNHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvUGxhdGZv cm1TdHJhdGVnaWVzR3RrLmNwcAppbmRleCAwMGE3MDYyYzljZTJlYzNhNWEyNjc4ODE2OWE5YTVm NmIwMjMwODg2Li42YTMxZmEyYmViODNlYjgxNzVmMzhhM2UzYTFiZWQ2ZGM0YTQ1ZmQ2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9QbGF0Zm9ybVN0cmF0ZWdp ZXNHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1BsYXRmb3Jt U3RyYXRlZ2llc0d0ay5jcHAKQEAgLTg0LDcgKzg0LDYgQEAgdm9pZCBQbGF0Zm9ybVN0cmF0ZWdp ZXNHdGs6OmdldFBsdWdpbkluZm8oY29uc3QgUGFnZSogcGFnZSwgVmVjdG9yPFBsdWdpbkluZm8+ JgogewogICAgIFBsdWdpbkRhdGFiYXNlKiBkYXRhYmFzZSA9IFBsdWdpbkRhdGFiYXNlOjppbnN0 YWxsZWRQbHVnaW5zKCk7CiAgICAgY29uc3QgVmVjdG9yPFBsdWdpblBhY2thZ2UqPiAmcGx1Z2lu cyA9IGRhdGFiYXNlLT5wbHVnaW5zKCk7Ci0gICAgb3V0UGx1Z2lucy5yZXNpemUocGx1Z2lucy5z aXplKCkpOwogCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBwbHVnaW5zLnNpemUoKTsgKytp KSB7CiAgICAgICAgIFBsdWdpblBhY2thZ2UqIHBhY2thZ2UgPSBwbHVnaW5zW2ldOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDVmOGRhOWE4OGZkNDYyY2RkMzM5MDYyMTEwYmJhNmMzOWY5NmNmNDIuLmY3ODdiZDE5NzI0OTVi ZjdlYzcyNzVhNDNhYzlmYmQ2Y2FlNjA2YTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0x Mi0wNCAgQXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgorCisg ICAgICAgIFtHdGtdIG5hdmlnYXRvci5wbHVnaW5zIGNvbnRhaW5zIHRvbyBtYW55IHBsdWdpbiBl bnRyaWVzLiBGaXJzdCBvbmUgYXJlIGdhcmJhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNrIHRoYXQgbmF2aWdhdG9y LnBsdWdpbnMgb25seSBjb250YWluIHZhbGlkIHBsdWdpbgorICAgICAgICBvYmplY3RzLgorCisg ICAgICAgICogcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lucy1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIHBsdWdpbnMvbmF2aWdhdG9yLXBsdWdpbnMuaHRtbDogQWRkZWQuCisgICAgICAg ICogcGx1Z2lucy9zY3JpcHQtdGVzdHMvbmF2aWdhdG9yLXBsdWdpbnMuanM6IEFkZGVkLgorCiAy MDEyLTExLTA5ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIGJhc2VsaW5lcyBjaGFuZ2UgLSByZW1vdmUgc3RyYXkgYmFzZWxpbmVzIGZv ciByZWZ0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsdWdpbnMvbmF2aWdhdG9yLXBs dWdpbnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lu cy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjA4NGI4YjM3MTZkYmJhYzRmMmQ5ZDYzMGNiMmNj NDkwYmU4NzM4ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsdWdpbnMvbmF2aWdh dG9yLXBsdWdpbnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK0NoZWNrIHRoYXQgbmF2 aWdhdG9yLnBsdWdpbnMgZG9lcyBub3QgY29udGFpbiBlbXB0eSBwbHVnaW4gb2JqZWN0cworCitP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xs b3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBoYXNJbnZhbGlkUGx1Z2luIGlzIGZh bHNlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lucy5odG1sIGIv TGF5b3V0VGVzdHMvcGx1Z2lucy9uYXZpZ2F0b3ItcGx1Z2lucy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjcw ZTg4YjFmNjZlOTFjNGMyOTRkYWJhOTI1NmI1YzIxZTJhNTA1ODgKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9wbHVnaW5zL25hdmlnYXRvci1wbHVnaW5zLmh0bWwKQEAgLTAsMCArMSwx MiBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0 bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBy ZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9w PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL25h dmlnYXRvci1wbHVnaW5zLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9zY3JpcHQtdGVzdHMvbmF2aWdhdG9yLXBsdWdp bnMuanMgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL3NjcmlwdC10ZXN0cy9uYXZpZ2F0b3ItcGx1Z2lu cy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi5iNjA0OTY5MWUyZjUzMDI3ZDI5Yjg2YzJlYzE5ODVlY2Y4NjdkM2Q4 Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGx1Z2lucy9zY3JpcHQtdGVzdHMvbmF2 aWdhdG9yLXBsdWdpbnMuanMKQEAgLTAsMCArMSwxNSBAQAorZGVzY3JpcHRpb24oCisgICAgIkNo ZWNrIHRoYXQgbmF2aWdhdG9yLnBsdWdpbnMgZG9lcyBub3QgY29udGFpbiBlbXB0eSBwbHVnaW4g b2JqZWN0cyIKKyk7CisKK3ZhciBoYXNJbnZhbGlkUGx1Z2luID0gZmFsc2U7Citmb3IgKHZhciBp ID0gMDsgaSA8IG5hdmlnYXRvci5wbHVnaW5zLmxlbmd0aDsgKytpKSB7CisgICAgdmFyIHBsdWdp biA9IG5hdmlnYXRvci5wbHVnaW5zW2ldOworICAgIGlmICghcGx1Z2luLmRlc2NyaXB0aW9uIHx8 ICFwbHVnaW4ubmFtZSB8fCAhcGx1Z2luLmZpbGVuYW1lKSB7CisgICAgICAgIGhhc0ludmFsaWRQ bHVnaW4gPSB0cnVlOworICAgICAgICBicmVhazsKKyAgICB9Cit9CitzaG91bGRCZUZhbHNlKCJo YXNJbnZhbGlkUGx1Z2luIik7CisKK3N1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==