102426 2012-11-15 13:54:51 -0800 Ignore autocomplete=off for chrome generated passwords. 2012-11-15 16:23:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zysxqn webkit-unassigned abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 768455 0 zysxqn 2012-11-15 13:54:51 -0800 Ignore autocomplete=off for chrome generated passwords. 768462 1 174510 zysxqn 2012-11-15 14:02:13 -0800 Created attachment 174510 Patch 768471 2 webkit.review.bot 2012-11-15 14:07:33 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 768481 3 174510 abarth 2012-11-15 14:16:28 -0800 Comment on attachment 174510 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174510&action=review > Source/WebKit/chromium/public/WebPasswordFormData.h:101 > + // Value of shouldAutocomplete for the password element. > + bool passwordShouldAutocomplete; Can you add an inline constructor that initializes this value to something? 768505 4 174518 zysxqn 2012-11-15 14:35:48 -0800 Created attachment 174518 Patch 768508 5 174518 abarth 2012-11-15 14:39:30 -0800 Comment on attachment 174518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174518&action=review > Source/WebKit/chromium/public/WebPasswordFormData.h:110 > + WebPasswordFormData(): passwordShouldAutocomplete(false) { } This isn't in quite the right style. The appropriate style is as follows: WebPasswordFormData() : passwordShouldAutocomplete(false) { } 768512 6 174521 zysxqn 2012-11-15 14:42:39 -0800 Created attachment 174521 Patch 768516 7 webkit.review.bot 2012-11-15 14:45:37 -0800 Attachment 174521 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/public/WebPasswordFormData.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 768518 8 174521 abarth 2012-11-15 14:47:09 -0800 Comment on attachment 174521 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174521&action=review >> Source/WebKit/chromium/public/WebPasswordFormData.h:111 >> + : passwordShouldAutocomplete(false) > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Yeah, you need two more spaces. 768524 9 174522 zysxqn 2012-11-15 14:50:08 -0800 Created attachment 174522 Patch 768535 10 174522 abarth 2012-11-15 14:53:48 -0800 Comment on attachment 174522 Patch Yay! Thanks! :) 768633 11 174522 webkit.review.bot 2012-11-15 16:23:47 -0800 Comment on attachment 174522 Patch Clearing flags on attachment: 174522 Committed r134852: <http://trac.webkit.org/changeset/134852> 768634 12 webkit.review.bot 2012-11-15 16:23:51 -0800 All reviewed patches have been landed. Closing bug. 174510 2012-11-15 14:02:13 -0800 2012-11-15 14:35:46 -0800 Patch bug-102426-20121115140010.patch text/plain 2884 zysxqn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlYzE4M2MxOWJlZTVjZGZlNGU5Njg2Mzc1NGRiNDQyNWU0ODc2ODYuLmZhMjFjNzc0ZmRkNTIy MWY1ZDAyZWM5NzIxN2I5ODE1ZmY4NjhkNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMTEtMTUgIFl1ZSBaaGFuZyAgPHp5c3hxbkBnb29nbGUuY29t PgorCisgICAgICAgIElnbm9yZSBhdXRvY29tcGxldGU9b2ZmIGZvciBjaHJvbWUgZ2VuZXJhdGVk IHBhc3N3b3Jkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlY29yZCB0aGUgYXV0b2NvbXBsZXRlIGF0dHJpYnV0ZSBpbiB0aGUgd2ViIHBhc3N3b3Jk IGZvcm0gZGF0YSwKKyAgICAgICAgc28gdGhhdCB3ZSBjYW4gaGFuZGxlIGF1dG9jb21wbGV0ZSBp biBjaHJvbWl1bSBjb2RlLiBUaGUKKyAgICAgICAgbW90aXZhdGlvbi9iYWNrZ3JvdW5kIGlzOiB3 ZSBzaG91bGQgaWdub3JlIGF1dG9jb21wbGV0ZT1vZmYgZmllbGQKKyAgICAgICAgZm9yIHBhc3N3 b3JkIGZvcm1zIHdpdGggY2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgKGhhcyBwYXNzZWQKKyAg ICAgICAgc2VjdXJpdHkgcmV2aWV3KS4gQnkgaGFuZGxpbmcgYXV0b2NvbXBsZXRlIGluIGNocm9t aXVtIGNvZGUgd2UgY2FuCisgICAgICAgIGRpc3Rpbmd1aXNoIHBhc3N3b3JkIGZvcm1zIHdpdGgg Y2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgYW5kCisgICAgICAgIHRob3NlIG5vcm1hbCBwYXNz d29yZCBmb3Jtcy4gTm90ZSB0aGF0IHdlIGhhdmVuJ3QgdHVybmVkIG9mZgorICAgICAgICBjaGVj a2luZyBhdXRvY29tcGxldGU9b2ZmIGluIHRoZSBXZWJraXQgY29kZSBmb3Igbm93IHNvIHRoZXJl IGlzCisgICAgICAgIG5vIGJlaGF2aW9yIGNoYW5nZSBhZnRlciB0aGlzIENMLCBhbmQgd2Ugd2ls bCB0dXJuIG9mZiBhZnRlciB3ZQorICAgICAgICBtYWtlIHRoZSBjaHJvbWl1bSBzaWRlIGNoYW5n ZSB0byBiZSBzYWZlLgorCisgICAgICAgICogcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaDoK KyAgICAgICAgKFdlYlBhc3N3b3JkRm9ybURhdGEpOgorICAgICAgICAqIHNyYy9XZWJQYXNzd29y ZEZvcm1EYXRhLmNwcDoKKwogMjAxMi0xMS0xNCAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29t PgogCiAgICAgICAgIER5bmFtaWNhbGx5IGNyZWF0ZSBjYW52YXMgaW4gU2V0dXAoKSB0byBhdm9p ZCBjYWxsaW5nIERFUFJFQ0FURUQgZnVuY3Rpb24gc2V0RGV2aWNlKCkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmgKaW5kZXggYzFh MTA2NTA5NTQ3OGU1OTAyZjA0MTdmMmViMWNhMDUyNDg5ZGU5MS4uNGFhOWZmOTcwNTBiMGZmYTgy MGNhZmQxZmE2YmVmOWFjOGI4ZGQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUGFzc3dvcmRGb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaApAQCAtOTcsNiArOTcsOSBAQCBzdHJ1Y3Qg V2ViUGFzc3dvcmRGb3JtRGF0YSB7CiAgICAgLy8gV2hlbiBwYXJzaW5nIGFuIEhUTUwgZm9ybSwg dGhpcyBpcyB0eXBpY2FsbHkgZW1wdHkuCiAgICAgV2ViU3RyaW5nIHBhc3N3b3JkVmFsdWU7CiAK KyAgICAvLyBWYWx1ZSBvZiBzaG91bGRBdXRvY29tcGxldGUgZm9yIHRoZSBwYXNzd29yZCBlbGVt ZW50LgorICAgIGJvb2wgcGFzc3dvcmRTaG91bGRBdXRvY29tcGxldGU7CisKICAgICAvLyBJZiB0 aGUgZm9ybSB3YXMgYSBjaGFuZ2UgcGFzc3dvcmQgZm9ybSwgdGhlIG5hbWUgb2YgdGhlCiAgICAg Ly8gJ29sZCBwYXNzd29yZCcgaW5wdXQgZWxlbWVudC4gT3B0aW9uYWwuCiAgICAgV2ViU3RyaW5n IG9sZFBhc3N3b3JkRWxlbWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlBhc3N3b3JkRm9ybURhdGEuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViUGFzc3dvcmRGb3JtRGF0YS5jcHAKaW5kZXggZWZkOGRlMzJiNzJhYTY2NDdlODNlZGQyZTY1 ZGI1MWY3MWNhODI0OC4uZmU0MzgyMDBhNmVjZTEzMzg5NWNiMDI0MjY4NzRmYjMzM2NiMmNiNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFzc3dvcmRGb3JtRGF0 YS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFzc3dvcmRGb3JtRGF0 YS5jcHAKQEAgLTEzOCw2ICsxMzgsNyBAQCB2b2lkIGFzc2VtYmxlUGFzc3dvcmRGb3JtUmVzdWx0 KGNvbnN0IEtVUkwmIGZ1bGxPcmlnaW4sCiAgICAgaWYgKHBhc3N3b3JkKSB7CiAgICAgICAgIHJl c3VsdC0+cGFzc3dvcmRFbGVtZW50ID0gcGFzc3dvcmQtPm5hbWUoKTsKICAgICAgICAgcmVzdWx0 LT5wYXNzd29yZFZhbHVlID0gcGFzc3dvcmQtPnZhbHVlKCk7CisgICAgICAgIHJlc3VsdC0+cGFz c3dvcmRTaG91bGRBdXRvY29tcGxldGUgPSBwYXNzd29yZC0+c2hvdWxkQXV0b2NvbXBsZXRlKCk7 CiAgICAgfQogICAgIGlmIChvbGRQYXNzd29yZCkgewogICAgICAgICByZXN1bHQtPm9sZFBhc3N3 b3JkRWxlbWVudCA9IG9sZFBhc3N3b3JkLT5uYW1lKCk7Cg== 174518 2012-11-15 14:35:48 -0800 2012-11-15 14:42:36 -0800 Patch bug-102426-20121115143345.patch text/plain 3054 zysxqn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlYzE4M2MxOWJlZTVjZGZlNGU5Njg2Mzc1NGRiNDQyNWU0ODc2ODYuLmZhMjFjNzc0ZmRkNTIy MWY1ZDAyZWM5NzIxN2I5ODE1ZmY4NjhkNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMTEtMTUgIFl1ZSBaaGFuZyAgPHp5c3hxbkBnb29nbGUuY29t PgorCisgICAgICAgIElnbm9yZSBhdXRvY29tcGxldGU9b2ZmIGZvciBjaHJvbWUgZ2VuZXJhdGVk IHBhc3N3b3Jkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlY29yZCB0aGUgYXV0b2NvbXBsZXRlIGF0dHJpYnV0ZSBpbiB0aGUgd2ViIHBhc3N3b3Jk IGZvcm0gZGF0YSwKKyAgICAgICAgc28gdGhhdCB3ZSBjYW4gaGFuZGxlIGF1dG9jb21wbGV0ZSBp biBjaHJvbWl1bSBjb2RlLiBUaGUKKyAgICAgICAgbW90aXZhdGlvbi9iYWNrZ3JvdW5kIGlzOiB3 ZSBzaG91bGQgaWdub3JlIGF1dG9jb21wbGV0ZT1vZmYgZmllbGQKKyAgICAgICAgZm9yIHBhc3N3 b3JkIGZvcm1zIHdpdGggY2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgKGhhcyBwYXNzZWQKKyAg ICAgICAgc2VjdXJpdHkgcmV2aWV3KS4gQnkgaGFuZGxpbmcgYXV0b2NvbXBsZXRlIGluIGNocm9t aXVtIGNvZGUgd2UgY2FuCisgICAgICAgIGRpc3Rpbmd1aXNoIHBhc3N3b3JkIGZvcm1zIHdpdGgg Y2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgYW5kCisgICAgICAgIHRob3NlIG5vcm1hbCBwYXNz d29yZCBmb3Jtcy4gTm90ZSB0aGF0IHdlIGhhdmVuJ3QgdHVybmVkIG9mZgorICAgICAgICBjaGVj a2luZyBhdXRvY29tcGxldGU9b2ZmIGluIHRoZSBXZWJraXQgY29kZSBmb3Igbm93IHNvIHRoZXJl IGlzCisgICAgICAgIG5vIGJlaGF2aW9yIGNoYW5nZSBhZnRlciB0aGlzIENMLCBhbmQgd2Ugd2ls bCB0dXJuIG9mZiBhZnRlciB3ZQorICAgICAgICBtYWtlIHRoZSBjaHJvbWl1bSBzaWRlIGNoYW5n ZSB0byBiZSBzYWZlLgorCisgICAgICAgICogcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaDoK KyAgICAgICAgKFdlYlBhc3N3b3JkRm9ybURhdGEpOgorICAgICAgICAqIHNyYy9XZWJQYXNzd29y ZEZvcm1EYXRhLmNwcDoKKwogMjAxMi0xMS0xNCAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29t PgogCiAgICAgICAgIER5bmFtaWNhbGx5IGNyZWF0ZSBjYW52YXMgaW4gU2V0dXAoKSB0byBhdm9p ZCBjYWxsaW5nIERFUFJFQ0FURUQgZnVuY3Rpb24gc2V0RGV2aWNlKCkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmgKaW5kZXggYzFh MTA2NTA5NTQ3OGU1OTAyZjA0MTdmMmViMWNhMDUyNDg5ZGU5MS4uZmY3ODVjZTQyZWVjN2E4ODVm ZmU3MGY2Njk3YjliZDE1YjFiYmYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUGFzc3dvcmRGb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaApAQCAtOTcsMTIgKzk3LDE3IEBAIHN0cnVj dCBXZWJQYXNzd29yZEZvcm1EYXRhIHsKICAgICAvLyBXaGVuIHBhcnNpbmcgYW4gSFRNTCBmb3Jt LCB0aGlzIGlzIHR5cGljYWxseSBlbXB0eS4KICAgICBXZWJTdHJpbmcgcGFzc3dvcmRWYWx1ZTsK IAorICAgIC8vIFZhbHVlIG9mIHNob3VsZEF1dG9jb21wbGV0ZSBmb3IgdGhlIHBhc3N3b3JkIGVs ZW1lbnQuCisgICAgYm9vbCBwYXNzd29yZFNob3VsZEF1dG9jb21wbGV0ZTsKKwogICAgIC8vIElm IHRoZSBmb3JtIHdhcyBhIGNoYW5nZSBwYXNzd29yZCBmb3JtLCB0aGUgbmFtZSBvZiB0aGUKICAg ICAvLyAnb2xkIHBhc3N3b3JkJyBpbnB1dCBlbGVtZW50LiBPcHRpb25hbC4KICAgICBXZWJTdHJp bmcgb2xkUGFzc3dvcmRFbGVtZW50OwogCiAgICAgLy8gVGhlIG9sZCBwYXNzd29yZC4gT3B0aW9u YWwuCiAgICAgV2ViU3RyaW5nIG9sZFBhc3N3b3JkVmFsdWU7CisKKyAgICBXZWJQYXNzd29yZEZv cm1EYXRhKCk6IHBhc3N3b3JkU2hvdWxkQXV0b2NvbXBsZXRlKGZhbHNlKSB7IH0KIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViUGFzc3dvcmRGb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQYXNzd29yZEZvcm1EYXRhLmNwcAppbmRleCBlZmQ4ZGUzMmI3MmFhNjY0N2U4M2VkZDJlNjVk YjUxZjcxY2E4MjQ4Li5mZTQzODIwMGE2ZWNlMTMzODk1Y2IwMjQyNjg3NGZiMzMzY2IyY2I0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYXNzd29yZEZvcm1EYXRh LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYXNzd29yZEZvcm1EYXRh LmNwcApAQCAtMTM4LDYgKzEzOCw3IEBAIHZvaWQgYXNzZW1ibGVQYXNzd29yZEZvcm1SZXN1bHQo Y29uc3QgS1VSTCYgZnVsbE9yaWdpbiwKICAgICBpZiAocGFzc3dvcmQpIHsKICAgICAgICAgcmVz dWx0LT5wYXNzd29yZEVsZW1lbnQgPSBwYXNzd29yZC0+bmFtZSgpOwogICAgICAgICByZXN1bHQt PnBhc3N3b3JkVmFsdWUgPSBwYXNzd29yZC0+dmFsdWUoKTsKKyAgICAgICAgcmVzdWx0LT5wYXNz d29yZFNob3VsZEF1dG9jb21wbGV0ZSA9IHBhc3N3b3JkLT5zaG91bGRBdXRvY29tcGxldGUoKTsK ICAgICB9CiAgICAgaWYgKG9sZFBhc3N3b3JkKSB7CiAgICAgICAgIHJlc3VsdC0+b2xkUGFzc3dv cmRFbGVtZW50ID0gb2xkUGFzc3dvcmQtPm5hbWUoKTsK 174521 2012-11-15 14:42:39 -0800 2012-11-15 14:50:05 -0800 Patch bug-102426-20121115144036.patch text/plain 3072 zysxqn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlYzE4M2MxOWJlZTVjZGZlNGU5Njg2Mzc1NGRiNDQyNWU0ODc2ODYuLmZhMjFjNzc0ZmRkNTIy MWY1ZDAyZWM5NzIxN2I5ODE1ZmY4NjhkNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMTEtMTUgIFl1ZSBaaGFuZyAgPHp5c3hxbkBnb29nbGUuY29t PgorCisgICAgICAgIElnbm9yZSBhdXRvY29tcGxldGU9b2ZmIGZvciBjaHJvbWUgZ2VuZXJhdGVk IHBhc3N3b3Jkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlY29yZCB0aGUgYXV0b2NvbXBsZXRlIGF0dHJpYnV0ZSBpbiB0aGUgd2ViIHBhc3N3b3Jk IGZvcm0gZGF0YSwKKyAgICAgICAgc28gdGhhdCB3ZSBjYW4gaGFuZGxlIGF1dG9jb21wbGV0ZSBp biBjaHJvbWl1bSBjb2RlLiBUaGUKKyAgICAgICAgbW90aXZhdGlvbi9iYWNrZ3JvdW5kIGlzOiB3 ZSBzaG91bGQgaWdub3JlIGF1dG9jb21wbGV0ZT1vZmYgZmllbGQKKyAgICAgICAgZm9yIHBhc3N3 b3JkIGZvcm1zIHdpdGggY2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgKGhhcyBwYXNzZWQKKyAg ICAgICAgc2VjdXJpdHkgcmV2aWV3KS4gQnkgaGFuZGxpbmcgYXV0b2NvbXBsZXRlIGluIGNocm9t aXVtIGNvZGUgd2UgY2FuCisgICAgICAgIGRpc3Rpbmd1aXNoIHBhc3N3b3JkIGZvcm1zIHdpdGgg Y2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgYW5kCisgICAgICAgIHRob3NlIG5vcm1hbCBwYXNz d29yZCBmb3Jtcy4gTm90ZSB0aGF0IHdlIGhhdmVuJ3QgdHVybmVkIG9mZgorICAgICAgICBjaGVj a2luZyBhdXRvY29tcGxldGU9b2ZmIGluIHRoZSBXZWJraXQgY29kZSBmb3Igbm93IHNvIHRoZXJl IGlzCisgICAgICAgIG5vIGJlaGF2aW9yIGNoYW5nZSBhZnRlciB0aGlzIENMLCBhbmQgd2Ugd2ls bCB0dXJuIG9mZiBhZnRlciB3ZQorICAgICAgICBtYWtlIHRoZSBjaHJvbWl1bSBzaWRlIGNoYW5n ZSB0byBiZSBzYWZlLgorCisgICAgICAgICogcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaDoK KyAgICAgICAgKFdlYlBhc3N3b3JkRm9ybURhdGEpOgorICAgICAgICAqIHNyYy9XZWJQYXNzd29y ZEZvcm1EYXRhLmNwcDoKKwogMjAxMi0xMS0xNCAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29t PgogCiAgICAgICAgIER5bmFtaWNhbGx5IGNyZWF0ZSBjYW52YXMgaW4gU2V0dXAoKSB0byBhdm9p ZCBjYWxsaW5nIERFUFJFQ0FURUQgZnVuY3Rpb24gc2V0RGV2aWNlKCkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmgKaW5kZXggYzFh MTA2NTA5NTQ3OGU1OTAyZjA0MTdmMmViMWNhMDUyNDg5ZGU5MS4uOWQ2NGMyYzZhZDRhODhhZDZk MDIxYmJlOWZkNTNmZjgyMjBlYTAzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUGFzc3dvcmRGb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaApAQCAtOTcsMTIgKzk3LDIwIEBAIHN0cnVj dCBXZWJQYXNzd29yZEZvcm1EYXRhIHsKICAgICAvLyBXaGVuIHBhcnNpbmcgYW4gSFRNTCBmb3Jt LCB0aGlzIGlzIHR5cGljYWxseSBlbXB0eS4KICAgICBXZWJTdHJpbmcgcGFzc3dvcmRWYWx1ZTsK IAorICAgIC8vIFZhbHVlIG9mIHNob3VsZEF1dG9jb21wbGV0ZSBmb3IgdGhlIHBhc3N3b3JkIGVs ZW1lbnQuCisgICAgYm9vbCBwYXNzd29yZFNob3VsZEF1dG9jb21wbGV0ZTsKKwogICAgIC8vIElm IHRoZSBmb3JtIHdhcyBhIGNoYW5nZSBwYXNzd29yZCBmb3JtLCB0aGUgbmFtZSBvZiB0aGUKICAg ICAvLyAnb2xkIHBhc3N3b3JkJyBpbnB1dCBlbGVtZW50LiBPcHRpb25hbC4KICAgICBXZWJTdHJp bmcgb2xkUGFzc3dvcmRFbGVtZW50OwogCiAgICAgLy8gVGhlIG9sZCBwYXNzd29yZC4gT3B0aW9u YWwuCiAgICAgV2ViU3RyaW5nIG9sZFBhc3N3b3JkVmFsdWU7CisKKyAgICBXZWJQYXNzd29yZEZv cm1EYXRhKCkKKyAgICAgIDogcGFzc3dvcmRTaG91bGRBdXRvY29tcGxldGUoZmFsc2UpCisgICAg eworICAgIH0KIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFzc3dvcmRGb3JtRGF0YS5jcHAgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJQYXNzd29yZEZvcm1EYXRhLmNwcAppbmRleCBlZmQ4ZGUzMmI3 MmFhNjY0N2U4M2VkZDJlNjVkYjUxZjcxY2E4MjQ4Li5mZTQzODIwMGE2ZWNlMTMzODk1Y2IwMjQy Njg3NGZiMzMzY2IyY2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQYXNzd29yZEZvcm1EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJQYXNzd29yZEZvcm1EYXRhLmNwcApAQCAtMTM4LDYgKzEzOCw3IEBAIHZvaWQgYXNzZW1ibGVQ YXNzd29yZEZvcm1SZXN1bHQoY29uc3QgS1VSTCYgZnVsbE9yaWdpbiwKICAgICBpZiAocGFzc3dv cmQpIHsKICAgICAgICAgcmVzdWx0LT5wYXNzd29yZEVsZW1lbnQgPSBwYXNzd29yZC0+bmFtZSgp OwogICAgICAgICByZXN1bHQtPnBhc3N3b3JkVmFsdWUgPSBwYXNzd29yZC0+dmFsdWUoKTsKKyAg ICAgICAgcmVzdWx0LT5wYXNzd29yZFNob3VsZEF1dG9jb21wbGV0ZSA9IHBhc3N3b3JkLT5zaG91 bGRBdXRvY29tcGxldGUoKTsKICAgICB9CiAgICAgaWYgKG9sZFBhc3N3b3JkKSB7CiAgICAgICAg IHJlc3VsdC0+b2xkUGFzc3dvcmRFbGVtZW50ID0gb2xkUGFzc3dvcmQtPm5hbWUoKTsK 174522 2012-11-15 14:50:08 -0800 2012-11-15 16:23:46 -0800 Patch bug-102426-20121115144804.patch text/plain 3074 zysxqn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNlYzE4M2MxOWJlZTVjZGZlNGU5Njg2Mzc1NGRiNDQyNWU0ODc2ODYuLmZhMjFjNzc0ZmRkNTIy MWY1ZDAyZWM5NzIxN2I5ODE1ZmY4NjhkNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMTEtMTUgIFl1ZSBaaGFuZyAgPHp5c3hxbkBnb29nbGUuY29t PgorCisgICAgICAgIElnbm9yZSBhdXRvY29tcGxldGU9b2ZmIGZvciBjaHJvbWUgZ2VuZXJhdGVk IHBhc3N3b3Jkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlY29yZCB0aGUgYXV0b2NvbXBsZXRlIGF0dHJpYnV0ZSBpbiB0aGUgd2ViIHBhc3N3b3Jk IGZvcm0gZGF0YSwKKyAgICAgICAgc28gdGhhdCB3ZSBjYW4gaGFuZGxlIGF1dG9jb21wbGV0ZSBp biBjaHJvbWl1bSBjb2RlLiBUaGUKKyAgICAgICAgbW90aXZhdGlvbi9iYWNrZ3JvdW5kIGlzOiB3 ZSBzaG91bGQgaWdub3JlIGF1dG9jb21wbGV0ZT1vZmYgZmllbGQKKyAgICAgICAgZm9yIHBhc3N3 b3JkIGZvcm1zIHdpdGggY2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgKGhhcyBwYXNzZWQKKyAg ICAgICAgc2VjdXJpdHkgcmV2aWV3KS4gQnkgaGFuZGxpbmcgYXV0b2NvbXBsZXRlIGluIGNocm9t aXVtIGNvZGUgd2UgY2FuCisgICAgICAgIGRpc3Rpbmd1aXNoIHBhc3N3b3JkIGZvcm1zIHdpdGgg Y2hyb21lIGdlbmVyYXRlZCBwYXNzd29yZHMgYW5kCisgICAgICAgIHRob3NlIG5vcm1hbCBwYXNz d29yZCBmb3Jtcy4gTm90ZSB0aGF0IHdlIGhhdmVuJ3QgdHVybmVkIG9mZgorICAgICAgICBjaGVj a2luZyBhdXRvY29tcGxldGU9b2ZmIGluIHRoZSBXZWJraXQgY29kZSBmb3Igbm93IHNvIHRoZXJl IGlzCisgICAgICAgIG5vIGJlaGF2aW9yIGNoYW5nZSBhZnRlciB0aGlzIENMLCBhbmQgd2Ugd2ls bCB0dXJuIG9mZiBhZnRlciB3ZQorICAgICAgICBtYWtlIHRoZSBjaHJvbWl1bSBzaWRlIGNoYW5n ZSB0byBiZSBzYWZlLgorCisgICAgICAgICogcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaDoK KyAgICAgICAgKFdlYlBhc3N3b3JkRm9ybURhdGEpOgorICAgICAgICAqIHNyYy9XZWJQYXNzd29y ZEZvcm1EYXRhLmNwcDoKKwogMjAxMi0xMS0xNCAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29t PgogCiAgICAgICAgIER5bmFtaWNhbGx5IGNyZWF0ZSBjYW52YXMgaW4gU2V0dXAoKSB0byBhdm9p ZCBjYWxsaW5nIERFUFJFQ0FURUQgZnVuY3Rpb24gc2V0RGV2aWNlKCkuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQYXNzd29yZEZvcm1EYXRhLmgKaW5kZXggYzFh MTA2NTA5NTQ3OGU1OTAyZjA0MTdmMmViMWNhMDUyNDg5ZGU5MS4uMTJjMmE1OTc5ZmYyYWI5MjIy Mjc1N2UyYjM0MWFlNzE5Y2MwZmY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViUGFzc3dvcmRGb3JtRGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlBhc3N3b3JkRm9ybURhdGEuaApAQCAtOTcsMTIgKzk3LDIwIEBAIHN0cnVj dCBXZWJQYXNzd29yZEZvcm1EYXRhIHsKICAgICAvLyBXaGVuIHBhcnNpbmcgYW4gSFRNTCBmb3Jt LCB0aGlzIGlzIHR5cGljYWxseSBlbXB0eS4KICAgICBXZWJTdHJpbmcgcGFzc3dvcmRWYWx1ZTsK IAorICAgIC8vIFZhbHVlIG9mIHNob3VsZEF1dG9jb21wbGV0ZSBmb3IgdGhlIHBhc3N3b3JkIGVs ZW1lbnQuCisgICAgYm9vbCBwYXNzd29yZFNob3VsZEF1dG9jb21wbGV0ZTsKKwogICAgIC8vIElm IHRoZSBmb3JtIHdhcyBhIGNoYW5nZSBwYXNzd29yZCBmb3JtLCB0aGUgbmFtZSBvZiB0aGUKICAg ICAvLyAnb2xkIHBhc3N3b3JkJyBpbnB1dCBlbGVtZW50LiBPcHRpb25hbC4KICAgICBXZWJTdHJp bmcgb2xkUGFzc3dvcmRFbGVtZW50OwogCiAgICAgLy8gVGhlIG9sZCBwYXNzd29yZC4gT3B0aW9u YWwuCiAgICAgV2ViU3RyaW5nIG9sZFBhc3N3b3JkVmFsdWU7CisKKyAgICBXZWJQYXNzd29yZEZv cm1EYXRhKCkKKyAgICAgICAgOiBwYXNzd29yZFNob3VsZEF1dG9jb21wbGV0ZShmYWxzZSkKKyAg ICB7CisgICAgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYXNzd29yZEZvcm1EYXRhLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhc3N3b3JkRm9ybURhdGEuY3BwCmluZGV4IGVmZDhkZTMy YjcyYWE2NjQ3ZTgzZWRkMmU2NWRiNTFmNzFjYTgyNDguLmZlNDM4MjAwYTZlY2UxMzM4OTVjYjAy NDI2ODc0ZmIzMzNjYjJjYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlBhc3N3b3JkRm9ybURhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYlBhc3N3b3JkRm9ybURhdGEuY3BwCkBAIC0xMzgsNiArMTM4LDcgQEAgdm9pZCBhc3NlbWJs ZVBhc3N3b3JkRm9ybVJlc3VsdChjb25zdCBLVVJMJiBmdWxsT3JpZ2luLAogICAgIGlmIChwYXNz d29yZCkgewogICAgICAgICByZXN1bHQtPnBhc3N3b3JkRWxlbWVudCA9IHBhc3N3b3JkLT5uYW1l KCk7CiAgICAgICAgIHJlc3VsdC0+cGFzc3dvcmRWYWx1ZSA9IHBhc3N3b3JkLT52YWx1ZSgpOwor ICAgICAgICByZXN1bHQtPnBhc3N3b3JkU2hvdWxkQXV0b2NvbXBsZXRlID0gcGFzc3dvcmQtPnNo b3VsZEF1dG9jb21wbGV0ZSgpOwogICAgIH0KICAgICBpZiAob2xkUGFzc3dvcmQpIHsKICAgICAg ICAgcmVzdWx0LT5vbGRQYXNzd29yZEVsZW1lbnQgPSBvbGRQYXNzd29yZC0+bmFtZSgpOwo=