102422 2012-11-15 13:04:13 -0800 Add setChecked API in WebInputElement 2012-11-16 16:32:07 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ramankk webkit-unassigned abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 768415 0 ramankk 2012-11-15 13:04:13 -0800 WebInputElement doesn't expose the underlying HTMLInputElement's setCheckout API. This is required to enable chromium to check a checkbox element. 769569 1 174742 ramankk 2012-11-16 12:29:09 -0800 Created attachment 174742 Patch 769579 2 webkit.review.bot 2012-11-16 12:36:03 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 769581 3 174742 abarth 2012-11-16 12:38:44 -0800 Comment on attachment 174742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review > Source/WebKit/chromium/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please fill out this part of the ChangeLog. > Source/WebKit/chromium/public/WebInputElement.h:77 > + WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false); Can we use an enum for the second parameter rather than a raw boolean? It looks like HTMLInputElement already uses an enum. 769679 4 174761 ramankk 2012-11-16 14:32:17 -0800 Created attachment 174761 Patch 769684 5 174742 ramankk 2012-11-16 14:39:26 -0800 Comment on attachment 174742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review >> Source/WebKit/chromium/ChangeLog:8 >> + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). > > Please fill out this part of the ChangeLog. Done. Sorry for that, this is my first CL in webkit, still figuring out the process. >> Source/WebKit/chromium/public/WebInputElement.h:77 >> + WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false); > > Can we use an enum for the second parameter rather than a raw boolean? It looks like HTMLInputElement already uses an enum. This change is consistent with setValue(), HTMLInputElement's setValue also uses same enum. I don't exactly understand why bool was preferred here earlier, assuming there is a reason, I am trying to be consistent. 769688 6 174761 abarth 2012-11-16 14:47:27 -0800 Comment on attachment 174761 Patch ok 769762 7 174761 webkit.review.bot 2012-11-16 16:32:03 -0800 Comment on attachment 174761 Patch Clearing flags on attachment: 174761 Committed r135016: <http://trac.webkit.org/changeset/135016> 769763 8 webkit.review.bot 2012-11-16 16:32:07 -0800 All reviewed patches have been landed. Closing bug. 174742 2012-11-16 12:29:09 -0800 2012-11-16 14:39:26 -0800 Patch bug-102422-20121116122704.patch text/plain 2435 ramankk U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI5Zjk5NTEyM2M0M2UwZWNkMDI4MTA4MTRiYjEwMWMxMWFiYTE3OGQuLjcwNmRmMmMzY2Q1N2Q0 OWFmMThlYTcyZTcxMTZhY2EyYmIxMjIyZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTEtMTYgIFJhbWFuIEt1bWFyICA8cmFtYW5ra0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQWRkIHNldENoZWNrZWQgQVBJIGluIFdlYklucHV0RWxlbWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNDIyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaXRpb25h bCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZS4g UGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25zIGJlbG93IChPT1BTISkuCisKKyAg ICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChXZWJJbnB1dEVsZW1l bnQpOgorICAgICAgICAqIHNyYy9XZWJJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJJbnB1dEVsZW1lbnQ6OnNldENoZWNrZWQpOgorICAgICAgICAoV2ViS2l0KToKKwogMjAx Mi0xMS0xNiAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW5wdXRFbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAppbmRleCBmYmMzNTAwMTJhMmUyNTFhN2I1MWYxOWM3NDk4 OTE1ZTE5OWQ3Y2Y2Li4yOTQzMmRmODE1M2E5MTYyOTE2ZDczN2IyMDdjNDk3YTVlN2IwM2U4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaApA QCAtNzQsNiArNzQsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0VYUE9S VCB2b2lkIHNldEFjdGl2YXRlZFN1Ym1pdChib29sKTsKICAgICAgICAgV0VCS0lUX0VYUE9SVCBp bnQgc2l6ZSgpIGNvbnN0OwogICAgICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgc2V0VmFsdWUoY29u c3QgV2ViU3RyaW5nJiwgYm9vbCBzZW5kQ2hhbmdlRXZlbnQgPSBmYWxzZSk7CisgICAgICAgIFdF QktJVF9FWFBPUlQgdm9pZCBzZXRDaGVja2VkKGJvb2wsIGJvb2wgc2VuZENoYW5nZUV2ZW50ID0g ZmFsc2UpOwogICAgICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB2YWx1ZSgpIGNvbnN0Owog ICAgICAgICAvLyBUaGlzIHJldHVybnMgdGhlIG5vbi1zYW5pdGl6ZWQsIGV4YWN0IHZhbHVlIGlu c2lkZSB0aGUgdGV4dCBmaWVsZC4KICAgICAgICAgV0VCS0lUX0VYUE9SVCBXZWJTdHJpbmcgZWRp dGluZ1ZhbHVlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5w dXRFbGVtZW50LmNwcAppbmRleCBiZGM5ZjVkYjI5ZmYzOGZlOGJhN2NjZDYyZTcwMWM2MTFlYmU0 OGY4Li5iZmMwYzIzNmJkOTZlZWMzY2Q1YmJiOTk1Y2E3Y2VlNmQxY2U1ODFmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKQEAgLTE2Myw2ICsx NjMsMTEgQEAgYm9vbCBXZWJJbnB1dEVsZW1lbnQ6OmlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJp bmcmIHZhbHVlKSBjb25zdAogICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRFbGVtZW50 PigpLT5pc1ZhbGlkVmFsdWUodmFsdWUpOwogfQogCit2b2lkIFdlYklucHV0RWxlbWVudDo6c2V0 Q2hlY2tlZChib29sIG5vd0NoZWNrZWQsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQoreworICAgIHVu d3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5zZXRDaGVja2VkKG5vd0NoZWNrZWQsIHNlbmRDaGFu Z2VFdmVudCA/IERpc3BhdGNoQ2hhbmdlRXZlbnQgOiBEaXNwYXRjaE5vRXZlbnQpOworfQorCiBi b29sIFdlYklucHV0RWxlbWVudDo6aXNDaGVja2VkKCkgY29uc3QKIHsKICAgICByZXR1cm4gY29u c3RVbndyYXA8SFRNTElucHV0RWxlbWVudD4oKS0+Y2hlY2tlZCgpOwo= 174761 2012-11-16 14:32:17 -0800 2012-11-16 16:32:03 -0800 Patch bug-102422-20121116143012.patch text/plain 2420 ramankk U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI5Zjk5NTEyM2M0M2UwZWNkMDI4MTA4MTRiYjEwMWMxMWFiYTE3OGQuLmQ4MmRkZTlmNWUyYjYy ODk2NmQxYjg0YmFhMjliMDdjZTIyYTRlMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMTEtMTYgIFJhbWFuIEt1bWFyICA8cmFtYW5ra0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgQWRkIHNldENoZWNrZWQgQVBJIGluIFdlYklucHV0RWxlbWVudAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNDIyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwdWJsaWMv V2ViSW5wdXRFbGVtZW50Lmg6CisgICAgICAgIChXZWJJbnB1dEVsZW1lbnQpOiBBZGQgc2V0Q2hl Y2tlZChib29sLCBib29sKSBBUEkKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViSW5wdXRFbGVtZW50OjpzZXRDaGVja2VkKTogSW1wbGVtZW50 IHNldENoZWNrZWQgYnkgY2FsbGluZworICAgICAgICB1bmRlcmx5aW5nIEhUTUxJbnB1dEVsZW1l bnQncyBzZXRDaGVja2VkLgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0xMS0xNiAgUGV0ZXIg QmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gIFJv bGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SW5wdXRFbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVs ZW1lbnQuaAppbmRleCBmYmMzNTAwMTJhMmUyNTFhN2I1MWYxOWM3NDk4OTE1ZTE5OWQ3Y2Y2Li4y OTQzMmRmODE1M2E5MTYyOTE2ZDczN2IyMDdjNDk3YTVlN2IwM2U4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEVsZW1lbnQuaApAQCAtNzQsNiArNzQsNyBA QCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIHNldEFjdGl2 YXRlZFN1Ym1pdChib29sKTsKICAgICAgICAgV0VCS0lUX0VYUE9SVCBpbnQgc2l6ZSgpIGNvbnN0 OwogICAgICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgc2V0VmFsdWUoY29uc3QgV2ViU3RyaW5nJiwg Ym9vbCBzZW5kQ2hhbmdlRXZlbnQgPSBmYWxzZSk7CisgICAgICAgIFdFQktJVF9FWFBPUlQgdm9p ZCBzZXRDaGVja2VkKGJvb2wsIGJvb2wgc2VuZENoYW5nZUV2ZW50ID0gZmFsc2UpOwogICAgICAg ICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyB2YWx1ZSgpIGNvbnN0OwogICAgICAgICAvLyBUaGlz IHJldHVybnMgdGhlIG5vbi1zYW5pdGl6ZWQsIGV4YWN0IHZhbHVlIGluc2lkZSB0aGUgdGV4dCBm aWVsZC4KICAgICAgICAgV0VCS0lUX0VYUE9SVCBXZWJTdHJpbmcgZWRpdGluZ1ZhbHVlKCkgY29u c3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1l bnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFbGVtZW50LmNwcApp bmRleCBiZGM5ZjVkYjI5ZmYzOGZlOGJhN2NjZDYyZTcwMWM2MTFlYmU0OGY4Li5iZmMwYzIzNmJk OTZlZWMzY2Q1YmJiOTk1Y2E3Y2VlNmQxY2U1ODFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYklucHV0RWxlbWVudC5jcHAKQEAgLTE2Myw2ICsxNjMsMTEgQEAgYm9vbCBX ZWJJbnB1dEVsZW1lbnQ6OmlzVmFsaWRWYWx1ZShjb25zdCBXZWJTdHJpbmcmIHZhbHVlKSBjb25z dAogICAgIHJldHVybiBjb25zdFVud3JhcDxIVE1MSW5wdXRFbGVtZW50PigpLT5pc1ZhbGlkVmFs dWUodmFsdWUpOwogfQogCit2b2lkIFdlYklucHV0RWxlbWVudDo6c2V0Q2hlY2tlZChib29sIG5v d0NoZWNrZWQsIGJvb2wgc2VuZENoYW5nZUV2ZW50KQoreworICAgIHVud3JhcDxIVE1MSW5wdXRF bGVtZW50PigpLT5zZXRDaGVja2VkKG5vd0NoZWNrZWQsIHNlbmRDaGFuZ2VFdmVudCA/IERpc3Bh dGNoQ2hhbmdlRXZlbnQgOiBEaXNwYXRjaE5vRXZlbnQpOworfQorCiBib29sIFdlYklucHV0RWxl bWVudDo6aXNDaGVja2VkKCkgY29uc3QKIHsKICAgICByZXR1cm4gY29uc3RVbndyYXA8SFRNTElu cHV0RWxlbWVudD4oKS0+Y2hlY2tlZCgpOwo=