102410 2012-11-15 10:14:00 -0800 [BlackBerry] Animate changes to viewport due to input focus changes. 2012-11-15 11:55:49 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo rwlbuis webkit.review.bot yong.li.webkit oldest_to_newest 768234 0 anlo 2012-11-15 10:14:00 -0800 When the viewport is adjusted due to input focus changes, animate the changes in zoom & scroll position rather than making the changes immediately. 768251 1 174480 anlo 2012-11-15 10:20:51 -0800 Created attachment 174480 Patch 768253 2 174480 rwlbuis 2012-11-15 10:22:54 -0800 Comment on attachment 174480 Patch LGTM. 768361 3 174480 webkit.review.bot 2012-11-15 11:55:46 -0800 Comment on attachment 174480 Patch Clearing flags on attachment: 174480 Committed r134807: <http://trac.webkit.org/changeset/134807> 768362 4 webkit.review.bot 2012-11-15 11:55:49 -0800 All reviewed patches have been landed. Closing bug. 174480 2012-11-15 10:20:51 -0800 2012-11-15 11:55:46 -0800 Patch bug-102410-20121115131859.patch text/plain 6605 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzM2IyOWVmNDgyYTEyNTUyMDU2N2JkNDc4Y2JhZDlmN2JhMGMxZTA5Li5lMTZkYmRlODMw NDk4NjgxNjFhMzAzMGFlNDdlOWYyZTNmMTY0MGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMS0xNSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBbmltYXRlIGNoYW5nZXMgdG8gdmlld3BvcnQg ZHVlIHRvIGlucHV0IGZvY3VzIGNoYW5nZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI0MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIGNoYW5naW5nIHNjcm9sbCBwb3NpdGlvbiBvciB6b29t IGxldmVsIGZvciBpbnB1dCBmaWVsZCBmb2N1cywKKyAgICAgICAgYW5pbWF0ZSB0aGUgY2hhbmdl LgorICAgICAgICBJbnRlcm5hbCBQUiAyMzE5MzcKKworICAgICAgICBJbnRlcm5hbGx5IHJldmll d2VkIGJ5IE1pa2UgRmVudG9uLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRs ZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmVuc3Vy ZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlKToKKwogMjAxMi0xMS0xMyAgTWlrZSBGZW50b24gIDxt aWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBGdWxseSByZXN0b3JlIGJv dGggem9vbSBhbmQgc2Nyb2xsIHdoZW4gbGVhdmluZyBhbiBpbnB1dCBmaWVsZC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIu Y3BwCmluZGV4IDY1M2I1ZmIwZGY4ZjQ2YmVhZThkNTBkNTMzYjFkMjkzZDc4ZWY0ZmUuLmYyYTY3 NThmN2NhMTllYWI1MWIzZTk0MTJlYTI4YmRhMGI5ZmFmNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAt MTIxMSwxMSArMTIxMSwxNyBAQCB2b2lkIElucHV0SGFuZGxlcjo6ZW5zdXJlRm9jdXNUZXh0RWxl bWVudFZpc2libGUoQ2FyZXRTY3JvbGxUeXBlIHNjcm9sbFR5cGUpCiAgICAgLy8gVGhlIG1pbmlt dW0gc2l6ZSBiZWluZyBkZWZpbmVkIGFzIDMgbW0gaXMgYSBnb29kIHZhbHVlIGJhc2VkIG9uIG15 IG9ic2VydmF0aW9ucy4KICAgICBzdGF0aWMgY29uc3QgaW50IHNfbWluaW11bVRleHRIZWlnaHRJ blBpeGVscyA9IEdyYXBoaWNzOjpTY3JlZW46OnByaW1hcnlTY3JlZW4oKS0+aGVpZ2h0SW5NTVRv UGl4ZWxzKDMpOwogCi0gICAgaWYgKG1fd2ViUGFnZS0+aXNVc2VyU2NhbGFibGUoKSAmJiBmb250 SGVpZ2h0ICYmIGZvbnRIZWlnaHQgKiBtX3dlYlBhZ2UtPmN1cnJlbnRTY2FsZSgpIDwgc19taW5p bXVtVGV4dEhlaWdodEluUGl4ZWxzICYmICFpc1J1bm5pbmdEcnQoKSkgewotICAgICAgICBkb3Vi bGUgem9vbVNjYWxlUmVxdWlyZWQgPSBzdGF0aWNfY2FzdDxkb3VibGU+KHNfbWluaW11bVRleHRI ZWlnaHRJblBpeGVscykgLyBmb250SGVpZ2h0OwotICAgICAgICBtX3dlYlBhZ2UtPnpvb21BYm91 dFBvaW50KHpvb21TY2FsZVJlcXVpcmVkLCBzZWxlY3Rpb25Gb2N1c1JlY3QubG9jYXRpb24oKSk7 Ci0gICAgICAgIElucHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6ZW5zdXJlRm9j dXNUZXh0RWxlbWVudFZpc2libGUgem9vbWluZyBpbiB0byAlZiBhdCBwb2ludCAlZCwgJWQiLCB6 b29tU2NhbGVSZXF1aXJlZCwgc2VsZWN0aW9uRm9jdXNSZWN0LmxvY2F0aW9uKCkueCgpLCBzZWxl Y3Rpb25Gb2N1c1JlY3QubG9jYXRpb24oKS55KCkpOwotICAgIH0KKyAgICBkb3VibGUgem9vbVNj YWxlUmVxdWlyZWQ7CisgICAgaWYgKG1fd2ViUGFnZS0+aXNVc2VyU2NhbGFibGUoKSAmJiBmb250 SGVpZ2h0ICYmIGZvbnRIZWlnaHQgKiBtX3dlYlBhZ2UtPmN1cnJlbnRTY2FsZSgpIDwgc19taW5p bXVtVGV4dEhlaWdodEluUGl4ZWxzICYmICFpc1J1bm5pbmdEcnQoKSkKKyAgICAgICAgem9vbVNj YWxlUmVxdWlyZWQgPSBzdGF0aWNfY2FzdDxkb3VibGU+KHNfbWluaW11bVRleHRIZWlnaHRJblBp eGVscykgLyBmb250SGVpZ2h0OworICAgIGVsc2UKKyAgICAgICAgem9vbVNjYWxlUmVxdWlyZWQg PSBtX3dlYlBhZ2UtPmN1cnJlbnRTY2FsZSgpOyAvLyBEb24ndCBzY2FsZS4KKworICAgIC8vIFRo ZSBzY3JvbGwgbG9jYXRpb24gd2Ugc2hvdWxkIGdvIHRvIGdpdmVuIHRoZSB6b29tIHJlcXVpcmVk LCBjb3VsZCBiZSBhZGp1c3RlZCBsYXRlci4KKyAgICBXZWJDb3JlOjpGbG9hdFBvaW50IG9mZnNl dChzZWxlY3Rpb25Gb2N1c1JlY3QubG9jYXRpb24oKS55KCkgLSBtX3dlYlBhZ2UtPnNjcm9sbFBv c2l0aW9uKCkueCgpLCBzZWxlY3Rpb25Gb2N1c1JlY3QubG9jYXRpb24oKS55KCkgLSBtX3dlYlBh Z2UtPnNjcm9sbFBvc2l0aW9uKCkueSgpKTsKKyAgICBkb3VibGUgaW52ZXJzZVNjYWxlID0gem9v bVNjYWxlUmVxdWlyZWQgLyBtX3dlYlBhZ2UtPmN1cnJlbnRTY2FsZSgpOworICAgIFdlYkNvcmU6 OkludFBvaW50IGRlc3RpbmF0aW9uU2Nyb2xsTG9jYXRpb24gPSBXZWJDb3JlOjpJbnRQb2ludCht YXgoMCwgc3RhdGljX2Nhc3Q8aW50Pihyb3VuZGYoc2VsZWN0aW9uRm9jdXNSZWN0LmxvY2F0aW9u KCkueCgpIC0gb2Zmc2V0LngoKSAvIGludmVyc2VTY2FsZSkpKSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4KDAs IHN0YXRpY19jYXN0PGludD4ocm91bmRmKHNlbGVjdGlvbkZvY3VzUmVjdC5sb2NhdGlvbigpLnko KSAtIG9mZnNldC55KCkgLyBpbnZlcnNlU2NhbGUpKSkpOwogCiAgICAgaWYgKGVsZW1lbnRGcmFt ZSAhPSBtYWluRnJhbWUpIHsgLy8gRWxlbWVudCBpcyBpbiBhIHN1YmZyYW1lLgogICAgICAgICAv LyBSZW1vdmUgYW55IHNjcm9sbCBvZmZzZXQgd2l0aGluIHRoZSBzdWJmcmFtZSB0byBnZXQgdGhl IHBvaW50IHJlbGF0aXZlIHRvIHRoZSBtYWluIGZyYW1lLgpAQCAtMTIzMSw3ICsxMjM3LDkgQEAg dm9pZCBJbnB1dEhhbmRsZXI6OmVuc3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxlKENhcmV0U2Ny b2xsVHlwZSBzY3JvbGxUeXBlKQogICAgIFBvc2l0aW9uIHN0YXJ0ID0gZWxlbWVudEZyYW1lLT5z ZWxlY3Rpb24oKS0+c3RhcnQoKTsKICAgICBpZiAoc3RhcnQuYW5jaG9yTm9kZSgpICYmIHN0YXJ0 LmFuY2hvck5vZGUoKS0+cmVuZGVyZXIoKSkgewogICAgICAgICBpZiAoUmVuZGVyTGF5ZXIqIGxh eWVyID0gc3RhcnQuYW5jaG9yTm9kZSgpLT5yZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpKSB7 Ci0gICAgICAgICAgICBXZWJDb3JlOjpJbnRSZWN0IGFjdHVhbFNjcmVlblJlY3QgPSBXZWJDb3Jl OjpJbnRSZWN0KG1haW5GcmFtZVZpZXctPnNjcm9sbFBvc2l0aW9uKCksIG1fd2ViUGFnZS0+YWN0 dWFsVmlzaWJsZVNpemUoKSk7CisgICAgICAgICAgICAvLyBTY3JlZW4gcmVjdCBhZnRlciB0aGUg cmVxdWlyZWQgem9vbS4KKyAgICAgICAgICAgIFdlYkNvcmU6OkludFJlY3QgYWN0dWFsU2NyZWVu UmVjdCA9IFdlYkNvcmU6OkludFJlY3QoZGVzdGluYXRpb25TY3JvbGxMb2NhdGlvbi54KCksIGRl c3RpbmF0aW9uU2Nyb2xsTG9jYXRpb24ueSgpLCBtX3dlYlBhZ2UtPmFjdHVhbFZpc2libGVTaXpl KCkud2lkdGgoKSAvIGludmVyc2VTY2FsZSwgbV93ZWJQYWdlLT5hY3R1YWxWaXNpYmxlU2l6ZSgp LmhlaWdodCgpIC8gaW52ZXJzZVNjYWxlKTsKKwogICAgICAgICAgICAgU2Nyb2xsQWxpZ25tZW50 IGhvcml6b250YWxTY3JvbGxBbGlnbm1lbnQgPSBTY3JvbGxBbGlnbm1lbnQ6OmFsaWduVG9FZGdl SWZOZWVkZWQ7CiAgICAgICAgICAgICBTY3JvbGxBbGlnbm1lbnQgdmVydGljYWxTY3JvbGxBbGln bm1lbnQgPSBTY3JvbGxBbGlnbm1lbnQ6OmFsaWduVG9FZGdlSWZOZWVkZWQ7CiAKQEAgLTEyNzgs MTcgKzEyODYsMjYgQEAgdm9pZCBJbnB1dEhhbmRsZXI6OmVuc3VyZUZvY3VzVGV4dEVsZW1lbnRW aXNpYmxlKENhcmV0U2Nyb2xsVHlwZSBzY3JvbGxUeXBlKQogICAgICAgICAgICAgLy8gSW4gb3Jk ZXIgdG8gYWRqdXN0IHRoZSBzY3JvbGwgcG9zaXRpb24gdG8gZW5zdXJlIHRoZSBmb2N1c2VkIGlu cHV0IGZpZWxkIGlzIHZpc2libGUsCiAgICAgICAgICAgICAvLyB3ZSBhbGxvdyBvdmVyc2Nyb2xs aW5nLiBIb3dldmVyIHRoaXMgb3ZlcnNjcm9sbCBoYXMgdG8gYmUgc3RyaWN0bHkgYWxsb3dlZCB0 b3dhcmRzIHRoZQogICAgICAgICAgICAgLy8gYm90dG9tIG9mIHRoZSBwYWdlIG9uIHRoZSB5IGF4 aXMgb25seSwgd2hlcmUgdGhlIHZpcnR1YWwga2V5Ym9hcmQgcG9wcyB1cCBmcm9tLgotICAgICAg ICAgICAgV2ViQ29yZTo6SW50UG9pbnQgc2Nyb2xsTG9jYXRpb24gPSByZXZlYWxSZWN0LmxvY2F0 aW9uKCk7Ci0gICAgICAgICAgICBzY3JvbGxMb2NhdGlvbi5jbGFtcE5lZ2F0aXZlVG9aZXJvKCk7 CisgICAgICAgICAgICBkZXN0aW5hdGlvblNjcm9sbExvY2F0aW9uID0gcmV2ZWFsUmVjdC5sb2Nh dGlvbigpOworICAgICAgICAgICAgZGVzdGluYXRpb25TY3JvbGxMb2NhdGlvbi5jbGFtcE5lZ2F0 aXZlVG9aZXJvKCk7CiAgICAgICAgICAgICBXZWJDb3JlOjpJbnRQb2ludCBtYXhpbXVtU2Nyb2xs UG9zaXRpb24gPSBXZWJDb3JlOjpJbnRQb2ludChtYWluRnJhbWVWaWV3LT5jb250ZW50c1dpZHRo KCkgLSBhY3R1YWxTY3JlZW5SZWN0LndpZHRoKCksIG1haW5GcmFtZVZpZXctPmNvbnRlbnRzSGVp Z2h0KCkgLSBhY3R1YWxTY3JlZW5SZWN0LmhlaWdodCgpKTsKLSAgICAgICAgICAgIHNjcm9sbExv Y2F0aW9uID0gc2Nyb2xsTG9jYXRpb24uc2hydW5rVG8obWF4aW11bVNjcm9sbFBvc2l0aW9uKTsK LSAgICAgICAgICAgIGlmIChzY3JvbGxMb2NhdGlvbiAhPSBtYWluRnJhbWVWaWV3LT5zY3JvbGxQ b3NpdGlvbigpKSB7Ci0gICAgICAgICAgICAgICAgbWFpbkZyYW1lVmlldy0+c2V0U2Nyb2xsUG9z aXRpb24oc2Nyb2xsTG9jYXRpb24pOwotICAgICAgICAgICAgICAgIG1haW5GcmFtZVZpZXctPnNl dENvbnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlKHRydWUpOwotICAgICAgICAgICAgICAg IElucHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6ZW5zdXJlRm9jdXNUZXh0RWxl bWVudFZpc2libGUgc2Nyb2xsaW5nIHRvIHBvaW50ICVkLCAlZCIsIHNjcm9sbExvY2F0aW9uLngo KSwgc2Nyb2xsTG9jYXRpb24ueSgpKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGRlc3Rp bmF0aW9uU2Nyb2xsTG9jYXRpb24gPSBkZXN0aW5hdGlvblNjcm9sbExvY2F0aW9uLnNocnVua1Rv KG1heGltdW1TY3JvbGxQb3NpdGlvbik7CiAgICAgICAgIH0KICAgICB9CisKKyAgICBpZiAoZGVz dGluYXRpb25TY3JvbGxMb2NhdGlvbiAhPSBtYWluRnJhbWVWaWV3LT5zY3JvbGxQb3NpdGlvbigp IHx8IHpvb21TY2FsZVJlcXVpcmVkICE9IG1fd2ViUGFnZS0+Y3VycmVudFNjYWxlKCkpIHsKKyAg ICAgICAgbWFpbkZyYW1lVmlldy0+c2V0Q29uc3RyYWluc1Njcm9sbGluZ1RvQ29udGVudEVkZ2Uo dHJ1ZSk7CisKKyAgICAgICAgSW5wdXRMb2coTG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjpl bnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZSB6b29taW5nIGluIHRvICVmIGFuZCBzY3JvbGxp bmcgdG8gcG9pbnQgJWQsICVkIiwgem9vbVNjYWxlUmVxdWlyZWQsIGRlc3RpbmF0aW9uU2Nyb2xs TG9jYXRpb24ueCgpLCBkZXN0aW5hdGlvblNjcm9sbExvY2F0aW9uLnkoKSk7CisKKyAgICAgICAg Ly8gQW5pbWF0ZSB0byBnaXZlbiBzY3JvbGwgcG9zaXRpb24gJiB6b29tIGxldmVsCisgICAgICAg IG1fd2ViUGFnZS0+bV9maW5hbEJsb2NrUG9pbnQgPSBXZWJDb3JlOjpGbG9hdFBvaW50KGRlc3Rp bmF0aW9uU2Nyb2xsTG9jYXRpb24pOworICAgICAgICBtX3dlYlBhZ2UtPm1fYmxvY2tab29tRmlu YWxTY2FsZSA9IHpvb21TY2FsZVJlcXVpcmVkOworICAgICAgICBtX3dlYlBhZ2UtPm1fc2hvdWxk UmVmbG93QmxvY2sgPSBmYWxzZTsKKyAgICAgICAgbV93ZWJQYWdlLT5tX3VzZXJQZXJmb3JtZWRN YW51YWxab29tID0gdHJ1ZTsKKyAgICAgICAgbV93ZWJQYWdlLT5tX3VzZXJQZXJmb3JtZWRNYW51 YWxTY3JvbGwgPSB0cnVlOworICAgICAgICBtX3dlYlBhZ2UtPmNsaWVudCgpLT5hbmltYXRlQmxv Y2tab29tKHpvb21TY2FsZVJlcXVpcmVkLCBtX3dlYlBhZ2UtPm1fZmluYWxCbG9ja1BvaW50KTsK KyAgICB9CiAgICAgbV93ZWJQYWdlLT5yZXN1bWVCYWNraW5nU3RvcmUoKTsKIH0KIAo=