102358 2012-11-15 02:19:16 -0800 Remove isHTMLInputElement since it's unused and toInputElement exists 2012-11-15 10:14:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn abarth mifenton ojan rniwa tkent webkit.review.bot oldest_to_newest 767840 0 esprehn 2012-11-15 02:19:16 -0800 Remove isHTMLInputElement since it's dangerous and unused 767842 1 174378 esprehn 2012-11-15 02:22:32 -0800 Created attachment 174378 Patch 767909 2 174378 rniwa 2012-11-15 03:33:32 -0800 Comment on attachment 174378 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174378&action=review > Source/WebCore/ChangeLog:11 > + isHTMLInputElement only checked if the tag name was input which is bad > + since other things inherit from HTMLInputElement. Instead callers should > + use Node::toInputElement() which is virtual and will handle subclasses > + properly. Why is that dangerous? If an element has the name HTMLNames::inputTag, then it can't certainly be some other element, right? I agree that you can't assume that an element's name is HTMLNames::inputTag just because it's an instance of a HTMLInputElement but that's a separate issue. 768158 3 esprehn 2012-11-15 09:13:53 -0800 (In reply to comment #2) > (From update of attachment 174378 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174378&action=review > > > Source/WebCore/ChangeLog:11 > > + isHTMLInputElement only checked if the tag name was input which is bad > > + since other things inherit from HTMLInputElement. Instead callers should > > + use Node::toInputElement() which is virtual and will handle subclasses > > + properly. > > Why is that dangerous? If an element has the name HTMLNames::inputTag, then it can't certainly be some other element, right? > I agree that you can't assume that an element's name is HTMLNames::inputTag just because it's an instance of a HTMLInputElement but that's a separate issue. Dangerous is probably the wrong word. Why would I ever want to call this method instead of just using toInputElement() though? 768174 4 174466 esprehn 2012-11-15 09:28:17 -0800 Created attachment 174466 Patch 768235 5 174466 webkit.review.bot 2012-11-15 10:14:31 -0800 Comment on attachment 174466 Patch Clearing flags on attachment: 174466 Committed r134790: <http://trac.webkit.org/changeset/134790> 768236 6 webkit.review.bot 2012-11-15 10:14:35 -0800 All reviewed patches have been landed. Closing bug. 174378 2012-11-15 02:22:32 -0800 2012-11-15 09:28:13 -0800 Patch bug-102358-20121115052029.patch text/plain 1414 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjk0ZDZmNjRmMDYzOWQw NjNlMWY4YjhmMzQyMzFlYTJkMTQ5YmUzZS4uMWYxZDg1ZjMzZDg4OGVjNWUwZTEzNGZkMjdkODA4 ZWZlNTBkYzA4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTE1ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBpc0hU TUxJbnB1dEVsZW1lbnQgc2luY2UgaXQncyBkYW5nZXJvdXMgYW5kIHVudXNlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzU4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaXNIVE1MSW5wdXRFbGVtZW50 IG9ubHkgY2hlY2tlZCBpZiB0aGUgdGFnIG5hbWUgd2FzIGlucHV0IHdoaWNoIGlzIGJhZAorICAg ICAgICBzaW5jZSBvdGhlciB0aGluZ3MgaW5oZXJpdCBmcm9tIEhUTUxJbnB1dEVsZW1lbnQuIElu c3RlYWQgY2FsbGVycyBzaG91bGQKKyAgICAgICAgdXNlIE5vZGU6OnRvSW5wdXRFbGVtZW50KCkg d2hpY2ggaXMgdmlydHVhbCBhbmQgd2lsbCBoYW5kbGUgc3ViY2xhc3NlcworICAgICAgICBwcm9w ZXJseS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMganVzdCBkZWxldGVzIGRlYWQgY29k ZS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5oOgorCiAyMDEyLTExLTE0ICBL ZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk LiBSZWJhc2VsaW5lZCBydW4tYmluZGluZ3MtdGVzdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5oCmluZGV4IGZmZWU5NDRhZTdmOThmYThlMzFlMWNjMGYzMWRjMTY0MDYxYjQ3 NzkuLjI4MmE2MWVmYmFkMWM4ZDZiOWIyZTA3MDU2MDdjMGRmNzllODE4MDYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC00MzEsMTEgKzQzMSw1IEBAIHByaXZhdGU6 CiAjZW5kaWYKIH07CiAKLWlubGluZSBib29sIGlzSFRNTElucHV0RWxlbWVudChOb2RlKiBub2Rl KQotewotICAgIEFTU0VSVChub2RlKTsKLSAgICByZXR1cm4gbm9kZS0+aGFzVGFnTmFtZShIVE1M TmFtZXM6OmlucHV0VGFnKTsKLX0KLQogfSAvL25hbWVzcGFjZQogI2VuZGlmCg== 174466 2012-11-15 09:28:17 -0800 2012-11-15 10:14:31 -0800 Patch bug-102358-20121115122614.patch text/plain 1612 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI2MGY1MGQxODllOGUz YWY0ZmUzOGY4ZWM3NTAyZTNiMmE2OTc3Mi4uMDNiNGNjM2Q5ZTJkMDljZDkyNDNkNDQ3ZWJjYzIw YjJkMzEzYWUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTE1ICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBpc0hU TUxJbnB1dEVsZW1lbnQgc2luY2UgaXQncyB1bnVzZWQgYW5kIHRvSW5wdXRFbGVtZW50IGV4aXN0 cyAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjM1 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBpc0hUTUxJbnB1dEVsZW1lbnQgYXMgbm8gb25lIHVzZXMgaXQuIEV2ZXJ5b25lIGp1c3QgdXNl cworICAgICAgICBOb2RlOjp0b0lucHV0RWxlbWVudCBhbmQgY2hlY2tzIGZvciBhIDAgcmV0dXJu IHZhbHVlIGluc3RlYWQuCisKKyAgICAgICAgdG9JbnB1dEVsZW1lbnQgaXMgYWxzbyBtb3JlIHJl bGlhYmxlIGFzIHRoZXJlJ3Mgbm8gcmVxdWlyZW1lbnQgdGhhdAorICAgICAgICBzdWJjbGFzc2Vz IG9mIEhUTUxJbnB1dEVsZW1lbnQgaGF2ZSB0aGUgdGFnIG5hbWUgb2YgaW5wdXRUYWcgc28gdXNp bmcKKyAgICAgICAgdGhpcyBtZXRob2QgaW4gYSBjaGVjayBjb3VsZCBwb3RlbnRpYWxseSBtaXNz IGZ1dHVyZSBzdWJjbGFzc2VzIHdpdGgKKyAgICAgICAgZGlmZmVyZW50IHRhZyBuYW1lcywgdGhv dWdoIG5vbmUgZXhpc3QgcmlnaHQgbm93LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBq dXN0IGRlbGV0ZXMgZGVhZCBjb2RlLgorCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50 Lmg6CisKIDIwMTItMTEtMTUgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVcGRhdGUgRE9NRXhjZXB0aW9uIG5hbWU6IE5vTW9kaWZpY2F0aW9uQWxsb3dlZEVy cm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCmluZGV4IGZmZWU5NDRhZTdm OThmYThlMzFlMWNjMGYzMWRjMTY0MDYxYjQ3NzkuLjI4MmE2MWVmYmFkMWM4ZDZiOWIyZTA3MDU2 MDdjMGRmNzllODE4MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0 RWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBA IC00MzEsMTEgKzQzMSw1IEBAIHByaXZhdGU6CiAjZW5kaWYKIH07CiAKLWlubGluZSBib29sIGlz SFRNTElucHV0RWxlbWVudChOb2RlKiBub2RlKQotewotICAgIEFTU0VSVChub2RlKTsKLSAgICBy ZXR1cm4gbm9kZS0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OmlucHV0VGFnKTsKLX0KLQogfSAvL25h bWVzcGFjZQogI2VuZGlmCg==