102355 2012-11-15 02:03:00 -0800 Rename member vars in ViewportArgument to match css-device-adapt 2012-11-15 05:01:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth gyuyoung.kim rakuco webkit.review.bot oldest_to_newest 767835 0 kenneth 2012-11-15 02:03:00 -0800 SSIA 767836 1 174375 kenneth 2012-11-15 02:04:45 -0800 Created attachment 174375 Patch 767966 2 174375 webkit.review.bot 2012-11-15 05:01:07 -0800 Comment on attachment 174375 Patch Clearing flags on attachment: 174375 Committed r134765: <http://trac.webkit.org/changeset/134765> 767967 3 webkit.review.bot 2012-11-15 05:01:12 -0800 All reviewed patches have been landed. Closing bug. 174375 2012-11-15 02:04:45 -0800 2012-11-15 05:01:07 -0800 Patch bug-102355-20121115110241.patch text/plain 7010 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDczMmRiZmNhM2E3MWQ3 NmRjNzM1Mjg5MTVhNGY1ZGYxYTMyZWE2OC4uMGJmM2YyZWEzYmY3ZDJmYjJhMmIxM2M4NGRlNmIz OGUxOTNhMDE4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTExLTE1ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBS ZW5hbWUgbWVtYmVyIHZhcnMgaW4gVmlld3BvcnRBcmd1bWVudCB0byBtYXRjaCBjc3MtZGV2aWNl LWFkYXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDIzNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBiZWhhdmlvciBjaGFuZ2UsIHRodXMgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogZG9tL1Zp ZXdwb3J0QXJndW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRz OjpyZXNvbHZlKToKKyAgICAgICAgKFdlYkNvcmU6OnNldFZpZXdwb3J0RmVhdHVyZSk6CisgICAg ICAgICogZG9tL1ZpZXdwb3J0QXJndW1lbnRzLmg6CisgICAgICAgIChXZWJDb3JlOjpWaWV3cG9y dEFyZ3VtZW50czo6Vmlld3BvcnRBcmd1bWVudHMpOgorICAgICAgICAoVmlld3BvcnRBcmd1bWVu dHMpOgorICAgICAgICAoV2ViQ29yZTo6Vmlld3BvcnRBcmd1bWVudHM6Om9wZXJhdG9yPT0pOgor CisyMDEyLTExLTE1ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0 Lm9yZz4KKwogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KIAogICAgICAgICAqIGRvbS9W aWV3cG9ydEFyZ3VtZW50cy5jcHA6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggNTIwMGI4MjBmZmY0ZDQy MDJjOWRlOTJlNzZlN2MzNzBjYWMxNWZjNC4uMzJkNmQ0ZmUwMjdiZTI4YjU1NzI4N2Q4NDdiZjQ0 ZGYwNmUxNjhmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTE1 ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZW5hbWUgbWVtYmVyIHZhcnMgaW4gVmlld3BvcnRBcmd1bWVudCB0byBtYXRjaCBjc3Mt ZGV2aWNlLWFkYXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDIzNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChfZXdrX3ZpZXdfcHJpdl9uZXcpOiBV cGRhdGUgdG8gcmVmbGVjdCBuYW1lIGNoYW5nZS4KKwogMjAxMi0xMS0xNCAgUnl1YW4gQ2hvaSAg PHJ5dWFuLmNob2lAZ21haWwuY29tPgogCiAgICAgICAgIFtFRkxdIFBvcnQgdGlsZWQgYmFja2lu ZyBzdG9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1ZpZXdwb3J0QXJndW1lbnRz LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5jcHAKaW5kZXggMDY1 Y2RhYzE3MTI0MGM4OTg2ODgxNGRhNGY0MzRiYmNlYjNiMjBhMS4uM2NhZGZkYTg5MGIwYmIzYzM2 MzM4MmRlZjhmMjQ3MmI0Y2U4NTBmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1Zp ZXdwb3J0QXJndW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vVmlld3BvcnRBcmd1 bWVudHMuY3BwCkBAIC02OSwxMCArNjksMTAgQEAgVmlld3BvcnRBdHRyaWJ1dGVzIFZpZXdwb3J0 QXJndW1lbnRzOjpyZXNvbHZlKGNvbnN0IEZsb2F0U2l6ZSYgaW5pdGlhbFZpZXdwb3J0U2kKIHsK ICAgICBmbG9hdCByZXN1bHRXaWR0aCA9IHdpZHRoOwogICAgIGZsb2F0IHJlc3VsdEhlaWdodCA9 IGhlaWdodDsKLSAgICBmbG9hdCByZXN1bHRab29tID0gaW5pdGlhbFNjYWxlOwotICAgIGZsb2F0 IHJlc3VsdE1pblpvb20gPSBtaW5pbXVtU2NhbGU7Ci0gICAgZmxvYXQgcmVzdWx0TWF4Wm9vbSA9 IG1heGltdW1TY2FsZTsKLSAgICBmbG9hdCByZXN1bHRVc2VyWm9vbSA9IHVzZXJTY2FsYWJsZTsK KyAgICBmbG9hdCByZXN1bHRab29tID0gem9vbTsKKyAgICBmbG9hdCByZXN1bHRNaW5ab29tID0g bWluWm9vbTsKKyAgICBmbG9hdCByZXN1bHRNYXhab29tID0gbWF4Wm9vbTsKKyAgICBmbG9hdCBy ZXN1bHRVc2VyWm9vbSA9IHVzZXJab29tOwogCiAgICAgYm9vbCByZXN1bHRBdXRvRml0ID0gcmVz dWx0Wm9vbSA9PSBWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvOwogCkBAIC0yOTksMTMgKzI5 OSwxMyBAQCB2b2lkIHNldFZpZXdwb3J0RmVhdHVyZShjb25zdCBTdHJpbmcmIGtleVN0cmluZywg Y29uc3QgU3RyaW5nJiB2YWx1ZVN0cmluZywgRG9jdQogICAgIGVsc2UgaWYgKGtleVN0cmluZyA9 PSAiaGVpZ2h0IikKICAgICAgICAgYXJndW1lbnRzLT5oZWlnaHQgPSBmaW5kU2l6ZVZhbHVlKGtl eVN0cmluZywgdmFsdWVTdHJpbmcsIGRvY3VtZW50KTsKICAgICBlbHNlIGlmIChrZXlTdHJpbmcg PT0gImluaXRpYWwtc2NhbGUiKQotICAgICAgICBhcmd1bWVudHMtPmluaXRpYWxTY2FsZSA9IGZp bmRTY2FsZVZhbHVlKGtleVN0cmluZywgdmFsdWVTdHJpbmcsIGRvY3VtZW50KTsKKyAgICAgICAg YXJndW1lbnRzLT56b29tID0gZmluZFNjYWxlVmFsdWUoa2V5U3RyaW5nLCB2YWx1ZVN0cmluZywg ZG9jdW1lbnQpOwogICAgIGVsc2UgaWYgKGtleVN0cmluZyA9PSAibWluaW11bS1zY2FsZSIpCi0g ICAgICAgIGFyZ3VtZW50cy0+bWluaW11bVNjYWxlID0gZmluZFNjYWxlVmFsdWUoa2V5U3RyaW5n LCB2YWx1ZVN0cmluZywgZG9jdW1lbnQpOworICAgICAgICBhcmd1bWVudHMtPm1pblpvb20gPSBm aW5kU2NhbGVWYWx1ZShrZXlTdHJpbmcsIHZhbHVlU3RyaW5nLCBkb2N1bWVudCk7CiAgICAgZWxz ZSBpZiAoa2V5U3RyaW5nID09ICJtYXhpbXVtLXNjYWxlIikKLSAgICAgICAgYXJndW1lbnRzLT5t YXhpbXVtU2NhbGUgPSBmaW5kU2NhbGVWYWx1ZShrZXlTdHJpbmcsIHZhbHVlU3RyaW5nLCBkb2N1 bWVudCk7CisgICAgICAgIGFyZ3VtZW50cy0+bWF4Wm9vbSA9IGZpbmRTY2FsZVZhbHVlKGtleVN0 cmluZywgdmFsdWVTdHJpbmcsIGRvY3VtZW50KTsKICAgICBlbHNlIGlmIChrZXlTdHJpbmcgPT0g InVzZXItc2NhbGFibGUiKQotICAgICAgICBhcmd1bWVudHMtPnVzZXJTY2FsYWJsZSA9IGZpbmRV c2VyU2NhbGFibGVWYWx1ZShrZXlTdHJpbmcsIHZhbHVlU3RyaW5nLCBkb2N1bWVudCk7CisgICAg ICAgIGFyZ3VtZW50cy0+dXNlclpvb20gPSBmaW5kVXNlclNjYWxhYmxlVmFsdWUoa2V5U3RyaW5n LCB2YWx1ZVN0cmluZywgZG9jdW1lbnQpOwogICAgIGVsc2UgaWYgKGtleVN0cmluZyA9PSAidGFy Z2V0LWRlbnNpdHlkcGkiKQogICAgICAgICByZXBvcnRWaWV3cG9ydFdhcm5pbmcoZG9jdW1lbnQs IFRhcmdldERlbnNpdHlEcGlVbnN1cHBvcnRlZCwgU3RyaW5nKCksIFN0cmluZygpKTsKICAgICBl bHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vVmlld3BvcnRBcmd1bWVudHMuaCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oCmluZGV4IDJkN2VhMWYyYTg0 MmJlYjVlYjMzMGJlNzNlZGFlNThjODNmNDYxYzcuLjVjMzk2MzdmMjdkMTU2NGYyN2E3YmUyMzFj OTI4MDM2MWIwN2YxZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFy Z3VtZW50cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5oCkBA IC03NCwzNSArNzQsMzUgQEAgc3RydWN0IFZpZXdwb3J0QXJndW1lbnRzIHsKIAogICAgIFZpZXdw b3J0QXJndW1lbnRzKFR5cGUgdHlwZSA9IEltcGxpY2l0KQogICAgICAgICA6IHR5cGUodHlwZSkK LSAgICAgICAgLCBpbml0aWFsU2NhbGUoVmFsdWVBdXRvKQotICAgICAgICAsIG1pbmltdW1TY2Fs ZShWYWx1ZUF1dG8pCi0gICAgICAgICwgbWF4aW11bVNjYWxlKFZhbHVlQXV0bykKICAgICAgICAg LCB3aWR0aChWYWx1ZUF1dG8pCiAgICAgICAgICwgaGVpZ2h0KFZhbHVlQXV0bykKLSAgICAgICAg LCB1c2VyU2NhbGFibGUoVmFsdWVBdXRvKQorICAgICAgICAsIHpvb20oVmFsdWVBdXRvKQorICAg ICAgICAsIG1pblpvb20oVmFsdWVBdXRvKQorICAgICAgICAsIG1heFpvb20oVmFsdWVBdXRvKQor ICAgICAgICAsIHVzZXJab29tKFZhbHVlQXV0bykKICAgICB7CiAgICAgfQogCiAgICAgLy8gQWxs IGFyZ3VtZW50cyBhcmUgaW4gQ1NTIHVuaXRzLgogICAgIFZpZXdwb3J0QXR0cmlidXRlcyByZXNv bHZlKGNvbnN0IEZsb2F0U2l6ZSYgaW5pdGlhbFZpZXdwb3J0U2l6ZSwgY29uc3QgRmxvYXRTaXpl JiBkZXZpY2VTaXplLCBpbnQgZGVmYXVsdFdpZHRoKSBjb25zdDsKIAotICAgIGZsb2F0IGluaXRp YWxTY2FsZTsKLSAgICBmbG9hdCBtaW5pbXVtU2NhbGU7Ci0gICAgZmxvYXQgbWF4aW11bVNjYWxl OwogICAgIGZsb2F0IHdpZHRoOwogICAgIGZsb2F0IGhlaWdodDsKLSAgICBmbG9hdCB1c2VyU2Nh bGFibGU7CisgICAgZmxvYXQgem9vbTsKKyAgICBmbG9hdCBtaW5ab29tOworICAgIGZsb2F0IG1h eFpvb207CisgICAgZmxvYXQgdXNlclpvb207CiAKICAgICBib29sIG9wZXJhdG9yPT0oY29uc3Qg Vmlld3BvcnRBcmd1bWVudHMmIG90aGVyKSBjb25zdAogICAgIHsKICAgICAgICAgLy8gVXNlZCBm b3IgZmlndXJpbmcgb3V0IHdoZXRoZXIgdG8gcmVzZXQgdGhlIHZpZXdwb3J0IG9yIG5vdCwKICAg ICAgICAgLy8gdGh1cyB3ZSBhcmUgbm90IHRha2luZyB0eXBlIGludG8gYWNjb3VudC4KLSAgICAg ICAgcmV0dXJuIGluaXRpYWxTY2FsZSA9PSBvdGhlci5pbml0aWFsU2NhbGUKLSAgICAgICAgICAg ICYmIG1pbmltdW1TY2FsZSA9PSBvdGhlci5taW5pbXVtU2NhbGUKLSAgICAgICAgICAgICYmIG1h eGltdW1TY2FsZSA9PSBvdGhlci5tYXhpbXVtU2NhbGUKLSAgICAgICAgICAgICYmIHdpZHRoID09 IG90aGVyLndpZHRoCisgICAgICAgIHJldHVybiB3aWR0aCA9PSBvdGhlci53aWR0aAogICAgICAg ICAgICAgJiYgaGVpZ2h0ID09IG90aGVyLmhlaWdodAotICAgICAgICAgICAgJiYgdXNlclNjYWxh YmxlID09IG90aGVyLnVzZXJTY2FsYWJsZTsKKyAgICAgICAgICAgICYmIHpvb20gPT0gb3RoZXIu em9vbQorICAgICAgICAgICAgJiYgbWluWm9vbSA9PSBvdGhlci5taW5ab29tCisgICAgICAgICAg ICAmJiBtYXhab29tID09IG90aGVyLm1heFpvb20KKyAgICAgICAgICAgICYmIHVzZXJab29tID09 IG90aGVyLnVzZXJab29tOwogICAgIH0KIAogICAgIGJvb2wgb3BlcmF0b3IhPShjb25zdCBWaWV3 cG9ydEFyZ3VtZW50cyYgb3RoZXIpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApp bmRleCBiMTU3MWEwZTllMjMxN2QxMjcyN2U0Y2UzZTViYWQzMTk0NTQ4MjdiLi5mNjliMGYxNmEx Mzk2MmVlMjAyMDg2MjE3MGJlMTlkNTg1YWRjNWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5jcHAKQEAgLTgwNCwxMiArODA0LDEzIEBAIHN0YXRpYyBFd2tfVmlld19Qcml2YXRlX0RhdGEq IF9ld2tfdmlld19wcml2X25ldyhFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiAgICAg V2ViQ29yZTo6TGF5b3V0TWlsZXN0b25lcyBsYXlvdXRNaWxlc3RvbmVzID0gV2ViQ29yZTo6RGlk Rmlyc3RMYXlvdXQgfCBXZWJDb3JlOjpEaWRGaXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXQ7CiAg ICAgcHJpdi0+cGFnZS0+YWRkTGF5b3V0TWlsZXN0b25lcyhsYXlvdXRNaWxlc3RvbmVzKTsKIAor ICAgIC8vIEZJWE1FOiBOb29uZSBpcyBzdXBwb3NlZCB0byBkbyB0aGlzIG1hbnVhbGx5LgogICAg IHByaXYtPnZpZXdwb3J0QXJndW1lbnRzLndpZHRoID0gV2ViQ29yZTo6Vmlld3BvcnRBcmd1bWVu dHM6OlZhbHVlQXV0bzsKICAgICBwcml2LT52aWV3cG9ydEFyZ3VtZW50cy5oZWlnaHQgPSBXZWJD b3JlOjpWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvOwotICAgIHByaXYtPnZpZXdwb3J0QXJn dW1lbnRzLmluaXRpYWxTY2FsZSA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1 dG87Ci0gICAgcHJpdi0+dmlld3BvcnRBcmd1bWVudHMubWluaW11bVNjYWxlID0gV2ViQ29yZTo6 Vmlld3BvcnRBcmd1bWVudHM6OlZhbHVlQXV0bzsKLSAgICBwcml2LT52aWV3cG9ydEFyZ3VtZW50 cy5tYXhpbXVtU2NhbGUgPSBXZWJDb3JlOjpWaWV3cG9ydEFyZ3VtZW50czo6VmFsdWVBdXRvOwot ICAgIHByaXYtPnZpZXdwb3J0QXJndW1lbnRzLnVzZXJTY2FsYWJsZSA9IHRydWU7CisgICAgcHJp di0+dmlld3BvcnRBcmd1bWVudHMuem9vbSA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpW YWx1ZUF1dG87CisgICAgcHJpdi0+dmlld3BvcnRBcmd1bWVudHMubWluWm9vbSA9IFdlYkNvcmU6 OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87CisgICAgcHJpdi0+dmlld3BvcnRBcmd1bWVu dHMubWF4Wm9vbSA9IFdlYkNvcmU6OlZpZXdwb3J0QXJndW1lbnRzOjpWYWx1ZUF1dG87CisgICAg cHJpdi0+dmlld3BvcnRBcmd1bWVudHMudXNlclpvb20gPSB0cnVlOwogCiAgICAgcHJpdi0+cGFn ZVNldHRpbmdzLT5zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkodHJ1ZSk7CiAgICAgcHJpdi0+ cGFnZVNldHRpbmdzLT5zZXREZWZhdWx0VGV4dEVuY29kaW5nTmFtZSgiaXNvLTg4NTktMSIpOwo=