102349 2012-11-15 01:08:10 -0800 :enabled should match with an anchor element having href attribute 2015-01-31 20:16:50 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 shinyak shinyak allan.jensen benjamin cmarcelo macpherson menard tkent webkit.review.bot oldest_to_newest 767805 0 shinyak 2012-11-15 01:08:10 -0800 According to HTML5 spec, http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#selector-enabled :enabled should match with anchor/area/link having href attribute. However, it does not match now. 767811 1 shinyak 2012-11-15 01:16:28 -0800 link element is moved to https://bugs.webkit.org/show_bug.cgi?id=102351 767813 2 174368 shinyak 2012-11-15 01:25:32 -0800 Created attachment 174368 Patch 767850 3 174368 allan.jensen 2012-11-15 02:30:40 -0800 Comment on attachment 174368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review > Source/WebCore/css/SelectorChecker.cpp:1042 > - if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag))) > + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. 767854 4 174368 shinyak 2012-11-15 02:35:55 -0800 Comment on attachment 174368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review >> Source/WebCore/css/SelectorChecker.cpp:1042 >> + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) > > Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. Ah, thanks! We have to check tagName. 767856 5 174368 shinyak 2012-11-15 02:39:40 -0800 Comment on attachment 174368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review >>> Source/WebCore/css/SelectorChecker.cpp:1042 >>> + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) >> >> Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. > > Ah, thanks! We have to check tagName. By the way this implementation is completely wrong :-( 767862 6 allan.jensen 2012-11-15 02:44:20 -0800 (In reply to comment #5) > (From update of attachment 174368 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review > > >>> Source/WebCore/css/SelectorChecker.cpp:1042 > >>> + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) > >> > >> Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. > > > > Ah, thanks! We have to check tagName. > > By the way this implementation is completely wrong :-( The more I think about it, I guess you should skip handling AREA elements to begin with. It seems they haven't thought it through in the standard. AREAs at least in WebKit do not even have their own render object, and will therefore not have their own style either, even if we manage to set a specific style for them in ElementRareData, it will not be used, because AREAs are not rendered. 767863 7 174384 shinyak 2012-11-15 02:45:04 -0800 Created attachment 174384 Patch 767869 8 shinyak 2012-11-15 02:47:53 -0800 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 174368 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review > > > > >>> Source/WebCore/css/SelectorChecker.cpp:1042 > > >>> + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) > > >> > > >> Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. > > > > > > Ah, thanks! We have to check tagName. > > > > By the way this implementation is completely wrong :-( > > The more I think about it, I guess you should skip handling AREA elements to begin with. It seems they haven't thought it through in the standard. AREAs at least in WebKit do not even have their own render object, and will therefore not have their own style either, even if we manage to set a specific style for them in ElementRareData, it will not be used, because AREAs are not rendered. Hmm... the reason why AREA is not rendered is just AREA has display: none. Actually my test renders AREA. 767875 9 shinyak 2012-11-15 02:50:12 -0800 This is an output of DRT Content-Type: text/plain layer at (0,0) size 800x600 RenderView at (0,0) size 800x600 layer at (0,0) size 800x196 RenderBlock {HTML} at (0,0) size 800x196 RenderBody {BODY} at (8,16) size 784x164 RenderBlock {P} at (0,0) size 784x20 RenderText {#text} at (0,0) size 448x19 text run at (0,0) width 448: ":enabled should match with an anchor or area element having href attribute." RenderBlock {P} at (0,36) size 784x20 RenderInline {A} at (0,0) size 196x19 [color=#0000EE] [bgcolor=#0000FF] RenderText {#text} at (0,0) size 196x19 text run at (0,0) width 196: "This background should be blue." RenderBlock {P} at (0,72) size 784x20 RenderInline {A} at (0,0) size 219x19 RenderText {#text} at (0,0) size 219x19 text run at (0,0) width 219: "This background should not be blue." RenderBlock {P} at (0,108) size 784x20 RenderInline {AREA} at (0,0) size 196x19 [bgcolor=#0000FF] RenderText {#text} at (0,0) size 196x19 text run at (0,0) width 196: "This background should be blue." RenderBlock {P} at (0,144) size 784x20 RenderInline {AREA} at (0,0) size 219x19 RenderText {#text} at (0,0) size 219x19 text run at (0,0) width 219: "This background should not be blue." #EOF 767894 10 allan.jensen 2012-11-15 03:11:57 -0800 (In reply to comment #8) > (In reply to comment #6) > > (In reply to comment #5) > > > (From update of attachment 174368 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=174368&action=review > > > > > > >>> Source/WebCore/css/SelectorChecker.cpp:1042 > > > >>> + if (element && (element->isFormControlElement() || element->hasTagName(optionTag) || element->hasTagName(optgroupTag) || element->isLink())) > > > >> > > > >> Won't this match the parent image of the AREA rather than the AREA element? That is any IMG element with a USEMAP property. > > > > > > > > Ah, thanks! We have to check tagName. > > > > > > By the way this implementation is completely wrong :-( > > > > The more I think about it, I guess you should skip handling AREA elements to begin with. It seems they haven't thought it through in the standard. AREAs at least in WebKit do not even have their own render object, and will therefore not have their own style either, even if we manage to set a specific style for them in ElementRareData, it will not be used, because AREAs are not rendered. > > Hmm... the reason why AREA is not rendered is just AREA has display: none. > Actually my test renders AREA. That is part of it. The reason they have display:none is that they are supposed to be used together with MAP and IMG elements, AREA elements represent different shapes (often non-rectangular) in an image. These shapes are where they respond to mouse-clicks, but since the image is rendered by the IMG element, the AREA elements are not supposed to render anything themselves. So your test-case works, but you are not using AREA in the role it is meant to be used. If I was a web-designer I would expect something like area:enabled or area:hover to be able to show me the areas in the images that they respond to, but we do not support having special styles for these areas. 768736 11 shinyak 2012-11-15 17:28:54 -0800 > That is part of it. The reason they have display:none is that they are supposed to be used together with MAP and IMG elements, AREA elements represent different shapes (often non-rectangular) in an image. These shapes are where they respond to mouse-clicks, but since the image is rendered by the IMG element, the AREA elements are not supposed to render anything themselves. > > So your test-case works, but you are not using AREA in the role it is meant to be used. If I was a web-designer I would expect something like area:enabled or area:hover to be able to show me the areas in the images that they respond to, but we do not support having special styles for these areas. I understand I was doing some non-expected thing. I was just obeying the spec. Actually, I don't have any strong insistence that :enabled should match AREA, though. Basically it's meaningless for now. So, anyway, I'll remove AREA support from this patch. 768771 12 174577 shinyak 2012-11-15 17:51:45 -0800 Created attachment 174577 Patch 863235 13 174577 tkent 2013-03-25 18:04:03 -0700 Comment on attachment 174577 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174577&action=review > Source/WebCore/css/SelectorChecker.cpp:1046 > + if (element->hasTagName(aTag)) > + return element->isLink(); We shouldn't add hasTagName checks in CSS code any more, should have Element::matchesEnabledPseudoClass virtual function instead. 174368 2012-11-15 01:25:32 -0800 2012-11-15 02:45:00 -0800 Patch bug-102349-20121115182329.patch text/plain 4069 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2N2MwODBiMTBjMGZi ZDZkMGUwMWNjOTkzODYzODJmN2MxNmI4YS4uZTA1OWZjN2IzNjYwYjZjNjk2YTY1ZDI3ZjIxMDUz NGJhMmI2NmJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICA6ZW5hYmxlZCBz aG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNob3IvYXJlYSBlbGVtZW50IGhhdmluZyBocmVmIGF0dHJp YnV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjM0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFj Y29yZGluZyB0byB0aGUgSFRNTDUgc3BlYywKKyAgICAgICAgaHR0cDovL3d3dy53aGF0d2cub3Jn L3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2Uvc2VsZWN0b3JzLmh0bWwjc2Vs ZWN0b3ItZW5hYmxlZAorICAgICAgICA6ZW5hYmxlZCBzaG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNo b3IvYXJlYSBlbGVtZW50IGhhdmluZyBocmVmIGF0dHJpYnV0ZS4KKworICAgICAgICBpc0xpbmso KSBob2xkcyBmb3Igc3VjaCBlbGVtZW50cy4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9lbmFi bGVkLXBzZXVkby1jbGFzcy1saW5rLmh0bWwKKworICAgICAgICAqIGNzcy9TZWxlY3RvckNoZWNr ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JDaGVja2VyOjpjaGVja09uZVNlbGVj dG9yKToKKwogMjAxMi0xMS0xNCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5v cmc+IAogCiAgICAgICAgIENoYW5naW5nIHBzZXVkb0NsYXNzICg6ZGlzYWJsZWQpIHNob3VsZCBj YXVzZSBkaXN0cmlidXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0 b3JDaGVja2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCmlu ZGV4IDM4ZDQxZjc4NDg4NjVkYzhhYzNjMTY0OTE5MjYzODY0NjU5MWJkMzIuLjc1ZjRkY2FmMGZi MTYwNGYwYTA4MjViZjgzYzg5M2MyZmQ1YjQ4NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3Rv ckNoZWNrZXIuY3BwCkBAIC0xMDM5LDcgKzEwMzksNyBAQCBib29sIFNlbGVjdG9yQ2hlY2tlcjo6 Y2hlY2tPbmVTZWxlY3Rvcihjb25zdCBTZWxlY3RvckNoZWNraW5nQ29udGV4dCYgY29udGV4dCwg YwogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTU2Vs ZWN0b3I6OlBzZXVkb0VuYWJsZWQ6Ci0gICAgICAgICAgICBpZiAoZWxlbWVudCAmJiAoZWxlbWVu dC0+aXNGb3JtQ29udHJvbEVsZW1lbnQoKSB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKG9wdGlvblRh ZykgfHwgZWxlbWVudC0+aGFzVGFnTmFtZShvcHRncm91cFRhZykpKQorICAgICAgICAgICAgaWYg KGVsZW1lbnQgJiYgKGVsZW1lbnQtPmlzRm9ybUNvbnRyb2xFbGVtZW50KCkgfHwgZWxlbWVudC0+ aGFzVGFnTmFtZShvcHRpb25UYWcpIHx8IGVsZW1lbnQtPmhhc1RhZ05hbWUob3B0Z3JvdXBUYWcp IHx8IGVsZW1lbnQtPmlzTGluaygpKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZWxlbWVudC0+ aXNFbmFibGVkRm9ybUNvbnRyb2woKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNl IENTU1NlbGVjdG9yOjpQc2V1ZG9GdWxsUGFnZU1lZGlhOgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNlYzQ2ZjI2OTg4YmJk NzRkNGU1MjAzOTM2ZDFhOWVlZmFhZWQ5OGQuLjU5Mjg4YTA2MDdjNWJlMmYwMTU5ODRiZTEyZmU3 MjQ0MTk4OGRhMDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMS0xNSAgU2hpbnlhIEth d2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgOmVuYWJsZWQgc2hvdWxk IG1hdGNoIHdpdGggYW4gYW5jaG9yL2FyZWEgZWxlbWVudCBoYXZpbmcgaHJlZiBhdHRyaWJ1dGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIzNDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3Qv Y3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAg ICAgICogZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGluay5odG1sOiBBZGRlZC4KKwog MjAxMi0xMS0xNCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+IAogCiAg ICAgICAgIENoYW5naW5nIHBzZXVkb0NsYXNzICg6ZGlzYWJsZWQpIHNob3VsZCBjYXVzZSBkaXN0 cmlidXRpb24uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVk by1jbGFzcy1saW5rLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVk LXBzZXVkby1jbGFzcy1saW5rLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMThlNzFhNTBhNDg0 YjAxMWQxMGY3YWU3ODI2ODdjMDlmNTEzNzY5MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhwZWN0ZWQuaHRtbApAQCAt MCwwICsxLDE2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHN0eWxlPgorYXJlYSB7Cisg ICAgZGlzcGxheTogaW5saW5lCit9Cis8L3N0eWxlPgorCis8cD48YSBocmVmPSJodHRwOi8vd3d3 LmV4YW1wbGUuY29tLyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6IGJsdWU7Ij5UaGlzIGJhY2tn cm91bmQgc2hvdWxkIGJlIGJsdWUuPC9hPjwvcD4KKzxwPjxhcmVhIGlkPSJhcmVhIiBocmVmPSJo dHRwOi8vd3d3LmV4YW1wbGUuY29tLyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6IGJsdWU7Ij48 L2FyZWE+PC9wPgorCis8c2NyaXB0PgorYXJlYS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZSgnVGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBiZSBibHVlLicpKTsKKzwvc2NyaXB0Pgor Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVk by1jbGFzcy1saW5rLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVkby1j bGFzcy1saW5rLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWU2YWMyNmI3YzczNmU0MDdlMGJiYjk2NDUyYTJj ZTI1YjRhZWE0NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2VuYWJs ZWQtcHNldWRvLWNsYXNzLWxpbmsuaHRtbApAQCAtMCwwICsxLDIwIEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPHN0eWxlPgorYXJlYSB7CisgICAgZGlzcGxheTogaW5saW5lCit9CisKKzpl bmFibGVkIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworfQorPC9zdHlsZT4KKworPHA+ PGEgaHJlZj0iaHR0cDovL3d3dy5leGFtcGxlLmNvbS8iPlRoaXMgYmFja2dyb3VuZCBzaG91bGQg YmUgYmx1ZS48L2E+PC9wPgorPHA+PGFyZWEgaWQ9ImFyZWEiIGhyZWY9Imh0dHA6Ly93d3cuZXhh bXBsZS5jb20vIj48L2FyZWE+PC9wPgorCis8c2NyaXB0PgorYXJlYS5hcHBlbmRDaGlsZChkb2N1 bWVudC5jcmVhdGVUZXh0Tm9kZSgnVGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBiZSBibHVlLicpKTsK Kzwvc2NyaXB0PgorCis8L2h0bWw+Cg== 174384 2012-11-15 02:45:04 -0800 2012-11-15 17:51:42 -0800 Patch bug-102349-20121115194301.patch text/plain 4877 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2N2MwODBiMTBjMGZi ZDZkMGUwMWNjOTkzODYzODJmN2MxNmI4YS4uZTA1OWZjN2IzNjYwYjZjNjk2YTY1ZDI3ZjIxMDUz NGJhMmI2NmJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTExLTE1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICA6ZW5hYmxlZCBz aG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNob3IvYXJlYSBlbGVtZW50IGhhdmluZyBocmVmIGF0dHJp YnV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjM0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFj Y29yZGluZyB0byB0aGUgSFRNTDUgc3BlYywKKyAgICAgICAgaHR0cDovL3d3dy53aGF0d2cub3Jn L3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2Uvc2VsZWN0b3JzLmh0bWwjc2Vs ZWN0b3ItZW5hYmxlZAorICAgICAgICA6ZW5hYmxlZCBzaG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNo b3IvYXJlYSBlbGVtZW50IGhhdmluZyBocmVmIGF0dHJpYnV0ZS4KKworICAgICAgICBpc0xpbmso KSBob2xkcyBmb3Igc3VjaCBlbGVtZW50cy4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9lbmFi bGVkLXBzZXVkby1jbGFzcy1saW5rLmh0bWwKKworICAgICAgICAqIGNzcy9TZWxlY3RvckNoZWNr ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JDaGVja2VyOjpjaGVja09uZVNlbGVj dG9yKToKKwogMjAxMi0xMS0xNCAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5v cmc+IAogCiAgICAgICAgIENoYW5naW5nIHBzZXVkb0NsYXNzICg6ZGlzYWJsZWQpIHNob3VsZCBj YXVzZSBkaXN0cmlidXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0 b3JDaGVja2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCmlu ZGV4IDM4ZDQxZjc4NDg4NjVkYzhhYzNjMTY0OTE5MjYzODY0NjU5MWJkMzIuLmIyNTZiZmJmNGRj NzMyNmE2NmVmYmViNDYxZDZiMGQ0OTMzY2E1M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3Rv ckNoZWNrZXIuY3BwCkBAIC0xMDM5LDggKzEwMzksMTIgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6 OmNoZWNrT25lU2VsZWN0b3IoY29uc3QgU2VsZWN0b3JDaGVja2luZ0NvbnRleHQmIGNvbnRleHQs IGMKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1Nl bGVjdG9yOjpQc2V1ZG9FbmFibGVkOgotICAgICAgICAgICAgaWYgKGVsZW1lbnQgJiYgKGVsZW1l bnQtPmlzRm9ybUNvbnRyb2xFbGVtZW50KCkgfHwgZWxlbWVudC0+aGFzVGFnTmFtZShvcHRpb25U YWcpIHx8IGVsZW1lbnQtPmhhc1RhZ05hbWUob3B0Z3JvdXBUYWcpKSkKLSAgICAgICAgICAgICAg ICByZXR1cm4gZWxlbWVudC0+aXNFbmFibGVkRm9ybUNvbnRyb2woKTsKKyAgICAgICAgICAgIGlm IChlbGVtZW50KSB7CisgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzRm9ybUNvbnRyb2xF bGVtZW50KCkgfHwgZWxlbWVudC0+aGFzVGFnTmFtZShvcHRpb25UYWcpIHx8IGVsZW1lbnQtPmhh c1RhZ05hbWUob3B0Z3JvdXBUYWcpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZWxlbWVu dC0+aXNFbmFibGVkRm9ybUNvbnRyb2woKTsKKyAgICAgICAgICAgICAgICBpZiAoZWxlbWVudC0+ aGFzVGFnTmFtZShhVGFnKSB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKGFyZWFUYWcpKQorICAgICAg ICAgICAgICAgICAgICByZXR1cm4gZWxlbWVudC0+aXNMaW5rKCk7CisgICAgICAgICAgICB9CiAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6UHNldWRvRnVsbFBh Z2VNZWRpYToKICAgICAgICAgICAgIHJldHVybiBlbGVtZW50ICYmIGVsZW1lbnQtPmRvY3VtZW50 KCkgJiYgZWxlbWVudC0+ZG9jdW1lbnQoKS0+aXNNZWRpYURvY3VtZW50KCk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2Vj NDZmMjY5ODhiYmQ3NGQ0ZTUyMDM5MzZkMWE5ZWVmYWFlZDk4ZC4uNTkyODhhMDYwN2M1YmUyZjAx NTk4NGJlMTJmZTcyNDQxOTg4ZGEwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTExLTE1 ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICA6ZW5h YmxlZCBzaG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNob3IvYXJlYSBlbGVtZW50IGhhdmluZyBocmVm IGF0dHJpYnV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMjM0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGluay1leHBlY3RlZC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9lbmFibGVkLXBzZXVkby1jbGFzcy1saW5rLmh0bWw6 IEFkZGVkLgorCiAyMDEyLTExLTE0ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVt Lm9yZz4gCiAKICAgICAgICAgQ2hhbmdpbmcgcHNldWRvQ2xhc3MgKDpkaXNhYmxlZCkgc2hvdWxk IGNhdXNlIGRpc3RyaWJ1dGlvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2Vu YWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44 Zjc0ZGQ2YzQ2MDhhMTk4NmU0N2MxM2YyYjJiMzkzZjc5N2FmZmUzCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGluay1leHBlY3Rl ZC5odG1sCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c3R5bGU+ CithcmVhIHsKKyAgICBkaXNwbGF5OiBpbmxpbmUKK30KKzwvc3R5bGU+CisKKzxwPjplbmFibGVk IHNob3VsZCBtYXRjaCB3aXRoIGFuIGFuY2hvciBvciBhcmVhIGVsZW1lbnQgaGF2aW5nIGhyZWYg YXR0cmlidXRlLjwvcD4KKworPHA+PGEgaHJlZj0iaHR0cDovL3d3dy5leGFtcGxlLmNvbS8iIHN0 eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOyI+VGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBiZSBi bHVlLjwvYT48L3A+Cis8cD48YT5UaGlzIGJhY2tncm91bmQgc2hvdWxkIG5vdCBiZSBibHVlLjwv YT48L3A+Cis8cD48YXJlYSBpZD0iYXJlYTEiIGhyZWY9Imh0dHA6Ly93d3cuZXhhbXBsZS5jb20v IiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsiPjwvYXJlYT48L3A+Cis8cD48YXJlYSBp ZD0iYXJlYTIiPjwvYXJlYT48L3A+CisKKzxzY3JpcHQ+CithcmVhMS5hcHBlbmRDaGlsZChkb2N1 bWVudC5jcmVhdGVUZXh0Tm9kZSgnVGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBiZSBibHVlLicpKTsK K2FyZWEyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCdUaGlzIGJhY2tncm91 bmQgc2hvdWxkIG5vdCBiZSBibHVlLicpKTsKKzwvc2NyaXB0PgorCis8L2h0bWw+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVkby1jbGFzcy1saW5rLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVkby1jbGFzcy1saW5rLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNjVmNDk1YTFkMWExMjkyN2MxYjhhMzE2YzZhMWY0ODhjNDYyYzBlZgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxp bmsuaHRtbApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPHN0eWxl PgorYXJlYSB7CisgICAgZGlzcGxheTogaW5saW5lCit9CisKKzplbmFibGVkIHsKKyAgICBiYWNr Z3JvdW5kLWNvbG9yOiBibHVlOworfQorPC9zdHlsZT4KKworPHA+OmVuYWJsZWQgc2hvdWxkIG1h dGNoIHdpdGggYW4gYW5jaG9yIG9yIGFyZWEgZWxlbWVudCBoYXZpbmcgaHJlZiBhdHRyaWJ1dGUu PC9wPgorCis8cD48YSBocmVmPSJodHRwOi8vd3d3LmV4YW1wbGUuY29tLyI+VGhpcyBiYWNrZ3Jv dW5kIHNob3VsZCBiZSBibHVlLjwvYT48L3A+Cis8cD48YT5UaGlzIGJhY2tncm91bmQgc2hvdWxk IG5vdCBiZSBibHVlLjwvYT48L3A+Cis8cD48YXJlYSBpZD0iYXJlYTEiIGhyZWY9Imh0dHA6Ly93 d3cuZXhhbXBsZS5jb20vIj48L2FyZWE+PC9wPgorPHA+PGFyZWEgaWQ9ImFyZWEyIj48L2FyZWE+ PC9wPgorCis8c2NyaXB0PgorYXJlYTEuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoJ1RoaXMgYmFja2dyb3VuZCBzaG91bGQgYmUgYmx1ZS4nKSk7CithcmVhMi5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgnVGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBub3QgYmUg Ymx1ZS4nKSk7Cis8L3NjcmlwdD4KKworPC9odG1sPgo= 174577 2012-11-15 17:51:45 -0800 2013-03-25 18:04:03 -0700 Patch bug-102349-20121116104941.patch text/plain 4050 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0ODY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU2Nzg2NTRmZTU2ZjMz NmIxMTk2N2FlMjYxNDc0NTc1NzcyZTUwYi4uNmJkN2YxMmE5NjVlMzM3YzU2YzE0NzQ1MDY0Y2E3 YjA0OWZlNDYwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTE1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICA6ZW5hYmxlZCBz aG91bGQgbWF0Y2ggd2l0aCBhbiBhbmNob3IgZWxlbWVudCBoYXZpbmcgaHJlZiBhdHRyaWJ1dGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDIzNDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRp bmcgdG8gdGhlIEhUTUw1IHNwZWMsCisgICAgICAgIGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVj cy93ZWItYXBwcy9jdXJyZW50LXdvcmsvbXVsdGlwYWdlL3NlbGVjdG9ycy5odG1sI3NlbGVjdG9y LWVuYWJsZWQKKyAgICAgICAgOmVuYWJsZWQgc2hvdWxkIG1hdGNoIHdpdGggYW4gYW5jaG9yIGVs ZW1lbnQgaGF2aW5nIGhyZWYgYXR0cmlidXRlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL2Vu YWJsZWQtcHNldWRvLWNsYXNzLWxpbmsuaHRtbAorCisgICAgICAgICogY3NzL1NlbGVjdG9yQ2hl Y2tlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2Vs ZWN0b3IpOgorCiAyMDEyLTExLTE1ICBBbGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBBZGQgdGVzdHMgZm9yIGV4cGxpY2l0IHNlcmlhbGl6YXRpb24gdmFsdWVz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCmluZGV4IDM4ZDQxZjc4NDg4NjVk YzhhYzNjMTY0OTE5MjYzODY0NjU5MWJkMzIuLjRlNjNlMmU2ZmRmODZkMjQ4YjA2Yzc1MjVlZjM2 YmZjYjQ0YTcwNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNr ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwCkBAIC0x MDM5LDggKzEwMzksMTIgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lU2VsZWN0b3Io Y29uc3QgU2VsZWN0b3JDaGVja2luZ0NvbnRleHQmIGNvbnRleHQsIGMKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9FbmFi bGVkOgotICAgICAgICAgICAgaWYgKGVsZW1lbnQgJiYgKGVsZW1lbnQtPmlzRm9ybUNvbnRyb2xF bGVtZW50KCkgfHwgZWxlbWVudC0+aGFzVGFnTmFtZShvcHRpb25UYWcpIHx8IGVsZW1lbnQtPmhh c1RhZ05hbWUob3B0Z3JvdXBUYWcpKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gZWxlbWVudC0+ aXNFbmFibGVkRm9ybUNvbnRyb2woKTsKKyAgICAgICAgICAgIGlmIChlbGVtZW50KSB7CisgICAg ICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzRm9ybUNvbnRyb2xFbGVtZW50KCkgfHwgZWxlbWVu dC0+aGFzVGFnTmFtZShvcHRpb25UYWcpIHx8IGVsZW1lbnQtPmhhc1RhZ05hbWUob3B0Z3JvdXBU YWcpKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gZWxlbWVudC0+aXNFbmFibGVkRm9ybUNv bnRyb2woKTsKKyAgICAgICAgICAgICAgICBpZiAoZWxlbWVudC0+aGFzVGFnTmFtZShhVGFnKSkK KyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQtPmlzTGluaygpOworICAgICAgICAg ICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVk b0Z1bGxQYWdlTWVkaWE6CiAgICAgICAgICAgICByZXR1cm4gZWxlbWVudCAmJiBlbGVtZW50LT5k b2N1bWVudCgpICYmIGVsZW1lbnQtPmRvY3VtZW50KCktPmlzTWVkaWFEb2N1bWVudCgpOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDI4NjVmNmNiMzUyZmE4MTljZTMzMjY2ZDRkZTZkMzZjMTU3Y2RkMDUuLjRkZmVhZDhlZjIw NWU3YTFiZGMxM2M5N2JhNzcwYjc3ODc4NzA2YmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx Mi0xMS0xNSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgOmVuYWJsZWQgc2hvdWxkIG1hdGNoIHdpdGggYW4gYW5jaG9yL2FyZWEgZWxlbWVudCBoYXZp bmcgaHJlZiBhdHRyaWJ1dGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDIzNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGZhc3QvY3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGlu ay5odG1sOiBBZGRlZC4KKwogMjAxMi0xMS0xNSAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBzZXRWZXJzaW9uIGJhdGNoIDgKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxpbmstZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2VuYWJsZWQtcHNldWRvLWNsYXNzLWxp bmstZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42ZWY3Yzk4OTBkZjM1YTYzNGY1Mjk3YzdlZDhm ZTAxYjRmNTQ1ZTgzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZW5h YmxlZC1wc2V1ZG8tY2xhc3MtbGluay1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsOSBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKworPHA+OmVuYWJsZWQgc2hvdWxkIG1hdGNoIHdpdGggYW4g YW5jaG9yIG9yIGFyZWEgZWxlbWVudCBoYXZpbmcgaHJlZiBhdHRyaWJ1dGUuPC9wPgorCis8cD48 YSBocmVmPSJodHRwOi8vd3d3LmV4YW1wbGUuY29tLyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6 IGJsdWU7Ij5UaGlzIGJhY2tncm91bmQgc2hvdWxkIGJlIGJsdWUuPC9hPjwvcD4KKzxwPjxhPlRo aXMgYmFja2dyb3VuZCBzaG91bGQgbm90IGJlIGJsdWUuPC9hPjwvcD4KKworPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGluay5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZW5hYmxlZC1wc2V1ZG8tY2xhc3MtbGluay5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmU5YTUxMDBkYTM3ZDU5ZDQ2NmY1M2IzYWQyN2NmMjkzZTdkMjAwMDIKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9lbmFibGVkLXBzZXVkby1jbGFz cy1saW5rLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxz dHlsZT4KKzplbmFibGVkIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworfQorPC9zdHls ZT4KKworPHA+OmVuYWJsZWQgc2hvdWxkIG1hdGNoIHdpdGggYW4gYW5jaG9yIG9yIGFyZWEgZWxl bWVudCBoYXZpbmcgaHJlZiBhdHRyaWJ1dGUuPC9wPgorCis8cD48YSBocmVmPSJodHRwOi8vd3d3 LmV4YW1wbGUuY29tLyI+VGhpcyBiYWNrZ3JvdW5kIHNob3VsZCBiZSBibHVlLjwvYT48L3A+Cis8 cD48YT5UaGlzIGJhY2tncm91bmQgc2hvdWxkIG5vdCBiZSBibHVlLjwvYT48L3A+CisKKzwvaHRt bD4K