102343 2012-11-14 23:42:44 -0800 Remove coneGain and distanceGain attributes from PannerNode.idl 2012-11-17 12:06:56 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 li.yin li.yin abarth crogers eric.carlson feature-media-reviews ojan webkit.review.bot oldest_to_newest 767776 0 li.yin 2012-11-14 23:42:44 -0800 Removing .coneGain and .distanceGain as publicly accessible values, since normally they only need to be calculated internally. 767778 1 174362 li.yin 2012-11-14 23:47:41 -0800 Created attachment 174362 Patch 769423 2 174362 crogers 2012-11-16 10:30:15 -0800 Comment on attachment 174362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review Li, thanks this looks good with minor nit. > Source/WebCore/ChangeLog:11 > + No new tests. No change in functionality. This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed." 769897 3 174807 li.yin 2012-11-16 22:20:00 -0800 Created attachment 174807 Patch 769898 4 li.yin 2012-11-16 22:20:58 -0800 (In reply to comment #2) > (From update of attachment 174362 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=174362&action=review > > Li, thanks this looks good with minor nit. > > > Source/WebCore/ChangeLog:11 > > + No new tests. No change in functionality. > > This is just a detail, but this comment should probably say: "No changes to tests, since these attributes were not tested and are being removed." Done. Thanks for your comments. 769974 5 174807 crogers 2012-11-17 11:46:37 -0800 Comment on attachment 174807 Patch thanks 769984 6 174807 webkit.review.bot 2012-11-17 12:06:52 -0800 Comment on attachment 174807 Patch Clearing flags on attachment: 174807 Committed r135050: <http://trac.webkit.org/changeset/135050> 769985 7 webkit.review.bot 2012-11-17 12:06:56 -0800 All reviewed patches have been landed. Closing bug. 174362 2012-11-14 23:47:41 -0800 2012-11-16 22:19:48 -0800 Patch bug-102343-20121115154539.patch text/plain 1475 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTZiY2JhNjI0MjcxM2I4 NGZkYjIxMGYwZTUwMjM5MGYyMWFiODM4Ni4uNTVkOTZkMzM5YWI4OGY3MzIxNmFhNDI1NDhkYTFi NGVlODc5ODQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE0ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFJlbW92ZSBjb25lR2FpbiBhbmQgZGlz dGFuY2VHYWluIGF0dHJpYnV0ZXMgZnJvbSBQYW5uZXJOb2RlLmlkbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZpbmcgLmNvbmVHYWluIGFuZCAu ZGlzdGFuY2VHYWluIGFzIHB1YmxpY2x5IGFjY2Vzc2libGUgdmFsdWVzLAorICAgICAgICBzaW5j ZSBub3JtYWxseSB0aGV5IG9ubHkgbmVlZCB0byBiZSBjYWxjdWxhdGVkIGludGVybmFsbHkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5pZGw6CisKIDIwMTItMTEtMTQgIE5p Y28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bS9tYWNd IEZpeCBkcmF3aW5nIG9mIGJ1dHRvbnMsIGNoZWNrYm94ZXMsIHJhZGlvIGJveGVzLCBhbmQgc3Rl cHBlcnMgd2hlbiB0aGUgcGFnZSBpcyBzY2FsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL1Bhbm5lck5vZGUuaWRsCmluZGV4IDhlZThhMzU0YWQxMzlmYjFkOTAxYzkwMjlj YTczNzhjZjIyMjU2YzkuLjVjZjFmN2M3ZWJhNGVjNWY5NmZkZjA2MDI3MWIyZTEzYThkNzBjMjYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVyTm9kZS5p ZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmlkbApA QCAtNTcsOCArNTcsNCBAQAogICAgIGF0dHJpYnV0ZSBmbG9hdCBjb25lSW5uZXJBbmdsZTsKICAg ICBhdHRyaWJ1dGUgZmxvYXQgY29uZU91dGVyQW5nbGU7CiAgICAgYXR0cmlidXRlIGZsb2F0IGNv bmVPdXRlckdhaW47Ci0KLSAgICAvLyBEeW5hbWljYWxseSBjYWxjdWxhdGVkIGdhaW4gdmFsdWVz ICAgICAgICAgIAotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBBdWRpb0dhaW4gY29uZUdhaW47Ci0g ICAgcmVhZG9ubHkgYXR0cmlidXRlIEF1ZGlvR2FpbiBkaXN0YW5jZUdhaW47CiB9Owo= 174807 2012-11-16 22:20:00 -0800 2012-11-17 12:06:52 -0800 Patch bug-102343-20121117141757.patch text/plain 1516 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTZiY2JhNjI0MjcxM2I4 NGZkYjIxMGYwZTUwMjM5MGYyMWFiODM4Ni4uNTYzZTIyOWYxZjIxYjlkYjhlYzJhOWExNDZiMTJk ZTNmYzg5ZmQzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE0ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFJlbW92ZSBjb25lR2FpbiBhbmQgZGlz dGFuY2VHYWluIGF0dHJpYnV0ZXMgZnJvbSBQYW5uZXJOb2RlLmlkbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyMzQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZpbmcgLmNvbmVHYWluIGFuZCAu ZGlzdGFuY2VHYWluIGFzIHB1YmxpY2x5IGFjY2Vzc2libGUgdmFsdWVzLAorICAgICAgICBzaW5j ZSBub3JtYWxseSB0aGV5IG9ubHkgbmVlZCB0byBiZSBjYWxjdWxhdGVkIGludGVybmFsbHkuCisK KyAgICAgICAgTm8gY2hhbmdlcyB0byB0ZXN0cywgc2luY2UgdGhlc2UgYXR0cmlidXRlcyB3ZXJl IG5vdCB0ZXN0ZWQgYW5kIGFyZSBiZWluZyByZW1vdmVkLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9QYW5uZXJOb2RlLmlkbDoKKwogMjAxMi0xMS0xNCAgTmljbyBXZWJlciAgPHRoYWtp c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtL21hY10gRml4IGRyYXdpbmcgb2Yg YnV0dG9ucywgY2hlY2tib3hlcywgcmFkaW8gYm94ZXMsIGFuZCBzdGVwcGVycyB3aGVuIHRoZSBw YWdlIGlzIHNjYWxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRp by9QYW5uZXJOb2RlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vUGFubmVy Tm9kZS5pZGwKaW5kZXggOGVlOGEzNTRhZDEzOWZiMWQ5MDFjOTAyOWNhNzM3OGNmMjIyNTZjOS4u NWNmMWY3YzdlYmE0ZWM1Zjk2ZmRmMDYwMjcxYjJlMTNhOGQ3MGMyNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9QYW5uZXJOb2RlLmlkbAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL1Bhbm5lck5vZGUuaWRsCkBAIC01Nyw4ICs1Nyw0IEBA CiAgICAgYXR0cmlidXRlIGZsb2F0IGNvbmVJbm5lckFuZ2xlOwogICAgIGF0dHJpYnV0ZSBmbG9h dCBjb25lT3V0ZXJBbmdsZTsKICAgICBhdHRyaWJ1dGUgZmxvYXQgY29uZU91dGVyR2FpbjsKLQot ICAgIC8vIER5bmFtaWNhbGx5IGNhbGN1bGF0ZWQgZ2FpbiB2YWx1ZXMgICAgICAgICAgCi0gICAg cmVhZG9ubHkgYXR0cmlidXRlIEF1ZGlvR2FpbiBjb25lR2FpbjsKLSAgICByZWFkb25seSBhdHRy aWJ1dGUgQXVkaW9HYWluIGRpc3RhbmNlR2FpbjsKIH07Cg==