102332 2012-11-14 21:58:36 -0800 audiopannernode-basic.html should cover default value of attribute. 2012-11-16 10:58:24 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 li.yin li.yin crogers eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 767716 0 li.yin 2012-11-14 21:58:36 -0800 According to spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#PannerNode Currently almost all of attributes are specified default value clearly, the test should cover them. 767718 1 174344 li.yin 2012-11-14 22:03:46 -0800 Created attachment 174344 Patch 769428 2 174344 crogers 2012-11-16 10:33:40 -0800 Comment on attachment 174344 Patch thanks 769456 3 174344 webkit.review.bot 2012-11-16 10:58:21 -0800 Comment on attachment 174344 Patch Clearing flags on attachment: 174344 Committed r134972: <http://trac.webkit.org/changeset/134972> 769457 4 webkit.review.bot 2012-11-16 10:58:24 -0800 All reviewed patches have been landed. Closing bug. 174344 2012-11-14 22:03:46 -0800 2012-11-16 10:58:21 -0800 Patch bug-102332-20121115140144.patch text/plain 3698 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0Njk4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWY1YjVjMDc3NGY1MzU0MDBjNzEx ZGU1ZjUyZjkxZGM0ZTJlMjFkNC4uOWUwYTY2NzQ3NzkyMWY2MzczMDM2MWFhMWQ4MTdjZTNjMTY0 MDJlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTE0ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIGF1ZGlvcGFubmVybm9kZS1iYXNpYy5odG1sIHNob3VsZCBj b3ZlciBkZWZhdWx0IHZhbHVlIG9mIGF0dHJpYnV0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjMzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHBzOi8vZHZjcy53My5vcmcvaGcvYXVk aW8vcmF3LWZpbGUvdGlwL3dlYmF1ZGlvL3NwZWNpZmljYXRpb24uaHRtbCNQYW5uZXJOb2RlCisg ICAgICAgIEN1cnJlbnRseSBhbG1vc3QgYWxsIGF0dHJpYnV0ZXMgb2YgUGFubmVyTm9kZSBhcmUg c3BlY2lmaWVkIGRlZmF1bHQgdmFsdWUgY2xlYXJseSwKKyAgICAgICAgdGhlIHRlc3Qgc2hvdWxk IGNvdmVyIHRoZW0uCisKKyAgICAgICAgKiB3ZWJhdWRpby9hdWRpb3Bhbm5lcm5vZGUtYmFzaWMt ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdlYmF1ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy5o dG1sOgorCiAyMDEyLTExLTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgUmVhZC1vbmx5IHByb3BlcnRpZXMgY3JlYXRlZCB3aXRoIHB1dERpcmVjdCgpIHNob3Vs ZCB0ZWxsIHRoZSBzdHJ1Y3R1cmUgdGhhdCB0aGVyZSBhcmUgcmVhZC1vbmx5IHByb3BlcnRpZXMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb3Bhbm5lcm5vZGUtYmFzaWMt ZXhwZWN0ZWQudHh0CmluZGV4IGMxMGVkNjY0N2Y3N2NjMmYwOTc5ODM2YzlmNWZkMTBlNjJkNDAw ODcuLjVhOTc3NGVjMjk1NDBjNDYwYzA0NjQwOTA5OGZjZDIyM2Y2MTE3MjggMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9wYW5uZXJub2RlLWJhc2ljLWV4cGVjdGVk LnR4dApAQCAtNSw2ICs1LDEyIEBAIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFCiBQQVNTIEF1ZGlv UGFubmVyTm9kZSBoYXMgb25lIGlucHV0LgogUEFTUyBBdWRpb1Bhbm5lck5vZGUgaGFzIG9uZSBv dXRwdXQuCiBQQVNTIHBhbm5pbmdNb2RlbCBkZWZhdWx0IHZhbHVlIGlzIEhSVEYuCitQQVNTIHJl ZkRpc3RhbmNlIGRlZmF1bHQgdmFsdWUgaXMgMS4KK1BBU1MgbWF4RGlzdGFuY2UgZGVmYXVsdCB2 YWx1ZSBpcyAxMDAwMC4KK1BBU1Mgcm9sbG9mZkZhY3RvciBkZWZhdWx0IHZhbHVlIGlzIDEuCitQ QVNTIGNvbmVJbm5lckFuZ2xlIGRlZmF1bHQgdmFsdWUgaXMgMzYwLgorUEFTUyBjb25lT3V0ZXJB bmdsZSBkZWZhdWx0IHZhbHVlIGlzIDM2MC4KK1BBU1MgY29uZU91dGVyR2FpbiBkZWZhdWx0IHZh bHVlIGlzIDAuCiBQQVNTIHBhbm5pbmdNb2RlbCBzZXQgdG8gRVFVQUxQT1dFUiBtb2RlbCBhbmQg cmVhZCBjb3JyZWN0bHkuCiBQQVNTIHBhbm5pbmdNb2RlbCBzZXQgdG8gSFJURiBtb2RlbCBhbmQg cmVhZCBjb3JyZWN0bHkuCiBQQVNTIFNldHRpbmcgcGFubmluZ01vZGVsIHRvIFNPVU5ERklFTEQg Y29ycmVjdGx5IHRocm93cyBleGNlcHRpb24gYmVjYXVzZSBpdCBpcyBub3QgaW1wbGVtZW50ZWQu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb3Bhbm5lcm5vZGUtYmFzaWMu aHRtbCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy5odG1sCmlu ZGV4IDg4MmNjZmFkYzNhMjI5ZWE0MjQzOWFmYWYzNzA5Y2U4OTI1MzEwMWYuLjM2ZDQyMDdkNDM4 MGZhNzlhNTY3Zjc4OTg0YzQ4MjI0NTg2ZmIzZjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dl YmF1ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy5odG1sCisrKyBiL0xheW91dFRlc3RzL3dlYmF1 ZGlvL2F1ZGlvcGFubmVybm9kZS1iYXNpYy5odG1sCkBAIC0zNyw3ICszNywzNyBAQCBmdW5jdGlv biBydW5UZXN0KCkgewogICAgICAgICB0ZXN0UGFzc2VkKCJwYW5uaW5nTW9kZWwgZGVmYXVsdCB2 YWx1ZSBpcyBIUlRGLiIpOwogICAgIGVsc2UKICAgICAgICAgdGVzdEZhaWxlZCgicGFubmluZ01v ZGVsIGRlZmF1bHQgdmFsdWUgaXMgbm90IEhSVEYuIik7Ci0gICAgCisgCisgICAgaWYgKHBhbm5l ci5yZWZEaXN0YW5jZSA9PT0gMSkKKyAgICAgICAgdGVzdFBhc3NlZCgicmVmRGlzdGFuY2UgZGVm YXVsdCB2YWx1ZSBpcyAxLiIpOworICAgIGVsc2UKKyAgICAgICAgdGVzdEZhaWxlZCgicmVmRGlz dGFuY2UgZGVmYXVsdCB2YWx1ZSBzaG91bGQgYmUgMS4iKTsKKworICAgIGlmIChwYW5uZXIubWF4 RGlzdGFuY2UgPT09IDEwMDAwKQorICAgICAgICB0ZXN0UGFzc2VkKCJtYXhEaXN0YW5jZSBkZWZh dWx0IHZhbHVlIGlzIDEwMDAwLiIpOworICAgIGVsc2UKKyAgICAgICAgdGVzdEZhaWxlZCgibWF4 RGlzdGFuY2UgZGVmYXVsdCB2YWx1ZSBzaG91bGQgYmUgMTAwMDAuIik7CisKKyAgICBpZiAocGFu bmVyLnJvbGxvZmZGYWN0b3IgPT09IDEpCisgICAgICAgIHRlc3RQYXNzZWQoInJvbGxvZmZGYWN0 b3IgZGVmYXVsdCB2YWx1ZSBpcyAxLiIpOworICAgIGVsc2UKKyAgICAgICAgdGVzdEZhaWxlZCgi cm9sbG9mZkZhY3RvciBkZWZhdWx0IHZhbHVlIHNob3VsZCBiZSAxLiIpOworCisgICAgaWYgKHBh bm5lci5jb25lSW5uZXJBbmdsZSA9PT0gMzYwKQorICAgICAgICB0ZXN0UGFzc2VkKCJjb25lSW5u ZXJBbmdsZSBkZWZhdWx0IHZhbHVlIGlzIDM2MC4iKTsKKyAgICBlbHNlCisgICAgICAgIHRlc3RG YWlsZWQoImNvbmVJbm5lckFuZ2xlIGRlZmF1bHQgdmFsdWUgc2hvdWxkIGJlIDM2MC4iKTsKKwor ICAgIGlmIChwYW5uZXIuY29uZU91dGVyQW5nbGUgPT09IDM2MCkKKyAgICAgICAgdGVzdFBhc3Nl ZCgiY29uZU91dGVyQW5nbGUgZGVmYXVsdCB2YWx1ZSBpcyAzNjAuIik7CisgICAgZWxzZQorICAg ICAgICB0ZXN0RmFpbGVkKCJjb25lT3V0ZXJBbmdsZSBkZWZhdWx0IHZhbHVlIHNob3VsZCBiZSAz NjAuIik7CisKKyAgICBpZiAocGFubmVyLmNvbmVPdXRlckdhaW4gPT09IDApCisgICAgICAgIHRl c3RQYXNzZWQoImNvbmVPdXRlckdhaW4gZGVmYXVsdCB2YWx1ZSBpcyAwLiIpOworICAgIGVsc2UK KyAgICAgICAgdGVzdEZhaWxlZCgiY29uZU91dGVyR2FpbiBkZWZhdWx0IHZhbHVlIHNob3VsZCBi ZSAwLiIpOworCiAgICAgLy8gU2V0IHRoZSBwYW5uaW5nIG1vZGVsIGFuZCBzZWUgaWYgaXQgY2Fu IGJlIHJlYWQgYmFjayBjb3JyZWN0bHkuCiAgICAgcGFubmVyLnBhbm5pbmdNb2RlbCA9IHBhbm5l ci5FUVVBTFBPV0VSOwogICAgIGlmIChwYW5uZXIucGFubmluZ01vZGVsID09PSAwKQo=