102319 2012-11-14 19:30:57 -0800 [chromium] Move allowWebGL query to WebFrameClient 2012-11-15 10:34:09 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 101826 1 kbr kbr abarth bajones dglazkov fishd gman jamesr tkent+wkapi webkit.review.bot zmo oldest_to_newest 767624 0 kbr 2012-11-14 19:30:57 -0800 After offline discussion, the allowWebGL query added in https://bugs.webkit.org/show_bug.cgi?id=101826 needs to be moved from WebPermissionClient to WebFrameClient in order to keep its implementation in the content/ module and avoid polluting the content/ API. 767628 1 174323 kbr 2012-11-14 19:39:53 -0800 Created attachment 174323 Patch 767631 2 webkit.review.bot 2012-11-14 19:42:23 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 768215 3 174323 abarth 2012-11-15 10:02:35 -0800 Comment on attachment 174323 Patch I'm slightly hesitant to design the WebKit API around the higher-level abstractions in Chromium, but this change seems ok. 768269 4 174323 webkit.review.bot 2012-11-15 10:34:05 -0800 Comment on attachment 174323 Patch Clearing flags on attachment: 174323 Committed r134794: <http://trac.webkit.org/changeset/134794> 768270 5 webkit.review.bot 2012-11-15 10:34:09 -0800 All reviewed patches have been landed. Closing bug. 174323 2012-11-14 19:39:53 -0800 2012-11-15 10:34:05 -0800 Patch bug-102319-20121114193751.patch text/plain 3632 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDFmOTY1MzY4OGZhNTkwOWVkZjdmOGExZTVhOWMyZDcwZGUzNzZiZGUuLjdiMjZmYjdlYWM5OTYw YTRkMDZmZTE3YTM1ZTg2ZWEwMjZhOTZkMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTEtMTQgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gTW92ZSBhbGxvd1dlYkdMIHF1ZXJ5IHRvIFdlYkZy YW1lQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDIzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNb3ZlZCBhbGxvd1dlYkdMIHF1ZXJ5IHRvIFdlYkZyYW1lQ2xpZW50IHRvIGF2b2lkIHBvbGx1 dGluZworICAgICAgICBjb250ZW50LyBBUEkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWVD bGllbnQuaDoKKyAgICAgICAgKFdlYkZyYW1lQ2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6V2Vi RnJhbWVDbGllbnQ6OmFsbG93V2ViR0wpOgorICAgICAgICAqIHB1YmxpYy9XZWJQZXJtaXNzaW9u Q2xpZW50Lmg6CisgICAgICAgICogc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6YWxsb3dXZWJHTCk6CisKIDIwMTIt MTEtMTQgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRl eGVkREI6IFJlbW92ZSBtYWdpYyBudW1iZXJzIGluIHJlY29yZCBjb21wYXJhdG9yLCBoYW5kbGUg bWlzc2luZyBjYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVD bGllbnQuaAppbmRleCBlYzBmZTMzNzUzNzI1MTY4YzI5OWZkNjA3ZjY5MzY4ZGYyYzk4NWRmLi5i ZGEzYzAzODlkMmM1NDA1MmEzNWU5YzU5ZGIzMWQ0ZGRiNDgwNjRjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKQEAgLTQyMiw2ICs0MjIsMTIg QEAgcHVibGljOgogCiAgICAgLy8gV2ViR0wgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKKyAgICAvLyBBc2tzIHRoZSBlbWJlZGRlciB3aGV0 aGVyIFdlYkdMIGlzIGFsbG93ZWQgZm9yIHRoZSBnaXZlbiBXZWJGcmFtZS4KKyAgICAvLyBUaGlz IGNhbGwgaXMgcGxhY2VkIGhlcmUgaW5zdGVhZCBvZiBXZWJQZXJtaXNzaW9uQ2xpZW50IGJlY2F1 c2UgdGhpcworICAgIC8vIGNsYXNzIGlzIGltcGxlbWVudGVkIGluIGNvbnRlbnQvLCBhbmQgcHV0 dGluZyBpdCBoZXJlIGF2b2lkcyBhZGRpbmcKKyAgICAvLyBtb3JlIHB1YmxpYyBjb250ZW50LyBB UElzLgorICAgIHZpcnR1YWwgYm9vbCBhbGxvd1dlYkdMKFdlYkZyYW1lKiwgYm9vbCBkZWZhdWx0 VmFsdWUpIHsgcmV0dXJuIGRlZmF1bHRWYWx1ZTsgfQorCiAgICAgLy8gTm90aWZpZXMgdGhlIGNs aWVudCB0aGF0IGEgV2ViR0wgY29udGV4dCB3YXMgbG9zdCBvbiB0aGlzIHBhZ2Ugd2l0aCB0aGUK ICAgICAvLyBnaXZlbiByZWFzb24gKG9uZSBvZiB0aGUgR0xfQVJCX3JvYnVzdG5lc3Mgc3RhdHVz IGNvZGVzOyBzZWUKICAgICAvLyBFeHRlbnNpb25zM0QuaCBpbiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBl cm1pc3Npb25DbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBlcm1p c3Npb25DbGllbnQuaAppbmRleCAxMGI0OTk1ZTVjMjdkMjc2YTljZmUxNDk1NzVmMjQ0MjhhMzY3 YmZkLi4wYjY0MTRiNGUyMjM4NjcyZjM0NWY1ZDBiYzI1MjY2OWEyZjM2NDdhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQZXJtaXNzaW9uQ2xpZW50LmgKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUGVybWlzc2lvbkNsaWVudC5oCkBA IC05Myw5ICs5Myw2IEBAIHB1YmxpYzoKICAgICAvLyBDb250cm9scyB3aGV0aGVyIGVuYWJsaW5n IFdlYiBDb21wb25lbnRzIEFQSSBmb3IgdGhpcyBmcmFtZS4KICAgICB2aXJ0dWFsIGJvb2wgYWxs b3dXZWJDb21wb25lbnRzKGNvbnN0IFdlYkRvY3VtZW50JiwgYm9vbCBkZWZhdWx0VmFsdWUpIHsg cmV0dXJuIGRlZmF1bHRWYWx1ZTsgfQogCi0gICAgLy8gQ29udHJvbHMgd2hldGhlciBlbmFibGlu ZyBXZWJHTCBmb3IgdGhpcyBmcmFtZS4KLSAgICB2aXJ0dWFsIGJvb2wgYWxsb3dXZWJHTChXZWJG cmFtZSosIGJvb2wgZGVmYXVsdFZhbHVlKSB7IHJldHVybiBkZWZhdWx0VmFsdWU7IH0KLQogICAg IC8vIENvbnRyb2xzIHdoZXRoZXIgZW5hYmxpbmcgSFRNTCBub3RpZmljYXRpb25zIGZvciB0aGlz IGZyYW1lLgogICAgIHZpcnR1YWwgYm9vbCBhbGxvd0hUTUxOb3RpZmljYXRpb25zKGNvbnN0IFdl YkRvY3VtZW50JikgeyByZXR1cm4gdHJ1ZTsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAppbmRleCA3MWRlMTdhYjhkMmFl NWIyNTg4NTlkMzZhMzYxMGI1OWRjMWY0OWQ5Li45ZDBhYWI0OTViMzNkODEyODRmMGNhMTZkMTA5 ZGI4NzEzNGVkNjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFt ZUxvYWRlckNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Zy YW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKQEAgLTE2NjUsOSArMTY2NSw4IEBAIHZvaWQgRnJhbWVM b2FkZXJDbGllbnRJbXBsOjpkaWRSZXF1ZXN0QXV0b2NvbXBsZXRlKFBhc3NSZWZQdHI8Rm9ybVN0 YXRlPiBmb3JtU3RhCiAjaWYgRU5BQkxFKFdFQkdMKQogYm9vbCBGcmFtZUxvYWRlckNsaWVudElt cGw6OmFsbG93V2ViR0woYm9vbCBlbmFibGVkUGVyU2V0dGluZ3MpCiB7Ci0gICAgV2ViVmlld0lt cGwqIHdlYnZpZXcgPSBtX3dlYkZyYW1lLT52aWV3SW1wbCgpOwotICAgIGlmICh3ZWJ2aWV3ICYm IHdlYnZpZXctPnBlcm1pc3Npb25DbGllbnQoKSkKLSAgICAgICAgcmV0dXJuIHdlYnZpZXctPnBl cm1pc3Npb25DbGllbnQoKS0+YWxsb3dXZWJHTChtX3dlYkZyYW1lLCBlbmFibGVkUGVyU2V0dGlu Z3MpOworICAgIGlmIChtX3dlYkZyYW1lLT5jbGllbnQoKSkKKyAgICAgICAgcmV0dXJuIG1fd2Vi RnJhbWUtPmNsaWVudCgpLT5hbGxvd1dlYkdMKG1fd2ViRnJhbWUsIGVuYWJsZWRQZXJTZXR0aW5n cyk7CiAKICAgICByZXR1cm4gZW5hYmxlZFBlclNldHRpbmdzOwogfQo=